Preparing report...

Report for github.com/wagoodman/bashful

A+    Excellent!    Found 18 issues across 30 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint50%

Golint is a linter for Go source code.

    • bashful/pkg/runtime/handler/task_logger.go
    • Line 26: warning: exported type TaskLogger should have comment or be unexported (golint)
    • Line 32: warning: exported function NewTaskLogger should have comment or be unexported (golint)
    • Line 43: warning: exported method TaskLogger.AddRuntimeData should have comment or be unexported (golint)
    • Line 59: warning: exported method TaskLogger.Register should have comment or be unexported (golint)
    • Line 70: warning: exported method TaskLogger.Unregister should have comment or be unexported (golint)
    • Line 83: warning: exported method TaskLogger.OnEvent should have comment or be unexported (golint)
    • Line 100: warning: exported method TaskLogger.Close should have comment or be unexported (golint)
    • bashful/pkg/runtime/types.go
    • Line 47: warning: exported type Client should have comment or be unexported (golint)
    • Line 55: warning: exported type Executor should have comment or be unexported (golint)
    • Line 73: warning: exported type TaskStatistics should have comment or be unexported (golint)
    • bashful/pkg/runtime/handler/vertical_ui.go
    • Line 22: warning: exported type VerticalUI should have comment or be unexported (golint)
    • Line 94: warning: exported function NewVerticalUI should have comment or be unexported (golint)
    • Line 114: warning: exported method VerticalUI.AddRuntimeData should have comment or be unexported (golint)
    • Line 159: warning: comment on exported method VerticalUI.Close should be of the form "Close ..." (golint)
    • Line 183: warning: exported method VerticalUI.Unregister should have comment or be unexported (golint)
    • Line 296: warning: exported method VerticalUI.Register should have comment or be unexported (golint)
    • Line 304: warning: exported method VerticalUI.OnEvent should have comment or be unexported (golint)
    • bashful/utils/test.go
    • Line 8: warning: exported function InterfaceSlice should have comment or be unexported (golint)
    • Line 23: warning: exported type TestCollection should have comment or be unexported (golint)
    • Line 28: warning: exported type TestCase should have comment or be unexported (golint)
    • Line 36: warning: exported function AssertTestCase should have comment or be unexported (golint)
    • Line 52: warning: exported function AssertTestCases should have comment or be unexported (golint)
    • bashful/pkg/runtime/task.go
    • Line 49: warning: exported const StatusRunning should have comment (or a comment on this block) or be unexported (golint)
    • Line 162: warning: comment on exported method Task.Execute should be of the form "Execute ..." (golint)
    • bashful/pkg/log/log.go
    • Line 15: warning: exported const StyleMajor should have comment (or a comment on this block) or be unexported (golint)
    • Line 37: warning: exported function LogToMain should have comment or be unexported (golint)
    • Line 66: warning: exported function SetupLogging should have comment or be unexported (golint)
    • bashful/pkg/runtime/handler/compressed_ui.go
    • Line 21: warning: exported type CompressedUI should have comment or be unexported (golint)
    • Line 30: warning: exported function NewCompressedUI should have comment or be unexported (golint)
    • Line 42: warning: exported method CompressedUI.AddRuntimeData should have comment or be unexported (golint)
    • Line 46: warning: exported method CompressedUI.Close should have comment or be unexported (golint)
    • Line 50: warning: exported method CompressedUI.Unregister should have comment or be unexported (golint)
    • Line 76: warning: exported method CompressedUI.Register should have comment or be unexported (golint)
    • Line 84: warning: exported method CompressedUI.OnEvent should have comment or be unexported (golint)
    • bashful/pkg/runtime/handler/simple_logger.go
    • Line 12: warning: exported type SimpleLogger should have comment or be unexported (golint)
    • Line 17: warning: exported function NewSimpleLogger should have comment or be unexported (golint)
    • Line 30: warning: exported method SimpleLogger.AddRuntimeData should have comment or be unexported (golint)
    • Line 34: warning: exported method SimpleLogger.Register should have comment or be unexported (golint)
    • Line 38: warning: exported method SimpleLogger.Unregister should have comment or be unexported (golint)
    • Line 42: warning: exported method SimpleLogger.OnEvent should have comment or be unexported (golint)
    • Line 49: warning: exported method SimpleLogger.Close should have comment or be unexported (golint)
    • bashful/utils/utils.go
    • Line 21: warning: exported var Purple should have comment or be unexported (golint)
    • Line 142: warning: comment on exported function GetSudoPasswd should be of the form "GetSudoPasswd ..." (golint)
    • Line 194: warning: comment on exported function GetFilenameFromUrl should be of the form "GetFilenameFromUrl ..." (golint)
    • Line 205: warning: comment on exported function Md5OfFile should be of the form "Md5OfFile ..." (golint)
    • bashful/pkg/runtime/client.go
    • Line 36: warning: exported function NewClientFromYaml should have comment or be unexported (golint)
    • Line 44: warning: exported function NewClientFromConfig should have comment or be unexported (golint)
    • Line 52: warning: exported method Client.AddEventHandler should have comment or be unexported (golint)
    • Line 56: warning: exported method Client.Run should have comment or be unexported (golint)
    • Line 100: warning: exported method Client.Bundle should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign93%

IneffAssign detects ineffectual assignments in Go code.


misspell96%

Misspell Finds commonly misspelled English words