Preparing report...

Report for github.com/wzshiming/xds

A    Great!    Found 7 issues across 9 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo66%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • xds/v2/xds.go
    • Line 141: warning: cyclomatic complexity 25 of function (*Client).handleRecv() is high (> 15) (gocyclo)
    • xds/v3/xds.go
    • Line 149: warning: cyclomatic complexity 25 of function (*Client).handleRecv() is high (> 15) (gocyclo)

golint22%

Golint is a linter for Go source code.

    • xds/v3/xds.go
    • Line 1: warning: don't use an underscore in package name (golint)
    • Line 27: warning: exported const ClusterType should have comment (or a comment on this block) or be unexported (golint)
    • Line 103: warning: exported method Client.Start should have comment or be unexported (golint)
    • Line 227: warning: exported method Client.Node should have comment or be unexported (golint)
    • Line 237: warning: exported method Client.Send should have comment or be unexported (golint)
    • Line 242: warning: exported method Client.SendRsc should have comment or be unexported (golint)
    • xds/utils/nodeid.go
    • Line 33: warning: exported method NodeConfig.ID should have comment or be unexported (golint)
    • Line 56: warning: exported method NodeConfig.Meta should have comment or be unexported (golint)
    • xds/utils/structpb.go
    • Line 30: warning: exported function MustMapToProtoStruct should have comment or be unexported (golint)
    • Line 38: warning: exported function MapToProtoStruct should have comment or be unexported (golint)
    • Line 50: warning: exported function ValueToStructValue should have comment or be unexported (golint)
    • xds/utils/tls.go
    • Line 10: warning: exported function TlsConfigFromDir should have comment or be unexported (golint)
    • Line 29: warning: exported function TlsConfig should have comment or be unexported (golint)
    • xds/v2/xds.go
    • Line 1: warning: don't use an underscore in package name (golint)
    • Line 24: warning: exported const ClusterType should have comment (or a comment on this block) or be unexported (golint)
    • Line 95: warning: exported method Client.Start should have comment or be unexported (golint)
    • Line 220: warning: exported method Client.Node should have comment or be unexported (golint)
    • Line 230: warning: exported method Client.Send should have comment or be unexported (golint)
    • Line 235: warning: exported method Client.SendRsc should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!