Preparing report...

Report for github.com/xridge/kubestone

A+    Excellent!    Found 19 issues across 99 files

Tweet

gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint82%

Golint is a linter for Go source code.

    • kubestone/pkg/k8s/client.go
    • Line 140: warning: exported method Access.GetJob should have comment or be unexported (golint)
    • Line 149: warning: exported method Access.GetJobPods should have comment or be unexported (golint)
    • Line 222: warning: exported method Access.GetStatefulSet should have comment or be unexported (golint)
    • kubestone/controllers/ycsbbench/job_test.go
    • Line 41: warning: don't use underscores in Go names; var expected_args should be expectedArgs (golint)
    • Line 72: warning: don't use underscores in Go names; var expected_args should be expectedArgs (golint)
    • Line 99: warning: don't use underscores in Go names; var expected_args should be expectedArgs (golint)
    • Line 111: warning: don't use underscores in Go names; func parameter expected_args should be expectedArgs (golint)
    • kubestone/controllers/kafkabench/controller.go
    • Line 41: warning: exported method KafkaBenchReconciler.Reconcile should have comment or be unexported (golint)
    • Line 104: warning: context.Context should be the first parameter of a function (golint)
    • Line 104: warning: error should be the last type when returning multiple items (golint)
    • Line 104: warning: exported method KafkaBenchReconciler.ProcessKafkaTest should have comment or be unexported (golint)
    • Line 121: warning: exported method KafkaBenchReconciler.SetupWithManager should have comment or be unexported (golint)
    • Line 127: warning: exported function AddPodAffinity should have comment or be unexported (golint)
    • kubestone/controllers/kafkabench/producer_job.go
    • Line 29: warning: exported function NewProducerJob should have comment or be unexported (golint)
    • Line 59: warning: exported function ProducerInitJobArgs should have comment or be unexported (golint)
    • Line 71: warning: exported function ProducerJobCmd should have comment or be unexported (golint)
    • kubestone/api/v1alpha1/esrally_types.go
    • Line 66: warning: exported type EsRallySecurity should have comment or be unexported (golint)
    • Line 81: warning: exported type EsRallyVolConfig should have comment or be unexported (golint)
    • Line 86: warning: exported type EsRallyStatus should have comment or be unexported (golint)
    • kubestone/api/v1alpha1/kafkabench_types.go
    • Line 39: warning: comment on exported type KafkaClusterInfo should be of the form "KafkaClusterInfo ..." (with optional leading article) (golint)
    • Line 48: warning: comment on exported type KafkaTestSpec should be of the form "KafkaTestSpec ..." (with optional leading article) (golint)
    • kubestone/controllers/esrally/controller.go
    • Line 33: warning: comment on exported type Reconciler should be of the form "Reconciler ..." (with optional leading article) (golint)
    • Line 46: warning: exported method Reconciler.Reconcile should have comment or be unexported (golint)
    • Line 123: warning: context.Context should be the first parameter of a function (golint)
    • Line 164: warning: context.Context should be the first parameter of a function (golint)
    • Line 179: warning: exported method Reconciler.SetupWithManager should have comment or be unexported (golint)
    • kubestone/controllers/esrally/job.go
    • Line 29: warning: exported function NewJob should have comment or be unexported (golint)
    • Line 65: warning: exported function CreateEsRallyCmd should have comment or be unexported (golint)
    • Line 108: warning: exported function ParseRallyNodeNames should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!