Preparing report...

Report for github.com/xtaci/smux

A+    Excellent!    Found 3 issues across 10 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint70%

Golint is a linter for Go source code.

    • smux/alloc.go
    • Line 46: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • smux/session.go
    • Line 19: warning: exported var ErrInvalidProtocol should have comment or be unexported (golint)
    • Line 205: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • smux/stream.go
    • Line 157: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 440: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

gocyclo80%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • smux/session.go
    • Line 306: warning: cyclomatic complexity 23 of function (*Session).recvLoop() is high (> 15) (gocyclo)
    • smux/stream.go
    • Line 339: warning: cyclomatic complexity 19 of function (*Stream).writeV2() is high (> 15) (gocyclo)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell90%

Misspell Finds commonly misspelled English words