Report for github.com/yannh/r10k-go
A+ Excellent! Found 11 issues across 18 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo83%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
r10k-go/gzip/main.go
- Line 15: warning: cyclomatic complexity 20 of function Extract() is high (> 15) (gocyclo)
-
-
r10k-go/puppetfileparser/main.go
- Line 24: warning: cyclomatic complexity 20 of function parseModule() is high (> 15) (gocyclo)
- Line 83: warning: cyclomatic complexity 16 of function Parse() is high (> 15) (gocyclo)
-
-
r10k-go/main.go
- Line 164: warning: cyclomatic complexity 25 of function main() is high (> 15) (gocyclo)
golint44%
Golint is a linter for Go source code.
-
-
r10k-go/puppetmodule/github_tarball.go
- Line 17: warning: exported type GithubTarballModule should have comment or be unexported (golint)
- Line 29: warning: exported function NewGithubTarballModule should have comment or be unexported (golint)
- Line 38: warning: exported method GithubTarballModule.Name should have comment or be unexported (golint)
- Line 42: warning: exported method GithubTarballModule.InstallPath should have comment or be unexported (golint)
- Line 52: warning: exported method GithubTarballModule.IsUpToDate should have comment or be unexported (golint)
- Line 134: warning: exported method GithubTarballModule.Download should have comment or be unexported (golint)
-
-
r10k-go/puppetsource/main.go
- Line 3: warning: exported type Source should have comment or be unexported (golint)
-
-
r10k-go/puppetfileparser/main.go
- Line 9: warning: exported type ErrMalformedPuppetfile should have comment or be unexported (golint)
- Line 12: warning: exported function NewErrMalformedPuppetfile should have comment or be unexported (golint)
- Line 36: warning: don't use underscores in Go names; var quoted_elements should be quotedElements (golint)
- Line 83: warning: exported function Parse should have comment or be unexported (golint)
-
-
r10k-go/gzip/main.go
- Line 15: warning: exported function Extract should have comment or be unexported (golint)
-
-
r10k-go/environment.go
- Line 64: warning: receiver name env should be consistent with previous receiver name e for environment (golint)
- Line 80: warning: exported function DeployedEnvironments should have comment or be unexported (golint)
-
-
r10k-go/puppetmodule/forge.go
- Line 17: warning: exported type ForgeModule should have comment or be unexported (golint)
- Line 22: warning: exported function NewForgeModule should have comment or be unexported (golint)
- Line 29: warning: exported method ForgeModule.InstallPath should have comment or be unexported (golint)
- Line 39: warning: exported method ForgeModule.Name should have comment or be unexported (golint)
- Line 68: warning: exported method ForgeModule.IsUpToDate should have comment or be unexported (golint)
- Line 143: warning: exported method ForgeModule.Download should have comment or be unexported (golint)
-
-
r10k-go/puppetmodule/git.go
- Line 16: warning: exported type GitModule should have comment or be unexported (golint)
- Line 23: warning: exported function NewGitModule should have comment or be unexported (golint)
- Line 32: warning: exported method GitModule.Name should have comment or be unexported (golint)
- Line 33: warning: exported method GitModule.InstallPath should have comment or be unexported (golint)
- Line 37: warning: exported method GitModule.IsUpToDate should have comment or be unexported (golint)
- Line 134: warning: exported method GitModule.Download should have comment or be unexported (golint)
-
-
r10k-go/puppetsource/gitsource.go
- Line 11: warning: exported type GitSource should have comment or be unexported (golint)
- Line 19: warning: exported function NewGitSource should have comment or be unexported (golint)
- Line 29: warning: exported method GitSource.Name should have comment or be unexported (golint)
- Line 30: warning: exported method GitSource.Remote should have comment or be unexported (golint)
- Line 31: warning: exported method GitSource.Location should have comment or be unexported (golint)
- Line 32: warning: exported method GitSource.Basedir should have comment or be unexported (golint)
- Line 34: warning: exported method GitSource.Fetch should have comment or be unexported (golint)
-
-
r10k-go/git/main.go
- Line 12: warning: exported const TypeRef should have comment or be unexported (golint)
- Line 13: warning: exported const TypeTag should have comment or be unexported (golint)
- Line 14: warning: exported const TypeBranch should have comment or be unexported (golint)
- Line 16: warning: exported type Ref should have comment or be unexported (golint)
- Line 26: warning: exported function NewRef should have comment or be unexported (golint)
- Line 39: warning: exported function RevParse should have comment or be unexported (golint)
- Line 45: warning: exported function Clone should have comment or be unexported (golint)
- Line 60: warning: exported function Fetch should have comment or be unexported (golint)
- Line 73: warning: exported function Checkout should have comment or be unexported (golint)
- Line 91: warning: exported function RepoHasRemoteBranch should have comment or be unexported (golint)
- Line 100: warning: exported function WorktreeAdd should have comment or be unexported (golint)
-
-
r10k-go/puppetmodule/main.go
- Line 3: warning: exported type DownloadError should have comment or be unexported (golint)
ineffassign88%
IneffAssign detects ineffectual assignments in Go code.
-
-
r10k-go/git/main.go
- Line 67: warning: ineffectual assignment to err (ineffassign)
- Line 85: warning: ineffectual assignment to err (ineffassign)
-
-
r10k-go/puppetfileparser/main.go
- Line 92: warning: ineffectual assignment to line (ineffassign)