gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• edward/runner/runner.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• edward/services/backends/docker/backend_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• edward/services/backends/docker/buildandrun_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• edward/instance/state_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• edward/edward/log.go
  • Line 16: warning: cyclomatic complexity 18 of function (*Client).Log() is high (> 15) (gocyclo)

• edward/config/config.go
  • Line 316: warning: cyclomatic complexity 17 of function (*Config).initMaps() is high (> 15) (gocyclo)

• edward/edward/generate.go
  • Line 17: warning: cyclomatic complexity 28 of function (*Client).Generate() is high (> 15) (gocyclo)

golint66%

Golint is a linter for Go source code.

• edward/edward/log.go
  • Line 16: warning: exported method Client.Log should have comment or be unexported (golint)

• edward/services/backends/fake/loader.go
  • Line 9: warning: exported type Loader should have comment or be unexported (golint)
  • Line 12: warning: exported method Loader.New should have comment or be unexported (golint)
  • Line 16: warning: exported method Loader.Name should have comment or be unexported (golint)
  • Line 20: warning: exported method Loader.Handles should have comment or be unexported (golint)
  • Line 25: warning: exported method Loader.Builder should have comment or be unexported (golint)
  • Line 29: warning: exported method Loader.Runner should have comment or be unexported (golint)

• edward/services/backends/docker/backend.go
  • Line 15: warning: exported type Backend should have comment or be unexported (golint)
  • Line 26: warning: exported method Backend.MarshalJSON should have comment or be unexported (golint)
  • Line 54: warning: exported method Backend.UnmarshalJSON should have comment or be unexported (golint)
  • Line 82: warning: exported method Backend.HasBuildStep should have comment or be unexported (golint)
  • Line 86: warning: exported method Backend.HasLaunchStep should have comment or be unexported (golint)
  • Line 90: warning: exported type PortMapping should have comment or be unexported (golint)
  • Line 97: warning: exported method PortMapping.MarshalJSON should have comment or be unexported (golint)
  • Line 105: warning: exported method PortMapping.UnmarshalJSON should have comment or be unexported (golint)

• edward/edward/client.go
  • Line 19: warning: exported type Client should have comment or be unexported (golint)
  • Line 50: warning: exported type TaskFollower should have comment or be unexported (golint)
  • Line 102: warning: exported method Client.BasePath should have comment or be unexported (golint)
  • Line 106: warning: exported method Client.ServiceMap should have comment or be unexported (golint)

• edward/edward/start.go
  • Line 10: warning: exported method Client.Start should have comment or be unexported (golint)

• edward/edward/version.go
  • Line 5: warning: exported method Client.Version should have comment or be unexported (golint)

• edward/output/rendering_inprogress.go
  • Line 12: warning: exported type InProgressRenderer should have comment or be unexported (golint)
  • Line 17: warning: exported function NewInProgressRenderer should have comment or be unexported (golint)
  • Line 24: warning: exported method InProgressRenderer.Render should have comment or be unexported (golint)

• edward/services/legacy.go
  • Line 3: warning: exported type LegacyMarshaler should have comment or be unexported (golint)
  • Line 9: warning: exported function RegisterLegacyMarshaler should have comment or be unexported (golint)

• edward/instance/loadrunning.go
  • Line 12: warning: exported function LoadRunningServices should have comment or be unexported (golint)

• edward/services/backends/commandline/legacy.go
  • Line 10: warning: exported type LegacyUnmarshaler should have comment or be unexported (golint)
  • Line 12: warning: exported method LegacyUnmarshaler.Unmarshal should have comment or be unexported (golint)

• edward/edward/restart.go
  • Line 15: warning: exported method Client.Restart should have comment or be unexported (golint)

• edward/edward/status.go
  • Line 11: warning: exported method Client.Status should have comment or be unexported (golint)

• edward/edward/stop.go
  • Line 11: warning: exported method Client.Stop should have comment or be unexported (golint)

• edward/config/load.go
  • Line 12: warning: exported function GetConfigPathFromWorkingDirectory should have comment or be unexported (golint)

• edward/output/rendering_completion.go
  • Line 13: warning: exported type CompletionRenderer should have comment or be unexported (golint)
  • Line 19: warning: exported function NewCompletionRenderer should have comment or be unexported (golint)
  • Line 27: warning: exported method CompletionRenderer.Render should have comment or be unexported (golint)

• edward/services/backends/docker/loader.go
  • Line 9: warning: exported type Loader should have comment or be unexported (golint)
  • Line 12: warning: exported method Loader.New should have comment or be unexported (golint)
  • Line 16: warning: exported method Loader.Name should have comment or be unexported (golint)
  • Line 20: warning: exported method Loader.Handles should have comment or be unexported (golint)
  • Line 25: warning: exported method Loader.Builder should have comment or be unexported (golint)
  • Line 29: warning: exported method Loader.Runner should have comment or be unexported (golint)

• edward/runner/logging.go
  • Line 22: warning: exported method Log.Len should have comment or be unexported (golint)

• edward/runner/runner.go
  • Line 41: warning: exported function NewRunner should have comment or be unexported (golint)
  • Line 62: warning: exported method Runner.Run should have comment or be unexported (golint)
  • Line 106: warning: should omit values from range; this loop is equivalent to `for range ...` (golint)

• edward/worker/pool.go
  • Line 28: warning: exported method Pool.Err should have comment or be unexported (golint)

• edward/ui/terminal/log.go
  • Line 11: warning: exported method Provider.ShowLog should have comment or be unexported (golint)

• edward/services/serviceconfig.go
  • Line 85: warning: exported method BackendConfig.UnmarshalJSON should have comment or be unexported (golint)
  • Line 110: warning: exported method BackendConfig.MarshalJSON should have comment or be unexported (golint)
  • Line 277: warning: exported method ServiceConfig.GetPid should have comment or be unexported (golint)
  • Line 289: warning: exported method ServiceConfig.GetStateBase should have comment or be unexported (golint)
  • Line 293: warning: exported method ServiceConfig.GetStatePath should have comment or be unexported (golint)
  • Line 297: warning: exported method ServiceConfig.GetPidPathLegacy should have comment or be unexported (golint)

• edward/services/services.go
  • Line 48: warning: exported method ContextOverride.Merge should have comment or be unexported (golint)

• edward/instance/state.go
  • Line 16: warning: exported type State should have comment or be unexported (golint)
  • Line 19: warning: exported const StateStarting should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: exported type Status should have comment or be unexported (golint)
  • Line 37: warning: exported function LoadStatusForService should have comment or be unexported (golint)
  • Line 69: warning: exported function SaveStatusForService should have comment or be unexported (golint)
  • Line 88: warning: exported function DeleteAllStatusesForService should have comment or be unexported (golint)
  • Line 97: warning: exported function DeleteStatusForService should have comment or be unexported (golint)

• edward/edward/generate.go
  • Line 17: warning: exported method Client.Generate should have comment or be unexported (golint)

• edward/edward/list.go
  • Line 3: warning: exported method Client.List should have comment or be unexported (golint)

• edward/services/backends/fake/backend.go
  • Line 9: warning: exported type Backend should have comment or be unexported (golint)
  • Line 42: warning: exported method Backend.Name should have comment or be unexported (golint)
  • Line 46: warning: exported method Backend.HasBuildStep should have comment or be unexported (golint)
  • Line 50: warning: exported method Backend.HasLaunchStep should have comment or be unexported (golint)

• edward/instance/processes/processes.go
  • Line 14: warning: exported type Processes should have comment or be unexported (golint)
  • Line 17: warning: exported method Processes.SendSignal should have comment or be unexported (golint)
  • Line 26: warning: exported method Processes.KillGroup should have comment or be unexported (golint)
  • Line 54: warning: exported method Processes.PidExists should have comment or be unexported (golint)
  • Line 60: warning: exported method Processes.PidCommandMatches should have comment or be unexported (golint)

• edward/output/tasks.go
  • Line 15: warning: exported type Follower should have comment or be unexported (golint)
  • Line 24: warning: exported function NewFollower should have comment or be unexported (golint)
  • Line 33: warning: exported method Follower.Reset should have comment or be unexported (golint)
  • Line 45: warning: exported method Follower.Handle should have comment or be unexported (golint)
  • Line 77: warning: exported method Follower.Done should have comment or be unexported (golint)
  • Line 85: warning: exported type NonLiveFollower should have comment or be unexported (golint)
  • Line 89: warning: exported function NewNonLiveFollower should have comment or be unexported (golint)
  • Line 96: warning: exported method NonLiveFollower.Handle should have comment or be unexported (golint)
  • Line 105: warning: exported method NonLiveFollower.Done should have comment or be unexported (golint)

• edward/tracker/task.go
  • Line 86: warning: exported function NewTask should have comment or be unexported (golint)

• edward/common/version.go
  • Line 3: warning: exported const EdwardVersion should have comment or be unexported (golint)

• edward/builder/build.go
  • Line 21: warning: exported function New should have comment or be unexported (golint)

• edward/ui/ui.go
  • Line 9: warning: exported type Provider should have comment or be unexported (golint)
  • Line 22: warning: exported type ServiceStatus should have comment or be unexported (golint)

• edward/ui/terminal/list.go
  • Line 5: warning: exported method Provider.List should have comment or be unexported (golint)

• edward/ui/terminal/provider.go
  • Line 14: warning: exported type Provider should have comment or be unexported (golint)
  • Line 17: warning: exported method Provider.Infof should have comment or be unexported (golint)
  • Line 22: warning: exported method Provider.Errorf should have comment or be unexported (golint)
  • Line 27: warning: exported method Provider.Confirm should have comment or be unexported (golint)

• edward/services/backends/commandline/backend.go
  • Line 12: warning: exported type Backend should have comment or be unexported (golint)
  • Line 20: warning: exported method Backend.UnmarshalJSON should have comment or be unexported (golint)
  • Line 103: warning: exported method Backend.Name should have comment or be unexported (golint)
  • Line 107: warning: exported method Backend.HasBuildStep should have comment or be unexported (golint)
  • Line 111: warning: exported method Backend.HasLaunchStep should have comment or be unexported (golint)
  • Line 115: warning: exported function GetConfigCommandLine should have comment or be unexported (golint)

• edward/config/config.go
  • Line 210: warning: exported method Config.RemoveGroup should have comment or be unexported (golint)

• edward/ui/terminal/status.go
  • Line 15: warning: exported method Provider.Status should have comment or be unexported (golint)

• edward/services/backends.go
  • Line 10: warning: exported type Backend should have comment or be unexported (golint)
  • Line 15: warning: exported type BackendLoader should have comment or be unexported (golint)
  • Line 23: warning: exported type Runner should have comment or be unexported (golint)
  • Line 30: warning: exported type BackendStatus should have comment or be unexported (golint)
  • Line 35: warning: exported type Builder should have comment or be unexported (golint)
  • Line 42: warning: exported function RegisterBackend should have comment or be unexported (golint)
  • Line 46: warning: exported function GetBuilder should have comment or be unexported (golint)
  • Line 60: warning: exported function GetRunner should have comment or be unexported (golint)

• edward/instance/servicelogs/follow.go
  • Line 12: warning: exported type LogFollower should have comment or be unexported (golint)
  • Line 27: warning: exported method LogFollower.Start should have comment or be unexported (golint)
  • Line 55: warning: exported method LogFollower.Stop should have comment or be unexported (golint)

• edward/home/home.go
  • Line 52: warning: exported method EdwardConfiguration.InitializeWithDir should have comment or be unexported (golint)

• edward/services/duration.go
  • Line 10: warning: exported type Duration should have comment or be unexported (golint)
  • Line 14: warning: exported method Duration.MarshalJSON should have comment or be unexported (golint)
  • Line 18: warning: exported method Duration.UnmarshalJSON should have comment or be unexported (golint)

• edward/services/backends/commandline/loader.go
  • Line 8: warning: exported type Loader should have comment or be unexported (golint)
  • Line 11: warning: exported method Loader.New should have comment or be unexported (golint)
  • Line 15: warning: exported method Loader.Name should have comment or be unexported (golint)
  • Line 19: warning: exported method Loader.Handles should have comment or be unexported (golint)
  • Line 24: warning: exported method Loader.Builder should have comment or be unexported (golint)
  • Line 28: warning: exported method Loader.Runner should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign95%

IneffAssign detects ineffectual assignments in Go code.

• edward/edward/start_test.go
  • Line 115: warning: ineffectual assignment to err (ineffassign)

• edward/edward/telemetry_test.go
  • Line 42: warning: ineffectual assignment to err (ineffassign)

• edward/instance/instance.go
  • Line 66: warning: ineffectual assignment to err (ineffassign)

• edward/services/backends/commandline/buildandrun_test.go
  • Line 109: warning: ineffectual assignment to err (ineffassign)

• edward/test/acceptance/acceptance_test.go
  • Line 125: warning: ineffectual assignment to err (ineffassign)

• edward/edward/restart_test.go
  • Line 82: warning: ineffectual assignment to err (ineffassign)

misspell99%

Misspell Finds commonly misspelled English words

• edward/config/config_test.go
  • Line 70: warning: "wonderfull" is a misspelling of "wonderful" (misspell)