gofmt94%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• ZanRedisDB/transport/rafthttp/http_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/transport/rafthttp/pipeline_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/server/secondary_index_merge.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/rockredis/t_ttl_compact_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/cluster/pdnode_coord/pd_learner_coord.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/pdserver/server_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/server/httpapi.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/rockredis/t_bitmap_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/engine/mem_eng.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/engine/pebble_eng.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/transport/rafthttp/util_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/rockredis/t_zset_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/pkg/testutil/leak.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/tools/clustersync/main.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/node/namespace.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/node/state_machine.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/pkg/wait/wait.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• ZanRedisDB/transport/rafthttp/util.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint52%

Golint is a linter for Go source code.

• ZanRedisDB/engine/skiplist_iterator.go
  • Line 8: warning: exported type SkipListIterator should have comment or be unexported (golint)
  • Line 62: warning: comment on exported method SkipListIterator.First should be of the form "First ..." (golint)
  • Line 70: warning: comment on exported method SkipListIterator.Last should be of the form "Last ..." (golint)
  • Line 87: warning: comment on exported method SkipListIterator.SeekForPrev should be of the form "SeekForPrev ..." (golint)

• ZanRedisDB/common/listener.go
  • Line 23: warning: comment on exported type StoppableListener should be of the form "StoppableListener ..." (with optional leading article) (golint)
  • Line 30: warning: exported function NewStoppableListener should have comment or be unexported (golint)
  • Line 38: warning: exported method StoppableListener.Accept should have comment or be unexported (golint)

• ZanRedisDB/pkg/testutil/pauseable_handler.go
  • Line 22: warning: exported type PauseableHandler should have comment or be unexported (golint)
  • Line 47: warning: exported method PauseableHandler.Pause should have comment or be unexported (golint)
  • Line 53: warning: exported method PauseableHandler.Resume should have comment or be unexported (golint)

• ZanRedisDB/server/server.go
  • Line 16: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 48: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 53: warning: exported function SLogger should have comment or be unexported (golint)
  • Line 71: warning: exported type Server should have comment or be unexported (golint)
  • Line 85: warning: exported function NewServer should have comment or be unexported (golint)
  • Line 311: warning: exported method Server.Stop should have comment or be unexported (golint)
  • Line 334: warning: exported method Server.GetCoord should have comment or be unexported (golint)
  • Line 338: warning: exported method Server.GetNamespace should have comment or be unexported (golint)
  • Line 341: warning: exported method Server.GetNamespaceFromFullName should have comment or be unexported (golint)
  • Line 345: warning: exported method Server.GetLogSyncStatsInSyncLearner should have comment or be unexported (golint)
  • Line 349: warning: exported method Server.GetLogSyncStats should have comment or be unexported (golint)
  • Line 353: warning: exported method Server.GetTableStats should have comment or be unexported (golint)
  • Line 379: warning: exported method Server.GetStats should have comment or be unexported (golint)
  • Line 386: warning: exported method Server.GetDBStats should have comment or be unexported (golint)
  • Line 390: warning: exported method Server.GetWALDBStats should have comment or be unexported (golint)
  • Line 394: warning: exported method Server.DeleteRange should have comment or be unexported (golint)
  • Line 398: warning: exported method Server.InitKVNamespace should have comment or be unexported (golint)
  • Line 402: warning: exported method Server.RestartAsStandalone should have comment or be unexported (golint)
  • Line 409: warning: exported method Server.Start should have comment or be unexported (golint)
  • Line 466: warning: exported function GetPKAndHashSum should have comment or be unexported (golint)
  • Line 480: warning: exported method Server.GetHandleNode should have comment or be unexported (golint)
  • Line 504: warning: exported method Server.GetHandler should have comment or be unexported (golint)
  • Line 518: warning: exported method Server.GetWriteHandler should have comment or be unexported (golint)
  • Line 545: warning: comment on exported method Server.Process should be of the form "Process ..." (golint)
  • Line 589: warning: exported method Server.IsPeerRemoved should have comment or be unexported (golint)
  • Line 591: warning: exported method Server.ReportUnreachable should have comment or be unexported (golint)
  • Line 604: warning: exported method Server.ReportSnapshot should have comment or be unexported (golint)
  • Line 618: warning: comment on exported method Server.SaveDBFrom should be of the form "SaveDBFrom ..." (golint)
  • Line 631: warning: exported method Server.GetNsMgr should have comment or be unexported (golint)

• ZanRedisDB/wal/util.go
  • Line 26: warning: error var badWalName should have name of the form errFoo (golint)

• ZanRedisDB/raft/progress.go
  • Line 24: warning: exported const ProgressStateProbe should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: exported type ProgressStateType should have comment or be unexported (golint)

• ZanRedisDB/node/list.go
  • Line 177: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• ZanRedisDB/server/grpc_api.go
  • Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 38: warning: exported method Server.GetSyncedRaft should have comment or be unexported (golint)
  • Line 51: warning: exported method Server.ApplyRaftReqs should have comment or be unexported (golint)
  • Line 161: warning: exported method Server.NotifyTransferSnap should have comment or be unexported (golint)
  • Line 183: warning: exported method Server.NotifyApplySnap should have comment or be unexported (golint)
  • Line 209: warning: exported method Server.GetApplySnapStatus should have comment or be unexported (golint)

• ZanRedisDB/pkg/logutil/merge_logger.go
  • Line 87: warning: exported function NewMergeLogger should have comment or be unexported (golint)
  • Line 96: warning: exported method MergeLogger.MergeInfo should have comment or be unexported (golint)
  • Line 103: warning: exported method MergeLogger.MergeInfof should have comment or be unexported (golint)
  • Line 110: warning: exported method MergeLogger.MergeNotice should have comment or be unexported (golint)
  • Line 117: warning: exported method MergeLogger.MergeNoticef should have comment or be unexported (golint)
  • Line 124: warning: exported method MergeLogger.MergeWarning should have comment or be unexported (golint)
  • Line 131: warning: exported method MergeLogger.MergeWarningf should have comment or be unexported (golint)
  • Line 138: warning: exported method MergeLogger.MergeError should have comment or be unexported (golint)
  • Line 145: warning: exported method MergeLogger.MergeErrorf should have comment or be unexported (golint)

• ZanRedisDB/cluster/datanode_coord/dn_schema_coord.go
  • Line 1: warning: don't use an underscore in package name (golint)

• ZanRedisDB/pkg/types/urls.go
  • Line 26: warning: exported type URLs should have comment or be unexported (golint)
  • Line 28: warning: exported function NewURLs should have comment or be unexported (golint)
  • Line 56: warning: exported function MustNewURLs should have comment or be unexported (golint)
  • Line 68: warning: exported method URLs.Sort should have comment or be unexported (golint)
  • Line 75: warning: exported method URLs.StringSlice should have comment or be unexported (golint)

• ZanRedisDB/engine/radix_mem.go
  • Line 18: warning: exported function NewRadix should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_set.go
  • Line 188: warning: exported method RockDB.SAdd should have comment or be unexported (golint)
  • Line 239: warning: exported method RockDB.SGetVer should have comment or be unexported (golint)
  • Line 243: warning: exported method RockDB.SCard should have comment or be unexported (golint)
  • Line 248: warning: exported method RockDB.SIsMember should have comment or be unexported (golint)
  • Line 273: warning: exported method RockDB.SMembers should have comment or be unexported (golint)
  • Line 286: warning: comment on exported method RockDB.SRandMembers should be of the form "SRandMembers ..." (golint)
  • Line 346: warning: exported method RockDB.SPop should have comment or be unexported (golint)
  • Line 356: warning: exported method RockDB.SRem should have comment or be unexported (golint)
  • Line 414: warning: exported method RockDB.SClear should have comment or be unexported (golint)
  • Line 430: warning: exported method RockDB.SMclear should have comment or be unexported (golint)
  • Line 470: warning: exported method RockDB.SKeyExists should have comment or be unexported (golint)
  • Line 478: warning: exported method RockDB.SExpire should have comment or be unexported (golint)
  • Line 482: warning: exported method RockDB.SPersist should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_ttl_l.go
  • Line 22: warning: exported var ErrLocalBatchFullToCommit should have comment or be unexported (golint)
  • Line 206: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 209: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 215: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 364: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/pkg/wait/wait_time.go
  • Line 19: warning: exported type WaitTime should have comment or be unexported (golint)
  • Line 38: warning: exported function NewTimeList should have comment or be unexported (golint)

• ZanRedisDB/slow/slowlog.go
  • Line 27: warning: exported function SetRemoteLogger should have comment or be unexported (golint)
  • Line 35: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 42: warning: exported function ChangeSlowLogLevel should have comment or be unexported (golint)
  • Line 82: warning: exported type SlowLogInfo should have comment or be unexported (golint)
  • Line 88: warning: exported function NewSlowLogInfo should have comment or be unexported (golint)
  • Line 101: warning: exported function LogSlowDBWrite should have comment or be unexported (golint)
  • Line 120: warning: exported function LogDebugSlowWrite should have comment or be unexported (golint)
  • Line 137: warning: exported function LogSlowForSteps should have comment or be unexported (golint)
  • Line 157: warning: exported function LogLargeCollection should have comment or be unexported (golint)
  • Line 196: warning: exported function LogLargeValue should have comment or be unexported (golint)
  • Line 200: warning: exported function LogLargeBatchWrite should have comment or be unexported (golint)

• ZanRedisDB/pkg/transport/transport.go
  • Line 26: warning: exported function NewTransport should have comment or be unexported (golint)

• ZanRedisDB/node/ttl.go
  • Line 13: warning: exported var ErrExpiredBatchedBuffFull should have comment or be unexported (golint)
  • Line 34: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 42: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 50: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 58: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 66: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 74: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 82: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• ZanRedisDB/cluster/pdnode_coord/place_driver_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• ZanRedisDB/common/api_request.go
  • Line 29: warning: exported function NewDeadlineTransport should have comment or be unexported (golint)
  • Line 42: warning: comment on exported function APIRequest should be of the form "APIRequest ..." (golint)

• ZanRedisDB/common/binary.go
  • Line 9: warning: exported var VerBinary should have comment or be unexported (golint)
  • Line 14: warning: exported function VerString should have comment or be unexported (golint)

• ZanRedisDB/transport/rafthttp/peer.go
  • Line 38: warning: exported const ConnWriteTimeout should have comment (or a comment on this block) or be unexported (golint)
  • Line 58: warning: exported type Peer should have comment or be unexported (golint)

• ZanRedisDB/common/geohash/type.go
  • Line 3: warning: exported type Range should have comment or be unexported (golint)
  • Line 8: warning: exported type Point should have comment or be unexported (golint)
  • Line 13: warning: exported type HashBits should have comment or be unexported (golint)
  • Line 18: warning: exported method HashBits.IsZero should have comment or be unexported (golint)
  • Line 22: warning: exported method HashBits.Clean should have comment or be unexported (golint)
  • Line 27: warning: exported type Neighbors should have comment or be unexported (golint)
  • Line 38: warning: exported type Area should have comment or be unexported (golint)
  • Line 44: warning: exported type Radius should have comment or be unexported (golint)

• ZanRedisDB/pkg/pbutil/pbutil.go
  • Line 24: warning: exported type Marshaler should have comment or be unexported (golint)
  • Line 28: warning: exported type Unmarshaler should have comment or be unexported (golint)
  • Line 32: warning: exported function MustMarshal should have comment or be unexported (golint)
  • Line 40: warning: exported function MustUnmarshal should have comment or be unexported (golint)
  • Line 46: warning: exported function MaybeUnmarshal should have comment or be unexported (golint)
  • Line 53: warning: exported function GetBool should have comment or be unexported (golint)
  • Line 60: warning: exported function Boolp should have comment or be unexported (golint)

• ZanRedisDB/pkg/fileutil/lock_linux.go
  • Line 58: warning: exported function TryLockFile should have comment or be unexported (golint)
  • Line 79: warning: exported function LockFile should have comment or be unexported (golint)

• ZanRedisDB/stats/leader.go
  • Line 24: warning: comment on exported type PeersStats should be of the form "PeersStats ..." (with optional leading article) (golint)
  • Line 33: warning: exported function NewPeersStats should have comment or be unexported (golint)
  • Line 39: warning: exported method PeersStats.JSON should have comment or be unexported (golint)
  • Line 49: warning: exported method PeersStats.RemovePeer should have comment or be unexported (golint)
  • Line 55: warning: exported method PeersStats.Peer should have comment or be unexported (golint)

• ZanRedisDB/node/slow_limiter_test.go
  • Line 44: warning: don't use underscores in Go names; var slow50s_10sHist should be slow50s10sHist (golint)

• ZanRedisDB/pkg/testutil/recorder.go
  • Line 24: warning: exported type Action should have comment or be unexported (golint)
  • Line 29: warning: exported type Recorder should have comment or be unexported (golint)
  • Line 47: warning: exported method RecorderBuffered.Record should have comment or be unexported (golint)
  • Line 52: warning: exported method RecorderBuffered.Action should have comment or be unexported (golint)
  • Line 59: warning: exported method RecorderBuffered.Wait should have comment or be unexported (golint)
  • Line 69: warning: exported method RecorderBuffered.Chan should have comment or be unexported (golint)
  • Line 86: warning: exported function NewRecorderStream should have comment or be unexported (golint)

• ZanRedisDB/wal/wal.go
  • Line 58: warning: exported var ErrMetadataConflict should have comment or be unexported (golint)
  • Line 344: warning: exported method WAL.ChangeFsyncFlag should have comment or be unexported (golint)
  • Line 715: warning: exported method WAL.Sync should have comment or be unexported (golint)
  • Line 825: warning: exported method WAL.Save should have comment or be unexported (golint)
  • Line 864: warning: exported method WAL.SaveSnapshot should have comment or be unexported (golint)

• ZanRedisDB/server/httpapi.go
  • Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 32: warning: exported type RaftProgress should have comment or be unexported (golint)
  • Line 38: warning: comment on exported type CustomRaftStatus should be of the form "CustomRaftStatus ..." (with optional leading article) (golint)
  • Line 51: warning: exported method CustomRaftStatus.Init should have comment or be unexported (golint)
  • Line 70: warning: exported type RaftStatus should have comment or be unexported (golint)
  • Line 103: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 812: warning: should omit 2nd value from range; this loop is equivalent to `for uri := range ...` (golint)

• ZanRedisDB/rockredis/t_ttl.go
  • Line 134: warning: exported method RockDB.KVTtl should have comment or be unexported (golint)
  • Line 143: warning: exported method RockDB.HashTtl should have comment or be unexported (golint)
  • Line 152: warning: exported method RockDB.BitTtl should have comment or be unexported (golint)
  • Line 161: warning: exported method RockDB.ListTtl should have comment or be unexported (golint)
  • Line 170: warning: exported method RockDB.SetTtl should have comment or be unexported (golint)
  • Line 179: warning: exported method RockDB.ZSetTtl should have comment or be unexported (golint)
  • Line 188: warning: exported type TTLChecker should have comment or be unexported (golint)

• ZanRedisDB/internal/flume_log/client_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• ZanRedisDB/cluster/etcd_utils.go
  • Line 10: warning: exported const ErrCodeEtcdNotReachable should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: exported function IsEtcdNotReachable should have comment or be unexported (golint)
  • Line 35: warning: exported function IsEtcdWatchExpired should have comment or be unexported (golint)

• ZanRedisDB/common/file_sync.go
  • Line 25: warning: exported const SnapWaitTimeout should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: exported var ErrTransferOutofdate should have comment or be unexported (golint)
  • Line 29: warning: exported var ErrRsyncFailed should have comment or be unexported (golint)
  • Line 31: warning: exported function SetRsyncLimit should have comment or be unexported (golint)
  • Line 35: warning: comment on exported function RunFileSync should be of the form "RunFileSync ..." (golint)

• ZanRedisDB/common/logger.go
  • Line 31: warning: exported type Logger should have comment or be unexported (golint)
  • Line 37: warning: exported function NewLogger should have comment or be unexported (golint)
  • Line 52: warning: exported function NewDefaultLogger should have comment or be unexported (golint)
  • Line 74: warning: exported const LOG_ERR should have comment (or a comment on this block) or be unexported (golint)
  • Line 81: warning: exported type LevelLogger should have comment or be unexported (golint)
  • Line 86: warning: exported function NewLevelLogger should have comment or be unexported (golint)
  • Line 93: warning: exported method LevelLogger.SetLevel should have comment or be unexported (golint)
  • Line 97: warning: exported method LevelLogger.Level should have comment or be unexported (golint)
  • Line 101: warning: exported method LevelLogger.InfoDepth should have comment or be unexported (golint)
  • Line 107: warning: exported method LevelLogger.Infof should have comment or be unexported (golint)
  • Line 113: warning: exported method LevelLogger.DebugDepth should have comment or be unexported (golint)
  • Line 119: warning: exported method LevelLogger.Debugf should have comment or be unexported (golint)
  • Line 125: warning: exported method LevelLogger.Errorf should have comment or be unexported (golint)
  • Line 131: warning: exported method LevelLogger.ErrorDepth should have comment or be unexported (golint)
  • Line 137: warning: exported method LevelLogger.Warningf should have comment or be unexported (golint)
  • Line 143: warning: exported method LevelLogger.Fatalf should have comment or be unexported (golint)
  • Line 150: warning: exported method LevelLogger.Panicf should have comment or be unexported (golint)
  • Line 158: warning: exported method LevelLogger.Info should have comment or be unexported (golint)
  • Line 164: warning: exported method LevelLogger.Debug should have comment or be unexported (golint)
  • Line 176: warning: exported method LevelLogger.Warning should have comment or be unexported (golint)
  • Line 182: warning: exported method LevelLogger.Fatal should have comment or be unexported (golint)
  • Line 189: warning: exported method LevelLogger.Panic should have comment or be unexported (golint)
  • Line 256: warning: exported function NewMergeLogger should have comment or be unexported (golint)
  • Line 265: warning: exported method MergeLogger.MergeInfo should have comment or be unexported (golint)
  • Line 272: warning: exported method MergeLogger.MergeInfof should have comment or be unexported (golint)
  • Line 279: warning: exported method MergeLogger.MergeWarning should have comment or be unexported (golint)
  • Line 286: warning: exported method MergeLogger.MergeWarningf should have comment or be unexported (golint)
  • Line 293: warning: exported method MergeLogger.MergeError should have comment or be unexported (golint)
  • Line 300: warning: exported method MergeLogger.MergeErrorf should have comment or be unexported (golint)
  • Line 370: warning: exported function FlushZapDefault should have comment or be unexported (golint)
  • Line 376: warning: exported function SetZapRotateOptions should have comment or be unexported (golint)

• ZanRedisDB/raft/status.go
  • Line 23: warning: exported type Status should have comment or be unexported (golint)

• ZanRedisDB/node/set.go
  • Line 160: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 174: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/node/state_machine.go
  • Line 46: warning: exported type StateMachine should have comment or be unexported (golint)
  • Line 67: warning: exported function NewStateMachine should have comment or be unexported (golint)
  • Line 92: warning: exported type IBatchOperator should have comment or be unexported (golint)
  • Line 194: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
  • Line 311: warning: exported function NewKVStoreSM should have comment or be unexported (golint)
  • Line 548: warning: exported function GetValidBackupInfo should have comment or be unexported (golint)

• ZanRedisDB/cluster/datanode_coord/data_node_coordinator.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 23: warning: exported var MaxRetryWait should have comment or be unexported (golint)
  • Line 27: warning: comment on exported var TransferLeaderWait should be of the form "TransferLeaderWait ..." (golint)
  • Line 32: warning: comment on exported var ChangeLeaderInRaftWait should be of the form "ChangeLeaderInRaftWait ..." (golint)
  • Line 39: warning: exported function ChangeIntervalForTest should have comment or be unexported (golint)
  • Line 48: warning: comment on exported const MaxRaftJoinRunning should be of the form "MaxRaftJoinRunning ..." (golint)
  • Line 52: warning: exported function GetNamespacePartitionFileName should have comment or be unexported (golint)
  • Line 61: warning: exported function GetNamespacePartitionBasePath should have comment or be unexported (golint)
  • Line 65: warning: exported type PartitionList should have comment or be unexported (golint)
  • Line 75: warning: exported type DataCoordinator should have comment or be unexported (golint)
  • Line 90: warning: exported function NewDataCoordinator should have comment or be unexported (golint)
  • Line 103: warning: exported method DataCoordinator.GetClusterName should have comment or be unexported (golint)
  • Line 107: warning: exported method DataCoordinator.GetMyID should have comment or be unexported (golint)
  • Line 111: warning: exported method DataCoordinator.GetMyRegID should have comment or be unexported (golint)
  • Line 115: warning: exported method DataCoordinator.SetRegister should have comment or be unexported (golint)
  • Line 144: warning: exported method DataCoordinator.UpdateSyncerWriteOnly should have comment or be unexported (golint)
  • Line 148: warning: exported method DataCoordinator.GetSyncerWriteOnly should have comment or be unexported (golint)
  • Line 152: warning: exported method DataCoordinator.UpdateSyncerNormalInit should have comment or be unexported (golint)
  • Line 156: warning: exported method DataCoordinator.GetSyncerNormalInit should have comment or be unexported (golint)
  • Line 191: warning: exported method DataCoordinator.Start should have comment or be unexported (golint)
  • Line 254: warning: exported method DataCoordinator.Stop should have comment or be unexported (golint)
  • Line 263: warning: exported method DataCoordinator.GetCurrentPD should have comment or be unexported (golint)
  • Line 1249: warning: exported method DataCoordinator.RestartAsStandalone should have comment or be unexported (golint)
  • Line 1276: warning: exported method DataCoordinator.GetSnapshotSyncInfo should have comment or be unexported (golint)
  • Line 1304: warning: exported method DataCoordinator.IsRemovingMember should have comment or be unexported (golint)
  • Line 1326: warning: exported method DataCoordinator.UpdateMeForNamespaceLeader should have comment or be unexported (golint)
  • Line 1395: warning: exported method DataCoordinator.Stats should have comment or be unexported (golint)

• ZanRedisDB/pkg/types/set.go
  • Line 23: warning: exported type Set should have comment or be unexported (golint)
  • Line 34: warning: exported function NewUnsafeSet should have comment or be unexported (golint)
  • Line 42: warning: exported function NewThreadsafeSet should have comment or be unexported (golint)

• ZanRedisDB/cluster/register.go
  • Line 10: warning: exported var ErrKeyAlreadyExist should have comment or be unexported (golint)
  • Line 17: warning: exported type EpochType should have comment or be unexported (golint)
  • Line 19: warning: exported type NodeInfo should have comment or be unexported (golint)
  • Line 36: warning: exported method NodeInfo.GetID should have comment or be unexported (golint)
  • Line 36: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 40: warning: exported method NodeInfo.Epoch should have comment or be unexported (golint)
  • Line 40: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 44: warning: exported method NodeInfo.GetRegisterID should have comment or be unexported (golint)
  • Line 44: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 48: warning: exported type ClusterMetaInfo should have comment or be unexported (golint)
  • Line 53: warning: exported type NamespaceMetaInfo should have comment or be unexported (golint)
  • Line 68: warning: exported method NamespaceMetaInfo.MetaEpoch should have comment or be unexported (golint)
  • Line 68: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 72: warning: exported method NamespaceMetaInfo.DeepClone should have comment or be unexported (golint)
  • Line 72: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 81: warning: exported type RemovingInfo should have comment or be unexported (golint)
  • Line 86: warning: exported type PartitionReplicaInfo should have comment or be unexported (golint)
  • Line 95: warning: exported method PartitionReplicaInfo.IsLearner should have comment or be unexported (golint)
  • Line 95: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 106: warning: exported method PartitionReplicaInfo.GetISR should have comment or be unexported (golint)
  • Line 106: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 120: warning: exported method PartitionReplicaInfo.Epoch should have comment or be unexported (golint)
  • Line 120: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 124: warning: exported method PartitionReplicaInfo.DeepClone should have comment or be unexported (golint)
  • Line 124: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 148: warning: exported type RealLeader should have comment or be unexported (golint)
  • Line 153: warning: exported type PartitionMetaInfo should have comment or be unexported (golint)
  • Line 161: warning: exported method PartitionMetaInfo.IsISRQuorum should have comment or be unexported (golint)
  • Line 161: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 165: warning: exported method PartitionMetaInfo.GetRealLeader should have comment or be unexported (golint)
  • Line 165: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 169: warning: exported method PartitionMetaInfo.GetCopy should have comment or be unexported (golint)
  • Line 169: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 178: warning: exported method PartitionMetaInfo.GetDesp should have comment or be unexported (golint)
  • Line 178: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 182: warning: exported type ConsistentStore should have comment or be unexported (golint)
  • Line 188: warning: exported type SchemaInfo should have comment or be unexported (golint)
  • Line 193: warning: exported type Register should have comment or be unexported (golint)
  • Line 218: warning: comment on exported type PDRegister should be of the form "PDRegister ..." (with optional leading article) (golint)
  • Line 251: warning: exported type DataNodeRegister should have comment or be unexported (golint)

• ZanRedisDB/raft/read_only.go
  • Line 31: warning: exported type ReadState should have comment or be unexported (golint)

• ZanRedisDB/internal/flume_log/log_item.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 34: warning: exported function NewLogItem should have comment or be unexported (golint)
  • Line 50: warning: exported type LogItem should have comment or be unexported (golint)
  • Line 55: warning: exported method LogItem.SetDetail should have comment or be unexported (golint)
  • Line 55: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 59: warning: exported method LogItem.SetTag should have comment or be unexported (golint)
  • Line 59: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 63: warning: exported method LogItem.Bytes should have comment or be unexported (golint)
  • Line 63: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 72: warning: exported type LogHeader should have comment or be unexported (golint)
  • Line 86: warning: exported type LogBody should have comment or be unexported (golint)
  • Line 95: warning: exported method LogBody.Bytes should have comment or be unexported (golint)

• ZanRedisDB/cluster/coordinator_stats.go
  • Line 16: warning: exported function AddCounter should have comment or be unexported (golint)
  • Line 25: warning: exported function IncCounter should have comment or be unexported (golint)
  • Line 29: warning: exported function IncCounterBy should have comment or be unexported (golint)
  • Line 44: warning: exported type CoordErrStatsData should have comment or be unexported (golint)
  • Line 50: warning: exported type CoordErrStats should have comment or be unexported (golint)
  • Line 61: warning: exported method CoordErrStats.GetCopy should have comment or be unexported (golint)
  • Line 61: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 73: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 77: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 81: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 94: warning: exported type ISRStat should have comment or be unexported (golint)
  • Line 99: warning: exported type NamespaceCoordStat should have comment or be unexported (golint)
  • Line 106: warning: exported type CoordStats should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_collections.go
  • Line 174: warning: comment on exported method RockDB.GetCollVersionKey should be of the form "GetCollVersionKey ..." (golint)

• ZanRedisDB/rockredis/scan.go
  • Line 15: warning: exported method RockDB.Scan should have comment or be unexported (golint)
  • Line 23: warning: exported method RockDB.ScanWithBuffer should have comment or be unexported (golint)
  • Line 327: warning: exported method RockDB.HScan should have comment or be unexported (golint)
  • Line 369: warning: exported method RockDB.SScan should have comment or be unexported (golint)
  • Line 417: warning: exported method RockDB.ZScan should have comment or be unexported (golint)

• ZanRedisDB/apps/restore/main.go
  • Line 34: warning: exported const MAGIC should have comment (or a comment on this block) or be unexported (golint)
  • Line 61: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/metric/stats.go
  • Line 8: warning: exported type WriteStats should have comment or be unexported (golint)
  • Line 15: warning: exported method WriteStats.UpdateSizeStats should have comment or be unexported (golint)
  • Line 29: warning: exported method WriteStats.BatchUpdateLatencyStats should have comment or be unexported (golint)
  • Line 41: warning: exported method WriteStats.UpdateLatencyStats should have comment or be unexported (golint)
  • Line 53: warning: exported method WriteStats.UpdateWriteStats should have comment or be unexported (golint)
  • Line 58: warning: exported method WriteStats.Copy should have comment or be unexported (golint)
  • Line 69: warning: exported type TableStats should have comment or be unexported (golint)
  • Line 76: warning: exported type CompactFilterStats should have comment or be unexported (golint)
  • Line 82: warning: exported type NamespaceStats should have comment or be unexported (golint)
  • Line 95: warning: exported type LogSyncStats should have comment or be unexported (golint)
  • Line 103: warning: exported type ScanStats should have comment or be unexported (golint)
  • Line 109: warning: exported method ScanStats.IncScanCount should have comment or be unexported (golint)
  • Line 113: warning: exported method ScanStats.UpdateLatencyStats should have comment or be unexported (golint)
  • Line 125: warning: exported method ScanStats.UpdateScanStats should have comment or be unexported (golint)
  • Line 130: warning: exported method ScanStats.Copy should have comment or be unexported (golint)
  • Line 139: warning: exported type ServerStats should have comment or be unexported (golint)

• ZanRedisDB/pdserver/http.go
  • Line 9: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 32: warning: exported type PartitionNodeInfo should have comment or be unexported (golint)
  • Line 37: warning: exported function GetValidPartitionNum should have comment or be unexported (golint)
  • Line 48: warning: exported function GetValidPartitionID should have comment or be unexported (golint)
  • Line 59: warning: exported function GetValidReplicator should have comment or be unexported (golint)
  • Line 369: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 387: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 802: warning: exported method Server.IsTombstonePDNode should have comment or be unexported (golint)
  • Line 809: warning: exported method Server.TombstonePDNode should have comment or be unexported (golint)
  • Line 815: warning: exported method Server.DelTombstonePDNode should have comment or be unexported (golint)

• ZanRedisDB/node/remote_sync_mgr.go
  • Line 14: warning: exported type SyncedState should have comment or be unexported (golint)
  • Line 22: warning: exported method SyncedState.IsNewer should have comment or be unexported (golint)
  • Line 29: warning: exported method SyncedState.IsSame should have comment or be unexported (golint)
  • Line 33: warning: exported method SyncedState.IsNewer2 should have comment or be unexported (golint)
  • Line 41: warning: exported const ApplySnapUnknown should have comment (or a comment on this block) or be unexported (golint)
  • Line 60: warning: exported type SnapApplyStatus should have comment or be unexported (golint)
  • Line 262: warning: exported method KVNode.SetRemoteClusterSyncedRaft should have comment or be unexported (golint)
  • Line 265: warning: exported method KVNode.GetRemoteClusterSyncedRaft should have comment or be unexported (golint)
  • Line 270: warning: exported method KVNode.GetLogSyncStatsInSyncLearner should have comment or be unexported (golint)
  • Line 280: warning: exported method KVNode.ApplyRemoteSnapshot should have comment or be unexported (golint)
  • Line 345: warning: exported method KVNode.BeginTransferRemoteSnap should have comment or be unexported (golint)
  • Line 389: warning: exported method KVNode.GetApplyRemoteSnapStatus should have comment or be unexported (golint)

• ZanRedisDB/node/geo.go
  • Line 25: warning: exported const RADIUS_COORDS should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported const SORT_NONE should have comment (or a comment on this block) or be unexported (golint)
  • Line 408: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/node/node.go
  • Line 34: warning: exported var UseRedisV2 should have comment or be unexported (golint)
  • Line 36: warning: exported function EnableSnapForTest should have comment or be unexported (golint)
  • Line 50: warning: exported var ErrReadIndexTimeout should have comment or be unexported (golint)
  • Line 54: warning: exported const RedisReq should have comment (or a comment on this block) or be unexported (golint)
  • Line 66: warning: don't use underscores in Go names; const ProposeOp_Backup should be ProposeOpBackup (golint)
  • Line 66: warning: exported const ProposeOp_Backup should have comment (or a comment on this block) or be unexported (golint)
  • Line 67: warning: don't use underscores in Go names; const ProposeOp_TransferRemoteSnap should be ProposeOpTransferRemoteSnap (golint)
  • Line 68: warning: don't use underscores in Go names; const ProposeOp_ApplyRemoteSnap should be ProposeOpApplyRemoteSnap (golint)
  • Line 69: warning: don't use underscores in Go names; const ProposeOp_RemoteConfChange should be ProposeOpRemoteConfChange (golint)
  • Line 70: warning: don't use underscores in Go names; const ProposeOp_ApplySkippedRemoteSnap should be ProposeOpApplySkippedRemoteSnap (golint)
  • Line 71: warning: don't use underscores in Go names; const ProposeOp_DeleteTable should be ProposeOpDeleteTable (golint)
  • Line 74: warning: exported type CompactAPIRange should have comment or be unexported (golint)
  • Line 80: warning: exported type DeleteTableRange should have comment or be unexported (golint)
  • Line 92: warning: exported method DeleteTableRange.CheckValid should have comment or be unexported (golint)
  • Line 111: warning: exported type RequestResultCode should have comment or be unexported (golint)
  • Line 114: warning: exported const ReqComplete should have comment (or a comment on this block) or be unexported (golint)
  • Line 193: warning: comment on exported type KVNode should be of the form "KVNode ..." (with optional leading article) (golint)
  • Line 225: warning: exported type KVSnapInfo should have comment or be unexported (golint)
  • Line 235: warning: exported method KVSnapInfo.GetData should have comment or be unexported (golint)
  • Line 247: warning: exported function NewKVNode should have comment or be unexported (golint)
  • Line 309: warning: exported method KVNode.GetRaftConfig should have comment or be unexported (golint)
  • Line 313: warning: exported method KVNode.GetLearnerRole should have comment or be unexported (golint)
  • Line 317: warning: exported method KVNode.GetFullName should have comment or be unexported (golint)
  • Line 321: warning: exported method KVNode.Start should have comment or be unexported (golint)
  • Line 352: warning: exported method KVNode.StopRaft should have comment or be unexported (golint)
  • Line 356: warning: exported method KVNode.IsStopping should have comment or be unexported (golint)
  • Line 360: warning: exported method KVNode.Stop should have comment or be unexported (golint)
  • Line 376: warning: comment on exported method KVNode.BackupDB should be of the form "BackupDB ..." (golint)
  • Line 396: warning: exported method KVNode.OptimizeDBExpire should have comment or be unexported (golint)
  • Line 408: warning: exported method KVNode.DisableOptimizeDB should have comment or be unexported (golint)
  • Line 416: warning: exported method KVNode.OptimizeDB should have comment or be unexported (golint)
  • Line 432: warning: exported method KVNode.OptimizeDBAnyRange should have comment or be unexported (golint)
  • Line 444: warning: exported method KVNode.DeleteRange should have comment or be unexported (golint)
  • Line 470: warning: exported method KVNode.IsLead should have comment or be unexported (golint)
  • Line 474: warning: exported method KVNode.GetRaftStatus should have comment or be unexported (golint)
  • Line 478: warning: comment on exported method KVNode.IsReplicaRaftReady should be of the form "IsReplicaRaftReady ..." (golint)
  • Line 497: warning: exported method KVNode.GetLeadMember should have comment or be unexported (golint)
  • Line 501: warning: exported method KVNode.GetMembers should have comment or be unexported (golint)
  • Line 505: warning: exported method KVNode.GetLearners should have comment or be unexported (golint)
  • Line 509: warning: exported method KVNode.GetLocalMemberInfo should have comment or be unexported (golint)
  • Line 522: warning: exported method KVNode.GetDBInternalStats should have comment or be unexported (golint)
  • Line 529: warning: exported method KVNode.SetMaxBackgroundOptions should have comment or be unexported (golint)
  • Line 536: warning: exported method KVNode.GetWALDBInternalStats should have comment or be unexported (golint)
  • Line 548: warning: exported method KVNode.GetStats should have comment or be unexported (golint)
  • Line 564: warning: exported method KVNode.CleanData should have comment or be unexported (golint)
  • Line 568: warning: exported method KVNode.GetHandler should have comment or be unexported (golint)
  • Line 571: warning: exported method KVNode.GetWriteHandler should have comment or be unexported (golint)
  • Line 575: warning: exported method KVNode.GetMergeHandler should have comment or be unexported (golint)
  • Line 579: warning: exported method KVNode.ProposeInternal should have comment or be unexported (golint)
  • Line 636: warning: exported method KVNode.SetDynamicInfo should have comment or be unexported (golint)
  • Line 642: warning: exported method KVNode.IsWriteReady should have comment or be unexported (golint)
  • Line 652: warning: exported method KVNode.ProposeRawAsyncFromSyncer should have comment or be unexported (golint)
  • Line 725: warning: exported method KVNode.ProposeRawAndWaitFromSyncer should have comment or be unexported (golint)
  • Line 752: warning: exported method KVNode.UpdateWriteStats should have comment or be unexported (golint)
  • Line 765: warning: exported type FutureRsp should have comment or be unexported (golint)
  • Line 770: warning: comment on exported method FutureRsp.WaitRsp should be of the form "WaitRsp ..." (golint)
  • Line 834: warning: exported method KVNode.RedisV2ProposeAsync should have comment or be unexported (golint)
  • Line 847: warning: exported method KVNode.RedisProposeAsync should have comment or be unexported (golint)
  • Line 861: warning: exported method KVNode.RedisPropose should have comment or be unexported (golint)
  • Line 878: warning: exported method KVNode.CustomPropose should have comment or be unexported (golint)
  • Line 895: warning: exported method KVNode.ProposeChangeTableSchema should have comment or be unexported (golint)
  • Line 915: warning: exported method KVNode.FillMyMemberInfo should have comment or be unexported (golint)
  • Line 919: warning: exported method KVNode.ProposeAddLearner should have comment or be unexported (golint)
  • Line 940: warning: exported method KVNode.ProposeAddMember should have comment or be unexported (golint)
  • Line 961: warning: exported method KVNode.ProposeRemoveMember should have comment or be unexported (golint)
  • Line 974: warning: exported method KVNode.ProposeUpdateMember should have comment or be unexported (golint)
  • Line 1004: warning: exported method KVNode.Tick should have comment or be unexported (golint)
  • Line 1012: warning: exported method KVNode.GetLastSnapIndex should have comment or be unexported (golint)
  • Line 1016: warning: exported method KVNode.SetLastSnapIndex should have comment or be unexported (golint)
  • Line 1020: warning: exported method KVNode.GetAppliedIndex should have comment or be unexported (golint)
  • Line 1024: warning: exported method KVNode.SetAppliedIndex should have comment or be unexported (golint)
  • Line 1028: warning: exported method KVNode.IsRaftSynced should have comment or be unexported (golint)
  • Line 1497: warning: exported method KVNode.GetSnapshot should have comment or be unexported (golint)
  • Line 1508: warning: exported method KVNode.PrepareSnapshot should have comment or be unexported (golint)
  • Line 1521: warning: exported method KVNode.RestoreFromSnapshot should have comment or be unexported (golint)
  • Line 1537: warning: exported method KVNode.CheckLocalBackup should have comment or be unexported (golint)
  • Line 1549: warning: exported method KVNode.GetLastLeaderChangedTime should have comment or be unexported (golint)
  • Line 1553: warning: exported method KVNode.ReportMeLeaderToCluster should have comment or be unexported (golint)
  • Line 1567: warning: comment on exported method KVNode.OnRaftLeaderChanged should be of the form "OnRaftLeaderChanged ..." (golint)
  • Line 1574: warning: exported method KVNode.Process should have comment or be unexported (golint)
  • Line 1596: warning: exported method KVNode.UpdateSnapshotState should have comment or be unexported (golint)
  • Line 1602: warning: exported method KVNode.ReportUnreachable should have comment or be unexported (golint)
  • Line 1606: warning: exported method KVNode.ReportSnapshot should have comment or be unexported (golint)
  • Line 1610: warning: exported method KVNode.SaveDBFrom should have comment or be unexported (golint)
  • Line 1614: warning: exported method KVNode.IsPeerRemoved should have comment or be unexported (golint)
  • Line 1616: warning: exported method KVNode.CanPass should have comment or be unexported (golint)
  • Line 1619: warning: exported method KVNode.MaybeAddSlow should have comment or be unexported (golint)
  • Line 1622: warning: exported method KVNode.PreWaitQueue should have comment or be unexported (golint)

• ZanRedisDB/server/merge.go
  • Line 216: warning: comment on exported method Server.GetMergeHandlers should be of the form "GetMergeHandlers ..." (golint)

• ZanRedisDB/stats/stats.go
  • Line 18: warning: exported type Stats should have comment or be unexported (golint)

• ZanRedisDB/cluster/pdnode_coord/pd_coordinator.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 20: warning: exported var ErrAlreadyExist should have comment or be unexported (golint)
  • Line 44: warning: exported function ChangeIntervalForTest should have comment or be unexported (golint)
  • Line 52: warning: exported type PDCoordinator should have comment or be unexported (golint)
  • Line 78: warning: exported function NewPDCoordinator should have comment or be unexported (golint)
  • Line 118: warning: exported method PDCoordinator.SetBalanceInterval should have comment or be unexported (golint)
  • Line 122: warning: exported method PDCoordinator.SetRegister should have comment or be unexported (golint)
  • Line 126: warning: exported method PDCoordinator.AutoBalanceEnabled should have comment or be unexported (golint)
  • Line 130: warning: exported method PDCoordinator.Start should have comment or be unexported (golint)
  • Line 159: warning: exported method PDCoordinator.Stop should have comment or be unexported (golint)
  • Line 996: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1035: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/raft/proposal_queue.go
  • Line 26: warning: exported var ErrProposalQueueTimeout should have comment or be unexported (golint)
  • Line 27: warning: exported var ErrProposalQueueTooFull should have comment or be unexported (golint)

• ZanRedisDB/raft/util.go
  • Line 24: warning: exported method StateType.MarshalJSON should have comment or be unexported (golint)
  • Line 49: warning: exported function IsLocalMsg should have comment or be unexported (golint)
  • Line 54: warning: exported function IsResponseMsg should have comment or be unexported (golint)

• ZanRedisDB/pkg/transport/unix_listener.go
  • Line 24: warning: exported function NewUnixListener should have comment or be unexported (golint)

• ZanRedisDB/raft/badger_storage.go
  • Line 63: warning: exported function NewBadgerStorage should have comment or be unexported (golint)
  • Line 131: warning: exported method BadgerStorage.Close should have comment or be unexported (golint)

• ZanRedisDB/rockredis/util.go
  • Line 15: warning: exported function Int64 should have comment or be unexported (golint)
  • Line 20: warning: exported function Uint64 should have comment or be unexported (golint)
  • Line 32: warning: exported function FormatInt64ToSlice should have comment or be unexported (golint)
  • Line 36: warning: exported function PutInt64ToBuf should have comment or be unexported (golint)
  • Line 40: warning: exported function PutInt64 should have comment or be unexported (golint)
  • Line 46: warning: exported function PutFloat64 should have comment or be unexported (golint)
  • Line 53: warning: exported function Float64 should have comment or be unexported (golint)
  • Line 66: warning: exported function StrInt64 should have comment or be unexported (golint)
  • Line 76: warning: exported function StrUint64 should have comment or be unexported (golint)
  • Line 86: warning: exported function StrInt32 should have comment or be unexported (golint)
  • Line 97: warning: exported function StrInt8 should have comment or be unexported (golint)
  • Line 108: warning: exported function MinUint should have comment or be unexported (golint)
  • Line 111: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 116: warning: exported function MaxUint should have comment or be unexported (golint)
  • Line 119: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 124: warning: exported function MinInt should have comment or be unexported (golint)
  • Line 127: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 132: warning: exported function MaxInt should have comment or be unexported (golint)
  • Line 135: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 140: warning: exported function MinUint8 should have comment or be unexported (golint)
  • Line 143: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 148: warning: exported function MaxUint8 should have comment or be unexported (golint)
  • Line 151: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 156: warning: exported function MinInt8 should have comment or be unexported (golint)
  • Line 159: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 164: warning: exported function MaxInt8 should have comment or be unexported (golint)
  • Line 167: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 172: warning: exported function MinUint16 should have comment or be unexported (golint)
  • Line 175: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 180: warning: exported function MaxUint16 should have comment or be unexported (golint)
  • Line 183: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 188: warning: exported function MinInt16 should have comment or be unexported (golint)
  • Line 191: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 196: warning: exported function MaxInt16 should have comment or be unexported (golint)
  • Line 199: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 204: warning: exported function MinUint32 should have comment or be unexported (golint)
  • Line 207: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 212: warning: exported function MaxUint32 should have comment or be unexported (golint)
  • Line 215: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 220: warning: exported function MinInt32 should have comment or be unexported (golint)
  • Line 223: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 228: warning: exported function MaxInt32 should have comment or be unexported (golint)
  • Line 231: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 236: warning: exported function MinUint64 should have comment or be unexported (golint)
  • Line 239: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 244: warning: exported function MaxUint64 should have comment or be unexported (golint)
  • Line 247: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 252: warning: exported function MinInt64 should have comment or be unexported (golint)
  • Line 255: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 260: warning: exported function MaxInt64 should have comment or be unexported (golint)
  • Line 263: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/node/raft_storage.go
  • Line 17: warning: exported function NewRaftPersistStorage should have comment or be unexported (golint)

• ZanRedisDB/server/config.go
  • Line 7: warning: exported type ServerConfig should have comment or be unexported (golint)
  • Line 49: warning: exported type NamespaceNodeConfig should have comment or be unexported (golint)
  • Line 54: warning: exported type ConfigFile should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_bitmap_test.go
  • Line 95: warning: should omit 2nd value from range; this loop is equivalent to `for bpos := range ...` (golint)
  • Line 173: warning: should omit 2nd value from range; this loop is equivalent to `for bpos := range ...` (golint)

• ZanRedisDB/transport/rafthttp/transport.go
  • Line 39: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 44: warning: exported function SetLogLevel should have comment or be unexported (golint)
  • Line 48: warning: exported type Raft should have comment or be unexported (golint)
  • Line 55: warning: exported type Transporter should have comment or be unexported (golint)
  • Line 138: warning: exported method Transport.Start should have comment or be unexported (golint)
  • Line 154: warning: exported method Transport.IsStarted should have comment or be unexported (golint)
  • Line 160: warning: exported method Transport.Handler should have comment or be unexported (golint)
  • Line 173: warning: exported method Transport.Get should have comment or be unexported (golint)
  • Line 179: warning: exported method Transport.Send should have comment or be unexported (golint)
  • Line 209: warning: exported method Transport.Stop should have comment or be unexported (golint)
  • Line 259: warning: exported method Transport.AddRemote should have comment or be unexported (golint)
  • Line 302: warning: exported method Transport.RemovePeer should have comment or be unexported (golint)
  • Line 308: warning: exported method Transport.RemoveAllPeers should have comment or be unexported (golint)
  • Line 316: warning: exported method Transport.GetAllPeers should have comment or be unexported (golint)
  • Line 340: warning: exported method Transport.UpdatePeer should have comment or be unexported (golint)
  • Line 366: warning: exported method Transport.ActiveSince should have comment or be unexported (golint)
  • Line 375: warning: exported method Transport.SendSnapshot should have comment or be unexported (golint)
  • Line 392: warning: exported method Transport.Pause should have comment or be unexported (golint)
  • Line 400: warning: exported method Transport.Resume should have comment or be unexported (golint)
  • Line 410: warning: exported function NewNopTransporter should have comment or be unexported (golint)
  • Line 435: warning: exported function NewSnapTransporter should have comment or be unexported (golint)

• ZanRedisDB/raft/storage.go
  • Line 76: warning: exported type IExtRaftStorage should have comment or be unexported (golint)
  • Line 109: warning: exported function NewRealMemoryStorage should have comment or be unexported (golint)
  • Line 150: warning: exported method MemoryStorage.Close should have comment or be unexported (golint)

• ZanRedisDB/cluster/pdnode_coord/pd_api.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 13: warning: comment on exported method PDCoordinator.IsClusterStable should be of the form "IsClusterStable ..." (golint)
  • Line 19: warning: exported method PDCoordinator.IsMineLeader should have comment or be unexported (golint)
  • Line 23: warning: exported method PDCoordinator.GetAllPDNodes should have comment or be unexported (golint)
  • Line 27: warning: exported method PDCoordinator.GetPDLeader should have comment or be unexported (golint)
  • Line 31: warning: exported method PDCoordinator.GetAllDataNodes should have comment or be unexported (golint)
  • Line 35: warning: comment on exported method PDCoordinator.GetAllNamespaces should be of the form "GetAllNamespaces ..." (golint)
  • Line 41: warning: exported method PDCoordinator.SwitchAutoBalance should have comment or be unexported (golint)
  • Line 51: warning: exported method PDCoordinator.SetClusterStableNodeNum should have comment or be unexported (golint)
  • Line 59: warning: exported method PDCoordinator.SetClusterUpgradeState should have comment or be unexported (golint)
  • Line 81: warning: exported method PDCoordinator.RemoveNamespaceFromNode should have comment or be unexported (golint)
  • Line 101: warning: exported method PDCoordinator.MarkNodeAsRemoving should have comment or be unexported (golint)
  • Line 123: warning: exported method PDCoordinator.DeleteNamespace should have comment or be unexported (golint)
  • Line 173: warning: exported method PDCoordinator.ChangeNamespaceMetaParam should have comment or be unexported (golint)
  • Line 192: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 230: warning: exported method PDCoordinator.CreateNamespace should have comment or be unexported (golint)
  • Line 318: warning: exported method PDCoordinator.AddHIndexSchema should have comment or be unexported (golint)
  • Line 323: warning: exported method PDCoordinator.DelHIndexSchema should have comment or be unexported (golint)
  • Line 327: warning: exported method PDCoordinator.RemoveLearnerFromNs should have comment or be unexported (golint)

• ZanRedisDB/engine/kv.go
  • Line 16: warning: exported type RefSlice should have comment or be unexported (golint)
  • Line 30: warning: exported function SetLogLevel should have comment or be unexported (golint)
  • Line 34: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 39: warning: exported type CRange should have comment or be unexported (golint)
  • Line 44: warning: exported type SharedRockConfig should have comment or be unexported (golint)
  • Line 49: warning: exported type RockEngConfig should have comment or be unexported (golint)
  • Line 59: warning: exported function NewRockConfig should have comment or be unexported (golint)
  • Line 67: warning: exported type RockOptions should have comment or be unexported (golint)
  • Line 98: warning: exported function FillDefaultOptions should have comment or be unexported (golint)
  • Line 166: warning: exported type KVCheckpoint should have comment or be unexported (golint)
  • Line 170: warning: exported type ICompactFilter should have comment or be unexported (golint)
  • Line 175: warning: exported type KVEngine should have comment or be unexported (golint)
  • Line 214: warning: exported function GetDataDirFromBase should have comment or be unexported (golint)
  • Line 227: warning: exported function NewKVEng should have comment or be unexported (golint)
  • Line 238: warning: exported function NewSharedEngConfig should have comment or be unexported (golint)

• ZanRedisDB/node/raft.go
  • Line 66: warning: exported type Snapshot should have comment or be unexported (golint)
  • Line 70: warning: exported type IRaftPersistStorage should have comment or be unexported (golint)
  • Line 86: warning: exported type DataStorage should have comment or be unexported (golint)
  • Line 239: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 779: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1207: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1210: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1213: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• ZanRedisDB/stats/server.go
  • Line 56: warning: exported method TransportStats.JSON should have comment or be unexported (golint)
  • Line 138: warning: exported method TransportStats.BecomeLeader should have comment or be unexported (golint)

• ZanRedisDB/tools/clustersync/main.go
  • Line 23: warning: exported type RaftProgress should have comment or be unexported (golint)
  • Line 29: warning: comment on exported type CustomRaftStatus should be of the form "CustomRaftStatus ..." (with optional leading article) (golint)
  • Line 42: warning: exported type LogSyncStats should have comment or be unexported (golint)
  • Line 50: warning: exported function JsonString should have comment or be unexported (golint)
  • Line 62: warning: should omit 2nd value from range; this loop is equivalent to `for nspid := range ...` (golint)

• ZanRedisDB/raft/rocksdb_storage.go
  • Line 41: warning: exported function NewRocksStorage should have comment or be unexported (golint)
  • Line 67: warning: exported method RocksStorage.Eng should have comment or be unexported (golint)
  • Line 71: warning: exported method RocksStorage.Close should have comment or be unexported (golint)

• ZanRedisDB/node/slow_limiter.go
  • Line 20: warning: exported function EnableSlowLimiterTest should have comment or be unexported (golint)
  • Line 45: warning: exported var SlowRefuseCostMs should have comment or be unexported (golint)
  • Line 46: warning: exported var SlowHalfOpenSec should have comment or be unexported (golint)
  • Line 64: warning: exported function IsMaybeSlowWriteCmd should have comment or be unexported (golint)
  • Line 69: warning: exported function ChangeSlowRefuseCost should have comment or be unexported (golint)
  • Line 73: warning: exported function RegisterSlowConfChanged should have comment or be unexported (golint)
  • Line 88: warning: exported type SlowWaitDone should have comment or be unexported (golint)
  • Line 92: warning: exported method SlowWaitDone.Done should have comment or be unexported (golint)
  • Line 118: warning: exported function NewSlowLimiter should have comment or be unexported (golint)
  • Line 137: warning: exported method SlowLimiter.Start should have comment or be unexported (golint)
  • Line 143: warning: exported method SlowLimiter.Stop should have comment or be unexported (golint)
  • Line 210: warning: exported method SlowLimiter.TurnOn should have comment or be unexported (golint)
  • Line 214: warning: exported method SlowLimiter.TurnOff should have comment or be unexported (golint)
  • Line 222: warning: exported method SlowLimiter.MarkHeavySlow should have comment or be unexported (golint)
  • Line 241: warning: exported method SlowLimiter.MaybeAddSlow should have comment or be unexported (golint)
  • Line 293: warning: exported method SlowLimiter.AddSlow should have comment or be unexported (golint)
  • Line 306: warning: exported method SlowLimiter.PreWaitQueue should have comment or be unexported (golint)
  • Line 357: warning: exported method SlowLimiter.CanPass should have comment or be unexported (golint)
  • Line 416: warning: exported method SlowLimiter.RecordSlowCmd should have comment or be unexported (golint)

• ZanRedisDB/engine/radixdb/memdb.go
  • Line 44: warning: exported method MemDB.Size should have comment or be unexported (golint)

• ZanRedisDB/pkg/idutil/id.go
  • Line 56: warning: exported function NewGenerator should have comment or be unexported (golint)

• ZanRedisDB/internal/test/assertions.go
  • Line 10: warning: exported function Assert should have comment or be unexported (golint)
  • Line 19: warning: exported function Equal should have comment or be unexported (golint)
  • Line 28: warning: exported function NotEqual should have comment or be unexported (golint)
  • Line 37: warning: exported function Nil should have comment or be unexported (golint)
  • Line 46: warning: exported function NotNil should have comment or be unexported (golint)

• ZanRedisDB/cluster/datanode_coord/data_learner_coord.go
  • Line 1: warning: don't use an underscore in package name (golint)

• ZanRedisDB/rockredis/t_hash_index.go
  • Line 17: warning: exported var ErrIndexExist should have comment or be unexported (golint)
  • Line 361: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 375: warning: comment on exported method RockDB.HsetIndexSearch should be of the form "HsetIndexSearch ..." (golint)
  • Line 389: warning: comment on exported type IndexCondition should be of the form "IndexCondition ..." (with optional leading article) (golint)
  • Line 401: warning: exported type HIndexResp should have comment or be unexported (golint)
  • Line 407: warning: exported type HsetIndex should have comment or be unexported (golint)
  • Line 412: warning: exported method HsetIndex.SearchRec should have comment or be unexported (golint)
  • Line 412: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 526: warning: exported method HsetIndex.UpdateRec should have comment or be unexported (golint)
  • Line 526: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 557: warning: exported method HsetIndex.RemoveRec should have comment or be unexported (golint)
  • Line 557: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 580: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• ZanRedisDB/cluster/pdnode_coord/pd_learner_coord.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 56: warning: comment on exported method PDCoordinator.SwitchStartLearner should be of the form "SwitchStartLearner ..." (golint)
  • Line 68: warning: exported method PDCoordinator.GetLearnerRunningState should have comment or be unexported (golint)
  • Line 90: warning: should omit 2nd value from range; this loop is equivalent to `for ns := range ...` (golint)
  • Line 199: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 228: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 276: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 306: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/engine/mem_eng.go
  • Line 80: warning: exported function NewMemEng should have comment or be unexported (golint)
  • Line 345: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)

• ZanRedisDB/pdserver/server.go
  • Line 20: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 25: warning: exported function SLogger should have comment or be unexported (golint)
  • Line 29: warning: exported type Server should have comment or be unexported (golint)
  • Line 39: warning: exported function NewServer should have comment or be unexported (golint)
  • Line 120: warning: exported method Server.Stop should have comment or be unexported (golint)
  • Line 127: warning: exported method Server.Start should have comment or be unexported (golint)

• ZanRedisDB/node/schema.go
  • Line 10: warning: exported method KVNode.GetIndexSchema should have comment or be unexported (golint)

• ZanRedisDB/node/namespace.go
  • Line 26: warning: exported var ErrNamespaceAlreadyExist should have comment or be unexported (golint)
  • Line 44: warning: exported type NamespaceNode should have comment or be unexported (golint)
  • Line 52: warning: exported method NamespaceNode.IsReady should have comment or be unexported (golint)
  • Line 56: warning: exported method NamespaceNode.FullName should have comment or be unexported (golint)
  • Line 60: warning: exported method NamespaceNode.SwitchForLearnerLeader should have comment or be unexported (golint)
  • Line 64: warning: exported method NamespaceNode.SetDynamicInfo should have comment or be unexported (golint)
  • Line 91: warning: exported function LoadMagicCode should have comment or be unexported (golint)
  • Line 117: warning: exported method NamespaceNode.SetMagicCode should have comment or be unexported (golint)
  • Line 142: warning: exported method NamespaceNode.SetDataFixState should have comment or be unexported (golint)
  • Line 145: warning: exported method NamespaceNode.GetLastLeaderChangedTime should have comment or be unexported (golint)
  • Line 149: warning: exported method NamespaceNode.GetRaftID should have comment or be unexported (golint)
  • Line 153: warning: exported method NamespaceNode.CheckRaftConf should have comment or be unexported (golint)
  • Line 166: warning: exported method NamespaceNode.Close should have comment or be unexported (golint)
  • Line 172: warning: exported method NamespaceNode.Destroy should have comment or be unexported (golint)
  • Line 176: warning: exported method NamespaceNode.IsDataNeedFix should have comment or be unexported (golint)
  • Line 180: warning: comment on exported method NamespaceNode.IsNsNodeFullReady should be of the form "IsNsNodeFullReady ..." (golint)
  • Line 192: warning: exported method NamespaceNode.GetLearners should have comment or be unexported (golint)
  • Line 196: warning: exported method NamespaceNode.GetMembers should have comment or be unexported (golint)
  • Line 200: warning: exported method NamespaceNode.Start should have comment or be unexported (golint)
  • Line 217: warning: exported method NamespaceNode.TransferMyLeader should have comment or be unexported (golint)
  • Line 234: warning: exported type NamespaceMeta should have comment or be unexported (golint)
  • Line 239: warning: exported type NamespaceMgr should have comment or be unexported (golint)
  • Line 253: warning: exported function NewNamespaceMgr should have comment or be unexported (golint)
  • Line 274: warning: exported method NamespaceMgr.SetDBOptions should have comment or be unexported (golint)
  • Line 307: warning: exported method NamespaceMgr.SetMaxBackgroundOptions should have comment or be unexported (golint)
  • Line 323: warning: exported method NamespaceMgr.SetRateLimiterBytesPerSec should have comment or be unexported (golint)
  • Line 330: warning: exported method NamespaceMgr.SetIClusterInfo should have comment or be unexported (golint)
  • Line 334: warning: exported method NamespaceMgr.LoadMachineRegID should have comment or be unexported (golint)
  • Line 348: warning: exported method NamespaceMgr.SaveMachineRegID should have comment or be unexported (golint)
  • Line 356: warning: exported method NamespaceMgr.GetDataRoot should have comment or be unexported (golint)
  • Line 360: warning: exported method NamespaceMgr.CheckLocalNamespaces should have comment or be unexported (golint)
  • Line 386: warning: exported method NamespaceMgr.Start should have comment or be unexported (golint)
  • Line 413: warning: exported method NamespaceMgr.Stop should have comment or be unexported (golint)
  • Line 451: warning: exported method NamespaceMgr.IsAllRecoveryDone should have comment or be unexported (golint)
  • Line 464: warning: exported method NamespaceMgr.GetNamespaces should have comment or be unexported (golint)
  • Line 527: warning: exported method NamespaceMgr.InitNamespaceNode should have comment or be unexported (golint)
  • Line 647: warning: exported function HashedKey should have comment or be unexported (golint)
  • Line 650: warning: exported function GetHashedPartitionID should have comment or be unexported (golint)
  • Line 654: warning: exported method NamespaceMgr.GetNamespaceNodeWithPrimaryKeySum should have comment or be unexported (golint)
  • Line 675: warning: exported method NamespaceMgr.GetNamespaceNodeWithPrimaryKey should have comment or be unexported (golint)
  • Line 680: warning: exported method NamespaceMgr.GetNamespaceNodes should have comment or be unexported (golint)
  • Line 701: warning: exported method NamespaceMgr.GetNamespaceNode should have comment or be unexported (golint)
  • Line 713: warning: exported method NamespaceMgr.GetNamespaceNodeFromGID should have comment or be unexported (golint)
  • Line 733: warning: exported method NamespaceMgr.GetWALDBStats should have comment or be unexported (golint)
  • Line 750: warning: exported method NamespaceMgr.GetDBStats should have comment or be unexported (golint)
  • Line 767: warning: exported method NamespaceMgr.GetLogSyncStatsInSyncer should have comment or be unexported (golint)
  • Line 788: warning: exported method NamespaceMgr.GetLogSyncStats should have comment or be unexported (golint)
  • Line 817: warning: exported method NamespaceMgr.GetStats should have comment or be unexported (golint)
  • Line 851: warning: exported method NamespaceMgr.BackupDB should have comment or be unexported (golint)
  • Line 863: warning: exported method NamespaceMgr.EnableTopn should have comment or be unexported (golint)
  • Line 875: warning: exported method NamespaceMgr.ClearTopn should have comment or be unexported (golint)
  • Line 887: warning: exported method NamespaceMgr.DisableOptimizeDB should have comment or be unexported (golint)
  • Line 899: warning: exported method NamespaceMgr.OptimizeDB should have comment or be unexported (golint)
  • Line 911: warning: exported method NamespaceMgr.OptimizeDBExpire should have comment or be unexported (golint)
  • Line 923: warning: exported method NamespaceMgr.OptimizeDBAnyRange should have comment or be unexported (golint)
  • Line 935: warning: exported method NamespaceMgr.DeleteRange should have comment or be unexported (golint)
  • Line 954: warning: comment on exported method NamespaceMgr.CleanSharedNsFiles should be of the form "CleanSharedNsFiles ..." (golint)
  • Line 960: warning: should omit 2nd value from range; this loop is equivalent to `for fullName := range ...` (golint)
  • Line 1009: warning: should omit 2nd value from range; this loop is equivalent to `for fullName := range ...` (golint)
  • Line 1130: warning: exported method NamespaceMgr.HandleSlowLimiterSwitchChanged should have comment or be unexported (golint)

• ZanRedisDB/pkg/ioutil/readcloser.go
  • Line 30: warning: exported var ErrShortRead should have comment or be unexported (golint)

• ZanRedisDB/cluster/common.go
  • Line 11: warning: exported const ErrFailedOnNotLeader should have comment (or a comment on this block) or be unexported (golint)
  • Line 17: warning: exported const MAX_WRITE_RETRY should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported type CoordErrType should have comment or be unexported (golint)
  • Line 23: warning: exported const CoordNoErr should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: exported const RpcNoErr should have comment (or a comment on this block) or be unexported (golint)
  • Line 40: warning: exported const RpcErrLeavingISRWait should have comment (or a comment on this block) or be unexported (golint)
  • Line 51: warning: exported type ErrRPCRetCode should have comment or be unexported (golint)
  • Line 53: warning: comment on exported type CoordErr should be of the form "CoordErr ..." (with optional leading article) (golint)
  • Line 61: warning: exported type CommonCoordErr should have comment or be unexported (golint)
  • Line 65: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 69: warning: exported function NewCoordErr should have comment or be unexported (golint)
  • Line 77: warning: exported function NewCoordErrWithCode should have comment or be unexported (golint)
  • Line 85: warning: exported method CoordErr.ToErrorType should have comment or be unexported (golint)
  • Line 85: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 93: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 104: warning: exported method CoordErr.HasError should have comment or be unexported (golint)
  • Line 104: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 111: warning: exported method CoordErr.IsEqual should have comment or be unexported (golint)
  • Line 111: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 134: warning: exported method CoordErr.IsNetErr should have comment or be unexported (golint)
  • Line 134: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 138: warning: exported method CoordErr.IsLocalErr should have comment or be unexported (golint)
  • Line 138: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 142: warning: exported method CoordErr.CanRetryWrite should have comment or be unexported (golint)
  • Line 142: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 157: warning: exported var ErrNamespaceInfoNotFound should have comment or be unexported (golint)
  • Line 174: warning: exported function GenNodeID should have comment or be unexported (golint)
  • Line 193: warning: exported function ExtractRegIDFromGenID should have comment or be unexported (golint)
  • Line 202: warning: exported function ExtractNodeInfoFromID should have comment or be unexported (golint)
  • Line 214: warning: exported function FindSlice should have comment or be unexported (golint)
  • Line 223: warning: exported function MergeList should have comment or be unexported (golint)
  • Line 234: warning: exported function FilterList should have comment or be unexported (golint)
  • Line 245: warning: exported type NamespaceNameInfo should have comment or be unexported (golint)
  • Line 250: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 254: warning: exported type Options should have comment or be unexported (golint)

• ZanRedisDB/engine/writebatch.go
  • Line 10: warning: exported type WriteBatch should have comment or be unexported (golint)

• ZanRedisDB/cluster/register_etcd.go
  • Line 19: warning: exported const EVENT_WATCH_L_CREATE should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: exported var EtcdTTL should have comment or be unexported (golint)
  • Line 28: warning: exported const ROOT_DIR should have comment (or a comment on this block) or be unexported (golint)
  • Line 43: warning: exported const ETCD_LOCK_NAMESPACE should have comment (or a comment on this block) or be unexported (golint)
  • Line 46: warning: exported type MasterChanInfo should have comment or be unexported (golint)
  • Line 51: warning: exported function IsEtcdNotFile should have comment or be unexported (golint)
  • Line 55: warning: exported function IsEtcdNodeExist should have comment or be unexported (golint)
  • Line 193: warning: exported type EtcdRegister should have comment or be unexported (golint)
  • Line 211: warning: exported function NewEtcdRegister should have comment or be unexported (golint)
  • Line 227: warning: exported method EtcdRegister.InitClusterID should have comment or be unexported (golint)
  • Line 234: warning: exported method EtcdRegister.Start should have comment or be unexported (golint)
  • Line 252: warning: exported method EtcdRegister.Stop should have comment or be unexported (golint)
  • Line 265: warning: exported method EtcdRegister.GetAllPDNodes should have comment or be unexported (golint)
  • Line 284: warning: exported method EtcdRegister.GetAllNamespaces should have comment or be unexported (golint)
  • Line 296: warning: exported method EtcdRegister.GetNamespaceSchemas should have comment or be unexported (golint)
  • Line 319: warning: exported method EtcdRegister.GetNamespacesNotifyChan should have comment or be unexported (golint)
  • Line 546: warning: exported method EtcdRegister.GetNamespacePartInfo should have comment or be unexported (golint)
  • Line 563: warning: exported method EtcdRegister.GetRemoteNamespaceReplicaInfo should have comment or be unexported (golint)
  • Line 580: warning: exported method EtcdRegister.GetNamespaceTableSchema should have comment or be unexported (golint)
  • Line 594: warning: exported method EtcdRegister.GetNamespaceInfo should have comment or be unexported (golint)
  • Line 608: warning: exported method EtcdRegister.GetNamespaceMetaInfo should have comment or be unexported (golint)
  • Line 631: warning: exported method EtcdRegister.GetKV should have comment or be unexported (golint)
  • Line 646: warning: exported method EtcdRegister.SaveKV should have comment or be unexported (golint)
  • Line 711: warning: comment on exported type PDEtcdRegister should be of the form "PDEtcdRegister ..." (with optional leading article) (golint)
  • Line 724: warning: exported function NewPDEtcdRegister should have comment or be unexported (golint)
  • Line 735: warning: exported method PDEtcdRegister.Register should have comment or be unexported (golint)
  • Line 778: warning: exported method PDEtcdRegister.Unregister should have comment or be unexported (golint)
  • Line 794: warning: exported method PDEtcdRegister.PrepareNamespaceMinGID should have comment or be unexported (golint)
  • Line 818: warning: exported method PDEtcdRegister.GetClusterMetaInfo should have comment or be unexported (golint)
  • Line 831: warning: exported method PDEtcdRegister.GetClusterEpoch should have comment or be unexported (golint)
  • Line 843: warning: exported method PDEtcdRegister.AcquireAndWatchLeader should have comment or be unexported (golint)
  • Line 878: warning: exported method PDEtcdRegister.CheckIfLeader should have comment or be unexported (golint)
  • Line 889: warning: exported method PDEtcdRegister.GetDataNodes should have comment or be unexported (golint)
  • Line 894: warning: exported method PDEtcdRegister.WatchDataNodes should have comment or be unexported (golint)
  • Line 958: warning: exported method PDEtcdRegister.CreateNamespacePartition should have comment or be unexported (golint)
  • Line 969: warning: exported method PDEtcdRegister.CreateNamespace should have comment or be unexported (golint)
  • Line 989: warning: exported method PDEtcdRegister.IsExistNamespace should have comment or be unexported (golint)
  • Line 1000: warning: exported method PDEtcdRegister.IsExistNamespacePartition should have comment or be unexported (golint)
  • Line 1011: warning: exported method PDEtcdRegister.UpdateNamespaceMetaInfo should have comment or be unexported (golint)
  • Line 1035: warning: exported method PDEtcdRegister.DeleteWholeNamespace should have comment or be unexported (golint)
  • Line 1044: warning: exported method PDEtcdRegister.DeleteNamespacePart should have comment or be unexported (golint)
  • Line 1055: warning: exported method PDEtcdRegister.UpdateNamespacePartReplicaInfo should have comment or be unexported (golint)
  • Line 1080: warning: exported method PDEtcdRegister.UpdateNamespaceSchema should have comment or be unexported (golint)
  • Line 1101: warning: exported type DNEtcdRegister should have comment or be unexported (golint)
  • Line 1110: warning: exported function NewDNEtcdRegister should have comment or be unexported (golint)
  • Line 1120: warning: exported method DNEtcdRegister.Register should have comment or be unexported (golint)
  • Line 1184: warning: exported method DNEtcdRegister.Unregister should have comment or be unexported (golint)
  • Line 1204: warning: exported method DNEtcdRegister.GetNamespaceLeader should have comment or be unexported (golint)
  • Line 1218: warning: exported method DNEtcdRegister.UpdateNamespaceLeader should have comment or be unexported (golint)
  • Line 1239: warning: exported method DNEtcdRegister.GetNodeInfo should have comment or be unexported (golint)
  • Line 1255: warning: exported method DNEtcdRegister.NewRegisterNodeID should have comment or be unexported (golint)
  • Line 1272: warning: exported method DNEtcdRegister.WatchPDLeader should have comment or be unexported (golint)

• ZanRedisDB/node/syncer_learner.go
  • Line 21: warning: exported function EnableForTest should have comment or be unexported (golint)
  • Line 33: warning: exported function SetSyncerNormalInit should have comment or be unexported (golint)
  • Line 41: warning: exported function IsSyncerNormalInit should have comment or be unexported (golint)
  • Line 67: warning: exported function NewLogSyncerSM should have comment or be unexported (golint)
  • Line 125: warning: exported function GetLogLatencyStats should have comment or be unexported (golint)

• ZanRedisDB/common/geohash/geohash.go
  • Line 10: warning: comment on exported const WGS84_LAT_MIN should be of the form "WGS84_LAT_MIN ..." (golint)
  • Line 13: warning: exported const WGS84_LAT_MAX should have comment (or a comment on this block) or be unexported (golint)
  • Line 17: warning: comment on exported const WGS84_GEO_STEP should be of the form "WGS84_GEO_STEP ..." (golint)
  • Line 22: warning: exported var WGS84_LONG_RANGE should have comment or be unexported (golint)
  • Line 27: warning: exported var ErrPositionOutOfRange should have comment or be unexported (golint)
  • Line 31: warning: exported function EncodeWGS84 should have comment or be unexported (golint)
  • Line 38: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 43: warning: exported function DecodeWGS84 should have comment or be unexported (golint)
  • Line 51: warning: exported function DecodeToLongLatWGS84 should have comment or be unexported (golint)
  • Line 56: warning: exported function Encode should have comment or be unexported (golint)
  • Line 90: warning: exported function DecodeAreaToLongLat should have comment or be unexported (golint)

• ZanRedisDB/internal/flume_log/flume_client.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 11: warning: exported type FlumeClient should have comment or be unexported (golint)
  • Line 20: warning: exported function NewFlumeClient should have comment or be unexported (golint)
  • Line 96: warning: exported method FlumeClient.SendLog should have comment or be unexported (golint)
  • Line 119: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/cluster/etcd_master_lock.go
  • Line 1: warning: package comment should be of the form "Package cluster ..." (golint)
  • Line 15: warning: exported type EVENT_TYPE should have comment or be unexported (golint)
  • Line 18: warning: exported const MASTER_ADD should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported const RETRY_SLEEP should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: exported type MasterEvent should have comment or be unexported (golint)
  • Line 34: warning: exported type Master should have comment or be unexported (golint)
  • Line 42: warning: exported type EtcdLock should have comment or be unexported (golint)
  • Line 59: warning: exported function NewMaster should have comment or be unexported (golint)
  • Line 76: warning: exported method EtcdLock.Start should have comment or be unexported (golint)
  • Line 76: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 96: warning: exported method EtcdLock.Stop should have comment or be unexported (golint)
  • Line 96: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 111: warning: exported method EtcdLock.GetEventsChan should have comment or be unexported (golint)
  • Line 111: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 115: warning: exported method EtcdLock.GetKey should have comment or be unexported (golint)
  • Line 115: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 119: warning: exported method EtcdLock.GetMaster should have comment or be unexported (golint)
  • Line 119: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 125: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 209: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 231: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 247: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• ZanRedisDB/engine/pebble_eng.go
  • Line 47: warning: exported function GetRocksdbUint64 should have comment or be unexported (golint)
  • Line 59: warning: exported type Uint64AddMerger should have comment or be unexported (golint)
  • Line 63: warning: exported method Uint64AddMerger.MergeNewer should have comment or be unexported (golint)
  • Line 80: warning: exported method Uint64AddMerger.MergeOlder should have comment or be unexported (golint)
  • Line 84: warning: exported method Uint64AddMerger.Finish should have comment or be unexported (golint)
  • Line 132: warning: exported type PebbleEng should have comment or be unexported (golint)
  • Line 146: warning: exported function NewPebbleEng should have comment or be unexported (golint)
  • Line 228: warning: exported method PebbleEng.NewWriteBatch should have comment or be unexported (golint)
  • Line 235: warning: exported method PebbleEng.DefaultWriteBatch should have comment or be unexported (golint)
  • Line 242: warning: exported method PebbleEng.GetDataDir should have comment or be unexported (golint)
  • Line 246: warning: exported method PebbleEng.SetCompactionFilter should have comment or be unexported (golint)
  • Line 249: warning: exported method PebbleEng.SetMaxBackgroundOptions should have comment or be unexported (golint)
  • Line 271: warning: exported method PebbleEng.CheckDBEngForRead should have comment or be unexported (golint)
  • Line 284: warning: exported method PebbleEng.OpenEng should have comment or be unexported (golint)
  • Line 323: warning: exported method PebbleEng.DeletedBeforeCompact should have comment or be unexported (golint)
  • Line 327: warning: exported method PebbleEng.AddDeletedCnt should have comment or be unexported (golint)
  • Line 331: warning: exported method PebbleEng.LastCompactTime should have comment or be unexported (golint)
  • Line 335: warning: exported method PebbleEng.CompactRange should have comment or be unexported (golint)
  • Line 347: warning: exported method PebbleEng.CompactAllRange should have comment or be unexported (golint)
  • Line 351: warning: exported method PebbleEng.DisableManualCompact should have comment or be unexported (golint)
  • Line 354: warning: exported method PebbleEng.GetApproximateTotalKeyNum should have comment or be unexported (golint)
  • Line 358: warning: exported method PebbleEng.GetApproximateKeyNum should have comment or be unexported (golint)
  • Line 362: warning: exported method PebbleEng.SetOptsForLogStorage should have comment or be unexported (golint)
  • Line 366: warning: exported method PebbleEng.GetApproximateSizes should have comment or be unexported (golint)
  • Line 379: warning: exported method PebbleEng.IsClosed should have comment or be unexported (golint)
  • Line 386: warning: exported method PebbleEng.CloseEng should have comment or be unexported (golint)
  • Line 402: warning: exported method PebbleEng.CloseAll should have comment or be unexported (golint)
  • Line 411: warning: exported method PebbleEng.GetStatistics should have comment or be unexported (golint)
  • Line 420: warning: exported method PebbleEng.GetInternalStatus should have comment or be unexported (golint)
  • Line 426: warning: exported method PebbleEng.GetInternalPropertyStatus should have comment or be unexported (golint)
  • Line 430: warning: exported method PebbleEng.GetBytesNoLock should have comment or be unexported (golint)
  • Line 445: warning: exported method PebbleEng.GetBytes should have comment or be unexported (golint)
  • Line 454: warning: exported method PebbleEng.MultiGetBytes should have comment or be unexported (golint)
  • Line 458: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
  • Line 468: warning: exported method PebbleEng.Exist should have comment or be unexported (golint)
  • Line 477: warning: exported method PebbleEng.ExistNoLock should have comment or be unexported (golint)
  • Line 490: warning: exported method PebbleEng.GetRefNoLock should have comment or be unexported (golint)
  • Line 498: warning: exported method PebbleEng.GetRef should have comment or be unexported (golint)
  • Line 507: warning: exported method PebbleEng.GetValueWithOp should have comment or be unexported (golint)
  • Line 517: warning: exported method PebbleEng.GetValueWithOpNoLock should have comment or be unexported (golint)
  • Line 530: warning: exported method PebbleEng.DeleteFilesInRange should have comment or be unexported (golint)
  • Line 534: warning: exported method PebbleEng.GetIterator should have comment or be unexported (golint)
  • Line 542: warning: exported method PebbleEng.NewCheckpoint should have comment or be unexported (golint)

• ZanRedisDB/metric/collheap.go
  • Line 11: warning: exported const DefaultHeapCapacity should have comment (or a comment on this block) or be unexported (golint)
  • Line 37: warning: exported method PriorityQueue.Push should have comment or be unexported (golint)
  • Line 44: warning: exported method PriorityQueue.Pop should have comment or be unexported (golint)
  • Line 60: warning: exported type CollSizeHeap should have comment or be unexported (golint)
  • Line 67: warning: exported function NewCollSizeHeap should have comment or be unexported (golint)
  • Line 77: warning: exported method CollSizeHeap.Update should have comment or be unexported (golint)
  • Line 120: warning: exported method CollSizeHeap.TopKeys should have comment or be unexported (golint)

• ZanRedisDB/pkg/fileutil/purge.go
  • Line 25: warning: exported function PurgeFile should have comment or be unexported (golint)
  • Line 29: warning: exported function PurgeFileWithDoneNotify should have comment or be unexported (golint)

• ZanRedisDB/node/zset.go
  • Line 568: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• ZanRedisDB/rockredis/t_bitmap.go
  • Line 17: warning: exported const MaxBitOffsetV2 should have comment (or a comment on this block) or be unexported (golint)
  • Line 246: warning: exported method RockDB.BitGetVer should have comment or be unexported (golint)
  • Line 257: warning: exported method RockDB.BitGetV2 should have comment or be unexported (golint)
  • Line 296: warning: exported method RockDB.BitCountV2 should have comment or be unexported (golint)
  • Line 354: warning: exported method RockDB.BitClear should have comment or be unexported (golint)
  • Line 404: warning: exported method RockDB.BitKeyExist should have comment or be unexported (golint)
  • Line 415: warning: exported method RockDB.BitExpire should have comment or be unexported (golint)
  • Line 419: warning: exported method RockDB.BitPersist should have comment or be unexported (golint)

• ZanRedisDB/common/dynamic_conf.go
  • Line 12: warning: exported const ConfCheckSnapTimeout should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: exported type KeyChangedHandler should have comment or be unexported (golint)
  • Line 48: warning: exported function RegisterConfChangedHandler should have comment or be unexported (golint)
  • Line 52: warning: exported function DumpDynamicConf should have comment or be unexported (golint)
  • Line 66: warning: exported function SetIntDynamicConf should have comment or be unexported (golint)
  • Line 80: warning: exported function IsConfSetted should have comment or be unexported (golint)
  • Line 92: warning: exported function GetIntDynamicConf should have comment or be unexported (golint)
  • Line 100: warning: exported function SetStrDynamicConf should have comment or be unexported (golint)
  • Line 111: warning: exported function GetStrDynamicConf should have comment or be unexported (golint)

• ZanRedisDB/engine/rockeng.go
  • Line 92: warning: exported type RockEng should have comment or be unexported (golint)
  • Line 107: warning: exported function NewRockEng should have comment or be unexported (golint)
  • Line 254: warning: exported method RockEng.SetCompactionFilter should have comment or be unexported (golint)
  • Line 258: warning: exported method RockEng.SetMaxBackgroundOptions should have comment or be unexported (golint)
  • Line 330: warning: exported method RockEng.SetOptsForLogStorage should have comment or be unexported (golint)
  • Line 338: warning: exported method RockEng.GetOpts should have comment or be unexported (golint)
  • Line 342: warning: exported method RockEng.GetDataDir should have comment or be unexported (golint)
  • Line 346: warning: exported method RockEng.CheckDBEngForRead should have comment or be unexported (golint)
  • Line 357: warning: exported method RockEng.OpenEng should have comment or be unexported (golint)
  • Line 395: warning: exported method RockEng.DeletedBeforeCompact should have comment or be unexported (golint)
  • Line 399: warning: exported method RockEng.AddDeletedCnt should have comment or be unexported (golint)
  • Line 403: warning: exported method RockEng.LastCompactTime should have comment or be unexported (golint)
  • Line 407: warning: exported method RockEng.CompactRange should have comment or be unexported (golint)
  • Line 417: warning: exported method RockEng.CompactAllRange should have comment or be unexported (golint)
  • Line 422: warning: exported method RockEng.DisableManualCompact should have comment or be unexported (golint)
  • Line 431: warning: exported method RockEng.GetApproximateTotalKeyNum should have comment or be unexported (golint)
  • Line 441: warning: exported method RockEng.GetApproximateKeyNum should have comment or be unexported (golint)
  • Line 449: warning: exported method RockEng.GetApproximateSizes should have comment or be unexported (golint)
  • Line 457: warning: exported method RockEng.IsClosed should have comment or be unexported (golint)
  • Line 464: warning: exported method RockEng.CloseEng should have comment or be unexported (golint)
  • Line 479: warning: exported method RockEng.CloseAll should have comment or be unexported (golint)
  • Line 507: warning: exported method RockEng.GetStatistics should have comment or be unexported (golint)
  • Line 511: warning: exported method RockEng.GetInternalStatus should have comment or be unexported (golint)
  • Line 531: warning: exported method RockEng.GetInternalPropertyStatus should have comment or be unexported (golint)
  • Line 535: warning: exported method RockEng.GetBytesNoLock should have comment or be unexported (golint)
  • Line 539: warning: exported method RockEng.GetBytes should have comment or be unexported (golint)
  • Line 543: warning: exported method RockEng.MultiGetBytes should have comment or be unexported (golint)
  • Line 547: warning: exported method RockEng.Exist should have comment or be unexported (golint)
  • Line 551: warning: exported method RockEng.ExistNoLock should have comment or be unexported (golint)
  • Line 555: warning: exported method RockEng.GetRefNoLock should have comment or be unexported (golint)
  • Line 563: warning: exported method RockEng.GetRef should have comment or be unexported (golint)
  • Line 571: warning: exported method RockEng.GetValueWithOp should have comment or be unexported (golint)
  • Line 581: warning: exported method RockEng.GetValueWithOpNoLock should have comment or be unexported (golint)
  • Line 591: warning: exported method RockEng.GetIterator should have comment or be unexported (golint)
  • Line 599: warning: exported method RockEng.DeleteFilesInRange should have comment or be unexported (golint)
  • Line 606: warning: exported method RockEng.NewCheckpoint should have comment or be unexported (golint)

• ZanRedisDB/snap/message.go
  • Line 39: warning: exported function NewMessage should have comment or be unexported (golint)
  • Line 55: warning: exported method Message.CloseWithError should have comment or be unexported (golint)

• ZanRedisDB/tools/data_tool/main.go
  • Line 33: warning: exported type DeleteTableRange should have comment or be unexported (golint)

• ZanRedisDB/common/geohash/util.go
  • Line 23: warning: exported const MERCATOR_MAX should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: comment on exported const EARTH_RADIUS_IN_METERS should be of the form "EARTH_RADIUS_IN_METERS ..." (golint)
  • Line 28: warning: don't use underscores in Go names; const D_R should be DR (golint)
  • Line 93: warning: exported function DistBetweenGeoHashWGS84 should have comment or be unexported (golint)
  • Line 100: warning: comment on exported function GetDistance should be of the form "GetDistance ..." (golint)
  • Line 117: warning: exported function EncodeToBase32 should have comment or be unexported (golint)
  • Line 127: warning: exported function GetAreasByRadiusWGS84 should have comment or be unexported (golint)
  • Line 273: warning: exported function GetNeighbors should have comment or be unexported (golint)

• ZanRedisDB/cluster/datanode_coord/data_node_coordinator_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• ZanRedisDB/pkg/wait/wait.go
  • Line 24: warning: exported type WaitResult should have comment or be unexported (golint)
  • Line 76: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
  • Line 132: warning: exported function NewWithResponse should have comment or be unexported (golint)

• ZanRedisDB/pkg/fileutil/lock.go
  • Line 23: warning: exported var ErrLocked should have comment or be unexported (golint)
  • Line 26: warning: exported type LockedFile should have comment or be unexported (golint)

• ZanRedisDB/transport/rafthttp/msg_codec.go
  • Line 48: warning: exported var ErrExceedSizeLimit should have comment or be unexported (golint)

• ZanRedisDB/rockredis/const.go
  • Line 10: warning: exported const EngType should have comment (or a comment on this block) or be unexported (golint)
  • Line 13: warning: exported type ErrType should have comment or be unexported (golint)
  • Line 16: warning: exported const NotFound should have comment (or a comment on this block) or be unexported (golint)
  • Line 68: warning: exported var TypeName should have comment or be unexported (golint)
  • Line 85: warning: exported const MAX_BATCH_NUM should have comment (or a comment on this block) or be unexported (golint)
  • Line 99: warning: exported const MaxDatabases should have comment (or a comment on this block) or be unexported (golint)
  • Line 103: warning: comment on exported const MaxKeySize should be of the form "MaxKeySize ..." (golint)
  • Line 106: warning: comment on exported const MaxSubKeyLen should be of the form "MaxSubKeyLen ..." (golint)
  • Line 109: warning: comment on exported const MaxValueSize should be of the form "MaxValueSize ..." (golint)
  • Line 114: warning: exported var ErrZScoreMiss should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_kv.go
  • Line 29: warning: exported var ErrBitOverflow should have comment or be unexported (golint)
  • Line 308: warning: exported method RockDB.KVDelWithBatch should have comment or be unexported (golint)
  • Line 327: warning: exported method RockDB.Decr should have comment or be unexported (golint)
  • Line 331: warning: exported method RockDB.DecrBy should have comment or be unexported (golint)
  • Line 335: warning: exported method RockDB.DelKeys should have comment or be unexported (golint)
  • Line 357: warning: exported method RockDB.KVExists should have comment or be unexported (golint)
  • Line 388: warning: exported method RockDB.KVGetVer should have comment or be unexported (golint)
  • Line 401: warning: exported method RockDB.GetValueWithOpNoLock should have comment or be unexported (golint)
  • Line 420: warning: exported method RockDB.GetValueWithOp should have comment or be unexported (golint)
  • Line 439: warning: exported method RockDB.KVGet should have comment or be unexported (golint)
  • Line 464: warning: exported method RockDB.Incr should have comment or be unexported (golint)
  • Line 468: warning: exported method RockDB.IncrBy should have comment or be unexported (golint)
  • Line 472: warning: exported method RockDB.MGet should have comment or be unexported (golint)
  • Line 503: warning: exported method RockDB.MSet should have comment or be unexported (golint)
  • Line 551: warning: exported method RockDB.KVSet should have comment or be unexported (golint)
  • Line 555: warning: exported method RockDB.KVSetWithOpts should have comment or be unexported (golint)
  • Line 609: warning: exported method RockDB.KVGetSet should have comment or be unexported (golint)
  • Line 639: warning: exported method RockDB.SetEx should have comment or be unexported (golint)
  • Line 646: warning: exported method RockDB.SetNX should have comment or be unexported (golint)
  • Line 650: warning: exported method RockDB.SetIfEQ should have comment or be unexported (golint)
  • Line 676: warning: exported method RockDB.DelIfEQ should have comment or be unexported (golint)
  • Line 691: warning: exported method RockDB.SetRange should have comment or be unexported (golint)
  • Line 747: warning: exported method RockDB.GetRange should have comment or be unexported (golint)
  • Line 763: warning: exported method RockDB.StrLen should have comment or be unexported (golint)
  • Line 773: warning: exported method RockDB.Append should have comment or be unexported (golint)
  • Line 803: warning: comment on exported method RockDB.BitSetOld should be of the form "BitSetOld ..." (golint)
  • Line 910: warning: exported method RockDB.Expire should have comment or be unexported (golint)
  • Line 918: warning: exported method RockDB.Persist should have comment or be unexported (golint)

• ZanRedisDB/apps/backup/main.go
  • Line 40: warning: exported const MAGIC should have comment (or a comment on this block) or be unexported (golint)

• ZanRedisDB/common/type.go
  • Line 15: warning: exported const DIR_PERM should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported const LearnerRoleLogSyncer should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: exported function IsRoleLogSyncer should have comment or be unexported (golint)
  • Line 29: warning: exported var SCAN_CURSOR_SEP should have comment or be unexported (golint)
  • Line 34: warning: exported var ErrInvalidCommand should have comment or be unexported (golint)
  • Line 50: warning: comment on exported type DataType should be of the form "DataType ..." (with optional leading article) (golint)
  • Line 54: warning: exported const NONE should have comment (or a comment on this block) or be unexported (golint)
  • Line 64: warning: exported const KVName should have comment (or a comment on this block) or be unexported (golint)
  • Line 72: warning: exported const KEYSEP should have comment (or a comment on this block) or be unexported (golint)
  • Line 92: warning: exported type ExpirationPolicy should have comment or be unexported (golint)
  • Line 99: warning: comment on exported const PeriodicalRotation should be of the form "PeriodicalRotation ..." (golint)
  • Line 105: warning: exported const UnknownPolicy should have comment (or a comment on this block) or be unexported (golint)
  • Line 109: warning: exported const DefaultExpirationPolicy should have comment (or a comment on this block) or be unexported (golint)
  • Line 114: warning: exported var DefaultSnapCount should have comment or be unexported (golint)
  • Line 118: warning: exported function StringToExpirationPolicy should have comment or be unexported (golint)
  • Line 129: warning: exported type DataVersionT should have comment or be unexported (golint)
  • Line 132: warning: exported const DefaultDataVer should have comment (or a comment on this block) or be unexported (golint)
  • Line 141: warning: exported const ValueHeaderV1Str should have comment (or a comment on this block) or be unexported (golint)
  • Line 145: warning: exported function StringToDataVersionType should have comment or be unexported (golint)
  • Line 158: warning: exported type WriteCmd should have comment or be unexported (golint)
  • Line 163: warning: exported type KVRecord should have comment or be unexported (golint)
  • Line 168: warning: exported type KVRecordRet should have comment or be unexported (golint)
  • Line 173: warning: exported type KVals should have comment or be unexported (golint)
  • Line 178: warning: exported type KFVals should have comment or be unexported (golint)
  • Line 184: warning: exported var MAX_BATCH_NUM should have comment or be unexported (golint)
  • Line 192: warning: exported const RangeClose should have comment (or a comment on this block) or be unexported (golint)
  • Line 198: warning: exported function ExtractTable should have comment or be unexported (golint)
  • Line 209: warning: exported type ScorePair should have comment or be unexported (golint)
  • Line 214: warning: exported type WriteCommandFunc should have comment or be unexported (golint)
  • Line 215: warning: exported type CommandFunc should have comment or be unexported (golint)
  • Line 216: warning: exported type CommandRspFunc should have comment or be unexported (golint)
  • Line 217: warning: exported type InternalCommandFunc should have comment or be unexported (golint)
  • Line 218: warning: exported type MergeCommandFunc should have comment or be unexported (golint)
  • Line 219: warning: exported type MergeWriteCommandFunc should have comment or be unexported (golint)
  • Line 221: warning: exported type CmdRouter should have comment or be unexported (golint)
  • Line 228: warning: exported function NewCmdRouter should have comment or be unexported (golint)
  • Line 237: warning: exported method CmdRouter.RegisterWrite should have comment or be unexported (golint)
  • Line 245: warning: exported method CmdRouter.RegisterRead should have comment or be unexported (golint)
  • Line 254: warning: exported method CmdRouter.GetWCmdHandler should have comment or be unexported (golint)
  • Line 259: warning: exported method CmdRouter.GetCmdHandler should have comment or be unexported (golint)
  • Line 264: warning: exported method CmdRouter.RegisterMerge should have comment or be unexported (golint)
  • Line 272: warning: exported method CmdRouter.RegisterWriteMerge should have comment or be unexported (golint)
  • Line 280: warning: comment on exported method CmdRouter.GetMergeCmdHandler should be of the form "GetMergeCmdHandler ..." (golint)
  • Line 290: warning: exported type SMCmdRouter should have comment or be unexported (golint)
  • Line 294: warning: exported function NewSMCmdRouter should have comment or be unexported (golint)
  • Line 300: warning: exported method SMCmdRouter.RegisterInternal should have comment or be unexported (golint)
  • Line 308: warning: exported method SMCmdRouter.GetInternalCmdHandler should have comment or be unexported (golint)
  • Line 313: warning: exported type StringArray should have comment or be unexported (golint)
  • Line 315: warning: exported method StringArray.Set should have comment or be unexported (golint)
  • Line 325: warning: exported const MAX_PARTITION_NUM should have comment (or a comment on this block) or be unexported (golint)
  • Line 329: warning: exported type MemberInfo should have comment or be unexported (golint)
  • Line 340: warning: exported method MemberInfo.IsEqual should have comment or be unexported (golint)
  • Line 340: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 359: warning: exported type SnapshotSyncInfo should have comment or be unexported (golint)
  • Line 368: warning: exported type IClusterInfo should have comment or be unexported (golint)
  • Line 374: warning: exported type ScanResult should have comment or be unexported (golint)
  • Line 381: warning: exported type IndexState should have comment or be unexported (golint)
  • Line 384: warning: exported const InitIndex should have comment (or a comment on this block) or be unexported (golint)
  • Line 392: warning: exported type IndexPropertyDType should have comment or be unexported (golint)
  • Line 395: warning: exported const Int64V should have comment (or a comment on this block) or be unexported (golint)
  • Line 401: warning: exported type HsetIndexSchema should have comment or be unexported (golint)
  • Line 410: warning: exported method HsetIndexSchema.IsValidNewSchema should have comment or be unexported (golint)
  • Line 414: warning: exported type HIndexRespWithValues should have comment or be unexported (golint)
  • Line 421: warning: exported type SearchResultHeap should have comment or be unexported (golint)
  • Line 464: warning: exported method SearchResultHeap.Push should have comment or be unexported (golint)
  • Line 471: warning: exported method SearchResultHeap.Pop should have comment or be unexported (golint)
  • Line 484: warning: exported type JSONIndexSchema should have comment or be unexported (golint)
  • Line 488: warning: exported type IndexSchema should have comment or be unexported (golint)
  • Line 493: warning: exported type ExpiredDataBuffer should have comment or be unexported (golint)
  • Line 497: warning: exported type FullScanResult should have comment or be unexported (golint)
  • Line 505: warning: exported type FieldPair should have comment or be unexported (golint)

• ZanRedisDB/pdserver/server_test.go
  • Line 157: warning: should omit 2nd value from range; this loop is equivalent to `for nid := range ...` (golint)

• ZanRedisDB/rockredis/t_table.go
  • Line 166: warning: exported method RockDB.GetTables should have comment or be unexported (golint)
  • Line 186: warning: exported method RockDB.DelTableKeyCount should have comment or be unexported (golint)
  • Line 195: warning: exported method RockDB.IncrTableKeyCount should have comment or be unexported (golint)
  • Line 204: warning: exported method RockDB.GetTableKeyCount should have comment or be unexported (golint)
  • Line 248: warning: exported method RockDB.GetHsetIndexTables should have comment or be unexported (golint)
  • Line 270: warning: exported method RockDB.GetTableHsetIndexValue should have comment or be unexported (golint)
  • Line 275: warning: exported method RockDB.SetTableHsetIndexValue should have comment or be unexported (golint)

• ZanRedisDB/pkg/testutil/testutil.go
  • Line 31: warning: exported function MustNewURLs should have comment or be unexported (golint)
  • Line 43: warning: exported function MustNewURL should have comment or be unexported (golint)

• ZanRedisDB/raft/node.go
  • Line 26: warning: exported type SnapshotStatus should have comment or be unexported (golint)
  • Line 29: warning: exported const SnapshotFinish should have comment (or a comment on this block) or be unexported (golint)
  • Line 207: warning: exported type Peer should have comment or be unexported (golint)

• ZanRedisDB/node/kvstore.go
  • Line 12: warning: comment on exported type KVStore should be of the form "KVStore ..." (with optional leading article) (golint)
  • Line 18: warning: exported type KVOptions should have comment or be unexported (golint)
  • Line 28: warning: exported function NewKVStore should have comment or be unexported (golint)
  • Line 60: warning: exported method KVStore.CleanData should have comment or be unexported (golint)
  • Line 73: warning: comment on exported method KVStore.Destroy should be of the form "Destroy ..." (golint)
  • Line 81: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 93: warning: exported method KVStore.LocalLookup should have comment or be unexported (golint)
  • Line 98: warning: exported method KVStore.LocalDelete should have comment or be unexported (golint)
  • Line 102: warning: exported method KVStore.LocalPut should have comment or be unexported (golint)
  • Line 107: warning: exported method KVStore.LocalWriteBatch should have comment or be unexported (golint)
  • Line 111: warning: exported method KVStore.IsBatchableWrite should have comment or be unexported (golint)
  • Line 114: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 119: warning: exported method KVStore.BeginBatchWrite should have comment or be unexported (golint)
  • Line 122: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 127: warning: exported method KVStore.CommitBatchWrite should have comment or be unexported (golint)
  • Line 130: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 135: warning: exported method KVStore.AbortBatch should have comment or be unexported (golint)

• ZanRedisDB/metric/prom.go
  • Line 9: warning: comment on exported var ClusterWriteLatency should be of the form "ClusterWriteLatency ..." (golint)
  • Line 15: warning: comment on exported var DBWriteLatency should be of the form "DBWriteLatency ..." (golint)
  • Line 21: warning: comment on exported var RaftWriteLatency should be of the form "RaftWriteLatency ..." (golint)
  • Line 28: warning: exported var WriteByteSize should have comment or be unexported (golint)

• ZanRedisDB/cluster/etcd_client.go
  • Line 24: warning: exported type EtcdClient should have comment or be unexported (golint)
  • Line 30: warning: exported function NewEClient should have comment or be unexported (golint)
  • Line 51: warning: exported method EtcdClient.GetNewest should have comment or be unexported (golint)
  • Line 51: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 62: warning: exported method EtcdClient.Get should have comment or be unexported (golint)
  • Line 62: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 72: warning: exported method EtcdClient.Create should have comment or be unexported (golint)
  • Line 72: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 82: warning: exported method EtcdClient.Delete should have comment or be unexported (golint)
  • Line 82: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 91: warning: exported method EtcdClient.CreateDir should have comment or be unexported (golint)
  • Line 91: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 101: warning: exported method EtcdClient.CreateInOrder should have comment or be unexported (golint)
  • Line 101: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 110: warning: exported method EtcdClient.Set should have comment or be unexported (golint)
  • Line 110: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 119: warning: exported method EtcdClient.SetWithTTL should have comment or be unexported (golint)
  • Line 119: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 130: warning: exported method EtcdClient.Update should have comment or be unexported (golint)
  • Line 130: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 141: warning: exported method EtcdClient.CompareAndSwap should have comment or be unexported (golint)
  • Line 141: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 152: warning: exported method EtcdClient.CompareAndDelete should have comment or be unexported (golint)
  • Line 152: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 162: warning: exported method EtcdClient.Watch should have comment or be unexported (golint)
  • Line 162: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• ZanRedisDB/common/api_response.go
  • Line 16: warning: exported var ErrDeprecatedAPI should have comment or be unexported (golint)
  • Line 19: warning: exported type Decorator should have comment or be unexported (golint)
  • Line 21: warning: exported type APIHandler should have comment or be unexported (golint)
  • Line 23: warning: exported type HttpErr should have comment or be unexported (golint)
  • Line 32: warning: exported function PlainText should have comment or be unexported (golint)
  • Line 54: warning: exported function V1 should have comment or be unexported (golint)
  • Line 66: warning: exported function RespondV1 should have comment or be unexported (golint)
  • Line 101: warning: exported function Decorate should have comment or be unexported (golint)
  • Line 111: warning: exported function HttpLog should have comment or be unexported (golint)

• ZanRedisDB/engine/iterator.go
  • Line 19: warning: exported type IteratorGetter should have comment or be unexported (golint)
  • Line 23: warning: exported type Iterator should have comment or be unexported (golint)
  • Line 74: warning: exported type Range should have comment or be unexported (golint)
  • Line 80: warning: exported type Limit should have comment or be unexported (golint)
  • Line 85: warning: exported type IteratorOpts should have comment or be unexported (golint)
  • Line 93: warning: comment on exported function NewDBRangeLimitIteratorWithOpts should be of the form "NewDBRangeLimitIteratorWithOpts ..." (golint)
  • Line 120: warning: comment on exported function NewDBRangeIteratorWithOpts should be of the form "NewDBRangeIteratorWithOpts ..." (golint)
  • Line 145: warning: exported type RangeLimitedIterator should have comment or be unexported (golint)
  • Line 154: warning: exported method RangeLimitedIterator.Valid should have comment or be unexported (golint)
  • Line 170: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 179: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 187: warning: exported method RangeLimitedIterator.Next should have comment or be unexported (golint)
  • Line 196: warning: exported function NewRangeLimitIterator should have comment or be unexported (golint)
  • Line 199: warning: exported function NewRevRangeLimitIterator should have comment or be unexported (golint)
  • Line 202: warning: exported function NewRangeIterator should have comment or be unexported (golint)
  • Line 205: warning: exported function NewRevRangeIterator should have comment or be unexported (golint)

• ZanRedisDB/settings/static.go
  • Line 3: warning: comment on exported var Static should be of the form "Static ..." (golint)

• ZanRedisDB/internal/test/helper.go
  • Line 3: warning: exported type TbLog should have comment or be unexported (golint)
  • Line 7: warning: exported type TestLogger should have comment or be unexported (golint)
  • Line 12: warning: exported method TestLogger.Output should have comment or be unexported (golint)
  • Line 17: warning: exported method TestLogger.OutputErr should have comment or be unexported (golint)
  • Line 22: warning: exported method TestLogger.OutputWarning should have comment or be unexported (golint)

• ZanRedisDB/node/log_sender.go
  • Line 43: warning: exported function NewRemoteLogSender should have comment or be unexported (golint)
  • Line 80: warning: exported method RemoteLogSender.Stop should have comment or be unexported (golint)
  • Line 93: warning: exported method RemoteLogSender.GetStats should have comment or be unexported (golint)
  • Line 436: warning: exported type RaftRpcFunc should have comment or be unexported (golint)

• ZanRedisDB/server/util.go
  • Line 16: warning: exported var ErrUnknownCommand should have comment or be unexported (golint)
  • Line 21: warning: exported function GetIPv4ForInterfaceName should have comment or be unexported (golint)

• ZanRedisDB/pdserver/config.go
  • Line 10: warning: exported type ServerConfig should have comment or be unexported (golint)
  • Line 32: warning: exported function NewServerConfig should have comment or be unexported (golint)

• ZanRedisDB/metric/topn.go
  • Line 18: warning: exported type HKeyInfo should have comment or be unexported (golint)
  • Line 24: warning: exported method HKeyInfo.Inc should have comment or be unexported (golint)
  • Line 33: warning: exported var TopnHotKeys should have comment or be unexported (golint)
  • Line 100: warning: exported type TopNHot should have comment or be unexported (golint)
  • Line 105: warning: exported function NewTopNHot should have comment or be unexported (golint)
  • Line 127: warning: exported method TopNHot.Enable should have comment or be unexported (golint)
  • Line 142: warning: exported method TopNHot.HitWrite should have comment or be unexported (golint)
  • Line 153: warning: exported type TopNInfo should have comment or be unexported (golint)
  • Line 173: warning: exported method TopNHot.GetTopNWrites should have comment or be unexported (golint)

• ZanRedisDB/internal/flume_log/client.go
  • Line 1: warning: don't use an underscore in package name (golint)

• ZanRedisDB/engine/skiplist.go
  • Line 29: warning: exported function NewSkipList should have comment or be unexported (golint)

• ZanRedisDB/cluster/util.go
  • Line 9: warning: exported function CoordLog should have comment or be unexported (golint)
  • Line 13: warning: exported function SetLogLevel should have comment or be unexported (golint)
  • Line 17: warning: exported function SetLogger should have comment or be unexported (golint)

• ZanRedisDB/node/util.go
  • Line 17: warning: exported function SetLogLevel should have comment or be unexported (golint)
  • Line 21: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 26: warning: exported function SetSyncerOnly should have comment or be unexported (golint)
  • Line 35: warning: exported function SwitchDisableMaybeConflictLog should have comment or be unexported (golint)
  • Line 43: warning: exported function MaybeConflictLogDisabled should have comment or be unexported (golint)
  • Line 47: warning: exported function GetSyncedOnlyChangedTs should have comment or be unexported (golint)
  • Line 51: warning: exported function IsSyncerOnly should have comment or be unexported (golint)

• ZanRedisDB/rockredis/rockredis.go
  • Line 28: warning: exported const MaxCheckpointNum should have comment (or a comment on this block) or be unexported (golint)
  • Line 43: warning: exported function SetLogLevel should have comment or be unexported (golint)
  • Line 47: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 52: warning: exported function GetCheckpointDir should have comment or be unexported (golint)
  • Line 58: warning: exported type RockRedisDBConfig should have comment or be unexported (golint)
  • Line 67: warning: exported function NewRockRedisDBConfig should have comment or be unexported (golint)
  • Line 75: warning: exported type CheckpointSortNames should have comment or be unexported (golint)
  • Line 77: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 81: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 85: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 106: warning: exported function GetLatestCheckpoint should have comment or be unexported (golint)
  • Line 269: warning: exported type RockDB should have comment or be unexported (golint)
  • Line 290: warning: exported function OpenRockDB should have comment or be unexported (golint)
  • Line 335: warning: exported function GetBackupDir should have comment or be unexported (golint)
  • Line 339: warning: exported function GetBackupDirForRemote should have comment or be unexported (golint)
  • Line 343: warning: exported method RockDB.SetLatestSnapIndex should have comment or be unexported (golint)
  • Line 347: warning: exported method RockDB.GetBackupBase should have comment or be unexported (golint)
  • Line 351: warning: exported method RockDB.GetBackupDirForRemote should have comment or be unexported (golint)
  • Line 355: warning: exported method RockDB.GetBackupDir should have comment or be unexported (golint)
  • Line 359: warning: exported method RockDB.GetDataDir should have comment or be unexported (golint)
  • Line 363: warning: exported method RockDB.GetCompactFilterStats should have comment or be unexported (golint)
  • Line 370: warning: exported method RockDB.RegisterCompactCallback should have comment or be unexported (golint)
  • Line 411: warning: exported method RockDB.SetMaxBackgroundOptions should have comment or be unexported (golint)
  • Line 415: warning: comment on exported method RockDB.DisableManualCompact should be of the form "DisableManualCompact ..." (golint)
  • Line 420: warning: exported method RockDB.CompactAllRange should have comment or be unexported (golint)
  • Line 424: warning: exported method RockDB.CompactOldExpireData should have comment or be unexported (golint)
  • Line 431: warning: exported method RockDB.CompactRange should have comment or be unexported (golint)
  • Line 456: warning: exported method RockDB.Close should have comment or be unexported (golint)
  • Line 473: warning: exported method RockDB.GetInternalStatus should have comment or be unexported (golint)
  • Line 477: warning: exported method RockDB.GetInternalPropertyStatus should have comment or be unexported (golint)
  • Line 481: warning: exported method RockDB.GetStatistics should have comment or be unexported (golint)
  • Line 485: warning: exported method RockDB.GetTopLargeKeys should have comment or be unexported (golint)
  • Line 489: warning: exported method RockDB.GetBytesNoLock should have comment or be unexported (golint)
  • Line 493: warning: exported method RockDB.GetBytes should have comment or be unexported (golint)
  • Line 497: warning: exported method RockDB.MultiGetBytes should have comment or be unexported (golint)
  • Line 501: warning: exported method RockDB.Exist should have comment or be unexported (golint)
  • Line 505: warning: exported method RockDB.ExistNoLock should have comment or be unexported (golint)
  • Line 509: warning: comment on exported method RockDB.NewDBRangeIterator should be of the form "NewDBRangeIterator ..." (golint)
  • Line 521: warning: exported method RockDB.NewDBRangeLimitIterator should have comment or be unexported (golint)
  • Line 534: warning: exported method RockDB.NewDBRangeIteratorWithOpts should have comment or be unexported (golint)
  • Line 538: warning: exported method RockDB.NewDBRangeLimitIteratorWithOpts should have comment or be unexported (golint)
  • Line 542: warning: comment on exported method RockDB.CompactTableRange should be of the form "CompactTableRange ..." (golint)
  • Line 626: warning: comment on exported method RockDB.DeleteTableRange should be of the form "DeleteTableRange ..." (golint)
  • Line 680: warning: exported method RockDB.GetBTablesSizes should have comment or be unexported (golint)
  • Line 690: warning: comment on exported method RockDB.GetTablesSizes should be of the form "GetTablesSizes ..." (golint)
  • Line 702: warning: comment on exported method RockDB.GetTableSizeInRange should be of the form "GetTableSizeInRange ..." (golint)
  • Line 735: warning: exported method RockDB.GetApproximateTotalNum should have comment or be unexported (golint)
  • Line 739: warning: comment on exported method RockDB.GetTableApproximateNumInRange should be of the form "GetTableApproximateNumInRange ..." (golint)
  • Line 776: warning: exported type BackupInfo should have comment or be unexported (golint)
  • Line 792: warning: exported method BackupInfo.WaitReady should have comment or be unexported (golint)
  • Line 792: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 799: warning: exported method BackupInfo.GetResult should have comment or be unexported (golint)
  • Line 799: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 862: warning: exported method RockDB.Backup should have comment or be unexported (golint)
  • Line 875: warning: exported method RockDB.IsLocalBackupOK should have comment or be unexported (golint)
  • Line 950: warning: exported method RockDB.RestoreFromRemoteBackup should have comment or be unexported (golint)
  • Line 965: warning: exported method RockDB.Restore should have comment or be unexported (golint)
  • Line 1086: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1106: warning: exported method RockDB.GetIndexSchema should have comment or be unexported (golint)
  • Line 1110: warning: exported method RockDB.GetAllIndexSchema should have comment or be unexported (golint)
  • Line 1114: warning: exported method RockDB.AddHsetIndex should have comment or be unexported (golint)
  • Line 1130: warning: exported method RockDB.UpdateHsetIndexState should have comment or be unexported (golint)
  • Line 1134: warning: exported method RockDB.BeginBatchWrite should have comment or be unexported (golint)
  • Line 1141: warning: exported method RockDB.MaybeCommitBatch should have comment or be unexported (golint)
  • Line 1150: warning: exported method RockDB.CommitBatchWrite should have comment or be unexported (golint)
  • Line 1160: warning: exported method RockDB.AbortBatch should have comment or be unexported (golint)
  • Line 1165: warning: exported function IsNeedAbortError should have comment or be unexported (golint)
  • Line 1174: warning: exported function IsBatchableWrite should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_list.go
  • Line 540: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 589: warning: exported method RockDB.LIndex should have comment or be unexported (golint)
  • Line 614: warning: exported method RockDB.LVer should have comment or be unexported (golint)
  • Line 623: warning: exported method RockDB.LLen should have comment or be unexported (golint)
  • Line 636: warning: exported method RockDB.LFixKey should have comment or be unexported (golint)
  • Line 640: warning: exported method RockDB.LPop should have comment or be unexported (golint)
  • Line 644: warning: exported method RockDB.LTrim should have comment or be unexported (golint)
  • Line 648: warning: exported method RockDB.LTrimFront should have comment or be unexported (golint)
  • Line 652: warning: exported method RockDB.LTrimBack should have comment or be unexported (golint)
  • Line 656: warning: exported method RockDB.LPush should have comment or be unexported (golint)
  • Line 662: warning: exported method RockDB.LSet should have comment or be unexported (golint)
  • Line 696: warning: exported method RockDB.LRange should have comment or be unexported (golint)
  • Line 752: warning: exported method RockDB.RPop should have comment or be unexported (golint)
  • Line 756: warning: exported method RockDB.RPush should have comment or be unexported (golint)
  • Line 763: warning: exported method RockDB.LClear should have comment or be unexported (golint)
  • Line 778: warning: exported method RockDB.LMclear should have comment or be unexported (golint)
  • Line 813: warning: exported method RockDB.LKeyExists should have comment or be unexported (golint)
  • Line 817: warning: exported method RockDB.LExpire should have comment or be unexported (golint)
  • Line 821: warning: exported method RockDB.LPersist should have comment or be unexported (golint)

• ZanRedisDB/engine/radixdb/txn.go
  • Line 27: warning: exported function KVFromObject should have comment or be unexported (golint)
  • Line 35: warning: comment on exported function FromObject should be of the form "FromObject ..." (golint)

• ZanRedisDB/pkg/fileutil/fileutil.go
  • Line 100: warning: exported function Exist should have comment or be unexported (golint)

• ZanRedisDB/raft/logger.go
  • Line 24: warning: exported type Logger should have comment or be unexported (golint)
  • Line 44: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 62: warning: exported method DefaultLogger.EnableTimestamps should have comment or be unexported (golint)
  • Line 66: warning: exported method DefaultLogger.EnableDebug should have comment or be unexported (golint)
  • Line 70: warning: exported method DefaultLogger.Debug should have comment or be unexported (golint)
  • Line 76: warning: exported method DefaultLogger.Debugf should have comment or be unexported (golint)
  • Line 82: warning: exported method DefaultLogger.Info should have comment or be unexported (golint)
  • Line 86: warning: exported method DefaultLogger.Infof should have comment or be unexported (golint)
  • Line 94: warning: exported method DefaultLogger.Errorf should have comment or be unexported (golint)
  • Line 98: warning: exported method DefaultLogger.Warning should have comment or be unexported (golint)
  • Line 102: warning: exported method DefaultLogger.Warningf should have comment or be unexported (golint)
  • Line 106: warning: exported method DefaultLogger.Fatal should have comment or be unexported (golint)
  • Line 111: warning: exported method DefaultLogger.Fatalf should have comment or be unexported (golint)
  • Line 116: warning: exported method DefaultLogger.Panic should have comment or be unexported (golint)
  • Line 120: warning: exported method DefaultLogger.Panicf should have comment or be unexported (golint)

• ZanRedisDB/node/config.go
  • Line 8: warning: exported type NamespaceConfig should have comment or be unexported (golint)
  • Line 24: warning: exported function NewNSConfig should have comment or be unexported (golint)
  • Line 32: warning: exported type NamespaceDynamicConf should have comment or be unexported (golint)
  • Line 36: warning: exported type RaftGroupConfig should have comment or be unexported (golint)
  • Line 41: warning: exported type MachineConfig should have comment or be unexported (golint)
  • Line 63: warning: exported type ReplicaInfo should have comment or be unexported (golint)
  • Line 69: warning: exported type RaftConfig should have comment or be unexported (golint)
  • Line 91: warning: exported method RaftConfig.SetEng should have comment or be unexported (golint)

• ZanRedisDB/node/secondary_index.go
  • Line 13: warning: exported type HindexSearchResults should have comment or be unexported (golint)
  • Line 194: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/server/scan_merge.go
  • Line 102: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/rockredis/doc.go
  • Line 1: warning: package comment should be of the form "Package rockredis ..." (golint)

• ZanRedisDB/rockredis/encode.go
  • Line 9: warning: exported function PutRocksdbUint64 should have comment or be unexported (golint)
  • Line 15: warning: exported function GetRocksdbUint64 should have comment or be unexported (golint)

• ZanRedisDB/pkg/ioutil/pagewriter.go
  • Line 98: warning: exported method PageWriter.Flush should have comment or be unexported (golint)

• ZanRedisDB/cluster/pdnode_coord/pd_schema_coord.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 14: warning: exported var ErrInvalidSchema should have comment or be unexported (golint)

• ZanRedisDB/transport/rafthttp/http.go
  • Line 46: warning: exported var RaftPrefix should have comment or be unexported (golint)
  • Line 138: warning: exported type ISnapSaver should have comment or be unexported (golint)

• ZanRedisDB/transport/rafthttp/stream.go
  • Line 330: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 372: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 439: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 453: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 537: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 544: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)
  • Line 550: warning: receiver name cr should be consistent with previous receiver name r for streamReader (golint)

• ZanRedisDB/internal/test/fakes.go
  • Line 8: warning: exported type FakeNetConn should have comment or be unexported (golint)
  • Line 21: warning: exported method FakeNetConn.Close should have comment or be unexported (golint)
  • Line 22: warning: exported method FakeNetConn.LocalAddr should have comment or be unexported (golint)
  • Line 23: warning: exported method FakeNetConn.RemoteAddr should have comment or be unexported (golint)
  • Line 24: warning: exported method FakeNetConn.SetDeadline should have comment or be unexported (golint)
  • Line 25: warning: exported method FakeNetConn.SetReadDeadline should have comment or be unexported (golint)
  • Line 26: warning: exported method FakeNetConn.SetWriteDeadline should have comment or be unexported (golint)
  • Line 33: warning: exported function NewFakeNetConn should have comment or be unexported (golint)

• ZanRedisDB/common/util.go
  • Line 18: warning: comment on exported const APIAddNode should be of the form "APIAddNode ..." (golint)
  • Line 20: warning: exported const APIAddLearnerNode should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: comment on exported const APIIsRaftSynced should be of the form "APIIsRaftSynced ..." (golint)
  • Line 31: warning: comment on exported const APIGetSnapshotSyncInfo should be of the form "APIGetSnapshotSyncInfo ..." (golint)
  • Line 36: warning: exported const NamespaceTableSeperator should have comment (or a comment on this block) or be unexported (golint)
  • Line 39: warning: exported function GetIPv4ForInterfaceName should have comment or be unexported (golint)
  • Line 62: warning: exported const InternalPrefix should have comment (or a comment on this block) or be unexported (golint)
  • Line 65: warning: exported function IsValidNamespaceName should have comment or be unexported (golint)
  • Line 69: warning: exported function IsInternalTableName should have comment or be unexported (golint)
  • Line 80: warning: exported function CutNamesapce should have comment or be unexported (golint)
  • Line 89: warning: exported function ExtractNamesapce should have comment or be unexported (golint)
  • Line 99: warning: exported function GetNsDesp should have comment or be unexported (golint)
  • Line 103: warning: exported function GetNamespaceAndPartition should have comment or be unexported (golint)
  • Line 117: warning: exported function DeepCopyCmd should have comment or be unexported (golint)
  • Line 128: warning: exported function IsMergeScanCommand should have comment or be unexported (golint)
  • Line 188: warning: exported function IsFullScanCommand should have comment or be unexported (golint)
  • Line 202: warning: exported function IsMergeIndexSearchCommand should have comment or be unexported (golint)
  • Line 209: warning: exported function IsMergeKeysCommand should have comment or be unexported (golint)
  • Line 214: warning: exported function IsMergeCommand should have comment or be unexported (golint)
  • Line 230: warning: exported function BuildCommand should have comment or be unexported (golint)
  • Line 261: warning: comment on exported function CopyFileForHardLink should be of the form "CopyFileForHardLink ..." (golint)

• ZanRedisDB/rockredis/fullscan.go
  • Line 13: warning: exported type ItemContainer should have comment or be unexported (golint)
  • Line 51: warning: exported method RockDB.FullScan should have comment or be unexported (golint)
  • Line 311: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/rockredis/t_zset.go
  • Line 17: warning: exported const MinScore should have comment (or a comment on this block) or be unexported (golint)
  • Line 42: warning: exported function IsMemberNotExist should have comment or be unexported (golint)
  • Line 253: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 286: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 295: warning: exported method RockDB.ZAdd should have comment or be unexported (golint)
  • Line 345: warning: exported method RockDB.ZFixKey should have comment or be unexported (golint)
  • Line 415: warning: exported method RockDB.ZGetVer should have comment or be unexported (golint)
  • Line 419: warning: exported method RockDB.ZCard should have comment or be unexported (golint)
  • Line 425: warning: exported method RockDB.ZScore should have comment or be unexported (golint)
  • Line 453: warning: exported method RockDB.ZRem should have comment or be unexported (golint)
  • Line 496: warning: exported method RockDB.ZIncrBy should have comment or be unexported (golint)
  • Line 548: warning: exported method RockDB.ZCount should have comment or be unexported (golint)
  • Line 597: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 600: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 631: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 896: warning: exported method RockDB.ZClear should have comment or be unexported (golint)
  • Line 909: warning: exported method RockDB.ZMclear should have comment or be unexported (golint)
  • Line 944: warning: exported method RockDB.ZRange should have comment or be unexported (golint)
  • Line 948: warning: comment on exported method RockDB.ZRangeByScore should be of the form "ZRangeByScore ..." (golint)
  • Line 955: warning: exported method RockDB.ZRank should have comment or be unexported (golint)
  • Line 959: warning: exported method RockDB.ZRemRangeByRank should have comment or be unexported (golint)
  • Line 984: warning: comment on exported method RockDB.ZRemRangeByScore should be of the form "ZRemRangeByScore ..." (golint)
  • Line 996: warning: exported method RockDB.ZRevRange should have comment or be unexported (golint)
  • Line 1000: warning: exported method RockDB.ZRevRank should have comment or be unexported (golint)
  • Line 1004: warning: comment on exported method RockDB.ZRevRangeByScore should be of the form "ZRevRangeByScore ..." (golint)
  • Line 1010: warning: exported method RockDB.ZRangeGeneric should have comment or be unexported (golint)
  • Line 1030: warning: comment on exported method RockDB.ZRangeByScoreGeneric should be of the form "ZRangeByScoreGeneric ..." (golint)
  • Line 1062: warning: exported method RockDB.ZRangeByLex should have comment or be unexported (golint)
  • Line 1155: warning: exported method RockDB.ZRemRangeByLex should have comment or be unexported (golint)
  • Line 1181: warning: exported method RockDB.ZLexCount should have comment or be unexported (golint)
  • Line 1203: warning: exported method RockDB.ZKeyExists should have comment or be unexported (golint)
  • Line 1211: warning: exported method RockDB.ZExpire should have comment or be unexported (golint)
  • Line 1215: warning: exported method RockDB.ZPersist should have comment or be unexported (golint)

• ZanRedisDB/pkg/testutil/assert.go
  • Line 23: warning: exported function AssertEqual should have comment or be unexported (golint)
  • Line 38: warning: exported function AssertNil should have comment or be unexported (golint)
  • Line 42: warning: exported function AssertNotNil should have comment or be unexported (golint)
  • Line 48: warning: exported function AssertTrue should have comment or be unexported (golint)
  • Line 52: warning: exported function AssertFalse should have comment or be unexported (golint)

• ZanRedisDB/pkg/transport/listener.go
  • Line 37: warning: exported function NewListener should have comment or be unexported (golint)
  • Line 59: warning: exported type TLSInfo should have comment or be unexported (golint)
  • Line 89: warning: exported method TLSInfo.Empty should have comment or be unexported (golint)
  • Line 93: warning: exported function SelfCert should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_hll.go
  • Line 385: warning: exported method RockDB.PFCount should have comment or be unexported (golint)
  • Line 448: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 486: warning: exported method RockDB.PFAdd should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_ttl_compact_test.go
  • Line 716: warning: don't use underscores in Go names; var hash_val should be hashVal (golint)
  • Line 760: warning: don't use underscores in Go names; var hash_val should be hashVal (golint)
  • Line 810: warning: don't use underscores in Go names; var hash_val should be hashVal (golint)
  • Line 888: warning: don't use underscores in Go names; var hash_val2 should be hashVal2 (golint)

• ZanRedisDB/raft/raft_test.go
  • Line 2360: warning: don't use underscores in Go names; struct field compact_index should be compactIndex (golint)

• ZanRedisDB/node/keys.go
  • Line 69: warning: exported method KVNode.Lookup should have comment or be unexported (golint)
  • Line 381: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• ZanRedisDB/apps/zankv/main.go
  • Line 85: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/common/limit.go
  • Line 11: warning: comment on exported const MaxKeySize should be of the form "MaxKeySize ..." (golint)
  • Line 14: warning: comment on exported const MaxSubKeyLen should be of the form "MaxSubKeyLen ..." (golint)
  • Line 17: warning: comment on exported const MaxValueSize should be of the form "MaxValueSize ..." (golint)
  • Line 21: warning: exported function CheckKey should have comment or be unexported (golint)
  • Line 28: warning: exported function CheckSubKey should have comment or be unexported (golint)
  • Line 35: warning: exported function CheckKeySubKey should have comment or be unexported (golint)

• ZanRedisDB/snap/db.go
  • Line 29: warning: exported var ErrNoDBSnapshot should have comment or be unexported (golint)

• ZanRedisDB/raft/raft.go
  • Line 44: warning: exported type ReadOnlyOption should have comment or be unexported (golint)
  • Line 238: warning: exported function IsFromLocalNodeMsg should have comment or be unexported (golint)

• ZanRedisDB/pkg/transport/limit_listen.go
  • Line 27: warning: exported var ErrNotTCP should have comment or be unexported (golint)

• ZanRedisDB/cluster/pdnode_coord/place_driver.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 21: warning: exported const BalanceV2Str should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported var ErrBalanceNodeUnavailable should have comment or be unexported (golint)
  • Line 48: warning: exported method IntHeap.Push should have comment or be unexported (golint)
  • Line 54: warning: exported method IntHeap.Pop should have comment or be unexported (golint)
  • Line 85: warning: comment on exported function IsRaftNodeJoined should be of the form "IsRaftNodeJoined ..." (golint)
  • Line 116: warning: comment on exported function IsAllISRFullReady should be of the form "IsAllISRFullReady ..." (golint)
  • Line 127: warning: comment on exported function IsRaftNodeFullReady should be of the form "IsRaftNodeFullReady ..." (golint)
  • Line 165: warning: comment on exported function IsRaftNodeSynced should be of the form "IsRaftNodeSynced ..." (golint)
  • Line 178: warning: exported type DataPlacement should have comment or be unexported (golint)
  • Line 184: warning: exported function NewDataPlacement should have comment or be unexported (golint)
  • Line 191: warning: exported method DataPlacement.SetBalanceInterval should have comment or be unexported (golint)
  • Line 199: warning: exported method DataPlacement.DoBalance should have comment or be unexported (golint)
  • Line 577: warning: exported type SortableStrings should have comment or be unexported (golint)

• ZanRedisDB/engine/mem_writebatch.go
  • Line 14: warning: exported const NotOp should have comment (or a comment on this block) or be unexported (golint)

• ZanRedisDB/snap/snapshotter.go
  • Line 46: warning: exported var ErrNoSnapshot should have comment or be unexported (golint)
  • Line 57: warning: exported type Snapshotter should have comment or be unexported (golint)
  • Line 61: warning: exported function New should have comment or be unexported (golint)
  • Line 67: warning: exported method Snapshotter.SaveSnap should have comment or be unexported (golint)
  • Line 238: warning: exported method Snapshotter.ReleaseSnapDBs should have comment or be unexported (golint)

• ZanRedisDB/wal/walpb/record.go
  • Line 20: warning: exported var ErrCRCMismatch should have comment or be unexported (golint)
  • Line 23: warning: exported method Record.Validate should have comment or be unexported (golint)

• ZanRedisDB/rockredis/memcmp_codec.go
  • Line 22: warning: exported const NilFlag should have comment (or a comment on this block) or be unexported (golint)
  • Line 76: warning: comment on exported function EncodeMemCmpKey should be of the form "EncodeMemCmpKey ..." (golint)
  • Line 82: warning: exported function EncodeMaxKey should have comment or be unexported (golint)
  • Line 87: warning: exported function EncodeMinNotNull should have comment or be unexported (golint)
  • Line 117: warning: exported function DecodeOne should have comment or be unexported (golint)
  • Line 146: warning: exported function CutOne should have comment or be unexported (golint)

• ZanRedisDB/rockredis/t_json.go
  • Line 104: warning: exported method RockDB.JSet should have comment or be unexported (golint)
  • Line 155: warning: exported method RockDB.JMset should have comment or be unexported (golint)
  • Line 206: warning: exported method RockDB.JMGet should have comment or be unexported (golint)
  • Line 210: warning: exported method RockDB.JType should have comment or be unexported (golint)
  • Line 236: warning: exported method RockDB.JGet should have comment or be unexported (golint)
  • Line 260: warning: exported method RockDB.JDel should have comment or be unexported (golint)
  • Line 301: warning: exported method RockDB.JKeyExists should have comment or be unexported (golint)
  • Line 314: warning: exported method RockDB.JArrayAppend should have comment or be unexported (golint)
  • Line 366: warning: exported method RockDB.JArrayPop should have comment or be unexported (golint)
  • Line 418: warning: exported method RockDB.JArrayLen should have comment or be unexported (golint)
  • Line 444: warning: exported method RockDB.JObjLen should have comment or be unexported (golint)
  • Line 470: warning: exported method RockDB.JObjKeys should have comment or be unexported (golint)

• ZanRedisDB/pkg/crc/crc.go
  • Line 14: warning: comment on exported const Size should be of the form "Size ..." (golint)

• ZanRedisDB/node/conflict_checker.go
  • Line 9: warning: exported type ConflictState should have comment or be unexported (golint)
  • Line 12: warning: exported const NoConflict should have comment (or a comment on this block) or be unexported (golint)
  • Line 17: warning: exported type ConflictCheckFunc should have comment or be unexported (golint)
  • Line 23: warning: exported function NewConflictRouter should have comment or be unexported (golint)

• ZanRedisDB/rockredis/index_mgr.go
  • Line 12: warning: exported var ErrIndexStateInvalidChange should have comment or be unexported (golint)
  • Line 21: warning: exported type JSONIndex should have comment or be unexported (golint)
  • Line 26: warning: exported type TableIndexContainer should have comment or be unexported (golint)
  • Line 33: warning: exported function NewIndexContainer should have comment or be unexported (golint)
  • Line 40: warning: exported method TableIndexContainer.GetHIndexNoLock should have comment or be unexported (golint)
  • Line 76: warning: exported method TableIndexContainer.GetJSONIndexNoLock should have comment or be unexported (golint)
  • Line 88: warning: exported type IndexMgr should have comment or be unexported (golint)
  • Line 96: warning: exported function NewIndexMgr should have comment or be unexported (golint)
  • Line 103: warning: exported method IndexMgr.GetAllIndexSchemaInfo should have comment or be unexported (golint)
  • Line 133: warning: exported method IndexMgr.GetIndexSchemaInfo should have comment or be unexported (golint)
  • Line 164: warning: exported method IndexMgr.LoadIndexes should have comment or be unexported (golint)
  • Line 212: warning: exported method IndexMgr.Close should have comment or be unexported (golint)
  • Line 228: warning: exported method IndexMgr.AddHsetIndex should have comment or be unexported (golint)
  • Line 260: warning: exported method IndexMgr.UpdateHsetIndexState should have comment or be unexported (golint)
  • Line 348: warning: exported method IndexMgr.GetTableIndexes should have comment or be unexported (golint)
  • Line 358: warning: exported method IndexMgr.GetHsetIndex should have comment or be unexported (golint)
  • Line 469: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• ZanRedisDB/rockredis/t_hash.go
  • Line 121: warning: exported method RockDB.HLen should have comment or be unexported (golint)
  • Line 155: warning: exported method RockDB.HSet should have comment or be unexported (golint)
  • Line 189: warning: exported method RockDB.HMset should have comment or be unexported (golint)
  • Line 280: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 303: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 309: warning: exported method RockDB.HGetVer should have comment or be unexported (golint)
  • Line 318: warning: exported method RockDB.HGetWithOp should have comment or be unexported (golint)
  • Line 343: warning: exported method RockDB.HGetExpired should have comment or be unexported (golint)
  • Line 347: warning: exported method RockDB.HGet should have comment or be unexported (golint)
  • Line 366: warning: exported method RockDB.HExist should have comment or be unexported (golint)
  • Line 372: warning: exported method RockDB.HMgetExpired should have comment or be unexported (golint)
  • Line 387: warning: exported method RockDB.HMget should have comment or be unexported (golint)
  • Line 402: warning: exported method RockDB.HDel should have comment or be unexported (golint)
  • Line 517: warning: exported method RockDB.HClear should have comment or be unexported (golint)
  • Line 588: warning: exported method RockDB.HMclear should have comment or be unexported (golint)
  • Line 594: warning: exported method RockDB.HIncrBy should have comment or be unexported (golint)
  • Line 638: warning: exported method RockDB.HGetAll should have comment or be unexported (golint)
  • Line 642: warning: exported method RockDB.HGetAllExpired should have comment or be unexported (golint)
  • Line 689: warning: exported method RockDB.HKeys should have comment or be unexported (golint)
  • Line 734: warning: exported method RockDB.HValues should have comment or be unexported (golint)
  • Line 779: warning: exported method RockDB.HKeyExists should have comment or be unexported (golint)
  • Line 787: warning: exported method RockDB.HExpire should have comment or be unexported (golint)
  • Line 791: warning: exported method RockDB.HPersist should have comment or be unexported (golint)

gocyclo78%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• ZanRedisDB/common/util.go
  • Line 128: warning: cyclomatic complexity 78 of function IsMergeScanCommand() is high (> 15) (gocyclo)
  • Line 188: warning: cyclomatic complexity 17 of function IsFullScanCommand() is high (> 15) (gocyclo)

• ZanRedisDB/wal/wal_test.go
  • Line 863: warning: cyclomatic complexity 18 of function TestOpenOnTornWrite() is high (> 15) (gocyclo)
  • Line 512: warning: cyclomatic complexity 16 of function TestRecoverAfterCut() is high (> 15) (gocyclo)

• ZanRedisDB/server/secondary_index_merge.go
  • Line 17: warning: cyclomatic complexity 26 of function (*Server).doMergeIndexSearch() is high (> 15) (gocyclo)

• ZanRedisDB/node/secondary_index.go
  • Line 100: warning: cyclomatic complexity 33 of function (*KVNode).hindexSearchCommand() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_ttl_compact_test.go
  • Line 1784: warning: cyclomatic complexity 28 of function TestDBCompactTTL() is high (> 15) (gocyclo)
  • Line 321: warning: cyclomatic complexity 21 of function TestKVTTL_Compact() is high (> 15) (gocyclo)
  • Line 939: warning: cyclomatic complexity 17 of function TestBitmapTTL_Compact() is high (> 15) (gocyclo)
  • Line 1521: warning: cyclomatic complexity 16 of function TestZSetTTL_Compact() is high (> 15) (gocyclo)
  • Line 1121: warning: cyclomatic complexity 16 of function TestListTTL_Compact() is high (> 15) (gocyclo)
  • Line 1317: warning: cyclomatic complexity 16 of function TestSetTTL_Compact() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/etcd_master_lock.go
  • Line 125: warning: cyclomatic complexity 18 of function (*EtcdLock).acquire() is high (> 15) (gocyclo)

• ZanRedisDB/raft/raft.go
  • Line 1007: warning: cyclomatic complexity 56 of function stepLeader() is high (> 15) (gocyclo)
  • Line 859: warning: cyclomatic complexity 41 of function (*raft).Step() is high (> 15) (gocyclo)
  • Line 311: warning: cyclomatic complexity 21 of function newRaft() is high (> 15) (gocyclo)
  • Line 1283: warning: cyclomatic complexity 18 of function stepFollower() is high (> 15) (gocyclo)

• ZanRedisDB/node/namespace.go
  • Line 527: warning: cyclomatic complexity 16 of function (*NamespaceMgr).InitNamespaceNode() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_bitmap.go
  • Line 147: warning: cyclomatic complexity 17 of function (*RockDB).BitSetV2() is high (> 15) (gocyclo)

• ZanRedisDB/pkg/types/set_test.go
  • Line 40: warning: cyclomatic complexity 19 of function driveSetTests() is high (> 15) (gocyclo)

• ZanRedisDB/server/util.go
  • Line 150: warning: cyclomatic complexity 73 of function qcmdlower() is high (> 15) (gocyclo)
  • Line 87: warning: cyclomatic complexity 18 of function parseCommand() is high (> 15) (gocyclo)

• ZanRedisDB/server/scan_merge.go
  • Line 107: warning: cyclomatic complexity 26 of function (*Server).doMergeFullScan() is high (> 15) (gocyclo)

• ZanRedisDB/raft/raft_test.go
  • Line 691: warning: cyclomatic complexity 18 of function testVoteFromAnyState() is high (> 15) (gocyclo)
  • Line 352: warning: cyclomatic complexity 16 of function TestProgressFlowControl() is high (> 15) (gocyclo)

• ZanRedisDB/node/log_sender.go
  • Line 331: warning: cyclomatic complexity 26 of function (*RemoteLogSender).waitApplySnapStatus() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/rockredis.go
  • Line 1015: warning: cyclomatic complexity 18 of function (*RockDB).restoreFromPath() is high (> 15) (gocyclo)

• ZanRedisDB/transport/rafthttp/stream.go
  • Line 138: warning: cyclomatic complexity 18 of function (*streamWriter).run() is high (> 15) (gocyclo)
  • Line 453: warning: cyclomatic complexity 16 of function (*streamReader).dial() is high (> 15) (gocyclo)

• ZanRedisDB/apps/backup/main.go
  • Line 482: warning: cyclomatic complexity 22 of function backup() is high (> 15) (gocyclo)

• ZanRedisDB/apps/restore/main.go
  • Line 211: warning: cyclomatic complexity 29 of function restore() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/pdnode_coord/pd_schema_coord.go
  • Line 57: warning: cyclomatic complexity 23 of function (*PDCoordinator).doSchemaCheck() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/pdnode_coord/place_driver_test.go
  • Line 99: warning: cyclomatic complexity 21 of function testClusterNodesPlacementAcrossDC() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/register_etcd.go
  • Line 1272: warning: cyclomatic complexity 20 of function (*DNEtcdRegister).WatchPDLeader() is high (> 15) (gocyclo)
  • Line 470: warning: cyclomatic complexity 16 of function (*EtcdRegister).processNamespaceNode() is high (> 15) (gocyclo)

• ZanRedisDB/server/redis_api_setlistzset_test.go
  • Line 544: warning: cyclomatic complexity 54 of function TestSet() is high (> 15) (gocyclo)
  • Line 1181: warning: cyclomatic complexity 41 of function TestZSetFloat64Score() is high (> 15) (gocyclo)
  • Line 1032: warning: cyclomatic complexity 31 of function TestZSet() is high (> 15) (gocyclo)
  • Line 1655: warning: cyclomatic complexity 31 of function TestZsetErrorParams() is high (> 15) (gocyclo)
  • Line 1542: warning: cyclomatic complexity 30 of function TestZSetRange() is high (> 15) (gocyclo)
  • Line 63: warning: cyclomatic complexity 29 of function TestList() is high (> 15) (gocyclo)
  • Line 1448: warning: cyclomatic complexity 24 of function TestZSetRangeScore() is high (> 15) (gocyclo)
  • Line 316: warning: cyclomatic complexity 21 of function disableTestTrim() is high (> 15) (gocyclo)
  • Line 243: warning: cyclomatic complexity 19 of function TestListPop() is high (> 15) (gocyclo)
  • Line 951: warning: cyclomatic complexity 18 of function TestSetErrorParams() is high (> 15) (gocyclo)
  • Line 1304: warning: cyclomatic complexity 18 of function TestZSetCount() is high (> 15) (gocyclo)

• ZanRedisDB/server/redis_api_fullscan_test.go
  • Line 1081: warning: cyclomatic complexity 47 of function checkZSetFullScan() is high (> 15) (gocyclo)
  • Line 928: warning: cyclomatic complexity 47 of function checkSetFullScan() is high (> 15) (gocyclo)
  • Line 381: warning: cyclomatic complexity 46 of function checkHashFullScan() is high (> 15) (gocyclo)
  • Line 776: warning: cyclomatic complexity 46 of function checkListFullScan() is high (> 15) (gocyclo)
  • Line 293: warning: cyclomatic complexity 25 of function checkKVFullScan() is high (> 15) (gocyclo)

• ZanRedisDB/pkg/fileutil/purge_test.go
  • Line 93: warning: cyclomatic complexity 22 of function TestPurgeFileHoldingLockFile() is high (> 15) (gocyclo)
  • Line 27: warning: cyclomatic complexity 16 of function TestPurgeFile() is high (> 15) (gocyclo)

• ZanRedisDB/server/server.go
  • Line 85: warning: cyclomatic complexity 31 of function NewServer() is high (> 15) (gocyclo)
  • Line 660: warning: cyclomatic complexity 20 of function (*Server).handleRedisWrite() is high (> 15) (gocyclo)

• ZanRedisDB/node/scan.go
  • Line 114: warning: cyclomatic complexity 23 of function (*KVNode).advanceScanCommand() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_hash_index.go
  • Line 412: warning: cyclomatic complexity 38 of function (*HsetIndex).SearchRec() is high (> 15) (gocyclo)

• ZanRedisDB/server/redis_api_merge_test.go
  • Line 145: warning: cyclomatic complexity 33 of function checkMergeAdvanceScan() is high (> 15) (gocyclo)

• ZanRedisDB/server/redis_api.go
  • Line 20: warning: cyclomatic complexity 28 of function (*Server).serverRedis() is high (> 15) (gocyclo)

• ZanRedisDB/node/state_machine.go
  • Line 684: warning: cyclomatic complexity 45 of function (*kvStoreSM).ApplyRaftRequest() is high (> 15) (gocyclo)
  • Line 862: warning: cyclomatic complexity 16 of function (*kvStoreSM).handleCustomRequest() is high (> 15) (gocyclo)

• ZanRedisDB/node/geo_test.go
  • Line 37: warning: cyclomatic complexity 29 of function TestKVNode_GeoCommand() is high (> 15) (gocyclo)

• ZanRedisDB/node/node.go
  • Line 1293: warning: cyclomatic complexity 19 of function (*KVNode).applyEntries() is high (> 15) (gocyclo)
  • Line 1082: warning: cyclomatic complexity 18 of function (*KVNode).readIndexLoop() is high (> 15) (gocyclo)
  • Line 1152: warning: cyclomatic complexity 16 of function (*KVNode).applySnapshot() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/pdnode_coord/pd_coordinator.go
  • Line 676: warning: cyclomatic complexity 50 of function (*PDCoordinator).doCheckNamespaces() is high (> 15) (gocyclo)
  • Line 496: warning: cyclomatic complexity 25 of function (*PDCoordinator).processRemovingNodes() is high (> 15) (gocyclo)
  • Line 872: warning: cyclomatic complexity 24 of function (*PDCoordinator).handleNamespaceMigrate() is high (> 15) (gocyclo)
  • Line 397: warning: cyclomatic complexity 18 of function (*PDCoordinator).handleDataNodes() is high (> 15) (gocyclo)

• ZanRedisDB/transport/rafthttp/msgappv2_codec.go
  • Line 97: warning: cyclomatic complexity 21 of function (*msgAppV2Encoder).encode() is high (> 15) (gocyclo)
  • Line 200: warning: cyclomatic complexity 21 of function (*msgAppV2Decoder).decode() is high (> 15) (gocyclo)

• ZanRedisDB/server/redis_api_hash_test.go
  • Line 40: warning: cyclomatic complexity 17 of function TestHash() is high (> 15) (gocyclo)
  • Line 464: warning: cyclomatic complexity 16 of function TestHashErrorParams() is high (> 15) (gocyclo)

• ZanRedisDB/raft/node.go
  • Line 593: warning: cyclomatic complexity 16 of function (*node).handleReceivedMessage() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/index_mgr.go
  • Line 388: warning: cyclomatic complexity 22 of function (*IndexMgr).dobuildIndexes() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_hash.go
  • Line 189: warning: cyclomatic complexity 19 of function (*RockDB).HMset() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/datanode_coord/data_learner_coord.go
  • Line 116: warning: cyclomatic complexity 21 of function (*DataCoordinator).ensureJoinNamespaceGroupForLearner() is high (> 15) (gocyclo)
  • Line 53: warning: cyclomatic complexity 17 of function (*DataCoordinator).loadLocalNamespaceForLearners() is high (> 15) (gocyclo)

• ZanRedisDB/tools/bench/main.go
  • Line 583: warning: cyclomatic complexity 25 of function main() is high (> 15) (gocyclo)

• ZanRedisDB/wal/wal.go
  • Line 360: warning: cyclomatic complexity 28 of function (*WAL).ReadAll() is high (> 15) (gocyclo)
  • Line 543: warning: cyclomatic complexity 20 of function Verify() is high (> 15) (gocyclo)
  • Line 99: warning: cyclomatic complexity 18 of function Create() is high (> 15) (gocyclo)
  • Line 619: warning: cyclomatic complexity 16 of function (*WAL).cut() is high (> 15) (gocyclo)

• ZanRedisDB/node/raft.go
  • Line 949: warning: cyclomatic complexity 43 of function (*raftNode).processReady() is high (> 15) (gocyclo)
  • Line 765: warning: cyclomatic complexity 21 of function (*raftNode).applyConfChange() is high (> 15) (gocyclo)
  • Line 348: warning: cyclomatic complexity 18 of function (*raftNode).startRaft() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_ttl_l_test.go
  • Line 258: warning: cyclomatic complexity 28 of function TestLocalDeletionTTLChecker() is high (> 15) (gocyclo)

• ZanRedisDB/pkg/testutil/leak.go
  • Line 111: warning: cyclomatic complexity 16 of function interestingGoroutines() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/pdnode_coord/place_driver.go
  • Line 427: warning: cyclomatic complexity 39 of function (*DataPlacement).rebalanceNamespace() is high (> 15) (gocyclo)
  • Line 238: warning: cyclomatic complexity 18 of function (*DataPlacement).addNodeToNamespaceAndWaitReady() is high (> 15) (gocyclo)
  • Line 807: warning: cyclomatic complexity 16 of function fillPartitionMapV2() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/datanode_coord/data_node_coordinator.go
  • Line 657: warning: cyclomatic complexity 63 of function (*DataCoordinator).checkForUnsyncedNamespaces() is high (> 15) (gocyclo)
  • Line 1059: warning: cyclomatic complexity 27 of function (*DataCoordinator).ensureJoinNamespaceGroup() is high (> 15) (gocyclo)
  • Line 293: warning: cyclomatic complexity 19 of function (*DataCoordinator).loadLocalNamespaceData() is high (> 15) (gocyclo)
  • Line 1177: warning: cyclomatic complexity 19 of function (*DataCoordinator).updateLocalNamespace() is high (> 15) (gocyclo)
  • Line 191: warning: cyclomatic complexity 17 of function (*DataCoordinator).Start() is high (> 15) (gocyclo)

• ZanRedisDB/server/redis_api_kv_test.go
  • Line 727: warning: cyclomatic complexity 48 of function TestKVBatch() is high (> 15) (gocyclo)
  • Line 20: warning: cyclomatic complexity 38 of function TestKV() is high (> 15) (gocyclo)
  • Line 600: warning: cyclomatic complexity 28 of function TestKVBitExpire() is high (> 15) (gocyclo)
  • Line 523: warning: cyclomatic complexity 27 of function TestKVBitOp() is high (> 15) (gocyclo)
  • Line 279: warning: cyclomatic complexity 25 of function TestKVExpire() is high (> 15) (gocyclo)
  • Line 1131: warning: cyclomatic complexity 22 of function TestSlowLimiterCommand() is high (> 15) (gocyclo)
  • Line 445: warning: cyclomatic complexity 16 of function TestKVM() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_hll.go
  • Line 385: warning: cyclomatic complexity 24 of function (*RockDB).PFCount() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/fullscan.go
  • Line 182: warning: cyclomatic complexity 22 of function (*RockDB).fullScanCommon() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/rockredis_test.go
  • Line 632: warning: cyclomatic complexity 17 of function testRockDBScanTableForZSet() is high (> 15) (gocyclo)
  • Line 507: warning: cyclomatic complexity 17 of function testRockDBScanTableForSet() is high (> 15) (gocyclo)

• ZanRedisDB/pdserver/server_test.go
  • Line 1608: warning: cyclomatic complexity 43 of function TestClusterBalanceToNewNodeAndBack() is high (> 15) (gocyclo)
  • Line 1140: warning: cyclomatic complexity 28 of function TestClusterNodeFailedTooLongBalance() is high (> 15) (gocyclo)
  • Line 1033: warning: cyclomatic complexity 19 of function testClusterRemoveNode() is high (> 15) (gocyclo)

• ZanRedisDB/node/syncer_learner.go
  • Line 224: warning: cyclomatic complexity 33 of function (*logSyncerSM).handlerRaftLogs() is high (> 15) (gocyclo)
  • Line 457: warning: cyclomatic complexity 23 of function (*logSyncerSM).PrepareSnapshot() is high (> 15) (gocyclo)
  • Line 600: warning: cyclomatic complexity 20 of function (*logSyncerSM).ApplyRaftRequest() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_hash_test.go
  • Line 37: warning: cyclomatic complexity 23 of function TestDBHash() is high (> 15) (gocyclo)
  • Line 441: warning: cyclomatic complexity 19 of function TestHashIndexStringV() is high (> 15) (gocyclo)

• ZanRedisDB/server/grpc_api.go
  • Line 51: warning: cyclomatic complexity 23 of function (*Server).ApplyRaftReqs() is high (> 15) (gocyclo)

• ZanRedisDB/server/server_test.go
  • Line 959: warning: cyclomatic complexity 16 of function BenchmarkGetOpWithLockAndNoLock() is high (> 15) (gocyclo)

• ZanRedisDB/raft/rawnode_test.go
  • Line 51: warning: cyclomatic complexity 16 of function TestRawNodeProposeAndConfChange() is high (> 15) (gocyclo)

• ZanRedisDB/node/geo.go
  • Line 194: warning: cyclomatic complexity 37 of function (*KVNode).geoRadiusGeneric() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_list_test.go
  • Line 41: warning: cyclomatic complexity 22 of function TestListTrim() is high (> 15) (gocyclo)
  • Line 245: warning: cyclomatic complexity 16 of function TestListPop() is high (> 15) (gocyclo)

• ZanRedisDB/server/merge.go
  • Line 75: warning: cyclomatic complexity 21 of function (*Server).getHandlersForKeys() is high (> 15) (gocyclo)
  • Line 217: warning: cyclomatic complexity 17 of function (*Server).GetMergeHandlers() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/pdnode_coord/pd_learner_coord.go
  • Line 74: warning: cyclomatic complexity 26 of function (*PDCoordinator).doCheckNamespacesForLearner() is high (> 15) (gocyclo)

• ZanRedisDB/tools/data_tool/main.go
  • Line 109: warning: cyclomatic complexity 21 of function checkLocalTTL() is high (> 15) (gocyclo)

• ZanRedisDB/engine/kv.go
  • Line 98: warning: cyclomatic complexity 20 of function FillDefaultOptions() is high (> 15) (gocyclo)

• ZanRedisDB/raft/raft_snap_test.go
  • Line 123: warning: cyclomatic complexity 17 of function TestSnapshotSucceedViaAppResp() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_ttl.go
  • Line 222: warning: cyclomatic complexity 22 of function (*TTLChecker).check() is high (> 15) (gocyclo)

• ZanRedisDB/cluster/datanode_coord/dn_schema_coord.go
  • Line 12: warning: cyclomatic complexity 23 of function (*DataCoordinator).doSyncSchemaInfo() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_list.go
  • Line 340: warning: cyclomatic complexity 20 of function (*RockDB).ltrim2() is high (> 15) (gocyclo)
  • Line 182: warning: cyclomatic complexity 19 of function (*RockDB).lpush() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_set_test.go
  • Line 107: warning: cyclomatic complexity 16 of function TestDBSet() is high (> 15) (gocyclo)

• ZanRedisDB/pdserver/http.go
  • Line 439: warning: cyclomatic complexity 23 of function (*Server).doCreateNamespace() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_zset_test.go
  • Line 221: warning: cyclomatic complexity 27 of function TestZSetOrder() is high (> 15) (gocyclo)

• ZanRedisDB/engine/rockeng.go
  • Line 107: warning: cyclomatic complexity 21 of function NewRockEng() is high (> 15) (gocyclo)

• ZanRedisDB/engine/iterator.go
  • Line 208: warning: cyclomatic complexity 17 of function rangeLimitIterator() is high (> 15) (gocyclo)

• ZanRedisDB/wal/repair_test.go
  • Line 44: warning: cyclomatic complexity 19 of function testRepair() is high (> 15) (gocyclo)

• ZanRedisDB/server/queue_test.go
  • Line 228: warning: cyclomatic complexity 19 of function TestEntryQueueAllowEntriesToBeAddedAndWait() is high (> 15) (gocyclo)

• ZanRedisDB/rockredis/t_zset.go
  • Line 768: warning: cyclomatic complexity 24 of function (*RockDB).zRangeBytes() is high (> 15) (gocyclo)
  • Line 691: warning: cyclomatic complexity 17 of function (*RockDB).zRemRangeBytes() is high (> 15) (gocyclo)
  • Line 1062: warning: cyclomatic complexity 17 of function (*RockDB).ZRangeByLex() is high (> 15) (gocyclo)

• ZanRedisDB/apps/zankv/main.go
  • Line 50: warning: cyclomatic complexity 16 of function (*program).Start() is high (> 15) (gocyclo)

ineffassign89%

IneffAssign detects ineffectual assignments in Go code.

• ZanRedisDB/rockredis/t_bitmap_test.go
  • Line 119: warning: ineffectual assignment to n (ineffassign)
  • Line 447: warning: ineffectual assignment to n (ineffassign)

• ZanRedisDB/rockredis/t_list_test.go
  • Line 343: warning: ineffectual assignment to err (ineffassign)
  • Line 344: warning: ineffectual assignment to err (ineffassign)
  • Line 345: warning: ineffectual assignment to err (ineffassign)
  • Line 353: warning: ineffectual assignment to err (ineffassign)
  • Line 357: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/raft/rocksdb_storage.go
  • Line 50: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/engine/mem_writebatch.go
  • Line 91: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/rockredis/t_hll_test.go
  • Line 40: warning: ineffectual assignment to err (ineffassign)
  • Line 100: warning: ineffectual assignment to err (ineffassign)
  • Line 229: warning: ineffectual assignment to ret (ineffassign)

• ZanRedisDB/rockredis/t_table.go
  • Line 148: warning: ineffectual assignment to bufLen (ineffassign)
  • Line 151: warning: ineffectual assignment to bufLen (ineffassign)

• ZanRedisDB/tools/bench/main.go
  • Line 189: warning: ineffectual assignment to index (ineffassign)
  • Line 231: warning: ineffectual assignment to index (ineffassign)
  • Line 323: warning: ineffectual assignment to index (ineffassign)
  • Line 430: warning: ineffectual assignment to index (ineffassign)

• ZanRedisDB/engine/kv_test.go
  • Line 118: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/node/syncer_learner.go
  • Line 537: warning: ineffectual assignment to restoreErr (ineffassign)

• ZanRedisDB/rockredis/t_json.go
  • Line 179: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/slow/slowlog_test.go
  • Line 34: warning: ineffectual assignment to logged (ineffassign)

• ZanRedisDB/server/redis_api_kv_test.go
  • Line 1019: warning: ineffectual assignment to cnt (ineffassign)

• ZanRedisDB/engine/mem_eng.go
  • Line 580: warning: ineffectual assignment to n (ineffassign)

• ZanRedisDB/engine/pebble_eng_test.go
  • Line 111: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/engine/rockeng_test.go
  • Line 19: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/transport/rafthttp/stream.go
  • Line 184: warning: ineffectual assignment to done (ineffassign)

• ZanRedisDB/node/node.go
  • Line 1232: warning: ineffectual assignment to forceBackup (ineffassign)

• ZanRedisDB/raft/badger_storage.go
  • Line 88: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/rockredis/t_kv.go
  • Line 577: warning: ineffectual assignment to err (ineffassign)
  • Line 669: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/apps/backup/main.go
  • Line 621: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/pdserver/http_test.go
  • Line 457: warning: ineffectual assignment to uri (ineffassign)

• ZanRedisDB/raft/node_test.go
  • Line 834: warning: ineffectual assignment to hasEvent (ineffassign)

• ZanRedisDB/rockredis/t_hash.go
  • Line 428: warning: ineffectual assignment to newNum (ineffassign)
  • Line 435: warning: ineffectual assignment to err (ineffassign)
  • Line 521: warning: ineffectual assignment to err (ineffassign)
  • Line 566: warning: ineffectual assignment to err (ineffassign)
  • Line 662: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/rockredis/t_ttl_compact_test.go
  • Line 165: warning: ineffectual assignment to hv (ineffassign)
  • Line 847: warning: ineffectual assignment to tn (ineffassign)
  • Line 863: warning: ineffectual assignment to err (ineffassign)
  • Line 866: warning: ineffectual assignment to err (ineffassign)
  • Line 869: warning: ineffectual assignment to err (ineffassign)
  • Line 905: warning: ineffectual assignment to err (ineffassign)
  • Line 931: warning: ineffectual assignment to err (ineffassign)
  • Line 934: warning: ineffectual assignment to err (ineffassign)
  • Line 1080: warning: ineffectual assignment to tn (ineffassign)
  • Line 1690: warning: ineffectual assignment to tn (ineffassign)

• ZanRedisDB/rockredis/t_zset.go
  • Line 791: warning: ineffectual assignment to nv (ineffassign)

• ZanRedisDB/rockredis/t_zset_test.go
  • Line 720: warning: ineffectual assignment to err (ineffassign)
  • Line 727: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/pdserver/http.go
  • Line 318: warning: ineffectual assignment to stable (ineffassign)

• ZanRedisDB/server/redis_api_scan_test.go
  • Line 216: warning: ineffectual assignment to err (ineffassign)
  • Line 222: warning: ineffectual assignment to err (ineffassign)
  • Line 268: warning: ineffectual assignment to err (ineffassign)
  • Line 274: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/server/server_test.go
  • Line 743: warning: ineffectual assignment to err (ineffassign)
  • Line 850: warning: ineffectual assignment to err (ineffassign)
  • Line 879: warning: ineffectual assignment to newci (ineffassign)

• ZanRedisDB/rockredis/t_kv_test.go
  • Line 348: warning: ineffectual assignment to v2 (ineffassign)

• ZanRedisDB/cluster/register_etcd_test.go
  • Line 106: warning: ineffectual assignment to err (ineffassign)
  • Line 131: warning: ineffectual assignment to err (ineffassign)
  • Line 153: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/rockredis/rockredis.go
  • Line 999: warning: ineffectual assignment to err2 (ineffassign)

• ZanRedisDB/rockredis/rockredis_test.go
  • Line 170: warning: ineffectual assignment to err (ineffassign)
  • Line 171: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/rockredis/t_hash_test.go
  • Line 140: warning: ineffectual assignment to n (ineffassign)
  • Line 611: warning: ineffectual assignment to pkList (ineffassign)
  • Line 810: warning: ineffectual assignment to pkList (ineffassign)
  • Line 923: warning: ineffectual assignment to err (ineffassign)
  • Line 946: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/rockredis/t_hll.go
  • Line 490: warning: ineffectual assignment to err (ineffassign)

• ZanRedisDB/rockredis/t_json_test.go
  • Line 47: warning: ineffectual assignment to err (ineffassign)
  • Line 148: warning: ineffectual assignment to n (ineffassign)
  • Line 339: warning: ineffectual assignment to poped (ineffassign)

• ZanRedisDB/cluster/datanode_coord/data_node_coordinator_test.go
  • Line 33: warning: ineffectual assignment to v (ineffassign)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell98%

Misspell Finds commonly misspelled English words

• ZanRedisDB/server/server.go
  • Line 569: warning: "recieve" is a misspelling of "receive" (misspell)

• ZanRedisDB/pdserver/server_test.go
  • Line 1585: warning: "happend" is a misspelling of "happened" (misspell)
  • Line 1816: warning: "happend" is a misspelling of "happened" (misspell)

• ZanRedisDB/node/conflict_checker.go
  • Line 98: warning: "forbiden" is a misspelling of "forbidden" (misspell)

• ZanRedisDB/node/namespace.go
  • Line 954: warning: "bewteen" is a misspelling of "between" (misspell)

• ZanRedisDB/common/util.go
  • Line 26: warning: "allready" is a misspelling of "already" (misspell)

• ZanRedisDB/cluster/register_etcd.go
  • Line 462: warning: "reponse" is a misspelling of "response" (misspell)

• ZanRedisDB/cluster/pdnode_coord/place_driver.go
  • Line 606: warning: "happend" is a misspelling of "happened" (misspell)