gofmt88%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• nsq/nsqlookupd_migrate/migrate_config.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/nsqlookupd_migrate/nsqlookup_migrate.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/nsqlookupd_migrate/topic_migrate_manager.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/apps/nsq_stat/nsq_stat.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/internal/ext/ext.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/nsqlookupd_migrate/context.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/consistence/nsqlookup_coordinator_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/nsqadmin/notify.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/consistence/nsqd_coordinator_cluster_write.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/consistence/nsqlookup_coord_api.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/nsqdserver/protocol_v2_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/consistence/nsqd_coordinator.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/apps/nsqlookupd_migrate_proxy/main.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/nsqadmin/http.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/nsqdserver/http.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/nsqadmin/options.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/nsqadmin/trace_query.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/nsqlookupd_migrate/lookupinfo.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/nsqlookupd_migrate/topics.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• nsq/nsqd/engine/pebble_eng.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint27%

Golint is a linter for Go source code.

• nsq/internal/test/helper.go
  • Line 3: warning: exported type TbLog should have comment or be unexported (golint)
  • Line 7: warning: exported type TestLogger should have comment or be unexported (golint)
  • Line 12: warning: exported method TestLogger.Output should have comment or be unexported (golint)
  • Line 17: warning: exported method TestLogger.OutputErr should have comment or be unexported (golint)
  • Line 22: warning: exported method TestLogger.OutputWarning should have comment or be unexported (golint)

• nsq/nsqlookupd/client_v1.go
  • Line 7: warning: exported type ClientV1 should have comment or be unexported (golint)
  • Line 12: warning: exported function NewClientV1 should have comment or be unexported (golint)

• nsq/consistence/nsqlookup_coordinator_test.go
  • Line 87: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 90: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 94: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 105: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 111: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 118: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 126: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 130: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 141: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 149: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 171: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 175: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 180: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 193: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 205: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 217: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 240: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 251: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 263: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 271: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 286: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 311: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 326: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 333: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 344: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 352: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 357: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 367: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 373: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 380: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 387: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 396: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 419: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 447: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 466: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 485: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 490: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 511: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 543: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 566: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1019: warning: don't use underscores in Go names; var topic_p1_r1 should be topicP1R1 (golint)
  • Line 1123: warning: don't use underscores in Go names; var topic_p1_r1 should be topicP1R1 (golint)
  • Line 1124: warning: don't use underscores in Go names; var topic_p1_r3 should be topicP1R3 (golint)
  • Line 1125: warning: don't use underscores in Go names; var topic_p3_r1 should be topicP3R1 (golint)
  • Line 1126: warning: don't use underscores in Go names; var topic_p2_r2 should be topicP2R2 (golint)
  • Line 1284: warning: don't use underscores in Go names; var topic_p3_r1 should be topicP3R1 (golint)
  • Line 1285: warning: don't use underscores in Go names; var topic_p2_r2 should be topicP2R2 (golint)
  • Line 1376: warning: don't use underscores in Go names; var topic_p1_r1 should be topicP1R1 (golint)
  • Line 1377: warning: don't use underscores in Go names; var topic_p2_r1 should be topicP2R1 (golint)
  • Line 1488: warning: don't use underscores in Go names; var topic_p1_r1 should be topicP1R1 (golint)
  • Line 1550: warning: don't use underscores in Go names; var topic_p4_r1 should be topicP4R1 (golint)
  • Line 1551: warning: don't use underscores in Go names; var topic_p2_r2 should be topicP2R2 (golint)
  • Line 1552: warning: don't use underscores in Go names; var topic_p1_r3 should be topicP1R3 (golint)
  • Line 1660: warning: don't use underscores in Go names; var topic_p1_r1 should be topicP1R1 (golint)
  • Line 1661: warning: don't use underscores in Go names; var topic_p1_r2 should be topicP1R2 (golint)
  • Line 1662: warning: don't use underscores in Go names; var topic_p1_r3 should be topicP1R3 (golint)
  • Line 1766: warning: don't use underscores in Go names; var topic_p1_r1 should be topicP1R1 (golint)
  • Line 1767: warning: don't use underscores in Go names; var topic_p2_r2 should be topicP2R2 (golint)
  • Line 1768: warning: don't use underscores in Go names; var topic_ordered_p4_r3 should be topicOrderedP4R3 (golint)
  • Line 2043: warning: don't use underscores in Go names; var topic_ordered_p1_r3 should be topicOrderedP1R3 (golint)
  • Line 2218: warning: don't use underscores in Go names; var topic_p1_r2 should be topicP1R2 (golint)
  • Line 2388: warning: don't use underscores in Go names; var topic_p1_r2 should be topicP1R2 (golint)
  • Line 2745: warning: don't use underscores in Go names; var topic_p8_r3 should be topicP8R3 (golint)
  • Line 2746: warning: don't use underscores in Go names; var topic_p13_r1 should be topicP13R1 (golint)
  • Line 2747: warning: don't use underscores in Go names; var topic_p25_r3 should be topicP25R3 (golint)
  • Line 2917: warning: don't use underscores in Go names; var topic_p13_r2 should be topicP13R2 (golint)
  • Line 3030: warning: don't use underscores in Go names; var topic_p1_r2 should be topicP1R2 (golint)
  • Line 3031: warning: don't use underscores in Go names; var topic_p1_r3 should be topicP1R3 (golint)
  • Line 3032: warning: don't use underscores in Go names; var topic_p2_r2 should be topicP2R2 (golint)
  • Line 3079: warning: should omit 2nd value from range; this loop is equivalent to `for n := range ...` (golint)
  • Line 3222: warning: don't use underscores in Go names; var topic_p1_r2 should be topicP1R2 (golint)

• nsq/consistence/nsqd_coordinator_test.go
  • Line 85: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 91: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 95: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 99: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 102: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 109: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 116: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 123: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 147: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 181: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 188: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• nsq/nsqd/nsqd_test.go
  • Line 521: warning: don't use underscores in Go names; var ch_closed should be chClosed (golint)

• nsq/internal/util/wait_group_wrapper.go
  • Line 7: warning: exported type WaitGroupWrapper should have comment or be unexported (golint)
  • Line 11: warning: exported method WaitGroupWrapper.Wrap should have comment or be unexported (golint)

• nsq/nsqadmin/whitelist.go
  • Line 12: warning: exported type AccessControl should have comment or be unexported (golint)
  • Line 18: warning: exported type YamlAccessControl should have comment or be unexported (golint)
  • Line 43: warning: exported function NewYamlAccessControl should have comment or be unexported (golint)
  • Line 65: warning: exported method YamlAccessControl.Start should have comment or be unexported (golint)
  • Line 88: warning: exported method YamlAccessControl.Stop should have comment or be unexported (golint)
  • Line 93: warning: exported method YamlAccessControl.IsAdmin should have comment or be unexported (golint)
  • Line 102: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 106: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 116: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• nsq/nsqdserver/context.go
  • Line 18: warning: exported const FailedOnNotLeader should have comment (or a comment on this block) or be unexported (golint)
  • Line 129: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nsq/internal/version/binary.go
  • Line 8: warning: exported const Binary should have comment or be unexported (golint)
  • Line 11: warning: exported var Commit should have comment or be unexported (golint)
  • Line 15: warning: exported function String should have comment or be unexported (golint)

• nsq/bench/multi_bench/multi_bench.go
  • Line 169: warning: exported type ByMsgOffset should have comment or be unexported (golint)
  • Line 171: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 175: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 179: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 183: warning: exported type ByPubOffset should have comment or be unexported (golint)
  • Line 185: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 189: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 193: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 771: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 826: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nsq/consistence/coord_grpc_server.go
  • Line 17: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 45: warning: exported function NewNsqdCoordGRpcServer should have comment or be unexported (golint)

• nsq/nsqd/buffer_pool.go
  • Line 61: warning: exported function NewBufioReader should have comment or be unexported (golint)
  • Line 70: warning: exported function PutBufioReader should have comment or be unexported (golint)

• nsq/internal/flume_log/flume_param.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 43: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 49: warning: don't use underscores in Go names; var ip_addr should be ipAddr (golint)
  • Line 57: warning: exported type LogInfo should have comment or be unexported (golint)
  • Line 73: warning: exported type LogInfoJson should have comment or be unexported (golint)
  • Line 83: warning: exported function NewLogInfo should have comment or be unexported (golint)
  • Line 84: warning: don't use underscores in Go names; var log_info should be logInfo (golint)
  • Line 108: warning: exported method LogInfo.Serialize should have comment or be unexported (golint)

• nsq/nsqlookupd_migrate/lookupinfo.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 4: warning: don't use underscores in Go names; type Lookupinfo_old should be LookupinfoOld (golint)
  • Line 4: warning: exported type Lookupinfo_old should have comment or be unexported (golint)
  • Line 5: warning: don't use underscores in Go names; struct field Status_code should be StatusCode (golint)
  • Line 6: warning: don't use underscores in Go names; struct field Status_txt should be StatusTxt (golint)
  • Line 10: warning: exported type Data should have comment or be unexported (golint)
  • Line 17: warning: exported type Producerinfo should have comment or be unexported (golint)
  • Line 18: warning: don't use underscores in Go names; struct field Remote_address should be RemoteAddress (golint)
  • Line 20: warning: don't use underscores in Go names; struct field Broadcast_address should be BroadcastAddress (golint)
  • Line 21: warning: don't use underscores in Go names; struct field Tcp_port should be TCPPort (golint)
  • Line 22: warning: don't use underscores in Go names; struct field Http_port should be HTTPPort (golint)
  • Line 26: warning: exported type Metainfo should have comment or be unexported (golint)
  • Line 27: warning: don't use underscores in Go names; struct field Partition_num should be PartitionNum (golint)
  • Line 32: warning: exported type Lookupinfo should have comment or be unexported (golint)
  • Line 41: warning: exported const M_OFF should have comment (or a comment on this block) or be unexported (golint)

• nsq/nsqlookupd_migrate/migrate_config.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 10: warning: exported type MigrateConfig should have comment or be unexported (golint)
  • Line 22: warning: exported var IP_REGEXP should have comment or be unexported (golint)
  • Line 28: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 33: warning: don't use underscores in Go names; func parameter key_in_cnf should be keyInCnf (golint)
  • Line 54: warning: comment on exported function NewMigrateConfig should be of the form "NewMigrateConfig ..." (golint)

• nsq/internal/http_api/api_response.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 16: warning: exported var ErrDeprecatedAPI should have comment or be unexported (golint)
  • Line 19: warning: exported type Decorator should have comment or be unexported (golint)
  • Line 21: warning: exported type APIHandler should have comment or be unexported (golint)
  • Line 23: warning: exported type Err should have comment or be unexported (golint)
  • Line 40: warning: exported function PlainText should have comment or be unexported (golint)
  • Line 62: warning: exported function DeprecatedAPI should have comment or be unexported (golint)
  • Line 70: warning: exported function NegotiateVersion should have comment or be unexported (golint)
  • Line 91: warning: exported function V1 should have comment or be unexported (golint)
  • Line 103: warning: exported function V1Stream should have comment or be unexported (golint)
  • Line 114: warning: exported function Respond should have comment or be unexported (golint)
  • Line 143: warning: exported function RespondV1 should have comment or be unexported (golint)
  • Line 179: warning: exported function Decorate should have comment or be unexported (golint)
  • Line 189: warning: exported function Log should have comment or be unexported (golint)
  • Line 193: warning: exported function DebugLog should have comment or be unexported (golint)
  • Line 218: warning: exported function LogPanicHandler should have comment or be unexported (golint)
  • Line 229: warning: exported function LogNotFoundHandler should have comment or be unexported (golint)
  • Line 237: warning: exported function LogMethodNotAllowedHandler should have comment or be unexported (golint)

• nsq/nsqlookupd/http.go
  • Line 25: warning: exported const MAX_PARTITION_NUM should have comment (or a comment on this block) or be unexported (golint)
  • Line 30: warning: exported function GetValidPartitionNum should have comment or be unexported (golint)
  • Line 41: warning: exported function GetValidPartitionID should have comment or be unexported (golint)
  • Line 55: warning: exported function GetValidReplicator should have comment or be unexported (golint)
  • Line 66: warning: exported function GetValidSuggestLF should have comment or be unexported (golint)
  • Line 143: warning: exported function HandleBlockRate should have comment or be unexported (golint)
  • Line 1052: warning: exported type NodeStat should have comment or be unexported (golint)
  • Line 1061: warning: exported type TopNInfo should have comment or be unexported (golint)
  • Line 1116: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1135: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nsq/nsqd/kv_topic.go
  • Line 19: warning: exported const SepStart should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported const TopicPrefix should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: comment on exported const TopicMetaPrefix should be of the form "TopicMetaPrefix ..." (golint)
  • Line 37: warning: exported var ErrMsgNotFoundInIndex should have comment or be unexported (golint)
  • Line 212: warning: exported type KVTopic should have comment or be unexported (golint)
  • Line 227: warning: exported function NewKVTopic should have comment or be unexported (golint)
  • Line 231: warning: exported function NewKVTopicWithExt should have comment or be unexported (golint)
  • Line 256: warning: exported function NewKVTopicWithEngine should have comment or be unexported (golint)
  • Line 294: warning: exported method KVTopic.IsExt should have comment or be unexported (golint)
  • Line 298: warning: exported method KVTopic.BufferPoolGet should have comment or be unexported (golint)
  • Line 305: warning: exported method KVTopic.BufferPoolPut should have comment or be unexported (golint)
  • Line 309: warning: exported method KVTopic.GetFullName should have comment or be unexported (golint)
  • Line 313: warning: exported method KVTopic.GetTopicName should have comment or be unexported (golint)
  • Line 317: warning: exported method KVTopic.GetTopicPart should have comment or be unexported (golint)
  • Line 321: warning: exported method KVTopic.GetTopicMeta should have comment or be unexported (golint)
  • Line 427: warning: exported method KVTopic.ResetBackendEnd should have comment or be unexported (golint)
  • Line 478: warning: comment on exported method KVTopic.PutRawDataOnReplica should be of the form "PutRawDataOnReplica ..." (golint)
  • Line 535: warning: exported method KVTopic.PutMessages should have comment or be unexported (golint)
  • Line 693: warning: exported method KVTopic.Empty should have comment or be unexported (golint)
  • Line 712: warning: comment on exported method KVTopic.TryCleanOldData should be of the form "TryCleanOldData ..." (golint)
  • Line 727: warning: exported method KVTopic.ResetBackendWithQueueStart should have comment or be unexported (golint)
  • Line 745: warning: exported method KVTopic.CleanBackendWithQueueStart should have comment or be unexported (golint)
  • Line 777: warning: exported method KVTopic.GetMsgRawByID should have comment or be unexported (golint)
  • Line 789: warning: exported method KVTopic.GetMsgByID should have comment or be unexported (golint)
  • Line 797: warning: exported method KVTopic.GetMsgByTraceID should have comment or be unexported (golint)
  • Line 848: warning: exported method KVTopic.GetMsgByOffset should have comment or be unexported (golint)
  • Line 856: warning: exported method KVTopic.GetMsgIDOffsetByCnt should have comment or be unexported (golint)
  • Line 872: warning: exported method KVTopic.GetMsgRawByCnt should have comment or be unexported (golint)
  • Line 880: warning: exported method KVTopic.GetMsgByCnt should have comment or be unexported (golint)
  • Line 889: warning: exported method KVTopic.GetMsgByTime should have comment or be unexported (golint)
  • Line 896: warning: exported method KVTopic.PullMsgByCntFrom should have comment or be unexported (golint)

• nsq/consistence/nsqlookup_coord_rpc.go
  • Line 10: warning: exported type RpcLookupReqBase should have comment or be unexported (golint)
  • Line 16: warning: exported type RpcReqJoinCatchup should have comment or be unexported (golint)
  • Line 20: warning: exported type RpcReqJoinISR should have comment or be unexported (golint)
  • Line 24: warning: exported type RpcReqCheckTopic should have comment or be unexported (golint)
  • Line 28: warning: exported type RpcReqNewTopicInfo should have comment or be unexported (golint)
  • Line 32: warning: exported type RpcReadyForISR should have comment or be unexported (golint)
  • Line 38: warning: exported type RpcRspJoinISR should have comment or be unexported (golint)
  • Line 43: warning: exported type RpcReqLeaveFromISR should have comment or be unexported (golint)
  • Line 47: warning: exported type RpcReqLeaveFromISRByLeader should have comment or be unexported (golint)
  • Line 52: warning: exported type NsqLookupCoordRpcServer should have comment or be unexported (golint)
  • Line 59: warning: exported function NewNsqLookupCoordRpcServer should have comment or be unexported (golint)
  • Line 86: warning: exported method NsqLookupCoordRpcServer.RequestJoinCatchup should have comment or be unexported (golint)
  • Line 103: warning: exported method NsqLookupCoordRpcServer.RequestJoinTopicISR should have comment or be unexported (golint)
  • Line 121: warning: exported method NsqLookupCoordRpcServer.ReadyForTopicISR should have comment or be unexported (golint)
  • Line 139: warning: exported method NsqLookupCoordRpcServer.RequestLeaveFromISR should have comment or be unexported (golint)
  • Line 157: warning: exported method NsqLookupCoordRpcServer.RequestLeaveFromISRByLeader should have comment or be unexported (golint)
  • Line 175: warning: exported method NsqLookupCoordRpcServer.RequestNotifyNewTopicInfo should have comment or be unexported (golint)
  • Line 184: warning: exported method NsqLookupCoordRpcServer.RequestCheckTopicConsistence should have comment or be unexported (golint)

• nsq/nsqadmin/nsqadmin.go
  • Line 25: warning: exported type NSQAdmin should have comment or be unexported (golint)
  • Line 37: warning: exported function New should have comment or be unexported (golint)
  • Line 62: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 206: warning: exported method NSQAdmin.RealHTTPAddr should have comment or be unexported (golint)
  • Line 230: warning: exported method NSQAdmin.IsAuthEnabled should have comment or be unexported (golint)
  • Line 234: warning: exported method NSQAdmin.Main should have comment or be unexported (golint)
  • Line 258: warning: exported method NSQAdmin.DC2LookupAddresses should have comment or be unexported (golint)
  • Line 272: warning: exported method NSQAdmin.Exit should have comment or be unexported (golint)

• nsq/consistence/etcd_utils.go
  • Line 11: warning: exported const ErrCodeEtcdNotReachable should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported function IsEtcdNotReachable should have comment or be unexported (golint)
  • Line 41: warning: exported function IsEtcdWatchExpired should have comment or be unexported (golint)
  • Line 45: warning: exported function CheckKeyIfExist should have comment or be unexported (golint)
  • Line 49: warning: exported function IsEtcdNotFile should have comment or be unexported (golint)
  • Line 53: warning: exported function IsEtcdNodeExist should have comment or be unexported (golint)

• nsq/nsqd/diskqueue_writer.go
  • Line 21: warning: exported const MAX_QUEUE_OFFSET_META_DATA_KEEP should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported var ErrInvalidOffset should have comment or be unexported (golint)
  • Line 92: warning: exported function NewDiskQueueWriterForRead should have comment or be unexported (golint)

• nsq/apps/nsq_to_nsq/nsq_to_nsq.go
  • Line 29: warning: exported const ModeRoundRobin should have comment (or a comment on this block) or be unexported (golint)
  • Line 62: warning: exported type PublishHandler should have comment or be unexported (golint)
  • Line 204: warning: exported method PublishHandler.HandleMessage should have comment or be unexported (golint)

• nsq/internal/protocol/byte_base10.go
  • Line 9: warning: exported function ByteToBase10 should have comment or be unexported (golint)

• nsq/internal/protocol/names.go
  • Line 27: warning: exported function IsEphemeral should have comment or be unexported (golint)

• nsq/internal/clusterinfo/lookup_peer.go
  • Line 14: warning: comment on exported type LookupPeer should be of the form "LookupPeer ..." (with optional leading article) (golint)
  • Line 49: warning: comment on exported function NewLookupPeer should be of the form "NewLookupPeer ..." (golint)

• nsq/apps/nsq_tail/nsq_tail.go
  • Line 36: warning: exported type TailHandler should have comment or be unexported (golint)
  • Line 41: warning: exported method TailHandler.HandleMessage should have comment or be unexported (golint)

• nsq/internal/http_api/http_server.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 23: warning: exported function Serve should have comment or be unexported (golint)

• nsq/consistence/nsqlookup_coordinator.go
  • Line 18: warning: exported var ErrAlreadyExist should have comment or be unexported (golint)
  • Line 48: warning: exported type JoinISRState should have comment or be unexported (golint)
  • Line 63: warning: exported type RpcFailedInfo should have comment or be unexported (golint)
  • Line 82: warning: exported type TopicNameInfo should have comment or be unexported (golint)
  • Line 87: warning: exported type Options should have comment or be unexported (golint)
  • Line 92: warning: comment on exported type NsqLookupCoordinator should be of the form "NsqLookupCoordinator ..." (with optional leading article) (golint)
  • Line 126: warning: exported function NewNsqLookupCoordinator should have comment or be unexported (golint)
  • Line 152: warning: exported method NsqLookupCoordinator.SetLeadershipMgr should have comment or be unexported (golint)
  • Line 159: warning: exported function RetryWithTimeout should have comment or be unexported (golint)
  • Line 166: warning: comment on exported method NsqLookupCoordinator.Start should be of the form "Start ..." (golint)
  • Line 182: warning: exported method NsqLookupCoordinator.Stop should have comment or be unexported (golint)
  • Line 1495: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1995: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nsq/internal/levellogger/logger.go
  • Line 12: warning: exported type Logger should have comment or be unexported (golint)
  • Line 18: warning: exported type SimpleLogger should have comment or be unexported (golint)
  • Line 22: warning: exported function NewSimpleLog should have comment or be unexported (golint)
  • Line 28: warning: exported method SimpleLogger.Output should have comment or be unexported (golint)
  • Line 28: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 35: warning: exported method SimpleLogger.OutputErr should have comment or be unexported (golint)
  • Line 35: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 42: warning: exported method SimpleLogger.OutputWarning should have comment or be unexported (golint)
  • Line 42: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 49: warning: exported type GLogger should have comment or be unexported (golint)
  • Line 52: warning: exported method GLogger.Output should have comment or be unexported (golint)
  • Line 52: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 57: warning: exported method GLogger.OutputErr should have comment or be unexported (golint)
  • Line 57: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 62: warning: exported method GLogger.OutputWarning should have comment or be unexported (golint)
  • Line 62: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 68: warning: exported const LOG_ERR should have comment (or a comment on this block) or be unexported (golint)
  • Line 75: warning: exported type LevelLogger should have comment or be unexported (golint)
  • Line 82: warning: exported function NewLevelLogger should have comment or be unexported (golint)
  • Line 90: warning: exported method LevelLogger.WrappedWithPrefix should have comment or be unexported (golint)
  • Line 90: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 99: warning: exported method LevelLogger.SetLevel should have comment or be unexported (golint)
  • Line 99: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 103: warning: exported method LevelLogger.Level should have comment or be unexported (golint)
  • Line 103: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 107: warning: exported method LevelLogger.Logf should have comment or be unexported (golint)
  • Line 107: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 113: warning: exported method LevelLogger.LogDebugf should have comment or be unexported (golint)
  • Line 113: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 119: warning: exported method LevelLogger.LogErrorf should have comment or be unexported (golint)
  • Line 119: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 125: warning: exported method LevelLogger.LogWarningf should have comment or be unexported (golint)
  • Line 125: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 131: warning: exported method LevelLogger.Infof should have comment or be unexported (golint)
  • Line 131: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 137: warning: exported method LevelLogger.Debugf should have comment or be unexported (golint)
  • Line 137: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 143: warning: exported method LevelLogger.Errorf should have comment or be unexported (golint)
  • Line 143: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 149: warning: exported method LevelLogger.Warningf should have comment or be unexported (golint)
  • Line 149: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 155: warning: exported method LevelLogger.Warningln should have comment or be unexported (golint)
  • Line 155: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• nsq/nsqlookupd/lookup_protocol_v1.go
  • Line 22: warning: exported const OLD_VERSION_PID should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported type LookupProtocolV1 should have comment or be unexported (golint)
  • Line 29: warning: exported method LookupProtocolV1.IOLoop should have comment or be unexported (golint)
  • Line 91: warning: exported method LookupProtocolV1.Exec should have comment or be unexported (golint)
  • Line 152: warning: exported method LookupProtocolV1.REGISTER should have comment or be unexported (golint)
  • Line 192: warning: exported method LookupProtocolV1.UNREGISTER should have comment or be unexported (golint)
  • Line 251: warning: exported method LookupProtocolV1.IDENTIFY should have comment or be unexported (golint)
  • Line 327: warning: exported method LookupProtocolV1.PING should have comment or be unexported (golint)

• nsq/nsqlookupd/registration_db.go
  • Line 12: warning: exported type RegistrationDB should have comment or be unexported (golint)
  • Line 20: warning: exported type ChannelReg should have comment or be unexported (golint)
  • Line 26: warning: exported type PeerInfo should have comment or be unexported (golint)
  • Line 39: warning: exported method PeerInfo.IsOldPeer should have comment or be unexported (golint)
  • Line 39: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 50: warning: exported type Producer should have comment or be unexported (golint)
  • Line 56: warning: exported type Producers should have comment or be unexported (golint)
  • Line 57: warning: exported type PeerInfoList should have comment or be unexported (golint)
  • Line 63: warning: exported method Producer.UndoTombstone should have comment or be unexported (golint)
  • Line 67: warning: exported method Producer.Tombstone should have comment or be unexported (golint)
  • Line 72: warning: exported method Producer.IsTombstoned should have comment or be unexported (golint)
  • Line 79: warning: exported type TopicProducerReg should have comment or be unexported (golint)
  • Line 84: warning: exported type ChannelRegistrations should have comment or be unexported (golint)
  • Line 85: warning: exported type TopicRegistrations should have comment or be unexported (golint)
  • Line 87: warning: exported function NewRegistrationDB should have comment or be unexported (golint)
  • Line 96: warning: exported method RegistrationDB.TombstoneLookupdNode should have comment or be unexported (golint)
  • Line 102: warning: exported method RegistrationDB.IsTombstoneLookupdNode should have comment or be unexported (golint)
  • Line 109: warning: exported method RegistrationDB.DelTombstoneLookupdNode should have comment or be unexported (golint)
  • Line 119: warning: comment on exported method RegistrationDB.AddChannelReg should be of the form "AddChannelReg ..." (golint)
  • Line 138: warning: exported method RegistrationDB.FindChannelRegs should have comment or be unexported (golint)
  • Line 154: warning: exported method RegistrationDB.RemoveChannelReg should have comment or be unexported (golint)
  • Line 191: warning: exported method RegistrationDB.SearchPeerClientByID should have comment or be unexported (golint)
  • Line 198: warning: exported method RegistrationDB.SearchPeerClientByClusterID should have comment or be unexported (golint)
  • Line 209: warning: exported method RegistrationDB.GetAllPeerClients should have comment or be unexported (golint)
  • Line 219: warning: exported method RegistrationDB.AddTopicProducer should have comment or be unexported (golint)
  • Line 251: warning: comment on exported method RegistrationDB.RemoveAllByPeerId should be of the form "RemoveAllByPeerId ..." (golint)
  • Line 287: warning: exported method RegistrationDB.RemoveTopicProducer should have comment or be unexported (golint)
  • Line 318: warning: exported method RegistrationDB.FindTopics should have comment or be unexported (golint)
  • Line 328: warning: exported method RegistrationDB.FindPeerTopics should have comment or be unexported (golint)
  • Line 346: warning: exported method RegistrationDB.FindTopicProducers should have comment or be unexported (golint)
  • Line 368: warning: exported method ChannelReg.IsMatch should have comment or be unexported (golint)
  • Line 381: warning: exported method ChannelRegistrations.Channels should have comment or be unexported (golint)
  • Line 394: warning: exported method TopicRegistrations.FilterByActive should have comment or be unexported (golint)
  • Line 410: warning: exported method PeerInfoList.FilterByActive should have comment or be unexported (golint)
  • Line 423: warning: exported method Producers.FilterByActive should have comment or be unexported (golint)
  • Line 439: warning: exported method Producers.PeerInfo should have comment or be unexported (golint)

• nsq/consistence/nsqd_coordinator_cluster_write.go
  • Line 39: warning: exported method NsqdCoordinator.PutMessageBodyToCluster should have comment or be unexported (golint)
  • Line 46: warning: exported method NsqdCoordinator.PutMessageToCluster should have comment or be unexported (golint)
  • Line 51: warning: exported method NsqdCoordinator.PutDelayedMessageToCluster should have comment or be unexported (golint)
  • Line 180: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 215: warning: exported method NsqdCoordinator.PutMessagesToCluster should have comment or be unexported (golint)
  • Line 974: warning: exported method NsqdCoordinator.SetChannelConsumeOffsetToCluster should have comment or be unexported (golint)
  • Line 1034: warning: exported method NsqdCoordinator.UpdateChannelStateToCluster should have comment or be unexported (golint)
  • Line 1087: warning: exported method NsqdCoordinator.FinishMessageToCluster should have comment or be unexported (golint)
  • Line 1317: warning: exported method NsqdCoordinator.DeleteChannel should have comment or be unexported (golint)
  • Line 1394: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1400: warning: exported method NsqdCoordinator.EmptyChannelDelayedStateToCluster should have comment or be unexported (golint)
  • Line 1506: warning: should omit 2nd value from range; this loop is equivalent to `for chName := range ...` (golint)

• nsq/nsqd/logger.go
  • Line 9: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 13: warning: exported function NsqLogger should have comment or be unexported (golint)

• nsq/consistence/nsqlookup_rpc_client.go
  • Line 10: warning: exported type INsqlookupRemoteProxy should have comment or be unexported (golint)
  • Line 32: warning: exported type NsqLookupRpcClient should have comment or be unexported (golint)
  • Line 40: warning: exported function NewNsqLookupRpcClient should have comment or be unexported (golint)
  • Line 54: warning: exported method NsqLookupRpcClient.Close should have comment or be unexported (golint)
  • Line 63: warning: exported method NsqLookupRpcClient.ShouldRemoved should have comment or be unexported (golint)
  • Line 73: warning: exported method NsqLookupRpcClient.RemoteAddr should have comment or be unexported (golint)
  • Line 77: warning: exported method NsqLookupRpcClient.Reconnect should have comment or be unexported (golint)
  • Line 91: warning: exported method NsqLookupRpcClient.CallFast should have comment or be unexported (golint)
  • Line 96: warning: exported method NsqLookupRpcClient.CallWithRetry should have comment or be unexported (golint)
  • Line 124: warning: exported method NsqLookupRpcClient.RequestJoinCatchup should have comment or be unexported (golint)
  • Line 133: warning: exported method NsqLookupRpcClient.RequestNotifyNewTopicInfo should have comment or be unexported (golint)
  • Line 141: warning: exported method NsqLookupRpcClient.RequestJoinTopicISR should have comment or be unexported (golint)
  • Line 150: warning: exported method NsqLookupRpcClient.ReadyForTopicISR should have comment or be unexported (golint)
  • Line 163: warning: exported method NsqLookupRpcClient.RequestLeaveFromISR should have comment or be unexported (golint)
  • Line 172: warning: exported method NsqLookupRpcClient.RequestLeaveFromISRFast should have comment or be unexported (golint)
  • Line 181: warning: exported method NsqLookupRpcClient.RequestLeaveFromISRByLeader should have comment or be unexported (golint)
  • Line 191: warning: exported method NsqLookupRpcClient.RequestCheckTopicConsistence should have comment or be unexported (golint)

• nsq/apps/nsqadmin/main.go
  • Line 56: warning: exported var AuthUrl should have comment or be unexported (golint)

• nsq/internal/flume_log/flume_client.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 11: warning: exported type FlumeClient should have comment or be unexported (golint)
  • Line 20: warning: exported function NewFlumeClient should have comment or be unexported (golint)
  • Line 95: warning: exported method FlumeClient.SendLog should have comment or be unexported (golint)
  • Line 118: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 126: warning: exported method FlumeClient.Stop should have comment or be unexported (golint)

• nsq/nsqlookupd/context.go
  • Line 3: warning: exported type Context should have comment or be unexported (golint)

• nsq/nsqd/delay_queue.go
  • Line 27: warning: exported var CompactThreshold should have comment or be unexported (golint)
  • Line 39: warning: exported const MinDelayedType should have comment (or a comment on this block) or be unexported (golint)
  • Line 55: warning: exported type RecentKeyList should have comment or be unexported (golint)
  • Line 71: warning: exported function IsValidDelayedMessage should have comment or be unexported (golint)
  • Line 254: warning: exported type DelayQueue should have comment or be unexported (golint)
  • Line 291: warning: exported function NewDelayQueueForRead should have comment or be unexported (golint)
  • Line 296: warning: exported function NewDelayQueue should have comment or be unexported (golint)
  • Line 380: warning: exported method DelayQueue.CheckConsistence should have comment or be unexported (golint)
  • Line 409: warning: exported method DelayQueue.Stats should have comment or be unexported (golint)
  • Line 458: warning: exported method DelayQueue.GetFullName should have comment or be unexported (golint)
  • Line 462: warning: exported method DelayQueue.GetTopicName should have comment or be unexported (golint)
  • Line 466: warning: exported method DelayQueue.GetTopicPart should have comment or be unexported (golint)
  • Line 470: warning: exported method DelayQueue.SetTrace should have comment or be unexported (golint)
  • Line 482: warning: exported method DelayQueue.IsExt should have comment or be unexported (golint)
  • Line 496: warning: exported method DelayQueue.RollbackNoLock should have comment or be unexported (golint)
  • Line 504: warning: exported method DelayQueue.ResetBackendEndNoLock should have comment or be unexported (golint)
  • Line 518: warning: exported method DelayQueue.TryFixQueueEnd should have comment or be unexported (golint)
  • Line 532: warning: exported method DelayQueue.CheckDiskQueueReadToEndOK should have comment or be unexported (golint)
  • Line 543: warning: exported method DelayQueue.ResetBackendWithQueueStartNoLock should have comment or be unexported (golint)
  • Line 559: warning: exported method DelayQueue.GetDiskQueueSnapshot should have comment or be unexported (golint)
  • Line 567: warning: exported method DelayQueue.IsDataNeedFix should have comment or be unexported (golint)
  • Line 571: warning: exported method DelayQueue.SetDataFixState should have comment or be unexported (golint)
  • Line 579: warning: exported method DelayQueue.TotalMessageCnt should have comment or be unexported (golint)
  • Line 583: warning: exported method DelayQueue.TotalDataSize should have comment or be unexported (golint)
  • Line 591: warning: exported method DelayQueue.GetDBSize should have comment or be unexported (golint)
  • Line 600: warning: exported method DelayQueue.BackupKVStoreTo should have comment or be unexported (golint)
  • Line 616: warning: exported method DelayQueue.ReopenWithEmpty should have comment or be unexported (golint)
  • Line 646: warning: exported method DelayQueue.RestoreKVStoreFrom should have comment or be unexported (golint)
  • Line 700: warning: exported method DelayQueue.PutDelayMessage should have comment or be unexported (golint)
  • Line 716: warning: exported method DelayQueue.PutRawDataOnReplica should have comment or be unexported (golint)
  • Line 737: warning: exported method DelayQueue.PutMessageOnReplica should have comment or be unexported (golint)
  • Line 882: warning: exported method DelayQueue.Delete should have comment or be unexported (golint)
  • Line 886: warning: exported method DelayQueue.Close should have comment or be unexported (golint)
  • Line 907: warning: exported method DelayQueue.ForceFlush should have comment or be unexported (golint)
  • Line 939: warning: exported method DelayQueue.GetChangedTs should have comment or be unexported (golint)
  • Line 1107: warning: exported method DelayQueue.EmptyDelayedChannel should have comment or be unexported (golint)
  • Line 1120: warning: exported method DelayQueue.PeekRecentTimeoutWithFilter should have comment or be unexported (golint)
  • Line 1212: warning: exported method DelayQueue.PeekRecentChannelTimeout should have comment or be unexported (golint)
  • Line 1216: warning: exported method DelayQueue.PeekRecentDelayedPub should have comment or be unexported (golint)
  • Line 1220: warning: exported method DelayQueue.PeekAll should have comment or be unexported (golint)
  • Line 1224: warning: exported method DelayQueue.GetSyncedOffset should have comment or be unexported (golint)
  • Line 1242: warning: exported method DelayQueue.GetCurrentDelayedCnt should have comment or be unexported (golint)
  • Line 1257: warning: exported method DelayQueue.ConfirmedMessage should have comment or be unexported (golint)
  • Line 1282: warning: comment on exported method DelayQueue.FindChannelMessageDelayed should be of the form "FindChannelMessageDelayed ..." (golint)
  • Line 1358: warning: comment on exported method DelayQueue.GetOldestConsumedState should be of the form "GetOldestConsumedState ..." (golint)
  • Line 1435: warning: exported method DelayQueue.UpdateConsumedState should have comment or be unexported (golint)
  • Line 1474: warning: exported method DelayQueue.TryCleanOldData should have comment or be unexported (golint)
  • Line 1660: warning: exported method DelayQueue.Dump should have comment or be unexported (golint)

• nsq/nsqlookupd/logger.go
  • Line 10: warning: exported function SetLogger should have comment or be unexported (golint)

• nsq/consistence/coordinator_stats.go
  • Line 17: warning: exported function AddCounter should have comment or be unexported (golint)
  • Line 26: warning: exported function IncCounter should have comment or be unexported (golint)
  • Line 30: warning: exported function IncCounterBy should have comment or be unexported (golint)
  • Line 45: warning: exported type CoordErrStatsData should have comment or be unexported (golint)
  • Line 57: warning: exported type CoordErrStats should have comment or be unexported (golint)
  • Line 68: warning: exported method CoordErrStats.GetCopy should have comment or be unexported (golint)
  • Line 68: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 80: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 84: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 88: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 92: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 96: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 112: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 125: warning: exported type ISRStat should have comment or be unexported (golint)
  • Line 130: warning: exported type CatchupStat should have comment or be unexported (golint)
  • Line 136: warning: exported type TopicCoordStat should have comment or be unexported (golint)
  • Line 144: warning: exported type CoordStats should have comment or be unexported (golint)

• nsq/nsqd/diskqueue_reader.go
  • Line 19: warning: exported const MAX_POSSIBLE_MSG_SIZE should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: exported var ErrReadQueueAlreadyCleaned should have comment or be unexported (golint)
  • Line 42: warning: exported var FileNumV2Seq should have comment or be unexported (golint)
  • Line 479: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1111: warning: exported function GetQueueFileName should have comment or be unexported (golint)

• nsq/consistence/nsqd_rpc_client_test.go
  • Line 35: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 39: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 44: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 50: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 54: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 71: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 76: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 126: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 136: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 144: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 150: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 163: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 176: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• nsq/internal/stringy/template.go
  • Line 7: warning: exported function Commafy should have comment or be unexported (golint)
  • Line 25: warning: exported function FloatToPercent should have comment or be unexported (golint)
  • Line 29: warning: exported function PercSuffix should have comment or be unexported (golint)
  • Line 41: warning: exported function NanoSecondToHuman should have comment or be unexported (golint)

• nsq/internal/test/assertions.go
  • Line 10: warning: exported function Assert should have comment or be unexported (golint)
  • Line 19: warning: exported function Equal should have comment or be unexported (golint)
  • Line 28: warning: exported function NotEqual should have comment or be unexported (golint)
  • Line 37: warning: exported function Nil should have comment or be unexported (golint)
  • Line 46: warning: exported function NotNil should have comment or be unexported (golint)

• nsq/apps/nsqlookupd_migrate_proxy/main.go
  • Line 23: warning: don't use underscores in Go names; var log_level should be logLevel (golint)
  • Line 25: warning: don't use underscores in Go names; var migrate_key should be migrateKey (golint)
  • Line 26: warning: don't use underscores in Go names; var log_dir should be logDir (golint)

• nsq/nsqd/engine/iterator.go
  • Line 9: warning: exported type IteratorGetter should have comment or be unexported (golint)
  • Line 13: warning: exported type Iterator should have comment or be unexported (golint)
  • Line 64: warning: exported type Range should have comment or be unexported (golint)
  • Line 70: warning: exported type Limit should have comment or be unexported (golint)
  • Line 75: warning: exported type IteratorOpts should have comment or be unexported (golint)
  • Line 83: warning: comment on exported function NewDBRangeLimitIteratorWithOpts should be of the form "NewDBRangeLimitIteratorWithOpts ..." (golint)
  • Line 110: warning: comment on exported function NewDBRangeIteratorWithOpts should be of the form "NewDBRangeIteratorWithOpts ..." (golint)
  • Line 135: warning: exported type RangeLimitedIterator should have comment or be unexported (golint)
  • Line 144: warning: exported method RangeLimitedIterator.Valid should have comment or be unexported (golint)
  • Line 160: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 169: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 177: warning: exported method RangeLimitedIterator.Next should have comment or be unexported (golint)
  • Line 186: warning: exported function NewRangeLimitIterator should have comment or be unexported (golint)
  • Line 189: warning: exported function NewRevRangeLimitIterator should have comment or be unexported (golint)
  • Line 192: warning: exported function NewRangeIterator should have comment or be unexported (golint)
  • Line 195: warning: exported function NewRevRangeIterator should have comment or be unexported (golint)

• nsq/consistence/struct.go
  • Line 10: warning: comment on exported var NSQ_ROOT_DIR should be of the form "NSQ_ROOT_DIR ..." (golint)
  • Line 14: warning: exported const NSQ_TOPIC_DIR should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: exported const ETCD_LOCK_NSQ_NAMESPACE should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: exported type TopicReplicasInfo should have comment or be unexported (golint)
  • Line 33: warning: exported type TopicCatchupInfo should have comment or be unexported (golint)
  • Line 37: warning: exported type TopicChannelsInfo should have comment or be unexported (golint)

• nsq/nsqd/meta_storage.go
  • Line 30: warning: exported function SwitchEnableFileMetaWriter should have comment or be unexported (golint)
  • Line 38: warning: exported type IMetaStorage should have comment or be unexported (golint)
  • Line 52: warning: exported function IsMetaNotFound should have comment or be unexported (golint)
  • Line 355: warning: exported function NewDBMetaStorageForRead should have comment or be unexported (golint)
  • Line 359: warning: exported function NewDBMetaStorage should have comment or be unexported (golint)
  • Line 651: warning: exported function NewShardedDBMetaStorageForRead should have comment or be unexported (golint)
  • Line 671: warning: exported function NewShardedDBMetaStorage should have comment or be unexported (golint)

• nsq/internal/stringy/slice.go
  • Line 3: warning: exported function Add should have comment or be unexported (golint)
  • Line 13: warning: exported function Union should have comment or be unexported (golint)
  • Line 29: warning: exported function Uniq should have comment or be unexported (golint)

• nsq/internal/http_api/req_params.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 10: warning: exported type ReqParams should have comment or be unexported (golint)
  • Line 15: warning: exported function NewReqParams should have comment or be unexported (golint)
  • Line 29: warning: exported method ReqParams.Get should have comment or be unexported (golint)
  • Line 37: warning: exported method ReqParams.GetAll should have comment or be unexported (golint)
  • Line 45: warning: exported type PostParams should have comment or be unexported (golint)
  • Line 49: warning: exported method PostParams.Get should have comment or be unexported (golint)

• nsq/nsqadmin/notify.go
  • Line 13: warning: exported type AdminAction should have comment or be unexported (golint)

• nsq/nsqd/client_v2.go
  • Line 36: warning: exported type IdentifyDataV2 should have comment or be unexported (golint)
  • Line 66: warning: exported type ClientV2 should have comment or be unexported (golint)
  • Line 145: warning: exported function NewClientV2 should have comment or be unexported (golint)
  • Line 196: warning: exported method ClientV2.GetTcpPubStats should have comment or be unexported (golint)
  • Line 217: warning: exported method ClientV2.GetID should have comment or be unexported (golint)
  • Line 221: warning: exported method ClientV2.Exit should have comment or be unexported (golint)
  • Line 227: warning: exported method ClientV2.FinalClose should have comment or be unexported (golint)
  • Line 245: warning: exported method ClientV2.LockWrite should have comment or be unexported (golint)
  • Line 249: warning: exported method ClientV2.UnlockWrite should have comment or be unexported (golint)
  • Line 253: warning: exported method ClientV2.Identify should have comment or be unexported (golint)
  • Line 331: warning: exported method ClientV2.Stats should have comment or be unexported (golint)
  • Line 440: warning: exported method ClientV2.IsReadyForMessages should have comment or be unexported (golint)
  • Line 480: warning: exported method ClientV2.SetLimitedRdy should have comment or be unexported (golint)
  • Line 485: warning: exported method ClientV2.SetReadyCount should have comment or be unexported (golint)
  • Line 500: warning: exported method ClientV2.IncrSubError should have comment or be unexported (golint)
  • Line 525: warning: exported method ClientV2.FinishedMessage should have comment or be unexported (golint)
  • Line 532: warning: exported method ClientV2.Empty should have comment or be unexported (golint)
  • Line 538: warning: exported method ClientV2.SendingMessage should have comment or be unexported (golint)
  • Line 543: warning: exported method ClientV2.TimedOutMessage should have comment or be unexported (golint)
  • Line 551: warning: exported method ClientV2.RequeuedMessage should have comment or be unexported (golint)
  • Line 557: warning: exported method ClientV2.StartClose should have comment or be unexported (golint)
  • Line 564: warning: exported method ClientV2.SkipZanTest should have comment or be unexported (golint)
  • Line 568: warning: exported method ClientV2.UnskipZanTest should have comment or be unexported (golint)
  • Line 572: warning: exported method ClientV2.Pause should have comment or be unexported (golint)
  • Line 576: warning: exported method ClientV2.UnPause should have comment or be unexported (golint)
  • Line 580: warning: exported method ClientV2.GetHeartbeatInterval should have comment or be unexported (golint)
  • Line 584: warning: exported method ClientV2.SwitchToConsumer should have comment or be unexported (golint)
  • Line 619: warning: exported method ClientV2.SetHeartbeatInterval should have comment or be unexported (golint)
  • Line 635: warning: exported method ClientV2.GetOutputBufferSize should have comment or be unexported (golint)
  • Line 643: warning: exported method ClientV2.SetOutputBufferSize should have comment or be unexported (golint)
  • Line 674: warning: exported method ClientV2.SetExtFilter should have comment or be unexported (golint)
  • Line 680: warning: exported method ClientV2.GetOutputBufferTimeout should have comment or be unexported (golint)
  • Line 684: warning: exported method ClientV2.SetOutputBufferTimeout should have comment or be unexported (golint)
  • Line 700: warning: exported method ClientV2.SetSampleRate should have comment or be unexported (golint)
  • Line 708: warning: exported method ClientV2.GetDesiredTag should have comment or be unexported (golint)
  • Line 714: warning: exported method ClientV2.ExtendSupport should have comment or be unexported (golint)
  • Line 719: warning: exported method ClientV2.SetExtendSupport should have comment or be unexported (golint)
  • Line 723: warning: exported method ClientV2.GetMsgTimeout should have comment or be unexported (golint)
  • Line 727: warning: exported method ClientV2.SetMsgTimeout should have comment or be unexported (golint)
  • Line 741: warning: exported method ClientV2.UnsetDesiredTag should have comment or be unexported (golint)
  • Line 747: warning: exported method ClientV2.SetDesiredTag should have comment or be unexported (golint)
  • Line 762: warning: comment on exported method ClientV2.SetTagMsgChannel should be of the form "SetTagMsgChannel ..." (golint)
  • Line 768: warning: exported method ClientV2.GetTagMsgChannel should have comment or be unexported (golint)
  • Line 772: warning: exported method ClientV2.UpgradeTLS should have comment or be unexported (golint)
  • Line 792: warning: exported method ClientV2.UpgradeDeflate should have comment or be unexported (golint)
  • Line 812: warning: exported method ClientV2.UpgradeSnappy should have comment or be unexported (golint)
  • Line 829: warning: exported method ClientV2.Flush should have comment or be unexported (golint)
  • Line 842: warning: exported method ClientV2.QueryAuthd should have comment or be unexported (golint)
  • Line 863: warning: exported method ClientV2.Auth should have comment or be unexported (golint)
  • Line 868: warning: exported method ClientV2.IsAuthorized should have comment or be unexported (golint)
  • Line 884: warning: exported method ClientV2.HasAuthorizations should have comment or be unexported (golint)

• nsq/internal/statsd/client.go
  • Line 10: warning: exported type Client should have comment or be unexported (golint)
  • Line 16: warning: exported function NewClient should have comment or be unexported (golint)
  • Line 27: warning: exported method Client.CreateSocket should have comment or be unexported (golint)
  • Line 36: warning: exported method Client.Close should have comment or be unexported (golint)
  • Line 43: warning: exported method Client.Incr should have comment or be unexported (golint)
  • Line 47: warning: exported method Client.Decr should have comment or be unexported (golint)
  • Line 51: warning: exported method Client.Timing should have comment or be unexported (golint)
  • Line 55: warning: exported method Client.Gauge should have comment or be unexported (golint)

• nsq/internal/util/rand.go
  • Line 7: warning: exported function UniqRands should have comment or be unexported (golint)

• nsq/nsqdserver/protocol_v2.go
  • Line 29: warning: exported const E_INVALID should have comment (or a comment on this block) or be unexported (golint)
  • Line 67: warning: exported var ErrOrderChannelOnSampleRate should have comment or be unexported (golint)
  • Line 98: warning: exported type ConsumeOffset should have comment or be unexported (golint)
  • Line 103: warning: exported method ConsumeOffset.ToString should have comment or be unexported (golint)
  • Line 103: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 107: warning: exported method ConsumeOffset.FromString should have comment or be unexported (golint)
  • Line 107: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 127: warning: exported method ConsumeOffset.FromBytes should have comment or be unexported (golint)
  • Line 127: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 378: warning: exported function SendMessage should have comment or be unexported (golint)
  • Line 393: warning: exported function SendNow should have comment or be unexported (golint)
  • Line 415: warning: exported function Send should have comment or be unexported (golint)
  • Line 1432: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nsq/internal/http_api/compress.go
  • Line 7: warning: don't use an underscore in package name (golint)

• nsq/consistence/nsq_lookupd_etcd.go
  • Line 25: warning: exported const EVENT_WATCH_TOPIC_L_CREATE should have comment (or a comment on this block) or be unexported (golint)
  • Line 52: warning: exported type NsqLookupdEtcdMgr should have comment or be unexported (golint)
  • Line 80: warning: exported function NewNsqLookupdEtcdMgr should have comment or be unexported (golint)
  • Line 99: warning: exported method NsqLookupdEtcdMgr.InitClusterID should have comment or be unexported (golint)
  • Line 99: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 108: warning: exported method NsqLookupdEtcdMgr.Register should have comment or be unexported (golint)
  • Line 108: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 132: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 152: warning: exported method NsqLookupdEtcdMgr.Unregister should have comment or be unexported (golint)
  • Line 152: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 168: warning: exported method NsqLookupdEtcdMgr.Stop should have comment or be unexported (golint)
  • Line 168: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 179: warning: exported method NsqLookupdEtcdMgr.GetClusterEpoch should have comment or be unexported (golint)
  • Line 179: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 191: warning: exported method NsqLookupdEtcdMgr.GetAllLookupdNodes should have comment or be unexported (golint)
  • Line 191: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 216: warning: exported method NsqLookupdEtcdMgr.AcquireAndWatchLeader should have comment or be unexported (golint)
  • Line 216: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 222: warning: exported method NsqLookupdEtcdMgr.GetTopicsMetaInfoMap should have comment or be unexported (golint)
  • Line 222: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 248: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 278: warning: exported method NsqLookupdEtcdMgr.GetNsqdNodes should have comment or be unexported (golint)
  • Line 278: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 283: warning: exported method NsqLookupdEtcdMgr.WatchNsqdNodes should have comment or be unexported (golint)
  • Line 283: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 320: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 349: warning: exported method NsqLookupdEtcdMgr.GetAllTopicMetas should have comment or be unexported (golint)
  • Line 349: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 356: warning: exported method NsqLookupdEtcdMgr.ScanTopics should have comment or be unexported (golint)
  • Line 356: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 449: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 477: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 487: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 574: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 633: warning: exported method NsqLookupdEtcdMgr.GetTopicInfoFromCacheOnly should have comment or be unexported (golint)
  • Line 633: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 658: warning: exported method NsqLookupdEtcdMgr.GetTopicInfo should have comment or be unexported (golint)
  • Line 658: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 710: warning: exported method NsqLookupdEtcdMgr.CreateTopicPartition should have comment or be unexported (golint)
  • Line 710: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 721: warning: exported method NsqLookupdEtcdMgr.CreateTopic should have comment or be unexported (golint)
  • Line 721: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 741: warning: exported method NsqLookupdEtcdMgr.IsExistTopic should have comment or be unexported (golint)
  • Line 741: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 746: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 753: warning: exported method NsqLookupdEtcdMgr.IsExistTopicPartition should have comment or be unexported (golint)
  • Line 753: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 758: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 765: warning: exported method NsqLookupdEtcdMgr.GetTopicMetaInfoTryCacheOnly should have comment or be unexported (golint)
  • Line 765: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 774: warning: exported method NsqLookupdEtcdMgr.GetTopicMetaInfoTryCache should have comment or be unexported (golint)
  • Line 774: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 800: warning: exported method NsqLookupdEtcdMgr.GetTopicMetaInfo should have comment or be unexported (golint)
  • Line 800: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 817: warning: exported method NsqLookupdEtcdMgr.UpdateTopicMetaInfo should have comment or be unexported (golint)
  • Line 817: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 844: warning: exported method NsqLookupdEtcdMgr.DeleteWholeTopic should have comment or be unexported (golint)
  • Line 844: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 857: warning: exported method NsqLookupdEtcdMgr.DeleteTopic should have comment or be unexported (golint)
  • Line 857: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 868: warning: exported method NsqLookupdEtcdMgr.UpdateTopicNodeInfo should have comment or be unexported (golint)
  • Line 868: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 892: warning: exported method NsqLookupdEtcdMgr.GetTopicLeaderSession should have comment or be unexported (golint)
  • Line 892: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 918: warning: exported method NsqLookupdEtcdMgr.ReleaseTopicLeader should have comment or be unexported (golint)
  • Line 918: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 949: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 953: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 957: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 961: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 965: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 969: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 973: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 977: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 981: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 985: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 989: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• nsq/nsqd/tracer.go
  • Line 15: warning: exported type IMsgTracer should have comment or be unexported (golint)
  • Line 24: warning: exported function GetMsgTracer should have comment or be unexported (golint)
  • Line 30: warning: exported type TraceLogItemInfo should have comment or be unexported (golint)
  • Line 39: warning: exported function SetRemoteMsgTracer should have comment or be unexported (golint)
  • Line 45: warning: comment on exported type LogMsgTracer should be of the form "LogMsgTracer ..." (with optional leading article) (golint)
  • Line 50: warning: exported method LogMsgTracer.Start should have comment or be unexported (golint)
  • Line 50: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 53: warning: exported method LogMsgTracer.TracePub should have comment or be unexported (golint)
  • Line 53: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 58: warning: exported method LogMsgTracer.TracePubClient should have comment or be unexported (golint)
  • Line 58: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 63: warning: exported method LogMsgTracer.TraceSub should have comment or be unexported (golint)
  • Line 63: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 69: warning: exported method LogMsgTracer.IsRemote should have comment or be unexported (golint)
  • Line 69: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 73: warning: comment on exported type RemoteMsgTracer should be of the form "RemoteMsgTracer ..." (with optional leading article) (golint)
  • Line 80: warning: exported function NewRemoteMsgTracer should have comment or be unexported (golint)
  • Line 88: warning: exported method RemoteMsgTracer.Start should have comment or be unexported (golint)
  • Line 88: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 92: warning: exported method RemoteMsgTracer.Stop should have comment or be unexported (golint)
  • Line 92: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 96: warning: exported method RemoteMsgTracer.TracePub should have comment or be unexported (golint)
  • Line 96: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 117: warning: exported method RemoteMsgTracer.TracePubClient should have comment or be unexported (golint)
  • Line 117: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 139: warning: exported method RemoteMsgTracer.TraceSub should have comment or be unexported (golint)
  • Line 139: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 162: warning: exported method RemoteMsgTracer.IsRemote should have comment or be unexported (golint)
  • Line 162: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• nsq/apps/nsq_to_http/http.go
  • Line 20: warning: exported function HTTPGet should have comment or be unexported (golint)
  • Line 29: warning: exported function HTTPPost should have comment or be unexported (golint)

• nsq/nsqd/engine/writebatch.go
  • Line 9: warning: exported type WriteBatch should have comment or be unexported (golint)

• nsq/nsqadmin/http.go
  • Line 39: warning: comment on exported function NewSingleHostReverseProxy should be of the form "NewSingleHostReverseProxy ..." (golint)
  • Line 62: warning: exported function NewHTTPServer should have comment or be unexported (golint)
  • Line 208: warning: exported type DCLookupdAddrs should have comment or be unexported (golint)
  • Line 215: warning: should omit 2nd value from range; this loop is equivalent to `for dc := range ...` (golint)
  • Line 734: warning: exported const MAX_INCR_ID_BIT should have comment (or a comment on this block) or be unexported (golint)
  • Line 737: warning: exported function GetPartitionFromMsgID should have comment or be unexported (golint)
  • Line 1258: warning: exported type ChannelActionRequest should have comment or be unexported (golint)
  • Line 1435: warning: exported type RankList should have comment or be unexported (golint)
  • Line 1437: warning: exported method RankList.Len should have comment or be unexported (golint)
  • Line 1438: warning: exported method RankList.Swap should have comment or be unexported (golint)
  • Line 1440: warning: exported type ChannelByTimeout should have comment or be unexported (golint)
  • Line 1444: warning: exported method ChannelByTimeout.Less should have comment or be unexported (golint)
  • Line 1450: warning: exported type ChannelByRequeue should have comment or be unexported (golint)
  • Line 1454: warning: exported method ChannelByRequeue.Less should have comment or be unexported (golint)
  • Line 1460: warning: exported type ChannelByDelayedQueue should have comment or be unexported (golint)
  • Line 1464: warning: exported method ChannelByDelayedQueue.Less should have comment or be unexported (golint)
  • Line 1470: warning: exported type TopicsByChannelDepth should have comment or be unexported (golint)
  • Line 1474: warning: exported method TopicsByChannelDepth.Less should have comment or be unexported (golint)
  • Line 1483: warning: exported type TopicsByHourlyPubsize should have comment or be unexported (golint)
  • Line 1487: warning: exported method TopicsByHourlyPubsize.Less should have comment or be unexported (golint)
  • Line 1536: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1545: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nsq/consistence/coordinator_rpc.go
  • Line 19: warning: exported type ErrRPCRetCode should have comment or be unexported (golint)
  • Line 22: warning: exported const RpcNoErr should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported const RpcErrLeavingISRWait should have comment (or a comment on this block) or be unexported (golint)
  • Line 51: warning: exported type SlaveAsyncWriteResult should have comment or be unexported (golint)
  • Line 55: warning: exported method SlaveAsyncWriteResult.Wait should have comment or be unexported (golint)
  • Line 55: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 59: warning: exported method SlaveAsyncWriteResult.GetResult should have comment or be unexported (golint)
  • Line 59: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 63: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 68: warning: exported type NsqdNodeLoadFactor should have comment or be unexported (golint)
  • Line 74: warning: exported type RpcAdminTopicInfo should have comment or be unexported (golint)
  • Line 80: warning: exported type RpcAcquireTopicLeaderReq should have comment or be unexported (golint)
  • Line 86: warning: exported type RpcReleaseTopicLeaderReq should have comment or be unexported (golint)
  • Line 92: warning: exported type RpcTopicLeaderSession should have comment or be unexported (golint)
  • Line 99: warning: exported type NsqdCoordRpcServer should have comment or be unexported (golint)
  • Line 107: warning: exported function NewNsqdCoordRpcServer should have comment or be unexported (golint)
  • Line 116: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 122: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 136: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 142: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 149: warning: exported method NsqdCoordRpcServer.NotifyReleaseTopicLeader should have comment or be unexported (golint)
  • Line 149: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 209: warning: exported method NsqdCoordRpcServer.NotifyTopicLeaderSession should have comment or be unexported (golint)
  • Line 209: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 264: warning: exported method NsqdCoordRpcServer.NotifyAcquireTopicLeader should have comment or be unexported (golint)
  • Line 264: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 304: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 353: warning: exported method NsqdCoordRpcServer.UpdateTopicInfo should have comment or be unexported (golint)
  • Line 353: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 424: warning: exported method NsqdCoordRpcServer.EnableTopicWrite should have comment or be unexported (golint)
  • Line 424: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 477: warning: exported method NsqdCoordRpcServer.DisableTopicWrite should have comment or be unexported (golint)
  • Line 477: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 533: warning: exported method NsqdCoordRpcServer.IsTopicWriteDisabled should have comment or be unexported (golint)
  • Line 533: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 549: warning: exported method NsqdCoordRpcServer.DeleteNsqdTopic should have comment or be unexported (golint)
  • Line 549: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 566: warning: exported method NsqdCoordRpcServer.GetTopicStats should have comment or be unexported (golint)
  • Line 566: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 651: warning: exported type RpcTopicData should have comment or be unexported (golint)
  • Line 661: warning: exported type RpcChannelState should have comment or be unexported (golint)
  • Line 669: warning: exported type RpcChannelOffsetArg should have comment or be unexported (golint)
  • Line 676: warning: exported type RpcChannelListArg should have comment or be unexported (golint)
  • Line 681: warning: exported type RpcPutMessages should have comment or be unexported (golint)
  • Line 689: warning: exported type RpcPutMessage should have comment or be unexported (golint)
  • Line 696: warning: exported type RpcCommitLogReq should have comment or be unexported (golint)
  • Line 704: warning: exported type RpcCommitLogRsp should have comment or be unexported (golint)
  • Line 713: warning: exported type RpcPullCommitLogsReq should have comment or be unexported (golint)
  • Line 722: warning: exported type RpcPullCommitLogsRsp should have comment or be unexported (golint)
  • Line 727: warning: exported type RpcGetFullSyncInfoReq should have comment or be unexported (golint)
  • Line 731: warning: exported type RpcGetFullSyncInfoRsp should have comment or be unexported (golint)
  • Line 736: warning: exported type RpcGetBackupedDQReq should have comment or be unexported (golint)
  • Line 739: warning: exported type RpcGetBackupedDQRsp should have comment or be unexported (golint)
  • Line 743: warning: exported type RpcTestReq should have comment or be unexported (golint)
  • Line 747: warning: exported type RpcTestRsp should have comment or be unexported (golint)
  • Line 752: warning: exported type RpcConfirmedDelayedCursor should have comment or be unexported (golint)
  • Line 761: warning: exported type RpcNodeInfoReq should have comment or be unexported (golint)
  • Line 765: warning: exported type RpcNodeInfoRsp should have comment or be unexported (golint)
  • Line 773: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 799: warning: exported method NsqdCoordRpcServer.UpdateChannelState should have comment or be unexported (golint)
  • Line 799: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 816: warning: exported method NsqdCoordRpcServer.UpdateChannelOffset should have comment or be unexported (golint)
  • Line 816: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 833: warning: exported method NsqdCoordRpcServer.UpdateChannelList should have comment or be unexported (golint)
  • Line 833: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 852: warning: exported method NsqdCoordRpcServer.UpdateDelayedQueueState should have comment or be unexported (golint)
  • Line 852: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 871: warning: exported method NsqdCoordRpcServer.DeleteChannel should have comment or be unexported (golint)
  • Line 871: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 888: warning: comment on exported method NsqdCoordRpcServer.PutDelayedMessage should be of the form "PutDelayedMessage ..." (golint)
  • Line 889: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 920: warning: comment on exported method NsqdCoordRpcServer.PutMessage should be of the form "PutMessage ..." (golint)
  • Line 921: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 952: warning: exported method NsqdCoordRpcServer.PutMessages should have comment or be unexported (golint)
  • Line 952: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 983: warning: exported method NsqdCoordRpcServer.GetLastCommitLogID should have comment or be unexported (golint)
  • Line 983: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 993: warning: exported method NsqdCoordRpcServer.GetLastDelayedQueueCommitLogID should have comment or be unexported (golint)
  • Line 993: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1058: warning: comment on exported method NsqdCoordRpcServer.GetCommitLogFromOffset should be of the form "GetCommitLogFromOffset ..." (golint)
  • Line 1060: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1064: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1096: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1105: warning: exported method NsqdCoordRpcServer.PullCommitLogsAndData should have comment or be unexported (golint)
  • Line 1105: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1109: warning: exported method NsqdCoordRpcServer.GetFullSyncInfo should have comment or be unexported (golint)
  • Line 1109: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1113: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1163: warning: exported method NsqdCoordRpcServer.TriggerLookupChanged should have comment or be unexported (golint)
  • Line 1163: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1169: warning: exported method NsqdCoordRpcServer.GetNodeInfo should have comment or be unexported (golint)
  • Line 1169: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1185: warning: exported method NsqdCoordRpcServer.GetDelayedQueueCommitLogFromOffset should have comment or be unexported (golint)
  • Line 1185: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1189: warning: exported method NsqdCoordRpcServer.PullDelayedQueueCommitLogsAndData should have comment or be unexported (golint)
  • Line 1189: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1193: warning: exported method NsqdCoordRpcServer.GetDelayedQueueFullSyncInfo should have comment or be unexported (golint)
  • Line 1193: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1197: warning: exported method NsqdCoordRpcServer.GetBackupedDelayedQueue should have comment or be unexported (golint)
  • Line 1197: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1220: warning: exported method NsqdCoordRpcServer.TestRpcCoordErr should have comment or be unexported (golint)
  • Line 1220: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1228: warning: exported method NsqdCoordRpcServer.TestRpcError should have comment or be unexported (golint)
  • Line 1228: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1239: warning: exported method NsqdCoordRpcServer.TestRpcTimeout should have comment or be unexported (golint)
  • Line 1239: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• nsq/nsqd/disk_queue_snapshot.go
  • Line 15: warning: comment on exported type DiskQueueSnapshot should be of the form "DiskQueueSnapshot ..." (with optional leading article) (golint)
  • Line 31: warning: comment on exported function NewDiskQueueSnapshot should be of the form "NewDiskQueueSnapshot ..." (golint)
  • Line 44: warning: exported method DiskQueueSnapshot.ResetToStart should have comment or be unexported (golint)
  • Line 67: warning: exported method DiskQueueSnapshot.SetQueueStart should have comment or be unexported (golint)
  • Line 85: warning: exported method DiskQueueSnapshot.GetQueueReadStart should have comment or be unexported (golint)
  • Line 92: warning: comment on exported method DiskQueueSnapshot.UpdateQueueEnd should be of the form "UpdateQueueEnd ..." (golint)
  • Line 127: warning: exported method DiskQueueSnapshot.GetCurrentReadQueueOffset should have comment or be unexported (golint)
  • Line 151: warning: exported method DiskQueueSnapshot.SkipToNext should have comment or be unexported (golint)
  • Line 183: warning: comment on exported method DiskQueueSnapshot.ResetSeekTo should be of the form "ResetSeekTo ..." (golint)
  • Line 188: warning: exported method DiskQueueSnapshot.SeekTo should have comment or be unexported (golint)
  • Line 227: warning: exported method DiskQueueSnapshot.SeekToEnd should have comment or be unexported (golint)
  • Line 239: warning: exported method DiskQueueSnapshot.ReadRaw should have comment or be unexported (golint)
  • Line 314: warning: comment on exported method DiskQueueSnapshot.ReadOne should be of the form "ReadOne ..." (golint)
  • Line 405: warning: exported method DiskQueueSnapshot.CheckDiskQueueReadToEndOK should have comment or be unexported (golint)
  • Line 419: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nsq/internal/http_api/api_request.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 31: warning: comment on exported function NewDeadlineTransport should be of the form "NewDeadlineTransport ..." (golint)
  • Line 45: warning: exported type Client should have comment or be unexported (golint)
  • Line 49: warning: exported function NewClient should have comment or be unexported (golint)
  • Line 156: warning: comment on exported method Client.POSTV1 should be of the form "POSTV1 ..." (golint)
  • Line 191: warning: exported method Client.POSTV1WithContent should have comment or be unexported (golint)

• nsq/internal/clusterinfo/data.go
  • Line 27: warning: exported type PartialErr should have comment or be unexported (golint)
  • Line 32: warning: exported type ErrList should have comment or be unexported (golint)
  • Line 42: warning: exported method ErrList.Errors should have comment or be unexported (golint)
  • Line 50: warning: exported type LookupdAddressDC should have comment or be unexported (golint)
  • Line 55: warning: exported type ClusterInfo should have comment or be unexported (golint)
  • Line 60: warning: exported function New should have comment or be unexported (golint)
  • Line 94: warning: comment on exported method ClusterInfo.IsTopicDisableChanelAutoCreate should be of the form "IsTopicDisableChanelAutoCreate ..." (golint)
  • Line 127: warning: exported method ClusterInfo.GetLookupdTopicsMeta should have comment or be unexported (golint)
  • Line 452: warning: exported type TopicInfo should have comment or be unexported (golint)
  • Line 461: warning: exported type TopicInfoSortByName should have comment or be unexported (golint)
  • Line 727: warning: exported method ClusterInfo.ListAllLookupdNodes should have comment or be unexported (golint)
  • Line 757: warning: exported method ClusterInfo.GetNSQDAllMessageHistoryStats should have comment or be unexported (golint)
  • Line 801: warning: exported method ClusterInfo.GetNSQDMessageHistoryStats should have comment or be unexported (golint)
  • Line 817: warning: exported method ClusterInfo.GetNSQDMessageByID should have comment or be unexported (golint)
  • Line 846: warning: exported method ClusterInfo.GetNSQDCoordStats should have comment or be unexported (golint)
  • Line 905: warning: exported var INDEX should have comment or be unexported (golint)
  • Line 907: warning: comment on exported method ClusterInfo.GetClusterInfo should be of the form "GetClusterInfo ..." (golint)
  • Line 924: warning: exported method ClusterInfo.GetClusterInfoDC should have comment or be unexported (golint)
  • Line 950: warning: exported method ClusterInfo.GetNSQDStatsWithClients should have comment or be unexported (golint)
  • Line 1110: warning: exported method ClusterInfo.CreateTopicChannelAfterTopicCreation should have comment or be unexported (golint)
  • Line 1179: warning: exported method ClusterInfo.UnregisterTopicChannel should have comment or be unexported (golint)
  • Line 1206: warning: comment on exported method ClusterInfo.RegisterTopicChannel should be of the form "RegisterTopicChannel ..." (golint)
  • Line 1234: warning: exported method ClusterInfo.CreateTopicChannel should have comment or be unexported (golint)
  • Line 1282: warning: exported method ClusterInfo.CreateTopic should have comment or be unexported (golint)
  • Line 1314: warning: comment on exported method ClusterInfo.DeleteTopic should be of the form "DeleteTopic ..." (golint)
  • Line 1345: warning: exported method ClusterInfo.DeleteChannel should have comment or be unexported (golint)
  • Line 1420: warning: exported method ClusterInfo.PauseTopic should have comment or be unexported (golint)
  • Line 1425: warning: exported method ClusterInfo.UnPauseTopic should have comment or be unexported (golint)
  • Line 1430: warning: exported method ClusterInfo.PauseChannel should have comment or be unexported (golint)
  • Line 1435: warning: exported method ClusterInfo.UnPauseChannel should have comment or be unexported (golint)
  • Line 1440: warning: exported method ClusterInfo.SkipChannel should have comment or be unexported (golint)
  • Line 1445: warning: exported method ClusterInfo.UnSkipChannel should have comment or be unexported (golint)
  • Line 1450: warning: exported method ClusterInfo.SkipZanTest should have comment or be unexported (golint)
  • Line 1455: warning: exported method ClusterInfo.UnskipZanTest should have comment or be unexported (golint)
  • Line 1460: warning: exported method ClusterInfo.EmptyTopic should have comment or be unexported (golint)
  • Line 1465: warning: exported method ClusterInfo.EmptyChannel should have comment or be unexported (golint)
  • Line 1470: warning: exported method ClusterInfo.ResetChannel should have comment or be unexported (golint)
  • Line 1475: warning: exported method ClusterInfo.FinishMessage should have comment or be unexported (golint)
  • Line 1579: warning: exported method ClusterInfo.GetProducers should have comment or be unexported (golint)
  • Line 1586: warning: exported method ClusterInfo.GetTopicProducers should have comment or be unexported (golint)

• nsq/consistence/nsqd_rpc_client.go
  • Line 19: warning: exported const RPC_TIMEOUT should have comment (or a comment on this block) or be unexported (golint)
  • Line 31: warning: exported type NsqdRpcClient should have comment or be unexported (golint)
  • Line 67: warning: exported function NewNsqdRpcClient should have comment or be unexported (golint)
  • Line 96: warning: exported method NsqdRpcClient.Close should have comment or be unexported (golint)
  • Line 109: warning: exported method NsqdRpcClient.ShouldRemoved should have comment or be unexported (golint)
  • Line 119: warning: exported method NsqdRpcClient.Reconnect should have comment or be unexported (golint)
  • Line 151: warning: exported method NsqdRpcClient.CallFast should have comment or be unexported (golint)
  • Line 156: warning: exported method NsqdRpcClient.CallWithRetry should have comment or be unexported (golint)
  • Line 191: warning: exported method NsqdRpcClient.NotifyTopicLeaderSession should have comment or be unexported (golint)
  • Line 206: warning: exported method NsqdRpcClient.NotifyAcquireTopicLeader should have comment or be unexported (golint)
  • Line 218: warning: exported method NsqdRpcClient.NotifyReleaseTopicLeader should have comment or be unexported (golint)
  • Line 233: warning: exported method NsqdRpcClient.UpdateTopicInfo should have comment or be unexported (golint)
  • Line 241: warning: exported method NsqdRpcClient.EnableTopicWrite should have comment or be unexported (golint)
  • Line 249: warning: exported method NsqdRpcClient.DisableTopicWriteFast should have comment or be unexported (golint)
  • Line 257: warning: exported method NsqdRpcClient.DisableTopicWrite should have comment or be unexported (golint)
  • Line 265: warning: exported method NsqdRpcClient.DeleteNsqdTopic should have comment or be unexported (golint)
  • Line 273: warning: exported method NsqdRpcClient.IsTopicWriteDisabled should have comment or be unexported (golint)
  • Line 283: warning: exported method NsqdRpcClient.GetTopicStats should have comment or be unexported (golint)
  • Line 291: warning: exported method NsqdRpcClient.TriggerLookupChanged should have comment or be unexported (golint)
  • Line 296: warning: exported method NsqdRpcClient.UpdateChannelList should have comment or be unexported (golint)
  • Line 309: warning: exported method NsqdRpcClient.NotifyChannelList should have comment or be unexported (golint)
  • Line 322: warning: exported method NsqdRpcClient.DeleteChannel should have comment or be unexported (golint)
  • Line 335: warning: exported method NsqdRpcClient.UpdateChannelState should have comment or be unexported (golint)
  • Line 352: warning: exported method NsqdRpcClient.UpdateChannelOffset should have comment or be unexported (golint)
  • Line 402: warning: exported method NsqdRpcClient.NotifyUpdateChannelOffset should have comment or be unexported (golint)
  • Line 416: warning: exported method NsqdRpcClient.UpdateDelayedQueueState should have comment or be unexported (golint)
  • Line 434: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 440: warning: exported method NsqdRpcClient.PutDelayedMessage should have comment or be unexported (golint)
  • Line 455: warning: exported method NsqdRpcClient.PutMessage should have comment or be unexported (golint)
  • Line 506: warning: exported method NsqdRpcClient.PutMessages should have comment or be unexported (golint)
  • Line 560: warning: exported method NsqdRpcClient.GetLastCommitLogID should have comment or be unexported (golint)
  • Line 572: warning: exported method NsqdRpcClient.GetLastDelayedQueueCommitLogID should have comment or be unexported (golint)
  • Line 584: warning: exported method NsqdRpcClient.GetCommitLogFromOffset should have comment or be unexported (golint)
  • Line 609: warning: exported method NsqdRpcClient.PullCommitLogsAndData should have comment or be unexported (golint)
  • Line 672: warning: exported method NsqdRpcClient.GetFullSyncInfo should have comment or be unexported (golint)
  • Line 691: warning: exported method NsqdRpcClient.GetBackupedDelayedQueue should have comment or be unexported (golint)
  • Line 706: warning: exported method NsqdRpcClient.GetNodeInfo should have comment or be unexported (golint)
  • Line 724: warning: exported method NsqdRpcClient.CallRpcTest should have comment or be unexported (golint)
  • Line 736: warning: exported method NsqdRpcClient.CallRpcTesttimeout should have comment or be unexported (golint)
  • Line 741: warning: exported method NsqdRpcClient.CallRpcTestCoordErr should have comment or be unexported (golint)

• nsq/nsqd/segment_tree.go
  • Line 10: warning: exported type QueueInterval should have comment or be unexported (golint)
  • Line 17: warning: exported type MsgQueueInterval should have comment or be unexported (golint)
  • Line 29: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 32: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 35: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 41: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 45: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 49: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 53: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 63: warning: exported type IntervalTree should have comment or be unexported (golint)
  • Line 67: warning: exported function NewIntervalTree should have comment or be unexported (golint)
  • Line 73: warning: comment on exported method IntervalTree.AddOrMerge should be of the form "AddOrMerge ..." (golint)
  • Line 74: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 102: warning: exported method IntervalTree.Len should have comment or be unexported (golint)
  • Line 102: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 106: warning: exported method IntervalTree.ToIntervalList should have comment or be unexported (golint)
  • Line 106: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 122: warning: exported method IntervalTree.ToString should have comment or be unexported (golint)
  • Line 122: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 130: warning: exported method IntervalTree.DeleteRange should have comment or be unexported (golint)
  • Line 130: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 140: warning: exported method IntervalTree.DeleteInterval should have comment or be unexported (golint)
  • Line 140: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 150: warning: exported method IntervalTree.DeleteLower should have comment or be unexported (golint)
  • Line 150: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 168: warning: exported method IntervalTree.IsCompleteOverlap should have comment or be unexported (golint)
  • Line 168: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 182: warning: exported method IntervalTree.Query should have comment or be unexported (golint)
  • Line 182: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 199: warning: exported method IntervalTree.IsLowestAt should have comment or be unexported (golint)
  • Line 199: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 217: warning: exported type IntervalSkipList should have comment or be unexported (golint)
  • Line 221: warning: exported function NewIntervalSkipList should have comment or be unexported (golint)
  • Line 228: warning: comment on exported method IntervalSkipList.AddOrMerge should be of the form "AddOrMerge ..." (golint)
  • Line 229: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 257: warning: exported method IntervalSkipList.Len should have comment or be unexported (golint)
  • Line 257: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 261: warning: exported method IntervalSkipList.ToIntervalList should have comment or be unexported (golint)
  • Line 261: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 278: warning: exported method IntervalSkipList.ToString should have comment or be unexported (golint)
  • Line 278: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 293: warning: exported method IntervalSkipList.DeleteRange should have comment or be unexported (golint)
  • Line 293: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 303: warning: exported method IntervalSkipList.DeleteInterval should have comment or be unexported (golint)
  • Line 303: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 307: warning: exported method IntervalSkipList.DeleteLower should have comment or be unexported (golint)
  • Line 307: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 325: warning: exported method IntervalSkipList.IsCompleteOverlap should have comment or be unexported (golint)
  • Line 325: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 330: warning: exported method IntervalSkipList.Query should have comment or be unexported (golint)
  • Line 330: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 377: warning: exported method IntervalSkipList.IsLowestAt should have comment or be unexported (golint)
  • Line 377: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 395: warning: exported type IntervalHash should have comment or be unexported (golint)
  • Line 400: warning: exported function NewIntervalHash should have comment or be unexported (golint)
  • Line 407: warning: comment on exported method IntervalHash.AddOrMerge should be of the form "AddOrMerge ..." (golint)
  • Line 408: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 448: warning: exported method IntervalHash.Len should have comment or be unexported (golint)
  • Line 448: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 452: warning: exported method IntervalHash.ToIntervalList should have comment or be unexported (golint)
  • Line 452: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 473: warning: exported method IntervalHash.ToString should have comment or be unexported (golint)
  • Line 473: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 497: warning: exported method IntervalHash.DeleteRange should have comment or be unexported (golint)
  • Line 497: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 507: warning: exported method IntervalHash.DeleteInterval should have comment or be unexported (golint)
  • Line 507: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 515: warning: exported method IntervalHash.DeleteLower should have comment or be unexported (golint)
  • Line 515: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 533: warning: exported method IntervalHash.IsCompleteOverlap should have comment or be unexported (golint)
  • Line 533: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 562: warning: exported method IntervalHash.QueryExist should have comment or be unexported (golint)
  • Line 562: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 566: warning: exported method IntervalHash.Query should have comment or be unexported (golint)
  • Line 566: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 570: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 601: warning: exported method IntervalHash.IsLowestAt should have comment or be unexported (golint)
  • Line 601: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 614: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nsq/nsqlookupd_migrate/topics.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 3: warning: don't use underscores in Go names; type Topics_old should be TopicsOld (golint)
  • Line 3: warning: exported type Topics_old should have comment or be unexported (golint)
  • Line 9: warning: exported type Topics should have comment or be unexported (golint)

• nsq/nsqadmin/context.go
  • Line 3: warning: exported type Context should have comment or be unexported (golint)

• nsq/consistence/leadership.go
  • Line 10: warning: exported var ErrLeaderSessionAlreadyExist should have comment or be unexported (golint)
  • Line 17: warning: exported const NoClusterWriteDisable should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: exported function DisableClusterWrite should have comment or be unexported (golint)
  • Line 30: warning: exported function IsAllClusterWriteDisabled should have comment or be unexported (golint)
  • Line 34: warning: exported function IsClusterWriteDisabledForOrdered should have comment or be unexported (golint)
  • Line 38: warning: exported type EpochType should have comment or be unexported (golint)
  • Line 40: warning: exported type NsqdNodeInfo should have comment or be unexported (golint)
  • Line 48: warning: exported method NsqdNodeInfo.GetID should have comment or be unexported (golint)
  • Line 48: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 52: warning: exported type NsqLookupdNodeInfo should have comment or be unexported (golint)
  • Line 61: warning: exported method NsqLookupdNodeInfo.GetID should have comment or be unexported (golint)
  • Line 61: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 69: warning: exported type TopicMetaInfo should have comment or be unexported (golint)
  • Line 91: warning: exported method TopicMetaInfo.AllowMulti should have comment or be unexported (golint)
  • Line 95: warning: exported type TopicPartitionReplicaInfo should have comment or be unexported (golint)
  • Line 106: warning: exported method TopicPartitionReplicaInfo.Copy should have comment or be unexported (golint)
  • Line 106: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 121: warning: exported type TopicPartitionMetaInfo should have comment or be unexported (golint)
  • Line 128: warning: exported method TopicPartitionMetaInfo.GetTopicDesp should have comment or be unexported (golint)
  • Line 128: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 132: warning: exported method TopicPartitionMetaInfo.Copy should have comment or be unexported (golint)
  • Line 132: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 138: warning: exported type TopicLeaderSession should have comment or be unexported (golint)
  • Line 146: warning: exported method TopicLeaderSession.IsSame should have comment or be unexported (golint)
  • Line 146: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 165: warning: exported type ConsistentStore should have comment or be unexported (golint)
  • Line 171: warning: comment on exported type NSQLookupdLeadership should be of the form "NSQLookupdLeadership ..." (with optional leading article) (golint)
  • Line 226: warning: exported type NSQDLeadership should have comment or be unexported (golint)

• nsq/nsqd/backend_queue.go
  • Line 3: warning: exported type BackendOffset should have comment or be unexported (golint)
  • Line 5: warning: exported type BackendQueueOffset should have comment or be unexported (golint)
  • Line 9: warning: exported type BackendQueueEnd should have comment or be unexported (golint)
  • Line 26: warning: comment on exported type BackendQueueWriter should be of the form "BackendQueueWriter ..." (with optional leading article) (golint)
  • Line 40: warning: exported type ReadResult should have comment or be unexported (golint)
  • Line 48: warning: comment on exported type BackendQueueReader should be of the form "BackendQueueReader ..." (with optional leading article) (golint)

• nsq/apps/nsq_to_file/nsq_to_file.go
  • Line 60: warning: exported type FileLogger should have comment or be unexported (golint)
  • Line 80: warning: exported type ConsumerFileLogger should have comment or be unexported (golint)
  • Line 85: warning: exported type TopicDiscoverer should have comment or be unexported (golint)
  • Line 102: warning: exported method FileLogger.HandleMessage should have comment or be unexported (golint)
  • Line 197: warning: exported method FileLogger.Close should have comment or be unexported (golint)
  • Line 213: warning: exported method FileLogger.Sync should have comment or be unexported (golint)
  • Line 319: warning: exported function NewFileLogger should have comment or be unexported (golint)

• nsq/internal/dirlock/dirlock.go
  • Line 11: warning: exported type DirLock should have comment or be unexported (golint)
  • Line 16: warning: exported function New should have comment or be unexported (golint)
  • Line 22: warning: exported method DirLock.Lock should have comment or be unexported (golint)
  • Line 35: warning: exported method DirLock.Unlock should have comment or be unexported (golint)

• nsq/nsqadmin/options.go
  • Line 10: warning: exported type Options should have comment or be unexported (golint)
  • Line 59: warning: exported function NewOptions should have comment or be unexported (golint)

• nsq/nsqd/codec/memcmp_codec.go
  • Line 22: warning: exported const NilFlag should have comment (or a comment on this block) or be unexported (golint)
  • Line 88: warning: comment on exported function EncodeMemCmpKey should be of the form "EncodeMemCmpKey ..." (golint)
  • Line 94: warning: exported function EncodeMaxKey should have comment or be unexported (golint)
  • Line 99: warning: exported function EncodeMinNotNull should have comment or be unexported (golint)
  • Line 129: warning: exported function DecodeOne should have comment or be unexported (golint)
  • Line 162: warning: exported function CutOne should have comment or be unexported (golint)

• nsq/nsqlookupd_migrate/topic_migrate_manager.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 10: warning: exported type ITopicMigrateGuard should have comment or be unexported (golint)
  • Line 16: warning: exported type HttpTopicMigrateGuard should have comment or be unexported (golint)
  • Line 21: warning: exported method HttpTopicMigrateGuard.GetTopicSwitch should have comment or be unexported (golint)
  • Line 27: warning: exported method HttpTopicMigrateGuard.UpdateTopicSwitches should have comment or be unexported (golint)
  • Line 38: warning: exported method HttpTopicMigrateGuard.Init should have comment or be unexported (golint)
  • Line 41: warning: exported function NewTopicMigrateGuard should have comment or be unexported (golint)

• nsq/nsqlookupd/nsqlookupd.go
  • Line 19: warning: exported type NSQLookupd should have comment or be unexported (golint)
  • Line 29: warning: exported function New should have comment or be unexported (golint)
  • Line 57: warning: exported method NSQLookupd.Main should have comment or be unexported (golint)
  • Line 165: warning: exported method NSQLookupd.RealTCPAddr should have comment or be unexported (golint)
  • Line 174: warning: exported method NSQLookupd.RealHTTPAddr should have comment or be unexported (golint)
  • Line 183: warning: exported method NSQLookupd.Exit should have comment or be unexported (golint)

• nsq/internal/clusterinfo/types.go
  • Line 16: warning: exported type ProducerTopic should have comment or be unexported (golint)
  • Line 21: warning: exported type ProducerTopics should have comment or be unexported (golint)
  • Line 27: warning: exported type Producer should have comment or be unexported (golint)
  • Line 75: warning: exported method Producer.Address should have comment or be unexported (golint)
  • Line 82: warning: exported method Producer.HTTPAddress should have comment or be unexported (golint)
  • Line 86: warning: exported method Producer.TCPAddress should have comment or be unexported (golint)
  • Line 97: warning: exported type ClientPubStats should have comment or be unexported (golint)
  • Line 106: warning: exported type NodeStat should have comment or be unexported (golint)
  • Line 115: warning: exported type ClusterNodeInfo should have comment or be unexported (golint)
  • Line 121: warning: exported type TopicStats should have comment or be unexported (golint)
  • Line 156: warning: exported type TopicMsgStatsInfo should have comment or be unexported (golint)
  • Line 163: warning: exported method TopicStats.Add should have comment or be unexported (golint)
  • Line 204: warning: exported type ChannelStats should have comment or be unexported (golint)
  • Line 241: warning: comment on exported method ChannelStats.Merge should be of the form "Merge ..." (golint)
  • Line 297: warning: exported method ChannelStats.Add should have comment or be unexported (golint)
  • Line 350: warning: exported type ExtFilterData should have comment or be unexported (golint)
  • Line 358: warning: exported type MultiFilterData should have comment or be unexported (golint)
  • Line 363: warning: exported type ClientStats should have comment or be unexported (golint)
  • Line 423: warning: exported method ClientStats.HasUserAgent should have comment or be unexported (golint)
  • Line 423: warning: receiver name c should be consistent with previous receiver name s for ClientStats (golint)
  • Line 427: warning: exported method ClientStats.HasSampleRate should have comment or be unexported (golint)
  • Line 427: warning: receiver name c should be consistent with previous receiver name s for ClientStats (golint)
  • Line 431: warning: exported type ChannelStatsList should have comment or be unexported (golint)
  • Line 433: warning: exported method ChannelStatsList.Len should have comment or be unexported (golint)
  • Line 434: warning: exported method ChannelStatsList.Swap should have comment or be unexported (golint)
  • Line 436: warning: exported type ChannelStatsByPartAndHost should have comment or be unexported (golint)
  • Line 440: warning: exported method ChannelStatsByPartAndHost.Less should have comment or be unexported (golint)
  • Line 450: warning: exported type ClientStatsList should have comment or be unexported (golint)
  • Line 452: warning: exported method ClientStatsList.Len should have comment or be unexported (golint)
  • Line 453: warning: exported method ClientStatsList.Swap should have comment or be unexported (golint)
  • Line 455: warning: exported type ClientsByHost should have comment or be unexported (golint)
  • Line 459: warning: exported method ClientsByHost.Less should have comment or be unexported (golint)
  • Line 466: warning: exported type TopicStatsList should have comment or be unexported (golint)
  • Line 468: warning: exported method TopicStatsList.Len should have comment or be unexported (golint)
  • Line 469: warning: exported method TopicStatsList.Swap should have comment or be unexported (golint)
  • Line 471: warning: exported type TopicStatsByPartitionAndHost should have comment or be unexported (golint)
  • Line 475: warning: exported method TopicStatsByPartitionAndHost.Less should have comment or be unexported (golint)
  • Line 484: warning: exported type TopicStatsByHourlyPubsize should have comment or be unexported (golint)
  • Line 488: warning: exported method TopicStatsByHourlyPubsize.Less should have comment or be unexported (golint)
  • Line 497: warning: exported type TopicStatsByChannelDepth should have comment or be unexported (golint)
  • Line 501: warning: exported method TopicStatsByChannelDepth.Less should have comment or be unexported (golint)
  • Line 510: warning: exported type TopicStatsByMessageCount should have comment or be unexported (golint)
  • Line 514: warning: exported method TopicStatsByMessageCount.Less should have comment or be unexported (golint)
  • Line 523: warning: exported type Producers should have comment or be unexported (golint)
  • Line 525: warning: exported method Producers.Len should have comment or be unexported (golint)
  • Line 526: warning: exported method Producers.Swap should have comment or be unexported (golint)
  • Line 528: warning: exported method Producers.HTTPAddrs should have comment or be unexported (golint)
  • Line 536: warning: exported method Producers.Search should have comment or be unexported (golint)
  • Line 545: warning: exported type ProducersByHost should have comment or be unexported (golint)
  • Line 549: warning: exported method ProducersByHost.Less should have comment or be unexported (golint)
  • Line 553: warning: exported type ISRStat should have comment or be unexported (golint)
  • Line 558: warning: exported type CatchupStat should have comment or be unexported (golint)
  • Line 564: warning: exported type TopicCoordStat should have comment or be unexported (golint)
  • Line 573: warning: exported type CoordStats should have comment or be unexported (golint)
  • Line 578: warning: exported type MessageHistoryStat should have comment or be unexported (golint)
  • Line 580: warning: exported type NsqLookupdNodeInfo should have comment or be unexported (golint)
  • Line 588: warning: exported type LookupdNodes should have comment or be unexported (golint)
  • Line 594: warning: exported type NodeHourlyPubsize should have comment or be unexported (golint)

• nsq/consistence/logger.go
  • Line 9: warning: exported function SetCoordLogger should have comment or be unexported (golint)
  • Line 14: warning: exported function SetCoordLogLevel should have comment or be unexported (golint)

• nsq/nsqd/options.go
  • Line 17: warning: exported const MAX_NODE_ID should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported type Options should have comment or be unexported (golint)
  • Line 126: warning: exported function NewOptions should have comment or be unexported (golint)
  • Line 224: warning: exported method Options.DecideBroadcast should have comment or be unexported (golint)

• nsq/nsqd/topic.go
  • Line 25: warning: exported const MAX_TOPIC_PARTITION should have comment (or a comment on this block) or be unexported (golint)
  • Line 31: warning: exported var ErrInvalidMessageID should have comment or be unexported (golint)
  • Line 61: warning: exported type MsgIDGenerator should have comment or be unexported (golint)
  • Line 66: warning: exported type TopicDynamicConf should have comment or be unexported (golint)
  • Line 76: warning: exported type PubInfo should have comment or be unexported (golint)
  • Line 84: warning: exported type PubInfoChan should have comment or be unexported (golint)
  • Line 86: warning: exported type MPubInfo should have comment or be unexported (golint)
  • Line 92: warning: exported type MPubInfoChan should have comment or be unexported (golint)
  • Line 94: warning: exported type ChannelMetaInfo should have comment or be unexported (golint)
  • Line 101: warning: exported method ChannelMetaInfo.IsZanTestSkipepd should have comment or be unexported (golint)
  • Line 105: warning: exported type Topic should have comment or be unexported (golint)
  • Line 158: warning: exported method Topic.IsExt should have comment or be unexported (golint)
  • Line 162: warning: exported method Topic.DisableChannelAutoCreate should have comment or be unexported (golint)
  • Line 166: warning: exported method Topic.EnableChannelAutoCreate should have comment or be unexported (golint)
  • Line 170: warning: exported method Topic.IsChannelAutoCreateDisabled should have comment or be unexported (golint)
  • Line 174: warning: exported method Topic.IncrPubWaitingBytes should have comment or be unexported (golint)
  • Line 178: warning: exported method Topic.IncrPubFailed should have comment or be unexported (golint)
  • Line 186: warning: exported method Topic.PubFailed should have comment or be unexported (golint)
  • Line 190: warning: exported function GetTopicFullName should have comment or be unexported (golint)
  • Line 194: warning: exported function NewTopicForDelete should have comment or be unexported (golint)
  • Line 200: warning: exported function NewTopicWithExt should have comment or be unexported (golint)
  • Line 207: warning: comment on exported function NewTopicWithExtAndDisableChannelAutoCreate should be of the form "NewTopicWithExtAndDisableChannelAutoCreate ..." (golint)
  • Line 309: warning: exported method Topic.GetDelayedQueue should have comment or be unexported (golint)
  • Line 320: warning: exported method Topic.GetOrCreateDelayedQueueForReadNoLock should have comment or be unexported (golint)
  • Line 333: warning: exported method Topic.GetOrCreateDelayedQueueNoLock should have comment or be unexported (golint)
  • Line 351: warning: exported method Topic.GetWaitChan should have comment or be unexported (golint)
  • Line 354: warning: exported method Topic.IsWaitChanFull should have comment or be unexported (golint)
  • Line 357: warning: exported method Topic.IsMWaitChanFull should have comment or be unexported (golint)
  • Line 360: warning: exported method Topic.GetMWaitChan should have comment or be unexported (golint)
  • Line 363: warning: exported method Topic.QuitChan should have comment or be unexported (golint)
  • Line 367: warning: exported method Topic.IsDataNeedFix should have comment or be unexported (golint)
  • Line 371: warning: exported method Topic.SetDataFixState should have comment or be unexported (golint)
  • Line 445: warning: exported method Topic.MarkAsRemoved should have comment or be unexported (golint)
  • Line 479: warning: comment on exported method Topic.SetMagicCode should be of the form "SetMagicCode ..." (golint)
  • Line 491: warning: comment on exported method Topic.GetMagicCode should be of the form "GetMagicCode ..." (golint)
  • Line 496: warning: exported method Topic.SetTrace should have comment or be unexported (golint)
  • Line 511: warning: exported method Topic.LoadChannelMeta should have comment or be unexported (golint)
  • Line 548: warning: exported method Topic.UpdateChannelMeta should have comment or be unexported (golint)
  • Line 572: warning: exported method Topic.GetChannelMeta should have comment or be unexported (golint)
  • Line 592: warning: exported method Topic.SaveChannelMeta should have comment or be unexported (golint)
  • Line 617: warning: exported method Topic.RemoveChannelMeta should have comment or be unexported (golint)
  • Line 626: warning: exported method Topic.GetDetailStats should have comment or be unexported (golint)
  • Line 630: warning: exported method Topic.SaveHistoryStats should have comment or be unexported (golint)
  • Line 639: warning: exported method Topic.LoadHistoryStats should have comment or be unexported (golint)
  • Line 643: warning: exported method Topic.GetCommitted should have comment or be unexported (golint)
  • Line 651: warning: comment on exported method Topic.UpdateCommittedOffset should be of the form "UpdateCommittedOffset ..." (golint)
  • Line 672: warning: exported method Topic.GetDiskQueueSnapshot should have comment or be unexported (golint)
  • Line 686: warning: exported method Topic.BufferPoolGet should have comment or be unexported (golint)
  • Line 693: warning: exported method Topic.BufferPoolPut should have comment or be unexported (golint)
  • Line 697: warning: exported method Topic.GetChannelMapCopy should have comment or be unexported (golint)
  • Line 712: warning: exported method Topic.GetDynamicInfo should have comment or be unexported (golint)
  • Line 719: warning: exported method Topic.IsOrdered should have comment or be unexported (golint)
  • Line 723: warning: exported method Topic.SetDynamicInfo should have comment or be unexported (golint)
  • Line 781: warning: exported method Topic.GetFullName should have comment or be unexported (golint)
  • Line 785: warning: exported method Topic.GetTopicName should have comment or be unexported (golint)
  • Line 789: warning: exported method Topic.GetTopicPart should have comment or be unexported (golint)
  • Line 812: warning: exported method Topic.NotifyReloadChannels should have comment or be unexported (golint)
  • Line 815: warning: exported method Topic.GetTopicChannelDebugStat should have comment or be unexported (golint)
  • Line 871: warning: exported method Topic.GetExistingChannel should have comment or be unexported (golint)
  • Line 881: warning: exported method Topic.CloseExistingChannel should have comment or be unexported (golint)
  • Line 927: warning: exported method Topic.RollbackNoLock should have comment or be unexported (golint)
  • Line 941: warning: exported method Topic.ResetBackendEndNoLock should have comment or be unexported (golint)
  • Line 977: warning: exported method Topic.PutMessageNoLock should have comment or be unexported (golint)
  • Line 1001: warning: exported method Topic.ForceFlushForChannels should have comment or be unexported (golint)
  • Line 1042: warning: exported method Topic.PutRawDataOnReplica should have comment or be unexported (golint)
  • Line 1079: warning: exported method Topic.PutMessageOnReplica should have comment or be unexported (golint)
  • Line 1095: warning: exported method Topic.PutMessagesOnReplica should have comment or be unexported (golint)
  • Line 1128: warning: exported method Topic.PutMessagesNoLock should have comment or be unexported (golint)
  • Line 1255: warning: exported method Topic.TotalMessageCnt should have comment or be unexported (golint)
  • Line 1259: warning: exported method Topic.GetQueueReadStart should have comment or be unexported (golint)
  • Line 1263: warning: exported method Topic.TotalDataSize should have comment or be unexported (golint)
  • Line 1345: warning: exported method Topic.IsWriteDisabled should have comment or be unexported (golint)
  • Line 1349: warning: comment on exported method Topic.DisableForSlave should be of the form "DisableForSlave ..." (golint)
  • Line 1373: warning: exported method Topic.EnableForMaster should have comment or be unexported (golint)
  • Line 1393: warning: exported method Topic.Empty should have comment or be unexported (golint)
  • Line 1398: warning: exported method Topic.ForceFlush should have comment or be unexported (golint)
  • Line 1434: warning: exported method Topic.IsFsync should have comment or be unexported (golint)
  • Line 1440: warning: error should be the last type when returning multiple items (golint)
  • Line 1467: warning: exported method Topic.PrintCurrentStats should have comment or be unexported (golint)
  • Line 1477: warning: exported method Topic.AggregateChannelE2eProcessingLatency should have comment or be unexported (golint)
  • Line 1499: warning: comment on exported method Topic.TryCleanOldData should be of the form "TryCleanOldData ..." (golint)
  • Line 1606: warning: exported method Topic.TryFixQueueEnd should have comment or be unexported (golint)
  • Line 1627: warning: exported method Topic.ResetBackendWithQueueStartNoLock should have comment or be unexported (golint)
  • Line 1662: warning: exported method Topic.GetDelayedQueueUpdateTs should have comment or be unexported (golint)
  • Line 1674: warning: exported method Topic.GetDelayedQueueConsumedState should have comment or be unexported (golint)
  • Line 1693: warning: exported method Topic.UpdateDelayedQueueConsumedState should have comment or be unexported (golint)
  • Line 1707: warning: comment on exported method Topic.TryFixData should be of the form "TryFixData ..." (golint)
  • Line 1802: warning: exported method Topic.CheckDiskQueueReadToEndOK should have comment or be unexported (golint)

• nsq/internal/statsd/host.go
  • Line 7: warning: exported function HostKey should have comment or be unexported (golint)

• nsq/internal/flume_log/flume_sdk.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 10: warning: exported type FlumeLogger should have comment or be unexported (golint)
  • Line 18: warning: exported function NewFlumeLogger should have comment or be unexported (golint)
  • Line 23: warning: exported function NewFlumeLoggerWithAddr should have comment or be unexported (golint)
  • Line 28: warning: exported method FlumeLogger.Info should have comment or be unexported (golint)
  • Line 32: warning: exported method FlumeLogger.Warn should have comment or be unexported (golint)
  • Line 41: warning: don't use underscores in Go names; var log_info should be logInfo (golint)
  • Line 55: warning: exported method FlumeLogger.Stop should have comment or be unexported (golint)

• nsq/internal/http_api/topic_channel_args.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 14: warning: exported function GetTopicArg should have comment or be unexported (golint)
  • Line 27: warning: exported function GetTopicChannelArgs should have comment or be unexported (golint)
  • Line 45: warning: comment on exported function GetTopicPartitionArgs should be of the form "GetTopicPartitionArgs ..." (golint)
  • Line 66: warning: exported function GetTopicPartitionChannelArgs should have comment or be unexported (golint)

• nsq/nsqd/stats.go
  • Line 25: warning: exported type TopicStats should have comment or be unexported (golint)
  • Line 49: warning: exported function NewTopicStats should have comment or be unexported (golint)
  • Line 82: warning: exported type ChannelStats should have comment or be unexported (golint)
  • Line 114: warning: exported function NewChannelStats should have comment or be unexported (golint)
  • Line 151: warning: exported type ClientPubStats should have comment or be unexported (golint)
  • Line 160: warning: exported method ClientPubStats.Copy should have comment or be unexported (golint)
  • Line 172: warning: exported method ClientPubStats.IncrCounter should have comment or be unexported (golint)
  • Line 180: warning: exported type ClientStats should have comment or be unexported (golint)
  • Line 219: warning: exported type Topics should have comment or be unexported (golint)
  • Line 221: warning: exported method Topics.Len should have comment or be unexported (golint)
  • Line 222: warning: exported method Topics.Swap should have comment or be unexported (golint)
  • Line 224: warning: exported type TopicsByName should have comment or be unexported (golint)
  • Line 228: warning: exported method TopicsByName.Less should have comment or be unexported (golint)
  • Line 233: warning: exported type Channels should have comment or be unexported (golint)
  • Line 235: warning: exported method Channels.Len should have comment or be unexported (golint)
  • Line 236: warning: exported method Channels.Swap should have comment or be unexported (golint)
  • Line 238: warning: exported type ChannelsByName should have comment or be unexported (golint)
  • Line 242: warning: exported method ChannelsByName.Less should have comment or be unexported (golint)
  • Line 244: warning: exported method NSQD.GetStats should have comment or be unexported (golint)
  • Line 292: warning: exported method NSQD.GetTopicStatsWithFilter should have comment or be unexported (golint)
  • Line 310: warning: exported method NSQD.GetTopicStats should have comment or be unexported (golint)
  • Line 314: warning: exported type DetailStatsInfo should have comment or be unexported (golint)
  • Line 322: warning: exported function NewDetailStatsInfo should have comment or be unexported (golint)
  • Line 333: warning: exported type TopicMsgStatsInfo should have comment or be unexported (golint)
  • Line 342: warning: exported type ChannelStatsInfo should have comment or be unexported (golint)
  • Line 351: warning: exported type TopicHistoryStatsInfo should have comment or be unexported (golint)
  • Line 357: warning: exported method ChannelStatsInfo.UpdateChannelStats should have comment or be unexported (golint)
  • Line 357: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 361: warning: exported method ChannelStatsInfo.GetChannelLatencyStats should have comment or be unexported (golint)
  • Line 361: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 369: warning: comment on exported method ChannelStatsInfo.UpdateChannelLatencyStats should be of the form "UpdateChannelLatencyStats ..." (golint)
  • Line 370: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 382: warning: exported method ChannelStatsInfo.UpdateDelivery2ACKStats should have comment or be unexported (golint)
  • Line 382: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 386: warning: exported method ChannelStatsInfo.GetDeliveryLatencyStats should have comment or be unexported (golint)
  • Line 386: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 394: warning: comment on exported method ChannelStatsInfo.UpdateDelivery2ACKLatencyStats should be of the form "UpdateDelivery2ACKLatencyStats ..." (golint)
  • Line 395: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 414: warning: exported method TopicMsgStatsInfo.UpdateMsgSizeStats should have comment or be unexported (golint)
  • Line 414: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 434: warning: exported method TopicMsgStatsInfo.BatchUpdateMsgLatencyStats should have comment or be unexported (golint)
  • Line 434: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 450: warning: exported method TopicMsgStatsInfo.UpdateMsgLatencyStats should have comment or be unexported (golint)
  • Line 450: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 466: warning: exported method TopicMsgStatsInfo.UpdateMsgStats should have comment or be unexported (golint)
  • Line 466: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 471: warning: comment on exported method TopicHistoryStatsInfo.UpdateHourlySize should be of the form "UpdateHourlySize ..." (golint)
  • Line 473: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 485: warning: exported method DetailStatsInfo.ResetHistoryInitPub should have comment or be unexported (golint)
  • Line 485: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 491: warning: exported method DetailStatsInfo.BatchUpdateTopicLatencyStats should have comment or be unexported (golint)
  • Line 491: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 495: warning: exported method DetailStatsInfo.UpdateTopicMsgStats should have comment or be unexported (golint)
  • Line 495: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 505: warning: exported method DetailStatsInfo.InitPubClientStats should have comment or be unexported (golint)
  • Line 505: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 530: warning: exported method DetailStatsInfo.RemovePubStats should have comment or be unexported (golint)
  • Line 530: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 536: warning: exported method DetailStatsInfo.GetPubClientStats should have comment or be unexported (golint)
  • Line 536: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 546: warning: exported method DetailStatsInfo.GetHourlyStats should have comment or be unexported (golint)
  • Line 546: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 550: warning: exported method DetailStatsInfo.GetMsgSizeStats should have comment or be unexported (golint)
  • Line 550: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 555: warning: exported method DetailStatsInfo.GetMsgWriteLatencyStats should have comment or be unexported (golint)
  • Line 555: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 563: warning: exported method DetailStatsInfo.UpdateHistory should have comment or be unexported (golint)
  • Line 563: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 571: warning: exported method DetailStatsInfo.LoadHistory should have comment or be unexported (golint)
  • Line 571: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 589: warning: exported method DetailStatsInfo.SaveHistory should have comment or be unexported (golint)
  • Line 589: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 617: warning: exported method NSQD.UpdateTopicHistoryStats should have comment or be unexported (golint)

• nsq/nsqd/ext_filter.go
  • Line 36: warning: exported type ExtFilterData should have comment or be unexported (golint)
  • Line 44: warning: exported type MultiFilterData should have comment or be unexported (golint)
  • Line 49: warning: exported type IExtFilter should have comment or be unexported (golint)
  • Line 146: warning: exported function NewExtFilter should have comment or be unexported (golint)

• nsq/internal/quantile/quantile.go
  • Line 12: warning: exported type Result should have comment or be unexported (golint)
  • Line 25: warning: exported type Quantile should have comment or be unexported (golint)
  • Line 36: warning: exported function New should have comment or be unexported (golint)
  • Line 50: warning: exported method Quantile.Result should have comment or be unexported (golint)
  • Line 66: warning: exported method Quantile.Insert should have comment or be unexported (golint)
  • Line 78: warning: exported method Quantile.QueryHandler should have comment or be unexported (golint)
  • Line 92: warning: exported method Quantile.IsDataStale should have comment or be unexported (golint)
  • Line 96: warning: exported method Quantile.Merge should have comment or be unexported (golint)

• nsq/internal/util/rename.go
  • Line 9: warning: exported function AtomicRename should have comment or be unexported (golint)

• nsq/internal/app/string_array.go
  • Line 7: warning: exported type StringArray should have comment or be unexported (golint)
  • Line 9: warning: exported method StringArray.Set should have comment or be unexported (golint)

• nsq/nsqlookupd_migrate/context.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 3: warning: exported type Context should have comment or be unexported (golint)
  • Line 11: warning: don't use underscores in Go names; struct field Migrate_key should be MigrateKey (golint)

• nsq/nsqdserver/nsqd_server.go
  • Line 23: warning: exported type NsqdServer should have comment or be unexported (golint)
  • Line 36: warning: exported const TLSNotRequired should have comment (or a comment on this block) or be unexported (golint)
  • Line 91: warning: exported function NewNsqdServer should have comment or be unexported (golint)
  • Line 174: warning: exported method NsqdServer.GetCoord should have comment or be unexported (golint)
  • Line 178: warning: exported method NsqdServer.GetNsqdInstance should have comment or be unexported (golint)
  • Line 182: warning: exported method NsqdServer.Exit should have comment or be unexported (golint)
  • Line 212: warning: exported method NsqdServer.Main should have comment or be unexported (golint)

• nsq/consistence/commitlog.go
  • Line 20: warning: exported const MAX_INCR_ID_BIT should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: exported var DEFAULT_COMMIT_BUF_SIZE should have comment or be unexported (golint)
  • Line 24: warning: exported var MAX_COMMIT_BUF_SIZE should have comment or be unexported (golint)
  • Line 27: warning: exported var ErrCommitLogWrongID should have comment or be unexported (golint)
  • Line 44: warning: exported var LOGROTATE_NUM should have comment or be unexported (golint)
  • Line 45: warning: exported var MIN_KEEP_LOG_ITEM should have comment or be unexported (golint)
  • Line 66: warning: exported type CommitLogData should have comment or be unexported (golint)
  • Line 89: warning: exported function GetLogDataSize should have comment or be unexported (golint)
  • Line 93: warning: exported function GetPrevLogOffset should have comment or be unexported (golint)
  • Line 97: warning: exported function GetNextLogOffset should have comment or be unexported (golint)
  • Line 101: warning: exported function GetPartitionFromMsgID should have comment or be unexported (golint)
  • Line 106: warning: don't use underscores in Go names; func parameter for_write should be forWrite (golint)
  • Line 278: warning: exported type LogStartInfo should have comment or be unexported (golint)
  • Line 286: warning: exported type TopicCommitLogMgr should have comment or be unexported (golint)
  • Line 301: warning: exported function GetTopicPartitionLogPath should have comment or be unexported (golint)
  • Line 306: warning: exported function InitTopicCommitLogMgrWithFixMode should have comment or be unexported (golint)
  • Line 368: warning: exported function InitTopicCommitLogMgr should have comment or be unexported (golint)
  • Line 514: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 531: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 538: warning: exported method TopicCommitLogMgr.MoveTo should have comment or be unexported (golint)
  • Line 538: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 561: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 587: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 623: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 632: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 651: warning: exported method TopicCommitLogMgr.ResetLogWithStart should have comment or be unexported (golint)
  • Line 651: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 686: warning: exported method TopicCommitLogMgr.GetLogStartInfo should have comment or be unexported (golint)
  • Line 686: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 698: warning: exported method TopicCommitLogMgr.GetCurrentStart should have comment or be unexported (golint)
  • Line 698: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 705: warning: exported method TopicCommitLogMgr.Delete should have comment or be unexported (golint)
  • Line 705: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 722: warning: exported method TopicCommitLogMgr.Close should have comment or be unexported (golint)
  • Line 722: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 732: warning: exported method TopicCommitLogMgr.Reopen should have comment or be unexported (golint)
  • Line 732: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 753: warning: exported method TopicCommitLogMgr.NextID should have comment or be unexported (golint)
  • Line 753: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 758: warning: comment on exported method TopicCommitLogMgr.Reset should be of the form "Reset ..." (golint)
  • Line 759: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 762: warning: exported method TopicCommitLogMgr.GetCurrentEnd should have comment or be unexported (golint)
  • Line 762: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 768: warning: exported method TopicCommitLogMgr.GetMaxAvailableCleanOffset should have comment or be unexported (golint)
  • Line 768: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 775: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 797: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 828: warning: exported method TopicCommitLogMgr.CleanOldData should have comment or be unexported (golint)
  • Line 828: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 917: warning: exported method TopicCommitLogMgr.TruncateToOffsetV2 should have comment or be unexported (golint)
  • Line 917: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 962: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 971: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 993: warning: exported method TopicCommitLogMgr.ConvertToCountIndex should have comment or be unexported (golint)
  • Line 993: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1024: warning: exported method TopicCommitLogMgr.ConvertToOffsetIndex should have comment or be unexported (golint)
  • Line 1024: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1059: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1083: warning: exported method TopicCommitLogMgr.GetCommitLogFromOffsetV2 should have comment or be unexported (golint)
  • Line 1083: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1089: warning: exported method TopicCommitLogMgr.GetLastCommitLogDataOnSegment should have comment or be unexported (golint)
  • Line 1089: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1106: warning: comment on exported method TopicCommitLogMgr.GetLastCommitLogOffsetV2 should be of the form "GetLastCommitLogOffsetV2 ..." (golint)
  • Line 1107: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1119: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1153: warning: exported method TopicCommitLogMgr.GetLastCommitLogID should have comment or be unexported (golint)
  • Line 1153: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1157: warning: exported method TopicCommitLogMgr.IsCommitted should have comment or be unexported (golint)
  • Line 1157: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1164: warning: exported method TopicCommitLogMgr.AppendCommitLog should have comment or be unexported (golint)
  • Line 1164: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1168: warning: exported method TopicCommitLogMgr.AppendCommitLogWithSync should have comment or be unexported (golint)
  • Line 1168: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1230: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1247: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1253: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1263: warning: exported method TopicCommitLogMgr.FlushCommitLogs should have comment or be unexported (golint)
  • Line 1263: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1269: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1323: warning: exported method TopicCommitLogMgr.GetCommitLogsV2 should have comment or be unexported (golint)
  • Line 1323: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1329: warning: exported type ICommitLogComparator should have comment or be unexported (golint)
  • Line 1335: warning: exported method TopicCommitLogMgr.SearchLogDataByComparator should have comment or be unexported (golint)
  • Line 1335: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1419: warning: exported type CntComparator should have comment or be unexported (golint)
  • Line 1421: warning: exported method CntComparator.SearchEndBoundary should have comment or be unexported (golint)
  • Line 1421: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1425: warning: exported method CntComparator.LessThanLeftBoundary should have comment or be unexported (golint)
  • Line 1425: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1432: warning: exported method CntComparator.GreatThanRightBoundary should have comment or be unexported (golint)
  • Line 1432: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1439: warning: exported type MsgIDComparator should have comment or be unexported (golint)
  • Line 1441: warning: exported method MsgIDComparator.SearchEndBoundary should have comment or be unexported (golint)
  • Line 1441: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1445: warning: exported method MsgIDComparator.LessThanLeftBoundary should have comment or be unexported (golint)
  • Line 1445: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1452: warning: exported method MsgIDComparator.GreatThanRightBoundary should have comment or be unexported (golint)
  • Line 1452: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1459: warning: exported type MsgOffsetComparator should have comment or be unexported (golint)
  • Line 1461: warning: exported method MsgOffsetComparator.SearchEndBoundary should have comment or be unexported (golint)
  • Line 1461: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1465: warning: exported method MsgOffsetComparator.LessThanLeftBoundary should have comment or be unexported (golint)
  • Line 1465: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1472: warning: exported method MsgOffsetComparator.GreatThanRightBoundary should have comment or be unexported (golint)
  • Line 1472: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1480: warning: exported method TopicCommitLogMgr.SearchLogDataByMsgCnt should have comment or be unexported (golint)
  • Line 1480: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1484: warning: exported method TopicCommitLogMgr.SearchLogDataByMsgID should have comment or be unexported (golint)
  • Line 1484: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 1488: warning: exported method TopicCommitLogMgr.SearchLogDataByMsgOffset should have comment or be unexported (golint)
  • Line 1488: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• nsq/nsqd/channel.go
  • Line 26: warning: exported const MaxMemReqTimes should have comment (or a comment on this block) or be unexported (golint)
  • Line 38: warning: exported function ChangeIntervalForTest should have comment or be unexported (golint)
  • Line 47: warning: exported var ErrMsgNotInFlight should have comment or be unexported (golint)
  • Line 57: warning: exported type Consumer should have comment or be unexported (golint)
  • Line 79: warning: exported type MsgChanData should have comment or be unexported (golint)
  • Line 274: warning: exported method Channel.GetName should have comment or be unexported (golint)
  • Line 278: warning: exported method Channel.GetTopicName should have comment or be unexported (golint)
  • Line 282: warning: exported method Channel.GetTopicPart should have comment or be unexported (golint)
  • Line 286: warning: exported method Channel.ChangeLimiterBytes should have comment or be unexported (golint)
  • Line 324: warning: exported method Channel.RemoveTagClientMsgChannel should have comment or be unexported (golint)
  • Line 350: warning: comment on exported method Channel.GetOrCreateClientMsgChannel should be of the form "GetOrCreateClientMsgChannel ..." (golint)
  • Line 374: warning: exported method Channel.GetClientMsgChan should have comment or be unexported (golint)
  • Line 378: warning: comment on exported method Channel.GetClientTagMsgChan should be of the form "GetClientTagMsgChan ..." (golint)
  • Line 403: warning: exported method Channel.IsSlowTraced should have comment or be unexported (golint)
  • Line 407: warning: exported method Channel.IsTraced should have comment or be unexported (golint)
  • Line 411: warning: exported method Channel.IsEphemeral should have comment or be unexported (golint)
  • Line 415: warning: exported method Channel.SetDelayedQueue should have comment or be unexported (golint)
  • Line 421: warning: exported method Channel.GetDelayedQueue should have comment or be unexported (golint)
  • Line 428: warning: exported method Channel.SetExt should have comment or be unexported (golint)
  • Line 436: warning: exported method Channel.IsExt should have comment or be unexported (golint)
  • Line 440: warning: exported method Channel.SetSlowTrace should have comment or be unexported (golint)
  • Line 448: warning: exported method Channel.SetTrace should have comment or be unexported (golint)
  • Line 456: warning: exported method Channel.SetConsumeOffset should have comment or be unexported (golint)
  • Line 487: warning: exported method Channel.SetOrdered should have comment or be unexported (golint)
  • Line 513: warning: exported method Channel.IsOrdered should have comment or be unexported (golint)
  • Line 558: warning: comment on exported method Channel.IsWaitingMoreDiskData should be of the form "IsWaitingMoreDiskData ..." (golint)
  • Line 571: warning: comment on exported method Channel.IsWaitingMoreData should be of the form "IsWaitingMoreData ..." (golint)
  • Line 640: warning: exported method Channel.Flush should have comment or be unexported (golint)
  • Line 659: warning: exported method Channel.Depth should have comment or be unexported (golint)
  • Line 663: warning: exported method Channel.DepthSize should have comment or be unexported (golint)
  • Line 670: warning: exported method Channel.DepthTimestamp should have comment or be unexported (golint)
  • Line 674: warning: exported method Channel.IsZanTestSkipped should have comment or be unexported (golint)
  • Line 678: warning: exported method Channel.SkipZanTest should have comment or be unexported (golint)
  • Line 682: warning: exported method Channel.UnskipZanTest should have comment or be unexported (golint)
  • Line 705: warning: exported method Channel.Pause should have comment or be unexported (golint)
  • Line 709: warning: exported method Channel.UnPause should have comment or be unexported (golint)
  • Line 731: warning: exported method Channel.IsPaused should have comment or be unexported (golint)
  • Line 735: warning: exported method Channel.Skip should have comment or be unexported (golint)
  • Line 739: warning: exported method Channel.UnSkip should have comment or be unexported (golint)
  • Line 743: warning: exported method Channel.IsSkipped should have comment or be unexported (golint)
  • Line 759: warning: comment on exported method Channel.UpdateQueueEnd should be of the form "UpdateQueueEnd ..." (golint)
  • Line 808: warning: exported method Channel.ConfirmBackendQueueOnSlave should have comment or be unexported (golint)
  • Line 852: warning: comment on exported method Channel.ConfirmMsgWithoutGoInflight should be of the form "ConfirmMsgWithoutGoInflight ..." (golint)
  • Line 893: warning: exported method Channel.ConfirmDelayedMessage should have comment or be unexported (golint)
  • Line 917: warning: comment on exported method Channel.ConfirmBackendQueue should be of the form "ConfirmBackendQueue ..." (golint)
  • Line 964: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 995: warning: exported method Channel.ShouldWaitDelayed should have comment or be unexported (golint)
  • Line 1021: warning: exported method Channel.IsConfirmed should have comment or be unexported (golint)
  • Line 1040: warning: exported method Channel.FinishMessage should have comment or be unexported (golint)
  • Line 1045: warning: exported method Channel.FinishMessageForce should have comment or be unexported (golint)
  • Line 1136: warning: comment on exported method Channel.TryRefreshChannelEnd should be of the form "TryRefreshChannelEnd ..." (golint)
  • Line 1144: warning: exported method Channel.ContinueConsumeForOrder should have comment or be unexported (golint)
  • Line 1165: warning: exported method Channel.ShouldRequeueToEnd should have comment or be unexported (golint)
  • Line 1309: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1432: warning: exported method Channel.RequeueClientMessages should have comment or be unexported (golint)
  • Line 1456: warning: exported method Channel.GetClientsCount should have comment or be unexported (golint)
  • Line 1462: warning: exported method Channel.GetClients should have comment or be unexported (golint)
  • Line 1473: warning: exported method Channel.SetClientLimitedRdy should have comment or be unexported (golint)
  • Line 1483: warning: exported method Channel.AddClient should have comment or be unexported (golint)
  • Line 1520: warning: exported method Channel.StartInFlightTimeout should have comment or be unexported (golint)
  • Line 1543: warning: exported method Channel.GetInflightNum should have comment or be unexported (golint)
  • Line 1550: warning: exported method Channel.UpdateConfirmedInterval should have comment or be unexported (golint)
  • Line 1567: warning: exported method Channel.GetConfirmedIntervalLen should have comment or be unexported (golint)
  • Line 1574: warning: exported method Channel.GetConfirmedInterval should have comment or be unexported (golint)
  • Line 1581: warning: exported method Channel.GetConfirmed should have comment or be unexported (golint)
  • Line 1585: warning: exported method Channel.GetChannelEnd should have comment or be unexported (golint)
  • Line 1589: warning: exported method Channel.GetChannelWaitingConfirmCnt should have comment or be unexported (golint)
  • Line 1687: warning: exported method Channel.IsConsumeDisabled should have comment or be unexported (golint)
  • Line 1691: warning: exported method Channel.DisableConsume should have comment or be unexported (golint)
  • Line 1832: warning: exported method Channel.TryWakeupRead should have comment or be unexported (golint)
  • Line 1887: warning: exported method Channel.TryFixConfirmedByResetRead should have comment or be unexported (golint)
  • Line 1903: warning: exported method Channel.CheckIfNeedResetRead should have comment or be unexported (golint)
  • Line 2340: warning: exported method Channel.GetChannelDebugStats should have comment or be unexported (golint)
  • Line 2376: warning: exported method Channel.CheckIfTimeoutToomuch should have comment or be unexported (golint)
  • Line 2717: warning: exported method Channel.GetDelayedQueueConsumedDetails should have comment or be unexported (golint)
  • Line 2727: warning: exported method Channel.GetDelayedQueueCnt should have comment or be unexported (golint)
  • Line 2737: warning: exported method Channel.GetDelayedQueueConsumedState should have comment or be unexported (golint)
  • Line 2762: warning: exported method Channel.GetMemDelayedMsgs should have comment or be unexported (golint)

• nsq/consistence/nsqd_coordinator.go
  • Line 24: warning: exported const MAX_WRITE_RETRY should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported var MaxRetryWait should have comment or be unexported (golint)
  • Line 41: warning: exported function ChangeSleepMsBetweenLogSyncPull should have comment or be unexported (golint)
  • Line 47: warning: exported function GetTopicPartitionFileName should have comment or be unexported (golint)
  • Line 56: warning: exported function GetTopicPartitionBasePath should have comment or be unexported (golint)
  • Line 60: warning: exported type TopicPartitionID should have comment or be unexported (golint)
  • Line 69: warning: exported type ILocalLogQueue should have comment or be unexported (golint)
  • Line 139: warning: exported type NsqdCoordinator should have comment or be unexported (golint)
  • Line 164: warning: exported function NewNsqdCoordinator should have comment or be unexported (golint)
  • Line 194: warning: exported method NsqdCoordinator.GetMyID should have comment or be unexported (golint)
  • Line 198: warning: exported method NsqdCoordinator.SetLeadershipMgr should have comment or be unexported (golint)
  • Line 271: warning: exported method NsqdCoordinator.Start should have comment or be unexported (golint)
  • Line 326: warning: exported method NsqdCoordinator.Stop should have comment or be unexported (golint)
  • Line 419: warning: exported method NsqdCoordinator.GreedyCleanTopicOldData should have comment or be unexported (golint)
  • Line 579: warning: exported method NsqdCoordinator.GetCurrentLookupd should have comment or be unexported (golint)
  • Line 585: warning: exported method NsqdCoordinator.GetAllLookupdNodes should have comment or be unexported (golint)
  • Line 935: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 951: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 995: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1248: warning: exported method NsqdCoordinator.IsMineConsumeLeaderForTopic should have comment or be unexported (golint)
  • Line 1256: warning: exported method NsqdCoordinator.IsMineLeaderForTopic should have comment or be unexported (golint)
  • Line 1270: warning: exported method NsqdCoordinator.SearchLogByMsgID should have comment or be unexported (golint)
  • Line 1285: warning: comment on exported method NsqdCoordinator.SearchLogByMsgOffset should be of the form "SearchLogByMsgOffset ..." (golint)
  • Line 1320: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1332: warning: exported method NsqdCoordinator.SearchLogByMsgCnt should have comment or be unexported (golint)
  • Line 1366: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1378: warning: exported type MsgTimestampComparator should have comment or be unexported (golint)
  • Line 1385: warning: exported method MsgTimestampComparator.SearchEndBoundary should have comment or be unexported (golint)
  • Line 1389: warning: exported method MsgTimestampComparator.LessThanLeftBoundary should have comment or be unexported (golint)
  • Line 1412: warning: exported method MsgTimestampComparator.GreatThanRightBoundary should have comment or be unexported (golint)
  • Line 1436: warning: comment on exported method NsqdCoordinator.SearchLogByMsgTimestamp should be of the form "SearchLogByMsgTimestamp ..." (golint)
  • Line 1437: warning: don't use underscores in Go names; method parameter ts_sec should be tsSec (golint)
  • Line 1484: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 2130: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 2211: warning: should omit 2nd value from range; this loop is equivalent to `for chName := range ...` (golint)
  • Line 2367: warning: exported method NsqdCoordinator.TryFixLocalTopic should have comment or be unexported (golint)
  • Line 2591: warning: comment on exported method NsqdCoordinator.GetMasterTopicCoordData should be of the form "GetMasterTopicCoordData ..." (golint)
  • Line 2614: warning: exported method NsqdCoordinator.GetTopicMetaInfo should have comment or be unexported (golint)
  • Line 2619: warning: exported method NsqdCoordinator.TryCleanUnusedTopicOnLocal should have comment or be unexported (golint)
  • Line 2699: warning: exported method NsqdCoordinator.SyncTopicChannels should have comment or be unexported (golint)
  • Line 3012: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
  • Line 3111: warning: exported method NsqdCoordinator.Stats should have comment or be unexported (golint)

• nsq/internal/test/fakes.go
  • Line 8: warning: exported type FakeNetConn should have comment or be unexported (golint)
  • Line 21: warning: exported method FakeNetConn.Close should have comment or be unexported (golint)
  • Line 22: warning: exported method FakeNetConn.LocalAddr should have comment or be unexported (golint)
  • Line 23: warning: exported method FakeNetConn.RemoteAddr should have comment or be unexported (golint)
  • Line 24: warning: exported method FakeNetConn.SetDeadline should have comment or be unexported (golint)
  • Line 25: warning: exported method FakeNetConn.SetReadDeadline should have comment or be unexported (golint)
  • Line 26: warning: exported method FakeNetConn.SetWriteDeadline should have comment or be unexported (golint)
  • Line 33: warning: exported function NewFakeNetConn should have comment or be unexported (golint)

• nsq/internal/protocol/tcp_server.go
  • Line 10: warning: exported type TCPHandler should have comment or be unexported (golint)
  • Line 14: warning: exported function TCPServer should have comment or be unexported (golint)

• nsq/nsqdserver/http.go
  • Line 35: warning: exported const HTTP_EXT_HEADER_PREFIX should have comment or be unexported (golint)
  • Line 447: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
  • Line 498: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 1093: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nsq/nsqdserver/http_test.go
  • Line 1279: warning: don't use underscores in Go names; var topic_another should be topicAnother (golint)

• nsq/nsqdserver/protocol_v2_test.go
  • Line 7767: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nsq/consistence/etcd_master_lock.go
  • Line 1: warning: package comment should be of the form "Package consistence ..." (golint)
  • Line 16: warning: exported type EVENT_TYPE should have comment or be unexported (golint)
  • Line 19: warning: exported const MASTER_ADD should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: exported const RETRY_SLEEP should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: exported type MasterEvent should have comment or be unexported (golint)
  • Line 35: warning: exported type Master should have comment or be unexported (golint)
  • Line 43: warning: exported type EtcdLock should have comment or be unexported (golint)
  • Line 61: warning: exported function NewMaster should have comment or be unexported (golint)
  • Line 78: warning: exported method EtcdLock.Start should have comment or be unexported (golint)
  • Line 78: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 98: warning: exported method EtcdLock.Stop should have comment or be unexported (golint)
  • Line 98: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 113: warning: exported method EtcdLock.GetEventsChan should have comment or be unexported (golint)
  • Line 113: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 117: warning: exported method EtcdLock.GetKey should have comment or be unexported (golint)
  • Line 117: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 121: warning: exported method EtcdLock.GetMaster should have comment or be unexported (golint)
  • Line 121: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 127: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 214: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 236: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 252: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• nsq/consistence/nsqd_node_etcd_test.go
  • Line 46: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• nsq/consistence/nsqlookup_coord_api.go
  • Line 15: warning: exported const MAX_PARTITION_NUM should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: exported method NsqLookupCoordinator.GetAllLookupdNodes should have comment or be unexported (golint)
  • Line 24: warning: exported method NsqLookupCoordinator.GetLookupLeader should have comment or be unexported (golint)
  • Line 30: warning: exported method NsqLookupCoordinator.GetTopicMetaInfo should have comment or be unexported (golint)
  • Line 47: warning: exported method NsqLookupCoordinator.GetTopicsMetaInfoMap should have comment or be unexported (golint)
  • Line 51: warning: exported method NsqLookupCoordinator.GetTopicLeaderNodes should have comment or be unexported (golint)
  • Line 78: warning: exported method NsqLookupCoordinator.GetTopicLeaderForConsume should have comment or be unexported (golint)
  • Line 86: warning: exported method NsqLookupCoordinator.IsMineLeader should have comment or be unexported (golint)
  • Line 90: warning: exported method NsqLookupCoordinator.IsClusterStable should have comment or be unexported (golint)
  • Line 95: warning: exported method NsqLookupCoordinator.SetTopNBalance should have comment or be unexported (golint)
  • Line 108: warning: exported method NsqLookupCoordinator.SetClusterUpgradeState should have comment or be unexported (golint)
  • Line 151: warning: exported method NsqLookupCoordinator.MoveTopicPartitionDataByManual should have comment or be unexported (golint)
  • Line 161: warning: exported method NsqLookupCoordinator.GetClusterNodeLoadFactor should have comment or be unexported (golint)
  • Line 178: warning: exported method NsqLookupCoordinator.GetClusterTopNTopics should have comment or be unexported (golint)
  • Line 197: warning: exported method NsqLookupCoordinator.IsTopicLeader should have comment or be unexported (golint)
  • Line 205: warning: exported method NsqLookupCoordinator.MarkNodeAsRemoving should have comment or be unexported (golint)
  • Line 227: warning: exported method NsqLookupCoordinator.DeleteTopicForce should have comment or be unexported (golint)
  • Line 276: warning: exported method NsqLookupCoordinator.DeleteTopic should have comment or be unexported (golint)
  • Line 409: warning: comment on exported method NsqLookupCoordinator.GetRegisteredChannel should be of the form "GetRegisteredChannel ..." (golint)
  • Line 430: warning: should omit 2nd value from range; this loop is equivalent to `for ch := range ...` (golint)
  • Line 438: warning: comment on exported method NsqLookupCoordinator.UpdateRegisteredChannel should be of the form "UpdateRegisteredChannel ..." (golint)
  • Line 467: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 510: warning: exported method NsqLookupCoordinator.ChangeTopicMetaParam should have comment or be unexported (golint)
  • Line 548: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 649: warning: exported method NsqLookupCoordinator.ExpandTopicPartition should have comment or be unexported (golint)
  • Line 684: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 705: warning: exported method NsqLookupCoordinator.CreateTopic should have comment or be unexported (golint)

• nsq/internal/protocol/errors.go
  • Line 3: warning: exported type ChildErr should have comment or be unexported (golint)
  • Line 32: warning: exported type FatalClientErr should have comment or be unexported (golint)
  • Line 48: warning: comment on exported function NewFatalClientErr should be of the form "NewFatalClientErr ..." (golint)

• nsq/consistence/data_placement_mgr.go
  • Line 59: warning: exported var ErrBalanceNodeUnavailable should have comment or be unexported (golint)
  • Line 70: warning: exported const RATIO_BETWEEN_LEADER_FOLLOWER should have comment (or a comment on this block) or be unexported (golint)
  • Line 124: warning: exported method IntHeap.Push should have comment or be unexported (golint)
  • Line 130: warning: exported method IntHeap.Pop should have comment or be unexported (golint)
  • Line 138: warning: exported type WrapChannelConsumerOffset should have comment or be unexported (golint)
  • Line 148: warning: exported type NodeTopicStats should have comment or be unexported (golint)
  • Line 181: warning: exported function NewNodeTopicStats should have comment or be unexported (golint)
  • Line 201: warning: exported method NodeTopicStats.GetNodeLoadFactor should have comment or be unexported (golint)
  • Line 214: warning: exported method NodeTopicStats.GetNodeLeaderLoadFactor should have comment or be unexported (golint)
  • Line 239: warning: exported method NodeTopicStats.GetNodePeakLevelList should have comment or be unexported (golint)
  • Line 257: warning: exported method NodeTopicStats.GetNodeAvgWriteLevel should have comment or be unexported (golint)
  • Line 282: warning: exported method NodeTopicStats.GetNodeAvgReadLevel should have comment or be unexported (golint)
  • Line 310: warning: exported method NodeTopicStats.GetTopicLoadFactor should have comment or be unexported (golint)
  • Line 318: warning: exported method NodeTopicStats.GetTopicLeaderLoadFactor should have comment or be unexported (golint)
  • Line 331: warning: exported method NodeTopicStats.GetTopicAvgWriteLevel should have comment or be unexported (golint)
  • Line 369: warning: exported type LFListT should have comment or be unexported (golint)
  • Line 384: warning: exported method NodeTopicStats.GetSortedTopicWriteLevel should have comment or be unexported (golint)
  • Line 408: warning: exported method NodeTopicStats.GetMostBusyAndIdleTopicWriteLevel should have comment or be unexported (golint)
  • Line 444: warning: exported method NodeTopicStats.GetTopicPeakLevel should have comment or be unexported (golint)
  • Line 459: warning: exported method NodeTopicStats.LeaderLessLoader should have comment or be unexported (golint)
  • Line 474: warning: exported method NodeTopicStats.SlaveLessLoader should have comment or be unexported (golint)
  • Line 488: warning: exported type By should have comment or be unexported (golint)
  • Line 490: warning: exported method By.Sort should have comment or be unexported (golint)
  • Line 498: warning: exported type StatsSorter should have comment or be unexported (golint)
  • Line 513: warning: exported type DataPlacement should have comment or be unexported (golint)
  • Line 518: warning: exported function NewDataPlacement should have comment or be unexported (golint)
  • Line 525: warning: exported method DataPlacement.SetBalanceInterval should have comment or be unexported (golint)
  • Line 615: warning: exported method DataPlacement.DoBalance should have comment or be unexported (golint)
  • Line 1404: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 2279: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 2285: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 2371: warning: exported type SortableStrings should have comment or be unexported (golint)

• nsq/nsqd/message.go
  • Line 18: warning: exported const MsgIDLength should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: comment on exported type FullMessageID should be of the form "FullMessageID ..." (with optional leading article) (golint)
  • Line 30: warning: exported type MessageID should have comment or be unexported (golint)
  • Line 32: warning: exported function GetMessageIDFromFullMsgID should have comment or be unexported (golint)
  • Line 36: warning: exported function GetTraceIDFromFullMsgID should have comment or be unexported (golint)
  • Line 40: warning: exported function PrintMessage should have comment or be unexported (golint)
  • Line 51: warning: exported function PrintMessageNoBody should have comment or be unexported (golint)
  • Line 62: warning: exported type Message should have comment or be unexported (golint)
  • Line 95: warning: exported function MessageHeaderBytes should have comment or be unexported (golint)
  • Line 99: warning: exported function NewMessageWithExt should have comment or be unexported (golint)
  • Line 110: warning: exported function NewMessage should have comment or be unexported (golint)
  • Line 119: warning: exported function NewMessageWithTs should have comment or be unexported (golint)
  • Line 128: warning: exported method Message.GetFullMsgID should have comment or be unexported (golint)
  • Line 135: warning: exported method Message.IsDeferred should have comment or be unexported (golint)
  • Line 139: warning: exported method Message.GetCopy should have comment or be unexported (golint)
  • Line 154: warning: exported method Message.GetClientID should have comment or be unexported (golint)
  • Line 161: warning: exported method Message.WriteToClient should have comment or be unexported (golint)
  • Line 166: warning: exported method Message.WriteTo should have comment or be unexported (golint)
  • Line 170: warning: exported method Message.Attempts should have comment or be unexported (golint)
  • Line 178: warning: exported method Message.IncrAttempts should have comment or be unexported (golint)
  • Line 184: warning: exported method Message.SetAttempts should have comment or be unexported (golint)
  • Line 263: warning: exported method Message.WriteDelayedTo should have comment or be unexported (golint)
  • Line 370: warning: exported function DecodeMessage should have comment or be unexported (golint)
  • Line 445: warning: exported function DecodeDelayedMessage should have comment or be unexported (golint)
  • Line 547: warning: exported function IsNotFoundJsonKey should have comment or be unexported (golint)
  • Line 551: warning: exported type IJsonExt should have comment or be unexported (golint)
  • Line 558: warning: exported function NewJsonExt should have comment or be unexported (golint)
  • Line 565: warning: exported type JsonExtObj should have comment or be unexported (golint)
  • Line 569: warning: exported method JsonExtObj.KeysCheck should have comment or be unexported (golint)
  • Line 585: warning: exported method JsonExtObj.GetString should have comment or be unexported (golint)
  • Line 602: warning: exported method JsonExtObj.GetBool should have comment or be unexported (golint)
  • Line 619: warning: exported method JsonExtObj.GetBoolOrStringBool should have comment or be unexported (golint)

• nsq/internal/app/float_array.go
  • Line 11: warning: exported type FloatArray should have comment or be unexported (golint)
  • Line 13: warning: exported method FloatArray.Set should have comment or be unexported (golint)

• nsq/nsqd/engine/kv.go
  • Line 17: warning: exported const RangeClose should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: exported const DIR_PERM should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: exported type RefSlice should have comment or be unexported (golint)
  • Line 42: warning: exported function SetLogLevel should have comment or be unexported (golint)
  • Line 46: warning: exported function SetLogger should have comment or be unexported (golint)
  • Line 51: warning: exported type CRange should have comment or be unexported (golint)
  • Line 56: warning: exported type SharedRockConfig should have comment or be unexported (golint)
  • Line 61: warning: exported type RockEngConfig should have comment or be unexported (golint)
  • Line 71: warning: exported function NewRockConfig should have comment or be unexported (golint)
  • Line 79: warning: exported type RockOptions should have comment or be unexported (golint)
  • Line 108: warning: exported function FillDefaultOptions should have comment or be unexported (golint)
  • Line 176: warning: exported type KVCheckpoint should have comment or be unexported (golint)
  • Line 180: warning: exported type ICompactFilter should have comment or be unexported (golint)
  • Line 185: warning: exported type KVEngine should have comment or be unexported (golint)
  • Line 225: warning: exported function GetDataDirFromBase should have comment or be unexported (golint)
  • Line 232: warning: exported function NewKVEng should have comment or be unexported (golint)
  • Line 239: warning: exported function NewSharedEngConfig should have comment or be unexported (golint)

• nsq/nsqlookupd/nsqlookupd_test.go
  • Line 652: warning: don't use underscores in Go names; var conn_p1 should be connP1 (golint)
  • Line 653: warning: don't use underscores in Go names; var conn_p2 should be connP2 (golint)
  • Line 654: warning: don't use underscores in Go names; var conn_p1_ip should be connP1IP (golint)
  • Line 655: warning: don't use underscores in Go names; var conn_p2_ip should be connP2IP (golint)
  • Line 692: warning: don't use underscores in Go names; var topic_p1 should be topicP1 (golint)
  • Line 694: warning: don't use underscores in Go names; var topic_p2 should be topicP2 (golint)
  • Line 746: warning: don't use underscores in Go names; var broadcastaddress_p1 should be broadcastaddressP1 (golint)
  • Line 760: warning: don't use underscores in Go names; var broadcastaddress_p2 should be broadcastaddressP2 (golint)
  • Line 844: warning: don't use underscores in Go names; var conn_p1 should be connP1 (golint)
  • Line 845: warning: don't use underscores in Go names; var conn_p2 should be connP2 (golint)
  • Line 846: warning: don't use underscores in Go names; var conn_p1_ip should be connP1IP (golint)
  • Line 847: warning: don't use underscores in Go names; var conn_p2_ip should be connP2IP (golint)
  • Line 884: warning: don't use underscores in Go names; var topic_p1 should be topicP1 (golint)
  • Line 886: warning: don't use underscores in Go names; var topic_p2 should be topicP2 (golint)

• nsq/nsqdserver/statsd.go
  • Line 16: warning: exported type Uint64Slice should have comment or be unexported (golint)

• nsq/internal/auth/authorizations.go
  • Line 14: warning: exported type Authorization should have comment or be unexported (golint)
  • Line 20: warning: exported type State should have comment or be unexported (golint)
  • Line 28: warning: exported method Authorization.HasPermission should have comment or be unexported (golint)
  • Line 37: warning: exported method Authorization.IsAllowed should have comment or be unexported (golint)
  • Line 63: warning: exported method State.IsAllowed should have comment or be unexported (golint)
  • Line 72: warning: exported method State.IsExpired should have comment or be unexported (golint)
  • Line 79: warning: exported function QueryAnyAuthd should have comment or be unexported (golint)
  • Line 91: warning: exported function QueryAuthd should have comment or be unexported (golint)

• nsq/nsqd/engine/pebble_eng.go
  • Line 46: warning: exported function GetRocksdbUint64 should have comment or be unexported (golint)
  • Line 58: warning: exported type Uint64AddMerger should have comment or be unexported (golint)
  • Line 62: warning: exported method Uint64AddMerger.MergeNewer should have comment or be unexported (golint)
  • Line 79: warning: exported method Uint64AddMerger.MergeOlder should have comment or be unexported (golint)
  • Line 83: warning: exported method Uint64AddMerger.Finish should have comment or be unexported (golint)
  • Line 130: warning: exported type PebbleEng should have comment or be unexported (golint)
  • Line 144: warning: exported function NewPebbleEng should have comment or be unexported (golint)
  • Line 220: warning: exported method PebbleEng.NewWriteBatch should have comment or be unexported (golint)
  • Line 227: warning: exported method PebbleEng.DefaultWriteBatch should have comment or be unexported (golint)
  • Line 234: warning: exported method PebbleEng.GetDataDir should have comment or be unexported (golint)
  • Line 238: warning: exported method PebbleEng.SetCompactionFilter should have comment or be unexported (golint)
  • Line 241: warning: exported method PebbleEng.SetMaxBackgroundOptions should have comment or be unexported (golint)
  • Line 263: warning: exported method PebbleEng.CheckDBEngForRead should have comment or be unexported (golint)
  • Line 276: warning: exported method PebbleEng.OpenEng should have comment or be unexported (golint)
  • Line 315: warning: exported method PebbleEng.DeletedBeforeCompact should have comment or be unexported (golint)
  • Line 319: warning: exported method PebbleEng.AddDeletedCnt should have comment or be unexported (golint)
  • Line 323: warning: exported method PebbleEng.LastCompactTime should have comment or be unexported (golint)
  • Line 327: warning: exported method PebbleEng.CompactRange should have comment or be unexported (golint)
  • Line 339: warning: exported method PebbleEng.CompactAllRange should have comment or be unexported (golint)
  • Line 343: warning: exported method PebbleEng.DisableManualCompact should have comment or be unexported (golint)
  • Line 346: warning: exported method PebbleEng.GetApproximateTotalKeyNum should have comment or be unexported (golint)
  • Line 350: warning: exported method PebbleEng.GetApproximateKeyNum should have comment or be unexported (golint)
  • Line 354: warning: exported method PebbleEng.SetOptsForLogStorage should have comment or be unexported (golint)
  • Line 358: warning: exported method PebbleEng.GetApproximateSizes should have comment or be unexported (golint)
  • Line 371: warning: exported method PebbleEng.IsClosed should have comment or be unexported (golint)
  • Line 378: warning: exported method PebbleEng.FlushAll should have comment or be unexported (golint)
  • Line 384: warning: exported method PebbleEng.CloseEng should have comment or be unexported (golint)
  • Line 403: warning: exported method PebbleEng.CloseAll should have comment or be unexported (golint)
  • Line 412: warning: exported method PebbleEng.GetStatistics should have comment or be unexported (golint)
  • Line 421: warning: exported method PebbleEng.GetInternalStatus should have comment or be unexported (golint)
  • Line 427: warning: exported method PebbleEng.GetInternalPropertyStatus should have comment or be unexported (golint)
  • Line 431: warning: exported method PebbleEng.GetBytesNoLock should have comment or be unexported (golint)
  • Line 446: warning: exported method PebbleEng.GetBytes should have comment or be unexported (golint)
  • Line 455: warning: exported method PebbleEng.MultiGetBytes should have comment or be unexported (golint)
  • Line 459: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
  • Line 469: warning: exported method PebbleEng.Exist should have comment or be unexported (golint)
  • Line 478: warning: exported method PebbleEng.ExistNoLock should have comment or be unexported (golint)
  • Line 491: warning: exported method PebbleEng.GetRefNoLock should have comment or be unexported (golint)
  • Line 499: warning: exported method PebbleEng.GetRef should have comment or be unexported (golint)
  • Line 508: warning: exported method PebbleEng.GetValueWithOp should have comment or be unexported (golint)
  • Line 518: warning: exported method PebbleEng.GetValueWithOpNoLock should have comment or be unexported (golint)
  • Line 531: warning: exported method PebbleEng.DeleteFilesInRange should have comment or be unexported (golint)
  • Line 535: warning: exported method PebbleEng.GetIterator should have comment or be unexported (golint)
  • Line 543: warning: exported method PebbleEng.NewCheckpoint should have comment or be unexported (golint)

• nsq/nsqd/metric.go
  • Line 9: warning: exported var ServerPubFailedCnt should have comment or be unexported (golint)
  • Line 13: warning: comment on exported var TopicPubFailedCnt should be of the form "TopicPubFailedCnt ..." (golint)
  • Line 45: warning: comment on exported var ChannelDepth should be of the form "ChannelDepth ..." (golint)

• nsq/internal/ext/ext.go
  • Line 9: warning: exported const E_EXT_NOT_SUPPORT should have comment (or a comment on this block) or be unexported (golint)
  • Line 19: warning: exported var MAX_TAG_LEN should have comment or be unexported (golint)
  • Line 22: warning: exported type ExtVer should have comment or be unexported (golint)
  • Line 24: warning: comment on exported var NO_EXT_VER should be of the form "NO_EXT_VER ..." (golint)
  • Line 28: warning: comment on exported var TAG_EXT_VER should be of the form "TAG_EXT_VER ..." (golint)
  • Line 31: warning: comment on exported var JSON_HEADER_EXT_VER should be of the form "JSON_HEADER_EXT_VER ..." (golint)
  • Line 36: warning: exported type NoExt should have comment or be unexported (golint)
  • Line 38: warning: exported function NewNoExt should have comment or be unexported (golint)
  • Line 42: warning: exported method NoExt.ExtVersion should have comment or be unexported (golint)
  • Line 46: warning: exported method NoExt.GetBytes should have comment or be unexported (golint)
  • Line 50: warning: exported type TagExt should have comment or be unexported (golint)
  • Line 52: warning: exported function NewTagExt should have comment or be unexported (golint)
  • Line 59: warning: exported method TagExt.GetTagName should have comment or be unexported (golint)
  • Line 63: warning: exported function ValidateTag should have comment or be unexported (golint)
  • Line 74: warning: exported type JsonHeaderExt should have comment or be unexported (golint)
  • Line 78: warning: exported function NewJsonHeaderExt should have comment or be unexported (golint)
  • Line 82: warning: exported method JsonHeaderExt.SetJsonHeaderBytes should have comment or be unexported (golint)
  • Line 82: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 86: warning: exported method JsonHeaderExt.ExtVersion should have comment or be unexported (golint)
  • Line 86: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 90: warning: exported method JsonHeaderExt.GetBytes should have comment or be unexported (golint)
  • Line 90: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 94: warning: exported type IExtContent should have comment or be unexported (golint)

• nsq/apps/nsq_to_http/nsq_to_http.go
  • Line 30: warning: exported const ModeAll should have comment (or a comment on this block) or be unexported (golint)
  • Line 66: warning: exported type Publisher should have comment or be unexported (golint)
  • Line 70: warning: exported type PublishHandler should have comment or be unexported (golint)
  • Line 83: warning: exported method PublishHandler.HandleMessage should have comment or be unexported (golint)
  • Line 123: warning: exported type PostPublisher should have comment or be unexported (golint)
  • Line 125: warning: exported method PostPublisher.Publish should have comment or be unexported (golint)
  • Line 140: warning: exported type GetPublisher should have comment or be unexported (golint)
  • Line 142: warning: exported method GetPublisher.Publish should have comment or be unexported (golint)

• nsq/nsqadmin/auth.go
  • Line 22: warning: exported type CasResponse should have comment or be unexported (golint)
  • Line 28: warning: exported type CasResponseValue should have comment or be unexported (golint)
  • Line 32: warning: exported type CasUserModel should have comment or be unexported (golint)
  • Line 62: warning: exported method CasUserModel.GetUserName should have comment or be unexported (golint)
  • Line 86: warning: exported function NewCasUserModel should have comment or be unexported (golint)
  • Line 106: warning: exported method CasUserModel.SetContext should have comment or be unexported (golint)
  • Line 111: warning: exported method CasUserModel.IsLogin should have comment or be unexported (golint)
  • Line 115: warning: exported method CasUserModel.GetUserRole should have comment or be unexported (golint)
  • Line 119: warning: exported method CasUserModel.IsAdmin should have comment or be unexported (golint)
  • Line 125: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 141: warning: exported method CasUserModel.DoAuth should have comment or be unexported (golint)
  • Line 186: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
  • Line 194: warning: exported function GetUserModel should have comment or be unexported (golint)
  • Line 203: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 214: warning: exported function LogoutUser should have comment or be unexported (golint)
  • Line 229: warning: exported type IUserAuth should have comment or be unexported (golint)

• nsq/internal/quantile/aggregate.go
  • Line 9: warning: exported type E2eProcessingLatencyAggregate should have comment or be unexported (golint)
  • Line 17: warning: exported method E2eProcessingLatencyAggregate.UnmarshalJSON should have comment or be unexported (golint)

• nsq/internal/flume_log/detail_info.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 3: warning: exported type DetailInfo should have comment or be unexported (golint)
  • Line 8: warning: exported type ExtraInfo should have comment or be unexported (golint)
  • Line 10: warning: exported function NewDetailInfo should have comment or be unexported (golint)
  • Line 18: warning: exported method DetailInfo.SetExtraInfo should have comment or be unexported (golint)
  • Line 22: warning: exported method DetailInfo.AddKeyValue should have comment or be unexported (golint)

• nsq/nsqlookupd_migrate/logger.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 11: warning: exported const LOG_ERR should have comment (or a comment on this block) or be unexported (golint)
  • Line 17: warning: exported type MigrateLogger should have comment or be unexported (golint)
  • Line 21: warning: exported method MigrateLogger.SetLevel should have comment or be unexported (golint)
  • Line 26: warning: exported method MigrateLogger.Level should have comment or be unexported (golint)
  • Line 30: warning: exported method MigrateLogger.AccessTrace should have comment or be unexported (golint)
  • Line 37: warning: exported method MigrateLogger.Debug should have comment or be unexported (golint)
  • Line 43: warning: exported method MigrateLogger.Info should have comment or be unexported (golint)
  • Line 49: warning: exported method MigrateLogger.Warn should have comment or be unexported (golint)
  • Line 57: warning: exported function NewMigrateLogger should have comment or be unexported (golint)

• nsq/consistence/topic_coordinator.go
  • Line 13: warning: exported function GetTopicFullName should have comment or be unexported (golint)
  • Line 17: warning: exported type ChannelConsumerOffset should have comment or be unexported (golint)
  • Line 26: warning: exported method ChannelConsumerOffset.IsSame should have comment or be unexported (golint)
  • Line 49: warning: exported type ChannelConsumeMgr should have comment or be unexported (golint)
  • Line 74: warning: exported method ChannelConsumeMgr.Clear should have comment or be unexported (golint)
  • Line 82: warning: exported method ChannelConsumeMgr.Get should have comment or be unexported (golint)
  • Line 89: warning: exported method ChannelConsumeMgr.Update should have comment or be unexported (golint)
  • Line 95: warning: exported method ChannelConsumeMgr.GetSyncedDelayedQueueTs should have comment or be unexported (golint)
  • Line 101: warning: exported method ChannelConsumeMgr.UpdateSyncedDelayedQueueTs should have comment or be unexported (golint)
  • Line 107: warning: exported method ChannelConsumeMgr.GetSyncedChs should have comment or be unexported (golint)
  • Line 114: warning: exported method ChannelConsumeMgr.UpdateSyncedChs should have comment or be unexported (golint)
  • Line 160: warning: exported type TopicCoordinator should have comment or be unexported (golint)
  • Line 173: warning: exported function NewTopicCoordinatorWithFixMode should have comment or be unexported (golint)
  • Line 178: warning: exported function NewTopicCoordinator should have comment or be unexported (golint)
  • Line 227: warning: exported method TopicCoordinator.GetDelayedQueueLogMgr should have comment or be unexported (golint)
  • Line 235: warning: exported method TopicCoordinator.DeleteNoWriteLock should have comment or be unexported (golint)
  • Line 253: warning: exported method TopicCoordinator.DeleteWithLock should have comment or be unexported (golint)
  • Line 273: warning: exported method TopicCoordinator.GetData should have comment or be unexported (golint)
  • Line 280: warning: exported method TopicCoordinator.IsWriteDisabled should have comment or be unexported (golint)
  • Line 284: warning: exported method TopicCoordinator.DisableWrite should have comment or be unexported (golint)
  • Line 295: warning: exported method TopicCoordinator.IsExiting should have comment or be unexported (golint)
  • Line 299: warning: exported method TopicCoordinator.Exiting should have comment or be unexported (golint)
  • Line 317: warning: exported method TopicCoordinator.SetForceLeave should have comment or be unexported (golint)
  • Line 325: warning: exported method TopicCoordinator.IsForceLeave should have comment or be unexported (golint)

• nsq/consistence/common.go
  • Line 11: warning: exported const ErrFailedOnNotLeader should have comment (or a comment on this block) or be unexported (golint)
  • Line 19: warning: exported type CoordErrType should have comment or be unexported (golint)
  • Line 22: warning: exported const CoordNoErr should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: comment on exported type CoordErr should be of the form "CoordErr ..." (with optional leading article) (golint)
  • Line 43: warning: exported type CommonCoordErr should have comment or be unexported (golint)
  • Line 47: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 51: warning: exported function NewCoordErr should have comment or be unexported (golint)
  • Line 59: warning: exported function NewCoordErrWithCode should have comment or be unexported (golint)
  • Line 67: warning: exported method CoordErr.ToErrorType should have comment or be unexported (golint)
  • Line 67: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 75: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 89: warning: exported method CoordErr.HasError should have comment or be unexported (golint)
  • Line 89: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 96: warning: exported method CoordErr.IsEqual should have comment or be unexported (golint)
  • Line 96: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 119: warning: exported method CoordErr.IsNetErr should have comment or be unexported (golint)
  • Line 119: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 123: warning: exported method CoordErr.IsLocalErr should have comment or be unexported (golint)
  • Line 123: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 127: warning: exported method CoordErr.CanRetryWrite should have comment or be unexported (golint)
  • Line 127: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 150: warning: exported var ErrTopicInfoNotFound should have comment or be unexported (golint)
  • Line 205: warning: exported function GenNsqdNodeID should have comment or be unexported (golint)
  • Line 217: warning: exported function GenNsqLookupNodeID should have comment or be unexported (golint)
  • Line 229: warning: exported function ExtractRpcAddrFromID should have comment or be unexported (golint)
  • Line 235: warning: exported function FindSlice should have comment or be unexported (golint)
  • Line 244: warning: exported function FindSliceList should have comment or be unexported (golint)
  • Line 253: warning: exported function MergeList should have comment or be unexported (golint)
  • Line 262: warning: exported function FilterList should have comment or be unexported (golint)

• nsq/consistence/etcd_client.go
  • Line 13: warning: exported type EtcdClient should have comment or be unexported (golint)
  • Line 30: warning: exported function NewEClient should have comment or be unexported (golint)
  • Line 54: warning: exported method EtcdClient.GetNewest should have comment or be unexported (golint)
  • Line 54: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 65: warning: exported method EtcdClient.Get should have comment or be unexported (golint)
  • Line 65: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 75: warning: exported method EtcdClient.Create should have comment or be unexported (golint)
  • Line 75: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 85: warning: exported method EtcdClient.Delete should have comment or be unexported (golint)
  • Line 85: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 94: warning: exported method EtcdClient.CreateDir should have comment or be unexported (golint)
  • Line 94: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 104: warning: exported method EtcdClient.CreateInOrder should have comment or be unexported (golint)
  • Line 104: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 113: warning: exported method EtcdClient.Set should have comment or be unexported (golint)
  • Line 113: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 122: warning: exported method EtcdClient.SetWithTTL should have comment or be unexported (golint)
  • Line 122: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 133: warning: exported method EtcdClient.Update should have comment or be unexported (golint)
  • Line 133: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 144: warning: exported method EtcdClient.CompareAndSwap should have comment or be unexported (golint)
  • Line 144: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 155: warning: exported method EtcdClient.CompareAndDelete should have comment or be unexported (golint)
  • Line 155: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 165: warning: exported method EtcdClient.Watch should have comment or be unexported (golint)
  • Line 165: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• nsq/consistence/nsqd_node_etcd.go
  • Line 15: warning: exported const ETCD_TTL should have comment (or a comment on this block) or be unexported (golint)
  • Line 18: warning: exported type MasterChanInfo should have comment or be unexported (golint)
  • Line 23: warning: exported type NsqdEtcdMgr should have comment or be unexported (golint)
  • Line 36: warning: exported function NewNsqdEtcdMgr should have comment or be unexported (golint)
  • Line 46: warning: exported method NsqdEtcdMgr.InitClusterID should have comment or be unexported (golint)
  • Line 52: warning: exported method NsqdEtcdMgr.RegisterNsqd should have comment or be unexported (golint)
  • Line 95: warning: exported method NsqdEtcdMgr.UnregisterNsqd should have comment or be unexported (golint)
  • Line 116: warning: exported method NsqdEtcdMgr.AcquireTopicLeader should have comment or be unexported (golint)
  • Line 140: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 153: warning: exported method NsqdEtcdMgr.ReleaseTopicLeader should have comment or be unexported (golint)
  • Line 192: warning: exported method NsqdEtcdMgr.GetAllLookupdNodes should have comment or be unexported (golint)
  • Line 211: warning: exported method NsqdEtcdMgr.WatchLookupdLeader should have comment or be unexported (golint)
  • Line 284: warning: exported method NsqdEtcdMgr.GetTopicMetaInfo should have comment or be unexported (golint)
  • Line 301: warning: exported method NsqdEtcdMgr.GetTopicInfo should have comment or be unexported (golint)
  • Line 333: warning: exported method NsqdEtcdMgr.GetTopicLeaderSession should have comment or be unexported (golint)
  • Line 348: warning: exported method NsqdEtcdMgr.IsTopicRealDeleted should have comment or be unexported (golint)

• nsq/nsqd/nsqd.go
  • Line 32: warning: exported const TLSNotRequired should have comment (or a comment on this block) or be unexported (golint)
  • Line 46: warning: exported var ErrTopicPartitionMismatch should have comment or be unexported (golint)
  • Line 50: warning: exported var DEFAULT_RETENTION_DAYS should have comment or be unexported (golint)
  • Line 52: warning: exported var EnableDelayedQueue should have comment or be unexported (golint)
  • Line 55: warning: exported const FLUSH_DISTANCE should have comment (or a comment on this block) or be unexported (golint)
  • Line 58: warning: exported type INsqdNotify should have comment or be unexported (golint)
  • Line 66: warning: exported type ReqToEndFunc should have comment or be unexported (golint)
  • Line 68: warning: exported type NSQD should have comment or be unexported (golint)
  • Line 103: warning: exported function New should have comment or be unexported (golint)
  • Line 240: warning: exported method NSQD.SetReqToEndCB should have comment or be unexported (golint)
  • Line 246: warning: exported method NSQD.SetPubLoop should have comment or be unexported (golint)
  • Line 252: warning: exported method NSQD.GetOpts should have comment or be unexported (golint)
  • Line 259: warning: exported method NSQD.SwapOpts should have comment or be unexported (golint)
  • Line 264: warning: exported method NSQD.TriggerOptsNotification should have comment or be unexported (golint)
  • Line 271: warning: exported method NSQD.SetHealth should have comment or be unexported (golint)
  • Line 275: warning: exported method NSQD.IsHealthy should have comment or be unexported (golint)
  • Line 279: warning: exported method NSQD.GetError should have comment or be unexported (golint)
  • Line 284: warning: exported method NSQD.GetHealth should have comment or be unexported (golint)
  • Line 292: warning: exported method NSQD.GetStartTime should have comment or be unexported (golint)
  • Line 296: warning: comment on exported method NSQD.GetTopicMapRef should be of the form "GetTopicMapRef ..." (golint)
  • Line 301: warning: exported method NSQD.GetTopicPartitions should have comment or be unexported (golint)
  • Line 314: warning: exported method NSQD.GetTopicMapCopy should have comment or be unexported (golint)
  • Line 326: warning: exported method NSQD.Start should have comment or be unexported (golint)
  • Line 332: warning: exported method NSQD.LoadMetadata should have comment or be unexported (golint)
  • Line 453: warning: exported method NSQD.NotifyPersistMetadata should have comment or be unexported (golint)
  • Line 515: warning: exported method NSQD.Exit should have comment or be unexported (golint)
  • Line 548: warning: exported method NSQD.GetTopicDefaultPart should have comment or be unexported (golint)
  • Line 563: warning: exported method NSQD.GetTopicIgnPart should have comment or be unexported (golint)
  • Line 578: warning: exported method NSQD.GetTopicWithDisabled should have comment or be unexported (golint)
  • Line 588: warning: exported method NSQD.GetTopicWithExt should have comment or be unexported (golint)
  • Line 681: warning: comment on exported method NSQD.CloseExistingTopic should be of the form "CloseExistingTopic ..." (golint)
  • Line 699: warning: exported method NSQD.ForceDeleteTopicData should have comment or be unexported (golint)
  • Line 721: warning: exported method NSQD.CheckMagicCode should have comment or be unexported (golint)
  • Line 743: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 754: warning: exported method NSQD.SetTopicMagicCode should have comment or be unexported (golint)
  • Line 781: warning: exported method NSQD.CleanClientPubStats should have comment or be unexported (golint)
  • Line 808: warning: exported method NSQD.ReqToEnd should have comment or be unexported (golint)
  • Line 817: warning: exported method NSQD.NotifyDeleteTopic should have comment or be unexported (golint)
  • Line 821: warning: exported method NSQD.NotifyScanChannel should have comment or be unexported (golint)
  • Line 837: warning: exported method NSQD.NotifyStateChanged should have comment or be unexported (golint)
  • Line 1072: warning: exported method NSQD.PushTopicJob should have comment or be unexported (golint)
  • Line 1144: warning: exported method NSQD.IsAuthEnabled should have comment or be unexported (golint)

• nsq/apps/nsq_pubsub/nsq_pubsub.go
  • Line 39: warning: exported type StreamServer should have comment or be unexported (golint)
  • Line 47: warning: exported method StreamServer.Set should have comment or be unexported (golint)
  • Line 53: warning: exported method StreamServer.Del should have comment or be unexported (golint)
  • Line 67: warning: exported type StreamReader should have comment or be unexported (golint)
  • Line 78: warning: exported function ConnectToNSQAndLookupd should have comment or be unexported (golint)
  • Line 97: warning: exported function StatsHandler should have comment or be unexported (golint)
  • Line 193: warning: exported method StreamReader.HeartbeatLoop should have comment or be unexported (golint)
  • Line 213: warning: exported method StreamReader.HandleMessage should have comment or be unexported (golint)

• nsq/nsqlookupd_migrate/nsqlookup_migrate.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 19: warning: exported type Decorator should have comment or be unexported (golint)
  • Line 21: warning: exported type APIHandler should have comment or be unexported (golint)
  • Line 23: warning: exported type Err should have comment or be unexported (golint)
  • Line 28: warning: exported type ProxyResponse should have comment or be unexported (golint)
  • Line 37: warning: exported type QueryHost should have comment or be unexported (golint)
  • Line 64: warning: don't use underscores in Go names; var listlookup_not_found_msg should be listlookupNotFoundMsg (golint)
  • Line 66: warning: exported function SetupLogger should have comment or be unexported (golint)
  • Line 70: warning: exported function NewHTTPServer should have comment or be unexported (golint)
  • Line 130: warning: don't use underscores in Go names; var ch_target should be chTarget (golint)
  • Line 131: warning: don't use underscores in Go names; var ch_ori should be chOri (golint)
  • Line 133: warning: don't use underscores in Go names; var lookupinfo_target should be lookupinfoTarget (golint)
  • Line 140: warning: don't use underscores in Go names; var lookupinfo_ori should be lookupinfoOri (golint)
  • Line 151: warning: don't use underscores in Go names; var lookup_tar should be lookupTar (golint)
  • Line 152: warning: don't use underscores in Go names; var lookup_ori should be lookupOri (golint)
  • Line 176: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 247: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 248: warning: don't use underscores in Go names; var lookupinfo_old should be lookupinfoOld (golint)
  • Line 309: warning: don't use underscores in Go names; var marshall_err should be marshallErr (golint)
  • Line 348: warning: don't use underscores in Go names; var topics_old should be topicsOld (golint)
  • Line 460: warning: don't use underscores in Go names; var nsqlookupd_err should be nsqlookupdErr (golint)
  • Line 475: warning: don't use underscores in Go names; var marshall_err should be marshallErr (golint)
  • Line 486: warning: exported function LogPanicHandler should have comment or be unexported (golint)
  • Line 492: warning: exported function LogNotFoundHandler should have comment or be unexported (golint)
  • Line 497: warning: exported function LogMethodNotAllowedHandler should have comment or be unexported (golint)
  • Line 502: warning: exported function Decorate should have comment or be unexported (golint)
  • Line 512: warning: exported function TagMigrate should have comment or be unexported (golint)
  • Line 542: warning: exported function Response should have comment or be unexported (golint)

• nsq/nsqadmin/trace_query.go
  • Line 9: warning: exported type QueryPairs should have comment or be unexported (golint)
  • Line 14: warning: exported type IndexFieldsQuery should have comment or be unexported (golint)
  • Line 16: warning: exported type TraceLogQueryInfo should have comment or be unexported (golint)
  • Line 32: warning: exported function NewLogQueryInfo should have comment or be unexported (golint)
  • Line 50: warning: exported type TraceLogItemInfo should have comment or be unexported (golint)
  • Line 59: warning: exported method TraceLogItemInfo.ToJsJson should have comment or be unexported (golint)
  • Line 70: warning: exported type TraceLogItemInfoForJs should have comment or be unexported (golint)
  • Line 80: warning: exported type TraceLogData should have comment or be unexported (golint)
  • Line 94: warning: exported type TraceLogDataForJs should have comment or be unexported (golint)
  • Line 99: warning: exported type TraceLog should have comment or be unexported (golint)
  • Line 104: warning: exported type TLListT should have comment or be unexported (golint)
  • Line 116: warning: exported type TraceLogResp should have comment or be unexported (golint)

• nsq/nsqlookupd/options.go
  • Line 11: warning: exported type Options should have comment or be unexported (golint)
  • Line 39: warning: exported function NewOptions should have comment or be unexported (golint)

gocyclo74%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• nsq/nsqd/disk_queue_snapshot.go
  • Line 239: warning: cyclomatic complexity 20 of function (*DiskQueueSnapshot).ReadRaw() is high (> 15) (gocyclo)
  • Line 316: warning: cyclomatic complexity 16 of function (*DiskQueueSnapshot).ReadOne() is high (> 15) (gocyclo)

• nsq/consistence/nsqlookup_coordinator_test.go
  • Line 2374: warning: cyclomatic complexity 75 of function TestNsqLookupMovePartitionAndSlaveTimeoutWhileReadWrite() is high (> 15) (gocyclo)
  • Line 3010: warning: cyclomatic complexity 34 of function TestNsqLookupTopNTopicBalance() is high (> 15) (gocyclo)
  • Line 711: warning: cyclomatic complexity 31 of function testNsqLookupNsqdNodesChange() is high (> 15) (gocyclo)
  • Line 1754: warning: cyclomatic complexity 30 of function TestNsqLookupMovePartition() is high (> 15) (gocyclo)
  • Line 2205: warning: cyclomatic complexity 25 of function TestNsqLookupSlaveTimeoutReadUncommitted() is high (> 15) (gocyclo)
  • Line 2029: warning: cyclomatic complexity 23 of function TestNsqLookupMovePartitionRetryWhileLocalRemoved() is high (> 15) (gocyclo)
  • Line 2803: warning: cyclomatic complexity 20 of function checkOrderedMultiTopic() is high (> 15) (gocyclo)
  • Line 1539: warning: cyclomatic complexity 16 of function TestNsqLookupMarkNodeRemove() is high (> 15) (gocyclo)

• nsq/nsqd/engine/kv.go
  • Line 108: warning: cyclomatic complexity 20 of function FillDefaultOptions() is high (> 15) (gocyclo)

• nsq/nsqdserver/context.go
  • Line 364: warning: cyclomatic complexity 35 of function (*context).internalPubLoop() is high (> 15) (gocyclo)
  • Line 296: warning: cyclomatic complexity 16 of function (*context).SetChannelOffset() is high (> 15) (gocyclo)

• nsq/nsqd/channel.go
  • Line 1931: warning: cyclomatic complexity 88 of function (*Channel).messagePump() is high (> 15) (gocyclo)
  • Line 1188: warning: cyclomatic complexity 48 of function (*Channel).checkMsgRequeueToEnd() is high (> 15) (gocyclo)
  • Line 2396: warning: cyclomatic complexity 37 of function (*Channel).doPeekInFlightQueue() is high (> 15) (gocyclo)
  • Line 1054: warning: cyclomatic complexity 24 of function (*Channel).internalFinishMessage() is high (> 15) (gocyclo)
  • Line 2613: warning: cyclomatic complexity 22 of function (*Channel).peekAndReqDelayedMessages() is high (> 15) (gocyclo)
  • Line 2542: warning: cyclomatic complexity 21 of function (*Channel).processInFlightQueue() is high (> 15) (gocyclo)
  • Line 1344: warning: cyclomatic complexity 20 of function (*Channel).RequeueMessage() is high (> 15) (gocyclo)
  • Line 921: warning: cyclomatic complexity 17 of function (*Channel).ConfirmBackendQueue() is high (> 15) (gocyclo)
  • Line 1691: warning: cyclomatic complexity 17 of function (*Channel).DisableConsume() is high (> 15) (gocyclo)

• nsq/nsqd/channel_test.go
  • Line 1058: warning: cyclomatic complexity 35 of function TestChannelResetConfirmedWhileDelayedQueueMsgInflight() is high (> 15) (gocyclo)
  • Line 880: warning: cyclomatic complexity 23 of function TestChannelResetConfirmedWhileDelayedQueuePop() is high (> 15) (gocyclo)
  • Line 539: warning: cyclomatic complexity 23 of function TestChannelEmptyWhileConfirmDelayMsg() is high (> 15) (gocyclo)

• nsq/nsqd/topic.go
  • Line 1500: warning: cyclomatic complexity 26 of function (*Topic).TryCleanOldData() is high (> 15) (gocyclo)
  • Line 1814: warning: cyclomatic complexity 24 of function (*Topic).tryFixKVTopic() is high (> 15) (gocyclo)
  • Line 1727: warning: cyclomatic complexity 16 of function (*Topic).tryFixCorruptData() is high (> 15) (gocyclo)

• nsq/nsqdserver/protocol_v2.go
  • Line 474: warning: cyclomatic complexity 62 of function (*protocolV2).messagePump() is high (> 15) (gocyclo)
  • Line 1585: warning: cyclomatic complexity 38 of function (*protocolV2).internalPubExtAndTrace() is high (> 15) (gocyclo)
  • Line 147: warning: cyclomatic complexity 37 of function (*protocolV2).IOLoop() is high (> 15) (gocyclo)
  • Line 1002: warning: cyclomatic complexity 31 of function (*protocolV2).internalSUB() is high (> 15) (gocyclo)
  • Line 739: warning: cyclomatic complexity 27 of function (*protocolV2).IDENTIFY() is high (> 15) (gocyclo)
  • Line 1848: warning: cyclomatic complexity 27 of function readMPUBEXT() is high (> 15) (gocyclo)
  • Line 1240: warning: cyclomatic complexity 20 of function (*protocolV2).REQ() is high (> 15) (gocyclo)
  • Line 419: warning: cyclomatic complexity 20 of function (*protocolV2).Exec() is high (> 15) (gocyclo)
  • Line 1734: warning: cyclomatic complexity 17 of function (*protocolV2).internalMPUBEXTAndTrace() is high (> 15) (gocyclo)

• nsq/nsqdserver/protocol_v2_test.go
  • Line 2195: warning: cyclomatic complexity 40 of function consumeTagConcurrent() is high (> 15) (gocyclo)
  • Line 4835: warning: cyclomatic complexity 35 of function testDelayManyMessagesToQueueEnd() is high (> 15) (gocyclo)
  • Line 7133: warning: cyclomatic complexity 29 of function TestResetChannelToOld() is high (> 15) (gocyclo)
  • Line 1434: warning: cyclomatic complexity 27 of function TestConsumeDelayedMessageWhileUpgrade() is high (> 15) (gocyclo)
  • Line 3587: warning: cyclomatic complexity 24 of function testConsumeWithFilter() is high (> 15) (gocyclo)
  • Line 3904: warning: cyclomatic complexity 19 of function testConsumeWithFilterComplex() is high (> 15) (gocyclo)
  • Line 5128: warning: cyclomatic complexity 18 of function TestSubTimeoutMany() is high (> 15) (gocyclo)
  • Line 5367: warning: cyclomatic complexity 18 of function TestSubReqToEndFailedPartial() is high (> 15) (gocyclo)
  • Line 5250: warning: cyclomatic complexity 16 of function TestSubFewMsgTimeoutAlwaysShouldNotBlocking() is high (> 15) (gocyclo)

• nsq/nsqd/nsqd.go
  • Line 103: warning: cyclomatic complexity 28 of function New() is high (> 15) (gocyclo)
  • Line 928: warning: cyclomatic complexity 28 of function (*NSQD).queueScanLoop() is high (> 15) (gocyclo)
  • Line 332: warning: cyclomatic complexity 20 of function (*NSQD).LoadMetadata() is high (> 15) (gocyclo)

• nsq/consistence/data_placement_mgr.go
  • Line 1888: warning: cyclomatic complexity 68 of function (*DataPlacement).rebalanceTopNTopicsByLoad() is high (> 15) (gocyclo)
  • Line 615: warning: cyclomatic complexity 51 of function (*DataPlacement).DoBalance() is high (> 15) (gocyclo)
  • Line 1036: warning: cyclomatic complexity 27 of function (*DataPlacement).tryMoveTopicPartition() is high (> 15) (gocyclo)
  • Line 1448: warning: cyclomatic complexity 26 of function (*DataPlacement).allocTopicLeaderAndISR() is high (> 15) (gocyclo)
  • Line 939: warning: cyclomatic complexity 23 of function (*DataPlacement).checkAndPrepareMove() is high (> 15) (gocyclo)
  • Line 858: warning: cyclomatic complexity 19 of function (*DataPlacement).balanceTopicLeaderBetweenNodes() is high (> 15) (gocyclo)
  • Line 2301: warning: cyclomatic complexity 17 of function (*DataPlacement).rebalanceMultiPartTopic() is high (> 15) (gocyclo)
  • Line 1134: warning: cyclomatic complexity 16 of function (*DataPlacement).addToCatchupAndWaitISRReady() is high (> 15) (gocyclo)

• nsq/consistence/coordinator_rpc.go
  • Line 1006: warning: cyclomatic complexity 18 of function handleCommitLogError() is high (> 15) (gocyclo)
  • Line 566: warning: cyclomatic complexity 17 of function (*NsqdCoordRpcServer).GetTopicStats() is high (> 15) (gocyclo)

• nsq/apps/nsq_to_nsq/nsq_to_nsq.go
  • Line 265: warning: cyclomatic complexity 24 of function main() is high (> 15) (gocyclo)

• nsq/nsqdserver/statsd.go
  • Line 44: warning: cyclomatic complexity 42 of function (*NsqdServer).statsdLoop() is high (> 15) (gocyclo)

• nsq/nsqd/diskqueue_reader.go
  • Line 665: warning: cyclomatic complexity 30 of function (*diskQueueReader).internalSkipTo() is high (> 15) (gocyclo)
  • Line 870: warning: cyclomatic complexity 30 of function (*diskQueueReader).readOne() is high (> 15) (gocyclo)
  • Line 534: warning: cyclomatic complexity 17 of function stepOffset() is high (> 15) (gocyclo)
  • Line 1149: warning: cyclomatic complexity 17 of function (*diskQueueReader).internalUpdateEnd() is high (> 15) (gocyclo)

• nsq/nsqd/message.go
  • Line 445: warning: cyclomatic complexity 19 of function DecodeDelayedMessage() is high (> 15) (gocyclo)
  • Line 263: warning: cyclomatic complexity 18 of function (*Message).WriteDelayedTo() is high (> 15) (gocyclo)

• nsq/consistence/nsqlookup_coord_rpc_helper.go
  • Line 10: warning: cyclomatic complexity 26 of function (*NsqLookupCoordinator).rpcFailRetryFunc() is high (> 15) (gocyclo)

• nsq/nsqd/engine/iterator.go
  • Line 198: warning: cyclomatic complexity 17 of function rangeLimitIterator() is high (> 15) (gocyclo)

• nsq/apps/nsq_to_http/nsq_to_http.go
  • Line 167: warning: cyclomatic complexity 33 of function main() is high (> 15) (gocyclo)

• nsq/bench/multi_bench/multi_bench.go
  • Line 531: warning: cyclomatic complexity 47 of function startCheckData() is high (> 15) (gocyclo)
  • Line 383: warning: cyclomatic complexity 24 of function startCheckData2() is high (> 15) (gocyclo)
  • Line 1287: warning: cyclomatic complexity 24 of function (*consumeHandler).HandleMessage() is high (> 15) (gocyclo)
  • Line 1167: warning: cyclomatic complexity 22 of function pubWorker() is high (> 15) (gocyclo)
  • Line 980: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo)
  • Line 1094: warning: cyclomatic complexity 17 of function pubPipelineWorker() is high (> 15) (gocyclo)

• nsq/apps/nsq_stat/nsq_stat.go
  • Line 131: warning: cyclomatic complexity 16 of function main() is high (> 15) (gocyclo)

• nsq/bench/bench_writer/bench_writer.go
  • Line 123: warning: cyclomatic complexity 16 of function pubWorker() is high (> 15) (gocyclo)

• nsq/nsqlookupd_migrate/nsqlookup_migrate.go
  • Line 397: warning: cyclomatic complexity 16 of function (*httpServer).lookupMigrateHandler() is high (> 15) (gocyclo)

• nsq/consistence/nsqd_node_etcd.go
  • Line 211: warning: cyclomatic complexity 21 of function (*NsqdEtcdMgr).WatchLookupdLeader() is high (> 15) (gocyclo)

• nsq/apps/nsq_data_tool/tool.go
  • Line 186: warning: cyclomatic complexity 44 of function main() is high (> 15) (gocyclo)

• nsq/nsqdserver/http_test.go
  • Line 147: warning: cyclomatic complexity 18 of function TestHTTPPubExt() is high (> 15) (gocyclo)

• nsq/nsqd/diskqueue_writer.go
  • Line 306: warning: cyclomatic complexity 28 of function (*diskQueueWriter).prepareCleanByRetention() is high (> 15) (gocyclo)
  • Line 762: warning: cyclomatic complexity 18 of function (*diskQueueWriter).writeOne() is high (> 15) (gocyclo)
  • Line 101: warning: cyclomatic complexity 17 of function newDiskQueueWriter() is high (> 15) (gocyclo)

• nsq/consistence/nsqlookup_coordinator.go
  • Line 679: warning: cyclomatic complexity 68 of function (*NsqLookupCoordinator).doCheckTopics() is high (> 15) (gocyclo)
  • Line 517: warning: cyclomatic complexity 22 of function (*NsqLookupCoordinator).processRemovingNodes() is high (> 15) (gocyclo)
  • Line 1696: warning: cyclomatic complexity 21 of function (*NsqLookupCoordinator).handleReadyForISR() is high (> 15) (gocyclo)
  • Line 1790: warning: cyclomatic complexity 18 of function (*NsqLookupCoordinator).resetJoinISRState() is high (> 15) (gocyclo)
  • Line 414: warning: cyclomatic complexity 16 of function (*NsqLookupCoordinator).handleNsqdNodes() is high (> 15) (gocyclo)

• nsq/consistence/nsqd_coordinator.go
  • Line 1549: warning: cyclomatic complexity 53 of function (*NsqdCoordinator).decideCatchupCommitLogInfo() is high (> 15) (gocyclo)
  • Line 714: warning: cyclomatic complexity 47 of function (*NsqdCoordinator).loadLocalTopicData() is high (> 15) (gocyclo)
  • Line 1974: warning: cyclomatic complexity 28 of function (*NsqdCoordinator).catchupFromLeader() is high (> 15) (gocyclo)
  • Line 2392: warning: cyclomatic complexity 26 of function (*NsqdCoordinator).switchStateForMaster() is high (> 15) (gocyclo)
  • Line 2769: warning: cyclomatic complexity 26 of function (*NsqdCoordinator).trySyncTopicChannels() is high (> 15) (gocyclo)
  • Line 1795: warning: cyclomatic complexity 26 of function (*NsqdCoordinator).pullCatchupDataFromLeader() is high (> 15) (gocyclo)
  • Line 1132: warning: cyclomatic complexity 23 of function (*NsqdCoordinator).checkForUnsyncedTopics() is high (> 15) (gocyclo)
  • Line 912: warning: cyclomatic complexity 23 of function checkAndFixLocalLogQueueEnd() is high (> 15) (gocyclo)
  • Line 2125: warning: cyclomatic complexity 23 of function (*NsqdCoordinator).syncChannelsFromOther() is high (> 15) (gocyclo)
  • Line 2272: warning: cyclomatic complexity 21 of function (*NsqdCoordinator).updateTopicInfo() is high (> 15) (gocyclo)
  • Line 2510: warning: cyclomatic complexity 19 of function (*NsqdCoordinator).updateTopicLeaderSession() is high (> 15) (gocyclo)
  • Line 1017: warning: cyclomatic complexity 18 of function checkAndFixLocalLogQueueData() is high (> 15) (gocyclo)
  • Line 497: warning: cyclomatic complexity 16 of function (*NsqdCoordinator).periodFlushCommitLogs() is high (> 15) (gocyclo)

• nsq/nsqdserver/http.go
  • Line 323: warning: cyclomatic complexity 42 of function (*httpServer).internalPUB() is high (> 15) (gocyclo)
  • Line 1113: warning: cyclomatic complexity 24 of function (*httpServer).doMessageGet() is high (> 15) (gocyclo)
  • Line 509: warning: cyclomatic complexity 21 of function (*httpServer).doMPUB() is high (> 15) (gocyclo)
  • Line 1472: warning: cyclomatic complexity 21 of function (*httpServer).doConfig() is high (> 15) (gocyclo)
  • Line 1628: warning: cyclomatic complexity 20 of function (*httpServer).doCleanUnusedTopicData() is high (> 15) (gocyclo)

• nsq/nsqd/delay_queue.go
  • Line 943: warning: cyclomatic complexity 45 of function (*DelayQueue).emptyDelayedUntil() is high (> 15) (gocyclo)
  • Line 757: warning: cyclomatic complexity 33 of function (*DelayQueue).put() is high (> 15) (gocyclo)
  • Line 1120: warning: cyclomatic complexity 28 of function (*DelayQueue).PeekRecentTimeoutWithFilter() is high (> 15) (gocyclo)
  • Line 1474: warning: cyclomatic complexity 21 of function (*DelayQueue).TryCleanOldData() is high (> 15) (gocyclo)
  • Line 1359: warning: cyclomatic complexity 18 of function (*DelayQueue).GetOldestConsumedState() is high (> 15) (gocyclo)
  • Line 1568: warning: cyclomatic complexity 18 of function (*DelayQueue).compactStore() is high (> 15) (gocyclo)
  • Line 1700: warning: cyclomatic complexity 17 of function compactBolt() is high (> 15) (gocyclo)
  • Line 301: warning: cyclomatic complexity 16 of function newDelayQueue() is high (> 15) (gocyclo)

• nsq/consistence/nsqlookup_coord_api.go
  • Line 510: warning: cyclomatic complexity 29 of function (*NsqLookupCoordinator).ChangeTopicMetaParam() is high (> 15) (gocyclo)
  • Line 705: warning: cyclomatic complexity 17 of function (*NsqLookupCoordinator).CreateTopic() is high (> 15) (gocyclo)

• nsq/consistence/commitlog.go
  • Line 372: warning: cyclomatic complexity 34 of function (*TopicCommitLogMgr).loadCommitLogMeta() is high (> 15) (gocyclo)
  • Line 1335: warning: cyclomatic complexity 20 of function (*TopicCommitLogMgr).SearchLogDataByComparator() is high (> 15) (gocyclo)
  • Line 828: warning: cyclomatic complexity 17 of function (*TopicCommitLogMgr).CleanOldData() is high (> 15) (gocyclo)

• nsq/consistence/etcd_master_lock.go
  • Line 127: warning: cyclomatic complexity 18 of function (*EtcdLock).acquire() is high (> 15) (gocyclo)

• nsq/apps/nsq_to_file/nsq_to_file.go
  • Line 108: warning: cyclomatic complexity 23 of function (*FileLogger).router() is high (> 15) (gocyclo)
  • Line 461: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo)

• nsq/nsqadmin/http.go
  • Line 742: warning: cyclomatic complexity 60 of function (*httpServer).searchMessageTrace() is high (> 15) (gocyclo)
  • Line 1560: warning: cyclomatic complexity 38 of function (*httpServer).statisticsHandler() is high (> 15) (gocyclo)
  • Line 1296: warning: cyclomatic complexity 24 of function (*httpServer).topicChannelAction() is high (> 15) (gocyclo)
  • Line 1183: warning: cyclomatic complexity 16 of function (*httpServer).topicChannelClientAction() is high (> 15) (gocyclo)

• nsq/nsqadmin/nsqadmin.go
  • Line 37: warning: cyclomatic complexity 36 of function New() is high (> 15) (gocyclo)

• nsq/nsqdserver/lookup.go
  • Line 91: warning: cyclomatic complexity 41 of function (*NsqdServer).lookupLoop() is high (> 15) (gocyclo)

• nsq/consistence/nsqd_coordinator_cluster_write.go
  • Line 346: warning: cyclomatic complexity 54 of function (*NsqdCoordinator).doSyncOpToCluster() is high (> 15) (gocyclo)
  • Line 56: warning: cyclomatic complexity 25 of function (*NsqdCoordinator).internalPutMessageToCluster() is high (> 15) (gocyclo)
  • Line 767: warning: cyclomatic complexity 22 of function (*NsqdCoordinator).putMessagesOnSlave() is high (> 15) (gocyclo)
  • Line 1087: warning: cyclomatic complexity 21 of function (*NsqdCoordinator).FinishMessageToCluster() is high (> 15) (gocyclo)
  • Line 1231: warning: cyclomatic complexity 20 of function (*NsqdCoordinator).updateChannelOffsetOnSlave() is high (> 15) (gocyclo)
  • Line 215: warning: cyclomatic complexity 19 of function (*NsqdCoordinator).PutMessagesToCluster() is high (> 15) (gocyclo)
  • Line 889: warning: cyclomatic complexity 17 of function (*NsqdCoordinator).doWriteOpOnSlave() is high (> 15) (gocyclo)

• nsq/consistence/nsqd_coordinator_test.go
  • Line 559: warning: cyclomatic complexity 22 of function testNsqdCoordCatchup() is high (> 15) (gocyclo)
  • Line 2273: warning: cyclomatic complexity 16 of function benchmarkNsqdCoordPubWithArg() is high (> 15) (gocyclo)

• nsq/internal/clusterinfo/data.go
  • Line 962: warning: cyclomatic complexity 20 of function (*ClusterInfo).getNSQDStats() is high (> 15) (gocyclo)
  • Line 1110: warning: cyclomatic complexity 18 of function (*ClusterInfo).CreateTopicChannelAfterTopicCreation() is high (> 15) (gocyclo)
  • Line 1345: warning: cyclomatic complexity 16 of function (*ClusterInfo).DeleteChannel() is high (> 15) (gocyclo)

• nsq/nsqd/codec/memcmp_codec.go
  • Line 30: warning: cyclomatic complexity 18 of function memcmpEncode() is high (> 15) (gocyclo)

• nsq/nsqlookupd/http.go
  • Line 320: warning: cyclomatic complexity 27 of function (*httpServer).doLookup() is high (> 15) (gocyclo)
  • Line 687: warning: cyclomatic complexity 21 of function (*httpServer).doCreateTopic() is high (> 15) (gocyclo)

• nsq/nsqd/diskqueue_writer_test.go
  • Line 795: warning: cyclomatic complexity 16 of function TestDiskQueueWriterTorture() is high (> 15) (gocyclo)

• nsq/consistence/commitlog_test.go
  • Line 566: warning: cyclomatic complexity 31 of function testCommitLogSearch() is high (> 15) (gocyclo)
  • Line 934: warning: cyclomatic complexity 22 of function TestCommitLogCleanOldAtMiddleOfSeg() is high (> 15) (gocyclo)

ineffassign81%

IneffAssign detects ineffectual assignments in Go code.

• nsq/nsqd/topic.go
  • Line 772: warning: ineffectual assignment to id (ineffassign)
  • Line 1110: warning: ineffectual assignment to wsize (ineffassign)

• nsq/consistence/nsqd_coordinator_cluster_write.go
  • Line 390: warning: ineffectual assignment to failedNodes (ineffassign)
  • Line 462: warning: ineffectual assignment to needRefreshISR (ineffassign)

• nsq/consistence/nsqlookup_coordinator.go
  • Line 810: warning: ineffectual assignment to needMigrate (ineffassign)

• nsq/nsqd/engine/pebble_eng_test.go
  • Line 111: warning: ineffectual assignment to err (ineffassign)

• nsq/nsqdserver/nsqd_server_test.go
  • Line 253: warning: ineffectual assignment to err (ineffassign)

• nsq/nsqd/channel.go
  • Line 300: warning: ineffectual assignment to newStart (ineffassign)
  • Line 2203: warning: ineffectual assignment to isZanTestSkip (ineffassign)

• nsq/consistence/nsq_lookupd_etcd_test.go
  • Line 120: warning: ineffectual assignment to allTopics (ineffassign)
  • Line 135: warning: ineffectual assignment to allTopics (ineffassign)
  • Line 137: warning: ineffectual assignment to err (ineffassign)
  • Line 152: warning: ineffectual assignment to allTopics (ineffassign)
  • Line 167: warning: ineffectual assignment to allTopics (ineffassign)

• nsq/nsqadmin/http.go
  • Line 793: warning: ineffectual assignment to requestMsgID (ineffassign)

• nsq/nsqdserver/protocol_v2_test.go
  • Line 912: warning: ineffectual assignment to err (ineffassign)
  • Line 2989: warning: ineffectual assignment to err (ineffassign)
  • Line 3453: warning: ineffectual assignment to err (ineffassign)
  • Line 3569: warning: ineffectual assignment to err (ineffassign)
  • Line 4414: warning: ineffectual assignment to err (ineffassign)
  • Line 4961: warning: ineffectual assignment to received (ineffassign)
  • Line 5761: warning: ineffectual assignment to err (ineffassign)
  • Line 5901: warning: ineffectual assignment to data (ineffassign)

• nsq/nsqd/diskqueue_reader.go
  • Line 529: warning: ineffectual assignment to vdiff (ineffassign)
  • Line 582: warning: ineffectual assignment to end (ineffassign)

• nsq/nsqd/diskqueue_writer.go
  • Line 523: warning: ineffectual assignment to newEnd (ineffassign)

• nsq/nsqd/diskqueue_writer_test.go
  • Line 393: warning: ineffectual assignment to err (ineffassign)
  • Line 395: warning: ineffectual assignment to err (ineffassign)
  • Line 405: warning: ineffectual assignment to err (ineffassign)
  • Line 417: warning: ineffectual assignment to err (ineffassign)
  • Line 419: warning: ineffectual assignment to err (ineffassign)
  • Line 941: warning: ineffectual assignment to err (ineffassign)

• nsq/nsqd/kv_topic_test.go
  • Line 199: warning: ineffectual assignment to msgs (ineffassign)
  • Line 276: warning: ineffectual assignment to wsize (ineffassign)

• nsq/nsqd/nsqd_test.go
  • Line 362: warning: ineffectual assignment to err (ineffassign)
  • Line 384: warning: ineffectual assignment to err (ineffassign)

• nsq/nsqd/topic_test.go
  • Line 141: warning: ineffectual assignment to err (ineffassign)
  • Line 214: warning: ineffectual assignment to err (ineffassign)

• nsq/consistence/commitlog_test.go
  • Line 105: warning: ineffectual assignment to alllogs (ineffassign)
  • Line 280: warning: ineffectual assignment to err (ineffassign)
  • Line 1121: warning: ineffectual assignment to err (ineffassign)
  • Line 1525: warning: ineffectual assignment to err (ineffassign)
  • Line 1627: warning: ineffectual assignment to err (ineffassign)

• nsq/consistence/data_placement_mgr.go
  • Line 665: warning: ineffectual assignment to topNBalanced (ineffassign)

• nsq/nsqdserver/context.go
  • Line 394: warning: ineffectual assignment to infoChan (ineffassign)
  • Line 395: warning: ineffectual assignment to minfoChan (ineffassign)

• nsq/nsqdserver/lookup.go
  • Line 157: warning: ineffectual assignment to discoveryChanged (ineffassign)
  • Line 269: warning: ineffectual assignment to discoveryChanged (ineffassign)

• nsq/consistence/nsqlookup_coordinator_test.go
  • Line 314: warning: ineffectual assignment to t (ineffassign)
  • Line 776: warning: ineffectual assignment to err (ineffassign)
  • Line 1038: warning: ineffectual assignment to err (ineffassign)
  • Line 1058: warning: ineffectual assignment to err (ineffassign)
  • Line 1080: warning: ineffectual assignment to err (ineffassign)
  • Line 1219: warning: ineffectual assignment to err (ineffassign)
  • Line 1251: warning: ineffectual assignment to err (ineffassign)
  • Line 1325: warning: ineffectual assignment to err (ineffassign)
  • Line 1356: warning: ineffectual assignment to err (ineffassign)
  • Line 1400: warning: ineffectual assignment to err (ineffassign)
  • Line 1414: warning: ineffectual assignment to err (ineffassign)
  • Line 1426: warning: ineffectual assignment to err (ineffassign)
  • Line 1442: warning: ineffectual assignment to err (ineffassign)
  • Line 1506: warning: ineffectual assignment to err (ineffassign)
  • Line 1520: warning: ineffectual assignment to err (ineffassign)
  • Line 2957: warning: ineffectual assignment to allDone (ineffassign)

• nsq/nsqd/meta_storage.go
  • Line 274: warning: ineffectual assignment to err (ineffassign)

• nsq/nsqadmin/http_test.go
  • Line 365: warning: ineffectual assignment to body (ineffassign)
  • Line 399: warning: ineffectual assignment to body (ineffassign)
  • Line 434: warning: ineffectual assignment to body (ineffassign)

• nsq/nsqlookupd/nsqlookupd_test.go
  • Line 250: warning: ineffectual assignment to err (ineffassign)
  • Line 314: warning: ineffectual assignment to err (ineffassign)
  • Line 674: warning: ineffectual assignment to err (ineffassign)
  • Line 866: warning: ineffectual assignment to err (ineffassign)

• nsq/nsqadmin/auth.go
  • Line 176: warning: ineffectual assignment to err (ineffassign)

• nsq/nsqdserver/http_test.go
  • Line 70: warning: ineffectual assignment to err (ineffassign)
  • Line 694: warning: ineffectual assignment to err (ineffassign)
  • Line 756: warning: ineffectual assignment to err (ineffassign)
  • Line 834: warning: ineffectual assignment to err (ineffassign)
  • Line 923: warning: ineffectual assignment to err (ineffassign)
  • Line 969: warning: ineffectual assignment to err (ineffassign)
  • Line 1279: warning: ineffectual assignment to err (ineffassign)

• nsq/nsqdserver/nsqd_server.go
  • Line 52: warning: ineffectual assignment to tlsClientAuthPolicy (ineffassign)
  • Line 92: warning: ineffectual assignment to ip (ineffassign)

• nsq/nsqdserver/protocol_v2.go
  • Line 715: warning: ineffectual assignment to err (ineffassign)
  • Line 793: warning: ineffectual assignment to deflateLevel (ineffassign)

• nsq/nsqd/delay_queue.go
  • Line 487: warning: ineffectual assignment to id (ineffassign)
  • Line 1126: warning: ineffectual assignment to ok (ineffassign)

• nsq/nsqd/diskqueue_reader_test.go
  • Line 651: warning: ineffectual assignment to err (ineffassign)
  • Line 658: warning: ineffectual assignment to err (ineffassign)

• nsq/internal/http_api/topic_channel_args.go
  • Line 53: warning: ineffectual assignment to topicPart (ineffassign)

• nsq/nsqd/engine/kv_test.go
  • Line 87: warning: ineffectual assignment to err (ineffassign)

• nsq/nsqadmin/nsqadmin.go
  • Line 45: warning: ineffectual assignment to err (ineffassign)

• nsq/nsqd/delay_queue_test.go
  • Line 240: warning: ineffectual assignment to wsize (ineffassign)
  • Line 912: warning: ineffectual assignment to err (ineffassign)
  • Line 990: warning: ineffectual assignment to err (ineffassign)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell96%

Misspell Finds commonly misspelled English words

• nsq/consistence/nsqd_coordinator_test.go
  • Line 2270: warning: "happend" is a misspelling of "happened" (misspell)

• nsq/nsqdserver/context.go
  • Line 535: warning: "nto" is a misspelling of "not" (misspell)
  • Line 536: warning: "nto" is a misspelling of "not" (misspell)
  • Line 537: warning: "nto" is a misspelling of "not" (misspell)

• nsq/nsqdserver/protocol_v2_test.go
  • Line 2142: warning: "shoudl" is a misspelling of "should" (misspell)
  • Line 4788: warning: "attemp" is a misspelling of "attempt" (misspell)

• nsq/nsqd/channel.go
  • Line 1353: warning: "frequence" is a misspelling of "frequencies" (misspell)

• nsq/nsqd/nsqd.go
  • Line 382: warning: "disbale" is a misspelling of "disable" (misspell)
  • Line 481: warning: "disbale" is a misspelling of "disable" (misspell)

• nsq/nsqd/nsqd_test.go
  • Line 370: warning: "disbale" is a misspelling of "disable" (misspell)
  • Line 392: warning: "disbale" is a misspelling of "disable" (misspell)