Report for github.com/zmap/zgrab
A+ Excellent! Found 108 issues across 210 files
gofmt97%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
zgrab/ztools/http/main_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
zgrab/ztools/zct/x509/x509_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
zgrab/ztools/xssh/kex.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
zgrab/ztools/xssh/kex_gex.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
zgrab/ztools/xssh/keys.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
golint60%
Golint is a linter for Go source code.
-
-
zgrab/zlib/processing.go
- Line 35: warning: don't use underscores in Go names; const status_success should be statusSuccess (golint)
- Line 36: warning: don't use underscores in Go names; const status_failure should be statusFailure (golint)
- Line 39: warning: exported method GrabWorker.Success should have comment or be unexported (golint)
- Line 43: warning: exported method GrabWorker.Failure should have comment or be unexported (golint)
- Line 47: warning: exported method GrabWorker.Total should have comment or be unexported (golint)
- Line 51: warning: exported method GrabWorker.RunCount should have comment or be unexported (golint)
- Line 55: warning: exported method GrabWorker.Done should have comment or be unexported (golint)
- Line 59: warning: exported method GrabWorker.MakeHandler should have comment or be unexported (golint)
- Line 72: warning: exported function NewGrabWorker should have comment or be unexported (golint)
- Line 97: warning: exported function NewGrabMarshaler should have comment or be unexported (golint)
-
-
zgrab/ztools/zct/client/logclient.go
- Line 211: warning: error should be the last type when returning multiple items (golint)
- Line 280: warning: error should be the last type when returning multiple items (golint)
- Line 285: warning: error should be the last type when returning multiple items (golint)
- Line 291: warning: error should be the last type when returning multiple items (golint)
- Line 295: warning: exported method LogClient.AddJSON should have comment or be unexported (golint)
-
-
zgrab/ztools/http/header.go
- Line 282: warning: exported function FormatHeaderName should have comment or be unexported (golint)
- Line 286: warning: exported type UnknownHeader should have comment or be unexported (golint)
- Line 318: warning: comment on exported method Header.MarshalJSON should be of the form "MarshalJSON ..." (golint)
-
-
zgrab/ztools/xssh/messages.go
- Line 74: warning: exported type JsonKexInitMsg should have comment or be unexported (golint)
-
-
zgrab/ztools/scada/siemens/s7.go
- Line 10: warning: exported function GetS7Banner should have comment or be unexported (golint)
-
-
zgrab/ztools/scada/bacnet/messages.go
- Line 5: warning: exported type VLC should have comment or be unexported (golint)
- Line 11: warning: exported type NPDU should have comment or be unexported (golint)
- Line 16: warning: exported type SegmentParameters should have comment or be unexported (golint)
- Line 21: warning: exported type APDU should have comment or be unexported (golint)
- Line 28: warning: exported type Frame should have comment or be unexported (golint)
-
-
zgrab/summary.go
- Line 22: warning: exported type Summary should have comment or be unexported (golint)
- Line 56: warning: exported method Summary.MarshalJSON should have comment or be unexported (golint)
- Line 81: warning: exported method Summary.UnmarshalJSON should have comment or be unexported (golint)
-
-
zgrab/ztools/zct/serialization.go
- Line 459: warning: exported function DeserializeSCT should have comment or be unexported (golint)
-
-
zgrab/ztools/zct/asn1/marshal.go
- Line 394: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 419: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
zgrab/ztools/zct/x509/x509.go
- Line 162: warning: exported type SignatureAlgorithm should have comment or be unexported (golint)
- Line 165: warning: exported const UnknownSignatureAlgorithm should have comment (or a comment on this block) or be unexported (golint)
- Line 180: warning: exported type PublicKeyAlgorithm should have comment or be unexported (golint)
- Line 183: warning: exported const UnknownPublicKeyAlgorithm should have comment (or a comment on this block) or be unexported (golint)
- Line 374: warning: exported const KeyUsageDigitalSignature should have comment (or a comment on this block) or be unexported (golint)
- Line 417: warning: exported const ExtKeyUsageAny should have comment (or a comment on this block) or be unexported (golint)
- Line 544: warning: exported method Certificate.Equal should have comment or be unexported (golint)
- Line 623: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 692: warning: comment on exported type UnhandledCriticalExtension should be of the form "UnhandledCriticalExtension ..." (with optional leading article) (golint)
- Line 824: warning: comment on exported method NonFatalErrors.AddError should be of the form "AddError ..." (golint)
- Line 839: warning: comment on exported method NonFatalErrors.HasError should be of the form "HasError ..." (golint)
-
-
zgrab/ztools/http/request.go
- Line 44: warning: exported type URLWrapper should have comment or be unexported (golint)
- Line 82: warning: comment on exported var ErrHeaderTooLong should be of the form "ErrHeaderTooLong ..." (golint)
- Line 84: warning: comment on exported var ErrShortBody should be of the form "ErrShortBody ..." (golint)
- Line 86: warning: comment on exported var ErrMissingContentLength should be of the form "ErrMissingContentLength ..." (golint)
- Line 320: warning: exported method Request.MarshalJSON should have comment or be unexported (golint)
- Line 350: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 359: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 371: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 381: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 389: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 394: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 405: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 416: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 433: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 449: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 460: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 478: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 509: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 519: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 529: warning: receiver name req should be consistent with previous receiver name request for Request (golint)
- Line 772: warning: exported function NewRequest should have comment or be unexported (golint)
- Line 776: warning: comment on exported function NewRequestWithHost should be of the form "NewRequestWithHost ..." (golint)
- Line 879: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 911: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 1187: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 1228: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 1273: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 1288: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 1300: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 1319: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 1323: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 1330: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 1334: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 1340: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
- Line 1352: warning: receiver name r should be consistent with previous receiver name request for Request (golint)
-
-
zgrab/ztools/xssh/channel.go
- Line 113: warning: exported const Prohibited should have comment (or a comment on this block) or be unexported (golint)
- Line 510: warning: receiver name ch should be consistent with previous receiver name c for channel (golint)
- Line 524: warning: receiver name ch should be consistent with previous receiver name c for channel (golint)
- Line 531: warning: receiver name ch should be consistent with previous receiver name c for channel (golint)
- Line 538: warning: receiver name ch should be consistent with previous receiver name c for channel (golint)
- Line 547: warning: receiver name ch should be consistent with previous receiver name c for channel (golint)
- Line 558: warning: receiver name ch should be consistent with previous receiver name c for channel (golint)
- Line 565: warning: receiver name ch should be consistent with previous receiver name c for channel (golint)
- Line 569: warning: receiver name ch should be consistent with previous receiver name c for channel (golint)
- Line 609: warning: receiver name ch should be consistent with previous receiver name c for channel (golint)
- Line 627: warning: receiver name ch should be consistent with previous receiver name c for channel (golint)
- Line 631: warning: receiver name ch should be consistent with previous receiver name c for channel (golint)
-
-
zgrab/ztools/smb/session.go
- Line 40: warning: exported type Session should have comment or be unexported (golint)
- Line 53: warning: exported type Options should have comment or be unexported (golint)
- Line 63: warning: exported function GetSMBBanner should have comment or be unexported (golint)
- Line 84: warning: exported method Session.NegotiateProtocol should have comment or be unexported (golint)
- Line 157: warning: exported method Session.Debug should have comment or be unexported (golint)
-
-
zgrab/ztools/util/util.go
- Line 18: warning: exported function ReadUntilRegex should have comment or be unexported (golint)
- Line 39: warning: comment on exported function TLDMatches should be of the form "TLDMatches ..." (golint)
-
-
zgrab/ztools/xssh/log.go
- Line 30: warning: exported type EndpointId should have comment or be unexported (golint)
-
-
zgrab/ztools/xssh/transport.go
- Line 74: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 80: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
zgrab/ztools/http/httputil/persist.go
- Line 19: warning: comment on exported var ErrPersistEOF should be of the form "ErrPersistEOF ..." (golint)
- Line 22: warning: comment on exported var ErrClosed should be of the form "ErrClosed ..." (golint)
- Line 25: warning: comment on exported var ErrPipeline should be of the form "ErrPipeline ..." (golint)
- Line 151: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
zgrab/ztools/smb/gss/oid.go
- Line 1: warning: package comment should be of the form "Package gss ..." (golint)
- Line 31: warning: exported function ObjectIDStrToInt should have comment or be unexported (golint)
-
-
zgrab/ztools/zct/scanner/scanner.go
- Line 20: warning: comment on exported type Matcher should be of the form "Matcher ..." (with optional leading article) (golint)
- Line 34: warning: exported method MatchAll.CertificateMatches should have comment or be unexported (golint)
- Line 38: warning: exported method MatchAll.PrecertificateMatches should have comment or be unexported (golint)
- Line 45: warning: exported method MatchNone.CertificateMatches should have comment or be unexported (golint)
- Line 49: warning: exported method MatchNone.PrecertificateMatches should have comment or be unexported (golint)
- Line 53: warning: exported type MatchSerialNumber should have comment or be unexported (golint)
- Line 57: warning: exported method MatchSerialNumber.CertificateMatches should have comment or be unexported (golint)
- Line 61: warning: exported method MatchSerialNumber.PrecertificateMatches should have comment or be unexported (golint)
- Line 74: warning: comment on exported method MatchSubjectRegex.CertificateMatches should be of the form "CertificateMatches ..." (golint)
- Line 87: warning: comment on exported method MatchSubjectRegex.PrecertificateMatches should be of the form "PrecertificateMatches ..." (golint)
- Line 100: warning: comment on exported type MatchIssuerRegex should be of the form "MatchIssuerRegex ..." (with optional leading article) (golint)
- Line 106: warning: exported method MatchIssuerRegex.CertificateMatches should have comment or be unexported (golint)
- Line 110: warning: exported method MatchIssuerRegex.PrecertificateMatches should have comment or be unexported (golint)
- Line 144: warning: comment on exported function DefaultScannerOptions should be of the form "DefaultScannerOptions ..." (golint)
- Line 309: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 318: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 345: warning: exported method Scanner.Log should have comment or be unexported (golint)
- Line 351: warning: exported method Scanner.LogWarn should have comment or be unexported (golint)
- Line 357: warning: exported method Scanner.LogError should have comment or be unexported (golint)
- Line 363: warning: comment on exported method Scanner.Scan should be of the form "Scan ..." (golint)
- Line 448: warning: comment on exported function NewScanner should be of the form "NewScanner ..." (golint)
-
-
zgrab/ztools/zlog/logger.go
- Line 25: warning: exported type Logger should have comment or be unexported (golint)
- Line 35: warning: exported type LogLevel should have comment or be unexported (golint)
- Line 43: warning: exported const LOG_FATAL should have comment (or a comment on this block) or be unexported (golint)
- Line 87: warning: exported method LogLevel.Color should have comment or be unexported (golint)
- Line 94: warning: exported function New should have comment or be unexported (golint)
- Line 112: warning: exported method Logger.Fatal should have comment or be unexported (golint)
- Line 117: warning: exported method Logger.Fatalf should have comment or be unexported (golint)
- Line 126: warning: exported method Logger.Errorf should have comment or be unexported (golint)
- Line 130: warning: exported method Logger.Warn should have comment or be unexported (golint)
- Line 134: warning: exported method Logger.Warnf should have comment or be unexported (golint)
- Line 138: warning: exported method Logger.Info should have comment or be unexported (golint)
- Line 142: warning: exported method Logger.Infof should have comment or be unexported (golint)
- Line 146: warning: exported method Logger.Debug should have comment or be unexported (golint)
- Line 150: warning: exported method Logger.Debugf should have comment or be unexported (golint)
- Line 154: warning: exported method Logger.Trace should have comment or be unexported (golint)
- Line 158: warning: exported method Logger.Tracef should have comment or be unexported (golint)
- Line 162: warning: exported function Fatal should have comment or be unexported (golint)
- Line 166: warning: exported function Fatalf should have comment or be unexported (golint)
- Line 170: warning: exported function Error should have comment or be unexported (golint)
- Line 174: warning: exported function Errorf should have comment or be unexported (golint)
- Line 178: warning: exported function Warn should have comment or be unexported (golint)
- Line 182: warning: exported function Warnf should have comment or be unexported (golint)
- Line 186: warning: exported function Debug should have comment or be unexported (golint)
- Line 190: warning: exported function Debugf should have comment or be unexported (golint)
- Line 194: warning: exported function Info should have comment or be unexported (golint)
- Line 198: warning: exported function Infof should have comment or be unexported (golint)
- Line 202: warning: exported function Trace should have comment or be unexported (golint)
- Line 206: warning: exported function Tracef should have comment or be unexported (golint)
- Line 210: warning: exported method Logger.Print should have comment or be unexported (golint)
- Line 220: warning: exported method Logger.Printf should have comment or be unexported (golint)
- Line 230: warning: exported function Print should have comment or be unexported (golint)
- Line 234: warning: exported function Printf should have comment or be unexported (golint)
-
-
zgrab/zlib/zgrab.go
- Line 33: warning: exported type Grab should have comment or be unexported (golint)
- Line 51: warning: exported type GrabData should have comment or be unexported (golint)
- Line 72: warning: exported method Grab.MarshalJSON should have comment or be unexported (golint)
- Line 90: warning: exported method Grab.UnmarshalJSON should have comment or be unexported (golint)
-
-
zgrab/ztools/xssh/agent/client_test.go
- Line 160: warning: don't use underscores in Go names; func DISABLED_TestAgent should be DISABLEDTestAgent (golint)
-
-
zgrab/ztools/telnet/log.go
- Line 17: warning: exported type TelnetLog should have comment or be unexported (golint)
-
-
zgrab/ztools/telnet/telnet.go
- Line 39: warning: exported type TelnetOption should have comment or be unexported (golint)
- Line 41: warning: exported method TelnetOption.Name should have comment or be unexported (golint)
- Line 49: warning: exported method TelnetOption.MarshalJSON should have comment or be unexported (golint)
- Line 60: warning: exported method TelnetOption.UnmarshalJSON should have comment or be unexported (golint)
- Line 74: warning: exported function GetTelnetBanner should have comment or be unexported (golint)
- Line 93: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 119: warning: exported function NegotiateOptions should have comment or be unexported (golint)
-
-
zgrab/ztools/scada/siemens/messages.go
- Line 8: warning: comment on exported type TPKTPacket should be of the form "TPKTPacket ..." (with optional leading article) (golint)
- Line 15: warning: comment on exported method TPKTPacket.Marshal should be of the form "Marshal ..." (golint)
- Line 31: warning: comment on exported method TPKTPacket.Unmarshal should be of the form "Unmarshal ..." (golint)
- Line 43: warning: comment on exported type COTPConnectionPacket should be of the form "COTPConnectionPacket ..." (with optional leading article) (golint)
- Line 54: warning: comment on exported method COTPConnectionPacket.Marshal should be of the form "Marshal ..." (golint)
- Line 81: warning: comment on exported method COTPConnectionPacket.Unmarshal should be of the form "Unmarshal ..." (golint)
- Line 106: warning: exported type COTPDataPacket should have comment or be unexported (golint)
- Line 112: warning: comment on exported method COTPDataPacket.Marshal should be of the form "Marshal ..." (golint)
- Line 124: warning: comment on exported method COTPDataPacket.Unmarshal should be of the form "Unmarshal ..." (golint)
- Line 142: warning: exported type S7Packet should have comment or be unexported (golint)
- Line 151: warning: exported const S7_PROTOCOL_ID should have comment (or a comment on this block) or be unexported (golint)
- Line 167: warning: comment on exported method S7Packet.Marshal should be of the form "Marshal ..." (golint)
- Line 193: warning: comment on exported method S7Packet.Unmarshal should be of the form "Unmarshal ..." (golint)
-
-
zgrab/zlib/grabber.go
- Line 44: warning: exported var ErrRedirLocalhost should have comment or be unexported (golint)
- Line 46: warning: exported type GrabTarget should have comment or be unexported (golint)
- Line 94: warning: exported function NewGrabTargetDecoder should have comment or be unexported (golint)
- Line 102: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 221: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 224: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 278: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 632: warning: exported function GrabBanner should have comment or be unexported (golint)
-
-
zgrab/zlib/modbus.go
- Line 25: warning: exported type MEIResponse should have comment or be unexported (golint)
- Line 32: warning: exported type MEIObjectSet should have comment or be unexported (golint)
- Line 34: warning: exported method MEIObjectSet.MarshalJSON should have comment or be unexported (golint)
- Line 42: warning: exported type MEIObject should have comment or be unexported (golint)
- Line 47: warning: exported type MEIObjectID should have comment or be unexported (golint)
- Line 50: warning: exported const OIDVendor should have comment (or a comment on this block) or be unexported (golint)
- Line 69: warning: exported method MEIObjectID.Name should have comment or be unexported (golint)
- Line 80: warning: exported method MEIObject.MarshalJSON should have comment or be unexported (golint)
- Line 87: warning: exported type ExceptionResponse should have comment or be unexported (golint)
- Line 92: warning: exported type ModbusEvent should have comment or be unexported (golint)
- Line 101: warning: exported method ModbusEvent.IsException should have comment or be unexported (golint)
- Line 105: warning: exported method ModbusEvent.ParseSelf should have comment or be unexported (golint)
- Line 181: warning: exported type FunctionCode should have comment or be unexported (golint)
- Line 182: warning: exported type ExceptionFunctionCode should have comment or be unexported (golint)
- Line 183: warning: exported type ExceptionCode should have comment or be unexported (golint)
- Line 185: warning: exported type ModbusRequest should have comment or be unexported (golint)
- Line 190: warning: exported method ModbusRequest.MarshalBinary should have comment or be unexported (golint)
- Line 201: warning: exported type ModbusResponse should have comment or be unexported (golint)
- Line 208: warning: exported method Conn.ReadMin should have comment or be unexported (golint)
- Line 226: warning: exported method Conn.GetModbusResponse should have comment or be unexported (golint)
- Line 286: warning: exported type ModbusException should have comment or be unexported (golint)
- Line 291: warning: exported method ExceptionFunctionCode.FunctionCode should have comment or be unexported (golint)
- Line 296: warning: exported method FunctionCode.ExceptionFunctionCode should have comment or be unexported (golint)
- Line 301: warning: exported method FunctionCode.IsException should have comment or be unexported (golint)
- Line 305: warning: exported var ModbusHeaderBytes should have comment or be unexported (golint)
- Line 310: warning: exported var ModbusFunctionEncapsulatedInterface should have comment or be unexported (golint)
- Line 313: warning: exported const FunctionCodeMEI should have comment (or a comment on this block) or be unexported (golint)
-
-
zgrab/ztools/scada/fox/fox.go
- Line 12: warning: exported const ORIGINAL_QUERY should have comment (or a comment on this block) or be unexported (golint)
- Line 43: warning: exported function GetFoxBanner should have comment or be unexported (golint)
-
-
zgrab/ztools/ftp/log.go
- Line 17: warning: exported type FTPLog should have comment or be unexported (golint)
-
-
zgrab/ztools/xssh/client_auth_test.go
- Line 356: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
zgrab/ztools/xssh/session.go
- Line 20: warning: exported type Signal should have comment or be unexported (golint)
- Line 53: warning: exported type TerminalModes should have comment or be unexported (golint)
- Line 57: warning: don't use underscores in Go names; const tty_OP_END should be ttyOPEND (golint)
- Line 155: warning: exported method Session.Close should have comment or be unexported (golint)
-
-
zgrab/ztools/ftp/ftp.go
- Line 27: warning: exported function GetFTPBanner should have comment or be unexported (golint)
- Line 41: warning: exported function SetupFTPS should have comment or be unexported (golint)
- Line 54: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
zgrab/zlib/output.go
- Line 23: warning: exported type OutputConfig should have comment or be unexported (golint)
- Line 28: warning: exported function WriteOutput should have comment or be unexported (golint)
-
-
zgrab/zlib/dial.go
- Line 22: warning: exported type Dialer should have comment or be unexported (golint)
- Line 30: warning: exported method Dialer.Dial should have comment or be unexported (golint)
-
-
zgrab/ztools/scada/bacnet/log.go
- Line 5: warning: exported type Log should have comment or be unexported (golint)
- Line 18: warning: error should be the last type when returning multiple items (golint)
- Line 49: warning: exported method Log.QueryDeviceID should have comment or be unexported (golint)
- Line 66: warning: exported method Log.QueryVendorNumber should have comment or be unexported (golint)
- Line 80: warning: exported method Log.QueryVendorName should have comment or be unexported (golint)
- Line 85: warning: exported method Log.QueryFirmwareRevision should have comment or be unexported (golint)
- Line 93: warning: exported method Log.QueryApplicationSoftwareRevision should have comment or be unexported (golint)
- Line 101: warning: exported method Log.QueryObjectName should have comment or be unexported (golint)
- Line 106: warning: exported method Log.QueryModelName should have comment or be unexported (golint)
- Line 111: warning: exported method Log.QueryDescription should have comment or be unexported (golint)
- Line 116: warning: exported method Log.QueryLocation should have comment or be unexported (golint)
-
-
zgrab/ztools/xssh/test/agent_unix_test.go
- Line 17: warning: don't use underscores in Go names; func DISABLED_TestAgentForward should be DISABLEDTestAgentForward (golint)
-
-
zgrab/ztools/xssh/test/doc.go
- Line 5: warning: package comment should be of the form "Package test ..." (golint)
-
-
zgrab/ztools/xssh/test/session_test.go
- Line 21: warning: don't use underscores in Go names; func DISABLED_TestRunCommandSuccess should be DISABLEDTestRunCommandSuccess (golint)
- Line 38: warning: don't use underscores in Go names; func DISABLED_TestHostKeyCheck should be DISABLEDTestHostKeyCheck (golint)
- Line 60: warning: don't use underscores in Go names; func DISABLED_TestRunCommandStdin should be DISABLEDTestRunCommandStdin (golint)
- Line 83: warning: don't use underscores in Go names; func DISABLED_TestRunCommandStdinError should be DISABLEDTestRunCommandStdinError (golint)
- Line 107: warning: don't use underscores in Go names; func DISABLED_TestRunCommandFailed should be DISABLEDTestRunCommandFailed (golint)
- Line 124: warning: don't use underscores in Go names; func DISABLED_TestRunCommandWeClosed should be DISABLEDTestRunCommandWeClosed (golint)
- Line 144: warning: don't use underscores in Go names; func DISABLED_TestFuncLargeRead should be DISABLEDTestFuncLargeRead (golint)
- Line 176: warning: don't use underscores in Go names; func DISABLED_TestKeyChange should be DISABLEDTestKeyChange (golint)
- Line 218: warning: don't use underscores in Go names; func DISABLED_TestInvalidTerminalMode should be DISABLEDTestInvalidTerminalMode (golint)
- Line 235: warning: don't use underscores in Go names; func DISABLED_TestValidTerminalMode should be DISABLEDTestValidTerminalMode (golint)
- Line 279: warning: don't use underscores in Go names; func DISABLED_TestCiphers should be DISABLEDTestCiphers (golint)
- Line 303: warning: don't use underscores in Go names; func DISABLED_TestMACs should be DISABLEDTestMACs (golint)
- Line 323: warning: don't use underscores in Go names; func DISABLED_TestKeyExchanges should be DISABLEDTestKeyExchanges (golint)
- Line 342: warning: don't use underscores in Go names; func DISABLED_TestClientAuthAlgorithms should be DISABLEDTestClientAuthAlgorithms (golint)
-
-
zgrab/ztools/http/httputil/non1.go
- Line 35: warning: exported function TestReverseProxy should have comment or be unexported (golint)
- Line 141: warning: comment on exported function TestReverseProxyStripHeadersPresentInConnection should be of the form "TestReverseProxyStripHeadersPresentInConnection ..." (golint)
- Line 196: warning: exported function TestXForwardedFor should have comment or be unexported (golint)
- Line 248: warning: exported function TestReverseProxyQuery should have comment or be unexported (golint)
- Line 275: warning: exported function TestReverseProxyFlushInterval should have comment or be unexported (golint)
- Line 316: warning: exported function TestReverseProxyCancelation should have comment or be unexported (golint)
- Line 379: warning: comment on exported function TestNilBody should be of the form "TestNilBody ..." (golint)
- Line 409: warning: comment on exported function TestUserAgentHeader should be of the form "TestUserAgentHeader ..." (golint)
- Line 457: warning: exported function TestReverseProxyGetPutBuffer should have comment or be unexported (golint)
- Line 514: warning: exported function TestReverseProxy_Post should have comment or be unexported (golint)
- Line 514: warning: don't use underscores in Go names; func TestReverseProxy_Post should be TestReverseProxyPost (golint)
- Line 554: warning: exported type RoundTripperFunc should have comment or be unexported (golint)
- Line 556: warning: exported method RoundTripperFunc.RoundTrip should have comment or be unexported (golint)
- Line 560: warning: comment on exported function TestReverseProxy_NilBody should be of the form "TestReverseProxy_NilBody ..." (golint)
- Line 561: warning: don't use underscores in Go names; func TestReverseProxy_NilBody should be TestReverseProxyNilBody (golint)
- Line 584: warning: comment on exported function TestReverseProxyModifyResponse should be of the form "TestReverseProxyModifyResponse ..." (golint)
- Line 625: warning: comment on exported function TestReverseProxy_CopyBuffer should be of the form "TestReverseProxy_CopyBuffer ..." (golint)
- Line 626: warning: don't use underscores in Go names; func TestReverseProxy_CopyBuffer should be TestReverseProxyCopyBuffer (golint)
-
-
zgrab/ztools/xssh/cipher.go
- Line 503: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
zgrab/ztools/smb/encoder/unicode.go
- Line 34: warning: exported function FromUnicode should have comment or be unexported (golint)
- Line 47: warning: exported function ToUnicode should have comment or be unexported (golint)
-
-
zgrab/ztools/scada/bacnet/objects.go
- Line 8: warning: exported type ObjectID should have comment or be unexported (golint)
- Line 11: warning: exported const OID_ANY should have comment (or a comment on this block) or be unexported (golint)
- Line 14: warning: exported type PropertyID should have comment or be unexported (golint)
- Line 17: warning: exported const PID_OID should have comment (or a comment on this block) or be unexported (golint)
- Line 28: warning: exported type ReadProperty should have comment or be unexported (golint)
- Line 33: warning: exported method ReadProperty.Marshal should have comment or be unexported (golint)
- Line 44: warning: exported method ReadProperty.Unmarshal should have comment or be unexported (golint)
-
-
zgrab/ztools/xssh/certs.go
- Line 73: warning: exported type JsonValidity should have comment or be unexported (golint)
- Line 79: warning: exported type JsonCertType should have comment or be unexported (golint)
- Line 84: warning: exported type JsonPubKeyWrapper should have comment or be unexported (golint)
- Line 91: warning: exported type JsonSignature should have comment or be unexported (golint)
- Line 97: warning: exported type JsonCertificate should have comment or be unexported (golint)
- Line 113: warning: exported method Certificate.MarshalJSON should have comment or be unexported (golint)
- Line 553: warning: receiver name cert should be consistent with previous receiver name c for Certificate (golint)
-
-
zgrab/ztools/xssh/flag.go
- Line 12: warning: exported type XSSHConfig should have comment or be unexported (golint)
- Line 24: warning: exported type HostKeyAlgorithmsList should have comment or be unexported (golint)
- Line 32: warning: exported method HostKeyAlgorithmsList.Set should have comment or be unexported (golint)
- Line 43: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 51: warning: exported method HostKeyAlgorithmsList.Get should have comment or be unexported (golint)
- Line 54: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 59: warning: exported type KexAlgorithmsList should have comment or be unexported (golint)
- Line 67: warning: exported method KexAlgorithmsList.Set should have comment or be unexported (golint)
- Line 78: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 86: warning: exported method KexAlgorithmsList.Get should have comment or be unexported (golint)
- Line 89: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 94: warning: exported type CipherList should have comment or be unexported (golint)
- Line 102: warning: exported method CipherList.Set should have comment or be unexported (golint)
- Line 113: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 122: warning: exported method CipherList.Get should have comment or be unexported (golint)
- Line 125: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
zgrab/ztools/xssh/kex.go
- Line 72: warning: exported type PublicKeyJsonLog should have comment or be unexported (golint)
- Line 80: warning: exported method PublicKeyJsonLog.AddPublicKey should have comment or be unexported (golint)
- Line 107: warning: exported type ServerHostKeyJsonLog should have comment or be unexported (golint)
- Line 116: warning: exported function LogServerHostKey should have comment or be unexported (golint)
-
-
zgrab/zlib/http.go
- Line 26: warning: exported type UnknownHeader should have comment or be unexported (golint)
- Line 31: warning: exported type HTTPHeaders should have comment or be unexported (golint)
- Line 33: warning: exported function HeadersFromGolangHeaders should have comment or be unexported (golint)
- Line 61: warning: exported type HTTPRequest should have comment or be unexported (golint)
- Line 68: warning: exported type HTTPResponse should have comment or be unexported (golint)
- Line 78: warning: exported type HTTP should have comment or be unexported (golint)
-
-
zgrab/ztools/http/chunked.go
- Line 19: warning: exported var ErrLineTooLong should have comment or be unexported (golint)
-
-
zgrab/ztools/xssh/config.go
- Line 3: warning: exported function MakeXSSHConfig should have comment or be unexported (golint)
-
-
zgrab/ztools/xssh/agent/client.go
- Line 162: warning: exported method Key.MarshalJSON should have comment or be unexported (golint)
- Line 562: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
zgrab/ztools/http/transfer.go
- Line 451: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 647: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
zgrab/ztools/smb/encoder/encoder.go
- Line 37: warning: exported type BinaryMarshallable should have comment or be unexported (golint)
- Line 42: warning: exported type Metadata should have comment or be unexported (golint)
- Line 52: warning: exported type TagMap should have comment or be unexported (golint)
- Line 57: warning: exported method TagMap.Has should have comment or be unexported (golint)
- Line 61: warning: exported method TagMap.Set should have comment or be unexported (golint)
- Line 66: warning: exported method TagMap.Get should have comment or be unexported (golint)
- Line 70: warning: exported method TagMap.GetInt should have comment or be unexported (golint)
- Line 77: warning: exported method TagMap.GetString should have comment or be unexported (golint)
- Line 214: warning: exported function Marshal should have comment or be unexported (golint)
- Line 335: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
- Line 487: warning: exported function Unmarshal should have comment or be unexported (golint)
-
-
zgrab/ztools/scada/bacnet/query.go
- Line 5: warning: exported type ReadPropertyRequest should have comment or be unexported (golint)
- Line 11: warning: exported method ReadPropertyRequest.Marshal should have comment or be unexported (golint)
- Line 29: warning: exported function NewReadPropertyRequest should have comment or be unexported (golint)
-
-
zgrab/ztools/zct/x509/verify.go
- Line 16: warning: exported type InvalidReason should have comment or be unexported (golint)
-
-
zgrab/ztools/http/transport.go
- Line 1162: warning: don't use underscores in Go names; var no_proxy should be noProxy (golint)
-
-
zgrab/ztools/smb/gss/gss.go
- Line 34: warning: exported const SpnegoOid should have comment or be unexported (golint)
- Line 35: warning: exported const NtLmSSPMechTypeOid should have comment or be unexported (golint)
- Line 37: warning: exported const GssStateAcceptCompleted should have comment or be unexported (golint)
- Line 38: warning: exported const GssStateAcceptIncomplete should have comment or be unexported (golint)
- Line 39: warning: exported const GssStateReject should have comment or be unexported (golint)
- Line 40: warning: exported const GssStateRequestMic should have comment or be unexported (golint)
- Line 42: warning: exported type NegTokenInitData should have comment or be unexported (golint)
- Line 49: warning: exported type NegTokenInit should have comment or be unexported (golint)
- Line 54: warning: exported type NegTokenResp should have comment or be unexported (golint)
- Line 66: warning: exported function NewNegTokenInit should have comment or be unexported (golint)
- Line 86: warning: exported function NewNegTokenResp should have comment or be unexported (golint)
- Line 90: warning: exported method NegTokenInit.MarshalBinary should have comment or be unexported (golint)
- Line 103: warning: exported method NegTokenInit.UnmarshalBinary should have comment or be unexported (golint)
- Line 112: warning: exported method NegTokenResp.MarshalBinary should have comment or be unexported (golint)
- Line 120: warning: exported method NegTokenResp.UnmarshalBinary should have comment or be unexported (golint)
-
-
zgrab/ztools/scada/dnp3/crc16.go
- Line 51: warning: exported function Crc16 should have comment or be unexported (golint)
-
-
zgrab/ztools/xssh/test/test_unix_test.go
- Line 28: warning: don't use underscores in Go names; const sshd_config should be sshdConfig (golint)
-
-
zgrab/zlib/conn.go
- Line 43: warning: exported const SMTP_COMMAND should have comment (or a comment on this block) or be unexported (golint)
- Line 48: warning: comment on exported type Conn should be of the form "Conn ..." (with optional leading article) (golint)
- Line 90: warning: exported method Conn.SetExternalClientHello should have comment or be unexported (golint)
- Line 94: warning: exported method Conn.SetExtendedRandom should have comment or be unexported (golint)
- Line 98: warning: exported method Conn.SetCAPool should have comment or be unexported (golint)
- Line 102: warning: exported method Conn.SetDomain should have comment or be unexported (golint)
- Line 106: warning: exported method Conn.SetNoSNI should have comment or be unexported (golint)
- Line 110: warning: exported method Conn.SetGatherSessionTicket should have comment or be unexported (golint)
- Line 114: warning: exported method Conn.SetOfferExtendedMasterSecret should have comment or be unexported (golint)
- Line 118: warning: exported method Conn.SetSignedCertificateTimestampExt should have comment or be unexported (golint)
- Line 122: warning: exported method Conn.SetTLSVerbose should have comment or be unexported (golint)
- Line 126: warning: exported method Conn.SetTLSCertsOnly should have comment or be unexported (golint)
- Line 130: warning: comment on exported method Conn.LocalAddr should be of the form "LocalAddr ..." (golint)
- Line 135: warning: exported method Conn.RemoteAddr should have comment or be unexported (golint)
- Line 139: warning: exported method Conn.SetDeadline should have comment or be unexported (golint)
- Line 145: warning: exported method Conn.SetReadDeadline should have comment or be unexported (golint)
- Line 150: warning: exported method Conn.SetWriteDeadline should have comment or be unexported (golint)
- Line 162: warning: exported method Conn.BasicBanner should have comment or be unexported (golint)
- Line 175: warning: exported method Conn.Close should have comment or be unexported (golint)
- Line 288: warning: comment on exported method Conn.TLSHandshake should be of the form "TLSHandshake ..." (golint)
- Line 361: warning: comment on exported method Conn.SMTPStartTLSHandshake should be of the form "SMTPStartTLSHandshake ..." (golint)
- Line 394: warning: exported method Conn.POP3StartTLSHandshake should have comment or be unexported (golint)
- Line 414: warning: exported method Conn.IMAPStartTLSHandshake should have comment or be unexported (golint)
- Line 438: warning: exported method Conn.SMTPBanner should have comment or be unexported (golint)
- Line 444: warning: exported method Conn.EHLO should have comment or be unexported (golint)
- Line 456: warning: exported method Conn.SMTPHelp should have comment or be unexported (golint)
- Line 470: warning: exported method Conn.SMTPQuit should have comment or be unexported (golint)
- Line 480: warning: exported method Conn.POP3Banner should have comment or be unexported (golint)
- Line 486: warning: exported method Conn.POP3Quit should have comment or be unexported (golint)
- Line 496: warning: exported method Conn.IMAPBanner should have comment or be unexported (golint)
- Line 502: warning: exported method Conn.IMAPQuit should have comment or be unexported (golint)
- Line 508: warning: exported method Conn.CheckHeartbleed should have comment or be unexported (golint)
- Line 523: warning: exported method Conn.BACNetVendorQuery should have comment or be unexported (golint)
- Line 555: warning: exported method Conn.SendModbusEcho should have comment or be unexported (golint)
- Line 588: warning: exported method Conn.GetFTPSCertificates should have comment or be unexported (golint)
- Line 597: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
zgrab/ztools/http/export_test.go
- Line 110: warning: don't use underscores in Go names; method IdleConnStrsForTesting_h2 should be IdleConnStrsForTestingH2 (golint)
- Line 189: warning: don't use underscores in Go names; var Export_shouldCopyHeaderOnRedirect should be ExportShouldCopyHeaderOnRedirect (golint)
-
-
zgrab/ztools/xssh/keys.go
- Line 166: warning: comment on exported function ParseAuthorizedKey should be of the form "ParseAuthorizedKey ..." (golint)
- Line 294: warning: comment on exported type CryptoPublicKey should be of the form "CryptoPublicKey ..." (with optional leading article) (golint)
- Line 410: warning: receiver name k should be consistent with previous receiver name r for dsaPublicKey (golint)
- Line 427: warning: receiver name k should be consistent with previous receiver name r for dsaPublicKey (golint)
- Line 451: warning: receiver name k should be consistent with previous receiver name r for dsaPublicKey (golint)
- Line 561: warning: receiver name k should be consistent with previous receiver name key for ed25519PublicKey (golint)
- Line 660: warning: receiver name k should be consistent with previous receiver name key for ecdsaPublicKey (golint)
-
-
zgrab/ztools/scada/siemens/log.go
- Line 3: warning: exported type S7Log should have comment or be unexported (golint)
-
-
zgrab/ztools/zct/x509/pkix/pkix.go
- Line 25: warning: exported type RDNSequence should have comment or be unexported (golint)
- Line 27: warning: exported type RelativeDistinguishedNameSET should have comment or be unexported (golint)
- Line 55: warning: exported method Name.FillFromRDNSequence should have comment or be unexported (golint)
- Line 123: warning: exported method Name.ToRDNSequence should have comment or be unexported (golint)
-
-
zgrab/ztools/smb/smb.go
- Line 31: warning: exported const ProtocolSmb should have comment or be unexported (golint)
- Line 32: warning: exported const ProtocolSmb2 should have comment or be unexported (golint)
- Line 34: warning: exported const StatusOk should have comment or be unexported (golint)
- Line 35: warning: exported const StatusMoreProcessingRequired should have comment or be unexported (golint)
- Line 36: warning: exported const StatusInvalidParameter should have comment or be unexported (golint)
- Line 37: warning: exported const StatusLogonFailure should have comment or be unexported (golint)
- Line 38: warning: exported const StatusUserSessionDeleted should have comment or be unexported (golint)
- Line 40: warning: exported var StatusMap should have comment or be unexported (golint)
- Line 48: warning: don't use underscores in Go names; const DialectSmb_2_0_2 should be DialectSmb2_0_2 (golint)
- Line 48: warning: exported const DialectSmb_2_0_2 should have comment or be unexported (golint)
- Line 49: warning: don't use underscores in Go names; const DialectSmb_2_1 should be DialectSmb2_1 (golint)
- Line 49: warning: exported const DialectSmb_2_1 should have comment or be unexported (golint)
- Line 50: warning: don't use underscores in Go names; const DialectSmb_3_0 should be DialectSmb3_0 (golint)
- Line 50: warning: exported const DialectSmb_3_0 should have comment or be unexported (golint)
- Line 51: warning: don't use underscores in Go names; const DialectSmb_3_0_2 should be DialectSmb3_0_2 (golint)
- Line 51: warning: exported const DialectSmb_3_0_2 should have comment or be unexported (golint)
- Line 52: warning: don't use underscores in Go names; const DialectSmb_3_1_1 should be DialectSmb3_1_1 (golint)
- Line 52: warning: exported const DialectSmb_3_1_1 should have comment or be unexported (golint)
- Line 53: warning: don't use underscores in Go names; const DialectSmb2_ALL should be DialectSmb2ALL (golint)
- Line 53: warning: exported const DialectSmb2_ALL should have comment or be unexported (golint)
- Line 56: warning: exported const CommandNegotiate should have comment (or a comment on this block) or be unexported (golint)
- Line 79: warning: exported const SecurityModeSigningEnabled should have comment (or a comment on this block) or be unexported (golint)
- Line 85: warning: exported const ShareTypeDisk should have comment (or a comment on this block) or be unexported (golint)
- Line 91: warning: exported const ShareFlagManualCaching should have comment (or a comment on this block) or be unexported (golint)
- Line 108: warning: exported const ShareCapDFS should have comment (or a comment on this block) or be unexported (golint)
- Line 115: warning: exported type Header should have comment or be unexported (golint)
- Line 131: warning: exported type NegotiateReq should have comment or be unexported (golint)
- Line 143: warning: exported type NegotiateRes should have comment or be unexported (golint)
- Line 180: warning: exported method Session.NewNegotiateReq should have comment or be unexported (golint)
- Line 202: warning: exported function NewNegotiateRes should have comment or be unexported (golint)
-
-
zgrab/ztools/scada/bacnet/common.go
- Line 9: warning: exported const MAX_BACNET_FRAME_LEN should have comment (or a comment on this block) or be unexported (golint)
- Line 35: warning: exported function SendVLC should have comment or be unexported (golint)
- Line 52: warning: error should be the last type when returning multiple items (golint)
- Line 52: warning: exported function ReadVLC should have comment or be unexported (golint)
-
-
zgrab/ztools/zct/x509/pem_decrypt.go
- Line 23: warning: exported type PEMCipher should have comment or be unexported (golint)
- Line 105: warning: error var IncorrectPasswordError should have name of the form ErrFoo (golint)
-
-
zgrab/ztools/http/protocol.go
- Line 3: warning: exported type Protocol should have comment or be unexported (golint)
-
-
zgrab/ztools/http/response.go
- Line 29: warning: exported type PageFingerprint should have comment or be unexported (golint)
-
-
zgrab/ztools/scada/dnp3/dnp3.go
- Line 62: warning: exported function GetDNP3Banner should have comment or be unexported (golint)
-
-
zgrab/ztools/scada/dnp3/log.go
- Line 3: warning: exported type DNP3Log should have comment or be unexported (golint)
-
-
zgrab/ztools/xssh/test/cert_test.go
- Line 16: warning: don't use underscores in Go names; func DISABLED_TestCertLogin should be DISABLEDTestCertLogin (golint)
-
-
zgrab/ztools/http/client.go
- Line 144: warning: exported function MakeNewClient should have comment or be unexported (golint)
- Line 368: warning: exported method Client.Get should have comment or be unexported (golint)
- Line 372: warning: comment on exported method Client.GetWithHost should be of the form "GetWithHost ..." (golint)
- Line 784: warning: comment on exported method Client.HeadWithHost should be of the form "HeadWithHost ..." (golint)
- Line 801: warning: exported method Client.Head should have comment or be unexported (golint)
-
-
zgrab/ztools/http/fs.go
- Line 36: warning: exported method Dir.Open should have comment or be unexported (golint)
- Line 429: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 493: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
zgrab/ztools/xssh/doc.go
- Line 5: warning: package comment should be of the form "Package xssh ..." (golint)
-
-
zgrab/ztools/xssh/server.go
- Line 43: warning: exported type JsonCriticalOptions should have comment or be unexported (golint)
- Line 47: warning: exported method JsonCriticalOptions.MarshalJSON should have comment or be unexported (golint)
- Line 79: warning: exported type JsonExtensions should have comment or be unexported (golint)
- Line 83: warning: exported method JsonExtensions.MarshalJSON should have comment or be unexported (golint)
-
-
zgrab/ztools/smb/log.go
- Line 3: warning: exported type SMBLog should have comment or be unexported (golint)
-
-
zgrab/ztools/scada/siemens/common.go
- Line 11: warning: exported type S7Error should have comment or be unexported (golint)
- Line 14: warning: exported var S7_ERROR_CODES should have comment or be unexported (golint)
- Line 24: warning: exported method S7Error.New should have comment or be unexported (golint)
-
-
zgrab/ztools/xssh/test/forward_unix_test.go
- Line 19: warning: don't use underscores in Go names; func DISABLED_TestPortForward should be DISABLEDTestPortForward (golint)
- Line 96: warning: don't use underscores in Go names; func DISABLED_TestAcceptClose should be DISABLEDTestAcceptClose (golint)
- Line 128: warning: don't use underscores in Go names; func DISABLED_TestPortForwardConnectionClose should be DISABLEDTestPortForwardConnectionClose (golint)
-
-
zgrab/ztools/xssh/test/tcpip_test.go
- Line 17: warning: don't use underscores in Go names; func DISABLED_TestDial should be DISABLEDTestDial (golint)
-
-
zgrab/zlib/config.go
- Line 24: warning: exported type HTTPConfig should have comment or be unexported (golint)
- Line 34: warning: exported type XSSHScanConfig should have comment or be unexported (golint)
- Line 38: warning: exported type SMBScanConfig should have comment or be unexported (golint)
- Line 43: warning: exported type Config should have comment or be unexported (golint)
-
-
zgrab/ztools/xssh/common.go
- Line 15: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
-
-
zgrab/ztools/processing/input.go
- Line 23: warning: exported type Decoder should have comment or be unexported (golint)
- Line 27: warning: exported type Marshaler should have comment or be unexported (golint)
- Line 31: warning: exported type Worker should have comment or be unexported (golint)
- Line 40: warning: exported type Handler should have comment or be unexported (golint)
- Line 42: warning: exported function Process should have comment or be unexported (golint)
-
-
zgrab/ztools/xssh/terminal/terminal.go
- Line 808: warning: exported method Terminal.SetSize should have comment or be unexported (golint)
-
-
zgrab/ztools/scada/fox/log.go
- Line 3: warning: exported type FoxLog should have comment or be unexported (golint)
-
-
zgrab/ztools/http/server.go
- Line 1526: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 2384: warning: receiver name s should be consistent with previous receiver name srv for Server (golint)
- Line 2390: warning: receiver name s should be consistent with previous receiver name srv for Server (golint)
- Line 2397: warning: receiver name s should be consistent with previous receiver name srv for Server (golint)
- Line 2475: warning: receiver name s should be consistent with previous receiver name srv for Server (golint)
- Line 2491: warning: receiver name s should be consistent with previous receiver name srv for Server (golint)
- Line 2612: warning: exported var ErrServerClosed should have comment or be unexported (golint)
- Line 2672: warning: receiver name s should be consistent with previous receiver name srv for Server (golint)
- Line 2690: warning: receiver name s should be consistent with previous receiver name srv for Server (golint)
- Line 2703: warning: receiver name s should be consistent with previous receiver name srv for Server (golint)
- Line 2710: warning: receiver name s should be consistent with previous receiver name srv for Server (golint)
- Line 2717: warning: receiver name s should be consistent with previous receiver name srv for Server (golint)
- Line 2721: warning: receiver name s should be consistent with previous receiver name srv for Server (golint)
- Line 2749: warning: receiver name s should be consistent with previous receiver name srv for Server (golint)
- Line 2876: warning: don't use underscores in Go names; method setupHTTP2_ListenAndServeTLS should be setupHTTP2ListenAndServeTLS (golint)
- Line 2889: warning: don't use underscores in Go names; method setupHTTP2_Serve should be setupHTTP2Serve (golint)
- Line 2894: warning: don't use underscores in Go names; method onceSetNextProtoDefaults_Serve should be onceSetNextProtoDefaultsServe (golint)
gocyclo78%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
zgrab/ztools/http/fs.go
- Line 152: warning: cyclomatic complexity 20 of function serveContent() is high (> 15) (gocyclo)
- Line 709: warning: cyclomatic complexity 18 of function parseRange() is high (> 15) (gocyclo)
-
-
zgrab/ztools/zct/asn1/asn1.go
- Line 575: warning: cyclomatic complexity 90 of function parseField() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/httputil/dump.go
- Line 192: warning: cyclomatic complexity 18 of function DumpRequest() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/transfer.go
- Line 404: warning: cyclomatic complexity 25 of function readTransfer() is high (> 15) (gocyclo)
- Line 300: warning: cyclomatic complexity 17 of function (*transferWriter).WriteBody() is high (> 15) (gocyclo)
- Line 71: warning: cyclomatic complexity 17 of function newTransferWriter() is high (> 15) (gocyclo)
- Line 588: warning: cyclomatic complexity 16 of function fixLength() is high (> 15) (gocyclo)
-
-
zgrab/ztools/xssh/handshake.go
- Line 337: warning: cyclomatic complexity 24 of function (*handshakeTransport).enterKeyExchangeLocked() is high (> 15) (gocyclo)
-
-
zgrab/ztools/xssh/certs.go
- Line 455: warning: cyclomatic complexity 20 of function (*CertChecker).CheckCert() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/transport_test.go
- Line 765: warning: cyclomatic complexity 22 of function TestTransportGzip() is high (> 15) (gocyclo)
-
-
zgrab/main.go
- Line 63: warning: cyclomatic complexity 66 of function init() is high (> 15) (gocyclo)
-
-
zgrab/ztools/zct/x509/pkix/pkix.go
- Line 55: warning: cyclomatic complexity 17 of function (*Name).FillFromRDNSequence() is high (> 15) (gocyclo)
-
-
zgrab/ztools/zct/x509/verify_test.go
- Line 302: warning: cyclomatic complexity 25 of function testVerify() is high (> 15) (gocyclo)
-
-
zgrab/ztools/zct/asn1/common.go
- Line 87: warning: cyclomatic complexity 16 of function parseFieldParameters() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/httputil/non1.go
- Line 35: warning: cyclomatic complexity 23 of function TestReverseProxy() is high (> 15) (gocyclo)
-
-
zgrab/ztools/zct/x509/x509_test.go
- Line 298: warning: cyclomatic complexity 25 of function TestCreateSelfSignedCertificate() is high (> 15) (gocyclo)
-
-
zgrab/ztools/zct/x509/verify.go
- Line 148: warning: cyclomatic complexity 18 of function (*Certificate).isValid() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/client_test.go
- Line 208: warning: cyclomatic complexity 19 of function TestClientRedirects() is high (> 15) (gocyclo)
-
-
zgrab/ztools/telnet/telnet.go
- Line 119: warning: cyclomatic complexity 16 of function NegotiateOptions() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/cookiejar/punycode.go
- Line 34: warning: cyclomatic complexity 17 of function encode() is high (> 15) (gocyclo)
-
-
zgrab/ztools/zct/asn1/marshal.go
- Line 468: warning: cyclomatic complexity 28 of function marshalField() is high (> 15) (gocyclo)
- Line 378: warning: cyclomatic complexity 24 of function marshalBody() is high (> 15) (gocyclo)
- Line 298: warning: cyclomatic complexity 18 of function marshalUTCTime() is high (> 15) (gocyclo)
-
-
zgrab/zlib/grabber.go
- Line 369: warning: cyclomatic complexity 69 of function makeGrabber() is high (> 15) (gocyclo)
- Line 239: warning: cyclomatic complexity 29 of function makeHTTPGrabber() is high (> 15) (gocyclo)
- Line 148: warning: cyclomatic complexity 17 of function makeTLSConfig() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/request.go
- Line 529: warning: cyclomatic complexity 35 of function (*Request).write() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/serve_test.go
- Line 2983: warning: cyclomatic complexity 21 of function TestHeaderToWire() is high (> 15) (gocyclo)
- Line 3621: warning: cyclomatic complexity 19 of function TestServerConnState() is high (> 15) (gocyclo)
- Line 4604: warning: cyclomatic complexity 16 of function BenchmarkClient() is high (> 15) (gocyclo)
- Line 1359: warning: cyclomatic complexity 16 of function TestServerExpect() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/httputil/non.go
- Line 132: warning: cyclomatic complexity 26 of function (*ReverseProxy).ServeHTTP() is high (> 15) (gocyclo)
-
-
zgrab/ztools/zct/x509/x509.go
- Line 846: warning: cyclomatic complexity 63 of function parseCertificate() is high (> 15) (gocyclo)
- Line 1252: warning: cyclomatic complexity 47 of function buildExtensions() is high (> 15) (gocyclo)
- Line 1457: warning: cyclomatic complexity 20 of function CreateCertificate() is high (> 15) (gocyclo)
- Line 631: warning: cyclomatic complexity 18 of function (*Certificate).CheckSignature() is high (> 15) (gocyclo)
- Line 742: warning: cyclomatic complexity 17 of function parsePublicKey() is high (> 15) (gocyclo)
-
-
zgrab/ztools/xssh/server.go
- Line 341: warning: cyclomatic complexity 44 of function (*connection).serverAuthenticate() is high (> 15) (gocyclo)
-
-
zgrab/ztools/xssh/messages.go
- Line 336: warning: cyclomatic complexity 35 of function Unmarshal() is high (> 15) (gocyclo)
- Line 738: warning: cyclomatic complexity 26 of function decode() is high (> 15) (gocyclo)
- Line 464: warning: cyclomatic complexity 23 of function marshalStruct() is high (> 15) (gocyclo)
-
-
zgrab/ztools/xssh/client_auth.go
- Line 362: warning: cyclomatic complexity 20 of function (KeyboardInteractiveChallenge).auth() is high (> 15) (gocyclo)
- Line 15: warning: cyclomatic complexity 16 of function (*connection).clientAuthenticate() is high (> 15) (gocyclo)
-
-
zgrab/ztools/scada/fox/fox.go
- Line 43: warning: cyclomatic complexity 45 of function GetFoxBanner() is high (> 15) (gocyclo)
-
-
zgrab/ztools/zct/client/logclient.go
- Line 211: warning: cyclomatic complexity 16 of function (*LogClient).addChainWithRetry() is high (> 15) (gocyclo)
-
-
zgrab/ztools/xssh/agent/server.go
- Line 76: warning: cyclomatic complexity 19 of function (*server).processRequest() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/response_test.go
- Line 636: warning: cyclomatic complexity 18 of function TestReadResponseCloseInMiddle() is high (> 15) (gocyclo)
-
-
zgrab/ztools/xssh/example_test.go
- Line 19: warning: cyclomatic complexity 18 of function ExampleNewServerConn() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/server.go
- Line 1131: warning: cyclomatic complexity 72 of function (*chunkWriter).writeHeader() is high (> 15) (gocyclo)
- Line 1715: warning: cyclomatic complexity 29 of function (*conn).serve() is high (> 15) (gocyclo)
- Line 905: warning: cyclomatic complexity 23 of function (*conn).readRequest() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/fs_test.go
- Line 71: warning: cyclomatic complexity 24 of function TestServeFile() is high (> 15) (gocyclo)
-
-
zgrab/ztools/smb/encoder/encoder.go
- Line 218: warning: cyclomatic complexity 39 of function marshal() is high (> 15) (gocyclo)
- Line 340: warning: cyclomatic complexity 32 of function unmarshal() is high (> 15) (gocyclo)
- Line 151: warning: cyclomatic complexity 21 of function getFieldLengthByName() is high (> 15) (gocyclo)
-
-
zgrab/ztools/xssh/terminal/terminal.go
- Line 143: warning: cyclomatic complexity 42 of function bytesToKey() is high (> 15) (gocyclo)
- Line 433: warning: cyclomatic complexity 36 of function (*Terminal).handleKey() is high (> 15) (gocyclo)
- Line 699: warning: cyclomatic complexity 18 of function (*Terminal).readLine() is high (> 15) (gocyclo)
-
-
zgrab/ztools/xssh/mux_test.go
- Line 295: warning: cyclomatic complexity 16 of function TestMuxGlobalRequest() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/response.go
- Line 247: warning: cyclomatic complexity 24 of function (*Response).Write() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/cookie.go
- Line 41: warning: cyclomatic complexity 24 of function readSetCookies() is high (> 15) (gocyclo)
- Line 258: warning: cyclomatic complexity 21 of function isCookieDomainName() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/httptest/recorder_test.go
- Line 15: warning: cyclomatic complexity 16 of function TestRecorder() is high (> 15) (gocyclo)
-
-
zgrab/ztools/xssh/keys.go
- Line 168: warning: cyclomatic complexity 26 of function ParseAuthorizedKey() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/transport.go
- Line 971: warning: cyclomatic complexity 42 of function (*Transport).dialConn() is high (> 15) (gocyclo)
- Line 1443: warning: cyclomatic complexity 41 of function (*persistConn).readLoop() is high (> 15) (gocyclo)
- Line 869: warning: cyclomatic complexity 24 of function (*Transport).getConn() is high (> 15) (gocyclo)
- Line 319: warning: cyclomatic complexity 23 of function (*Transport).RoundTrip() is high (> 15) (gocyclo)
- Line 1825: warning: cyclomatic complexity 23 of function (*persistConn).roundTrip() is high (> 15) (gocyclo)
- Line 1145: warning: cyclomatic complexity 18 of function useProxy() is high (> 15) (gocyclo)
- Line 657: warning: cyclomatic complexity 17 of function (*Transport).tryPutIdleConn() is high (> 15) (gocyclo)
-
-
zgrab/ztools/http/client.go
- Line 492: warning: cyclomatic complexity 23 of function (*Client).Do() is high (> 15) (gocyclo)
-
-
zgrab/ztools/xssh/agent/client_test.go
- Line 251: warning: cyclomatic complexity 16 of function testLockAgent() is high (> 15) (gocyclo)
-
-
zgrab/ztools/xssh/buffer_test.go
- Line 46: warning: cyclomatic complexity 20 of function TestBufferClose() is high (> 15) (gocyclo)
-
-
zgrab/ztools/xssh/client.go
- Line 86: warning: cyclomatic complexity 16 of function (*connection).clientHandshake() is high (> 15) (gocyclo)
ineffassign96%
IneffAssign detects ineffectual assignments in Go code.
-
-
zgrab/ztools/zct/x509/verify.go
- Line 109: warning: ineffectual assignment to certName (ineffassign)
-
-
zgrab/ztools/http/serve_test.go
- Line 4234: warning: ineffectual assignment to err (ineffassign)
-
-
zgrab/ztools/http/transport_test.go
- Line 734: warning: ineffectual assignment to err (ineffassign)
-
-
zgrab/zlib/conn.go
- Line 566: warning: ineffectual assignment to err (ineffassign)
-
-
zgrab/zlib/modbus.go
- Line 232: warning: ineffectual assignment to cnt (ineffassign)
-
-
zgrab/ztools/zct/client/logclient.go
- Line 377: warning: ineffectual assignment to err (ineffassign)
-
-
zgrab/ztools/telnet/telnet.go
- Line 142: warning: ineffectual assignment to firstUnreadIndex (ineffassign)
- Line 150: warning: ineffectual assignment to firstUnreadIndex (ineffassign)
-
-
zgrab/ztools/zct/asn1/marshal.go
- Line 559: warning: ineffectual assignment to err (ineffassign)