gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• certificate-transparency-go/asn1/asn1_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo87%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• certificate-transparency-go/loglist/findlog/main.go
  • Line 42: warning: cyclomatic complexity 18 of function main() is high (> 15) (gocyclo)

• certificate-transparency-go/gossip/minimal/instance.go
  • Line 87: warning: cyclomatic complexity 28 of function NewBoundaryGossiper() is high (> 15) (gocyclo)

• certificate-transparency-go/x509/names.go
  • Line 96: warning: cyclomatic complexity 19 of function parseGeneralName() is high (> 15) (gocyclo)

• certificate-transparency-go/trillian/integration/ct_hammer/main.go
  • Line 175: warning: cyclomatic complexity 19 of function main() is high (> 15) (gocyclo)

• certificate-transparency-go/x509/x509_test.go
  • Line 648: warning: cyclomatic complexity 55 of function TestCreateSelfSignedCertificate() is high (> 15) (gocyclo)
  • Line 229: warning: cyclomatic complexity 16 of function TestMarshalRSAPublicKey() is high (> 15) (gocyclo)

• certificate-transparency-go/tls/signature.go
  • Line 66: warning: cyclomatic complexity 20 of function VerifySignature() is high (> 15) (gocyclo)

• certificate-transparency-go/x509util/x509util.go
  • Line 43: warning: cyclomatic complexity 22 of function OIDForStandardExtension() is high (> 15) (gocyclo)
  • Line 255: warning: cyclomatic complexity 19 of function attributeOIDToString() is high (> 15) (gocyclo)
  • Line 297: warning: cyclomatic complexity 18 of function NameToString() is high (> 15) (gocyclo)
  • Line 776: warning: cyclomatic complexity 17 of function oidAlreadyPrinted() is high (> 15) (gocyclo)

• certificate-transparency-go/trillian/ctfe/ct_server/main.go
  • Line 75: warning: cyclomatic complexity 21 of function main() is high (> 15) (gocyclo)

• certificate-transparency-go/x509/verify.go
  • Line 235: warning: cyclomatic complexity 65 of function parseRFC2821Mailbox() is high (> 15) (gocyclo)
  • Line 570: warning: cyclomatic complexity 43 of function (*Certificate).isValid() is high (> 15) (gocyclo)
  • Line 733: warning: cyclomatic complexity 21 of function (*Certificate).Verify() is high (> 15) (gocyclo)
  • Line 818: warning: cyclomatic complexity 17 of function (*Certificate).buildChains() is high (> 15) (gocyclo)
  • Line 889: warning: cyclomatic complexity 17 of function validHostname() is high (> 15) (gocyclo)

• certificate-transparency-go/x509/verify_test.go
  • Line 588: warning: cyclomatic complexity 25 of function testVerify() is high (> 15) (gocyclo)

• certificate-transparency-go/x509/error.go
  • Line 106: warning: cyclomatic complexity 16 of function (ErrCategory).String() is high (> 15) (gocyclo)

• certificate-transparency-go/trillian/integration/ct_integration.go
  • Line 257: warning: cyclomatic complexity 64 of function RunCTIntegrationForLog() is high (> 15) (gocyclo)
  • Line 604: warning: cyclomatic complexity 32 of function RunCTLifecycleForLog() is high (> 15) (gocyclo)

• certificate-transparency-go/asn1/common.go
  • Line 95: warning: cyclomatic complexity 22 of function parseFieldParameters() is high (> 15) (gocyclo)

• certificate-transparency-go/x509/x509.go
  • Line 1806: warning: cyclomatic complexity 75 of function parseCertificate() is high (> 15) (gocyclo)
  • Line 2288: warning: cyclomatic complexity 75 of function buildExtensions() is high (> 15) (gocyclo)
  • Line 1646: warning: cyclomatic complexity 39 of function parseNameConstraintsExtension() is high (> 15) (gocyclo)
  • Line 1333: warning: cyclomatic complexity 29 of function parsePublicKey() is high (> 15) (gocyclo)
  • Line 3039: warning: cyclomatic complexity 29 of function CreateCertificateRequest() is high (> 15) (gocyclo)
  • Line 1053: warning: cyclomatic complexity 28 of function checkSignature() is high (> 15) (gocyclo)
  • Line 510: warning: cyclomatic complexity 21 of function SignatureAlgorithmFromAI() is high (> 15) (gocyclo)
  • Line 2600: warning: cyclomatic complexity 18 of function signingParamsForPublicKey() is high (> 15) (gocyclo)
  • Line 1219: warning: cyclomatic complexity 16 of function BuildPrecertTBS() is high (> 15) (gocyclo)

• certificate-transparency-go/tls/tls.go
  • Line 525: warning: cyclomatic complexity 39 of function marshalField() is high (> 15) (gocyclo)
  • Line 314: warning: cyclomatic complexity 36 of function parseField() is high (> 15) (gocyclo)
  • Line 208: warning: cyclomatic complexity 24 of function fieldTagToFieldInfo() is high (> 15) (gocyclo)

• certificate-transparency-go/client/ctclient/ctclient.go
  • Line 453: warning: cyclomatic complexity 31 of function main() is high (> 15) (gocyclo)

• certificate-transparency-go/asn1/asn1.go
  • Line 741: warning: cyclomatic complexity 100 of function parseField() is high (> 15) (gocyclo)
  • Line 474: warning: cyclomatic complexity 18 of function isPrintable() is high (> 15) (gocyclo)

• certificate-transparency-go/gossip/minimal/goshawk.go
  • Line 362: warning: cyclomatic complexity 17 of function NewBoundaryGoshawk() is high (> 15) (gocyclo)

• certificate-transparency-go/fixchain/roundtrip_test.go
  • Line 41: warning: cyclomatic complexity 22 of function (testRoundTripper).RoundTrip() is high (> 15) (gocyclo)

• certificate-transparency-go/fixchain/fix_error.go
  • Line 50: warning: cyclomatic complexity 16 of function (FixError).Equal() is high (> 15) (gocyclo)

• certificate-transparency-go/x509/root_darwin_test.go
  • Line 17: warning: cyclomatic complexity 24 of function TestSystemRoots() is high (> 15) (gocyclo)

• certificate-transparency-go/x509/root_unix.go
  • Line 38: warning: cyclomatic complexity 17 of function loadSystemRoots() is high (> 15) (gocyclo)

• certificate-transparency-go/jsonclient/client_test.go
  • Line 129: warning: cyclomatic complexity 20 of function MockServer() is high (> 15) (gocyclo)

• certificate-transparency-go/x509/pkix/pkix.go
  • Line 134: warning: cyclomatic complexity 18 of function (*Name).FillFromRDNSequence() is high (> 15) (gocyclo)

• certificate-transparency-go/x509util/revoked.go
  • Line 57: warning: cyclomatic complexity 19 of function CRLToString() is high (> 15) (gocyclo)

• certificate-transparency-go/trillian/integration/copier.go
  • Line 78: warning: cyclomatic complexity 16 of function NewCopyChainGeneratorFromOpts() is high (> 15) (gocyclo)

• certificate-transparency-go/asn1/marshal.go
  • Line 532: warning: cyclomatic complexity 38 of function makeField() is high (> 15) (gocyclo)
  • Line 417: warning: cyclomatic complexity 34 of function makeBody() is high (> 15) (gocyclo)

• certificate-transparency-go/x509/revoked.go
  • Line 151: warning: cyclomatic complexity 38 of function ParseCertificateListDER() is high (> 15) (gocyclo)
  • Line 320: warning: cyclomatic complexity 17 of function parseRevokedCertificate() is high (> 15) (gocyclo)

• certificate-transparency-go/x509/name_constraints_test.go
  • Line 1865: warning: cyclomatic complexity 25 of function TestConstraintCases() is high (> 15) (gocyclo)
  • Line 1770: warning: cyclomatic complexity 19 of function addConstraintsToTemplate() is high (> 15) (gocyclo)
  • Line 1654: warning: cyclomatic complexity 16 of function makeConstraintsLeafCert() is high (> 15) (gocyclo)

golint98%

Golint is a linter for Go source code.

• certificate-transparency-go/x509/pkix/pkix.go
  • Line 25: warning: exported type RDNSequence should have comment or be unexported (golint)
  • Line 96: warning: exported type RelativeDistinguishedNameSET should have comment or be unexported (golint)
  • Line 134: warning: exported method Name.FillFromRDNSequence should have comment or be unexported (golint)
  • Line 175: warning: exported var OIDAttribute should have comment or be unexported (golint)
  • Line 214: warning: exported method Name.ToRDNSequence should have comment or be unexported (golint)

• certificate-transparency-go/x509/pem_decrypt.go
  • Line 23: warning: exported type PEMCipher should have comment or be unexported (golint)
  • Line 105: warning: error var IncorrectPasswordError should have name of the form ErrFoo (golint)

• certificate-transparency-go/x509/verify.go
  • Line 24: warning: exported type InvalidReason should have comment or be unexported (golint)

• certificate-transparency-go/x509/x509.go
  • Line 57: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 1087: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 2236: warning: exported var OIDAuthorityInfoAccessOCSP should have comment or be unexported (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!