Preparing report...

Report for github.jparrowsec.cn/skydive-project/skydive

(v0.28.0)

A    Great!    Found 116 issues across 340 files

Tweet

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gofmt72%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


gocyclo88%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • topology/probes/ovsdb/ovsdb.go
    • Line 316: warning: cyclomatic complexity 45 of function (*Probe).OnOvsInterfaceAdd() is high (> 15) (gocyclo)
    • Line 553: warning: cyclomatic complexity 26 of function (*Probe).OnOvsPortAdd() is high (> 15) (gocyclo)
    • Line 119: warning: cyclomatic complexity 17 of function (*Probe).OnOvsBridgeAdd() is high (> 15) (gocyclo)
    • flow/set.go
    • Line 155: warning: cyclomatic complexity 23 of function (*FlowSet).mergeSortedFlows() is high (> 15) (gocyclo)
    • topology/probes/ovsdb/ofctl.go
    • Line 667: warning: cyclomatic complexity 18 of function (*OfctlProbe).MonitorGroup() is high (> 15) (gocyclo)
    • Line 590: warning: cyclomatic complexity 17 of function (*OfctlProbe).Monitor() is high (> 15) (gocyclo)
    • tests/flow_test.go
    • Line 531: warning: cyclomatic complexity 39 of function TestFlowMetrics() is high (> 15) (gocyclo)
    • Line 878: warning: cyclomatic complexity 18 of function TestIPv6FlowHopsIPv6() is high (> 15) (gocyclo)
    • Line 697: warning: cyclomatic complexity 16 of function TestFlowMetricsStep() is high (> 15) (gocyclo)
    • ovs/ovsdb/ovsdb.go
    • Line 460: warning: cyclomatic complexity 16 of function (*OvsMonitor).setMonitorRequests() is high (> 15) (gocyclo)
    • tests/scale_test.go
    • Line 289: warning: cyclomatic complexity 28 of function TestScaleHA() is high (> 15) (gocyclo)
    • Line 174: warning: cyclomatic complexity 17 of function checkIPerfFlows() is high (> 15) (gocyclo)
    • flow/flow.go
    • Line 1361: warning: cyclomatic complexity 25 of function (*Flow).GetFieldInt64() is high (> 15) (gocyclo)
    • Line 919: warning: cyclomatic complexity 21 of function (*Flow).updateTCPMetrics() is high (> 15) (gocyclo)
    • Line 1294: warning: cyclomatic complexity 21 of function (*Flow).GetFieldString() is high (> 15) (gocyclo)
    • Line 1121: warning: cyclomatic complexity 18 of function PacketSeqFromGoPacket() is high (> 15) (gocyclo)
    • Line 685: warning: cyclomatic complexity 18 of function (*Flow).updateRTT() is high (> 15) (gocyclo)
    • Line 313: warning: cyclomatic complexity 16 of function (*Packet).Keys() is high (> 15) (gocyclo)
    • Line 754: warning: cyclomatic complexity 16 of function (*Flow).isABPacket() is high (> 15) (gocyclo)
    • flow/flow_test.go
    • Line 1124: warning: cyclomatic complexity 41 of function compareDNSLayer() is high (> 15) (gocyclo)
    • Line 1170: warning: cyclomatic complexity 25 of function compareFlow() is high (> 15) (gocyclo)
    • Line 1096: warning: cyclomatic complexity 22 of function compareDNSResourceRecords() is high (> 15) (gocyclo)
    • flow/table.go
    • Line 531: warning: cyclomatic complexity 16 of function (*Table).Run() is high (> 15) (gocyclo)
    • topology/probes/netlink/netlink.go
    • Line 453: warning: cyclomatic complexity 35 of function (*Probe).addLinkToTopology() is high (> 15) (gocyclo)
    • Line 1128: warning: cyclomatic complexity 17 of function (*Probe).onMessageAvailable() is high (> 15) (gocyclo)
    • sflow/agent.go
    • Line 74: warning: cyclomatic complexity 23 of function (*Agent).feedFlowTable() is high (> 15) (gocyclo)
    • flow/ebpf.go
    • Line 110: warning: cyclomatic complexity 19 of function (*Table).newFlowFromEBPF() is high (> 15) (gocyclo)
    • packetinjector/client.go
    • Line 77: warning: cyclomatic complexity 31 of function (*onDemandPacketInjectionHandler).createRequest() is high (> 15) (gocyclo)
    • tests/api_test.go
    • Line 734: warning: cyclomatic complexity 21 of function TestAPIPatchEdgeTable() is high (> 15) (gocyclo)
    • Line 247: warning: cyclomatic complexity 16 of function TestAPIPatchNodeTable() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!