Report for gitlab.com/dcomptb/cogs
A Great! Found 42 issues across 59 files
gofmt93%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
/gitlab.com/dcomptb/cogs/fabric/linkplan.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
/gitlab.com/dcomptb/cogs/util/cogctl/mz.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
/gitlab.com/dcomptb/cogs/model-test/hw.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
/gitlab.com/dcomptb/cogs/pkg/task.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
golint32%
Golint is a linter for Go source code.
-
-
/gitlab.com/dcomptb/cogs/rex/sled.go
- Line 228: warning: exported const Timeout should have comment (or a comment on this block) or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/foundry.go
- Line 16: warning: exported const FoundryNamespace should have comment (or a comment on this block) or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/merge.go
- Line 21: warning: exported function HandleIncoming should have comment or be unexported (golint)
- Line 55: warning: exported function HandleStatus should have comment or be unexported (golint)
- Line 66: warning: exported function HandleNodeSetup should have comment or be unexported (golint)
- Line 77: warning: exported function HandleLinkCreate should have comment or be unexported (golint)
- Line 88: warning: exported function HandleNodeRecycle should have comment or be unexported (golint)
- Line 99: warning: exported function HandleLinkDestroy should have comment or be unexported (golint)
- Line 110: warning: exported function RegisterWithCommander should have comment or be unexported (golint)
- Line 141: warning: exported function CommanderClient should have comment or be unexported (golint)
- Line 162: warning: exported function Cmdr should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/nex.go
- Line 8: warning: exported const NexNamespace should have comment (or a comment on this block) or be unexported (golint)
- Line 16: warning: exported type NexNetworkSpec should have comment or be unexported (golint)
- Line 24: warning: exported type NexMemberSpec should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/test/v1/xir/tb.go
- Line 9: warning: exported type Testbed should have comment or be unexported (golint)
- Line 19: warning: exported method Testbed.Components should have comment or be unexported (golint)
- Line 110: warning: exported method Testbed.Cable should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/model-test/hw.go
- Line 9: warning: exported function MinnowBoard should have comment or be unexported (golint)
- Line 38: warning: exported function RccVe should have comment or be unexported (golint)
- Line 77: warning: exported function XPort should have comment or be unexported (golint)
- Line 95: warning: exported function Moa1000 should have comment or be unexported (golint)
- Line 133: warning: exported function RSled1000 should have comment or be unexported (golint)
- Line 162: warning: exported function DComp1000 should have comment or be unexported (golint)
- Line 190: warning: exported function EdgecoreAS4610 should have comment or be unexported (golint)
- Line 227: warning: exported function QuantaLYR4 should have comment or be unexported (golint)
- Line 264: warning: exported function Msn2100 should have comment or be unexported (golint)
- Line 293: warning: exported function Msn2700 should have comment or be unexported (golint)
- Line 322: warning: exported function Zpe96 should have comment or be unexported (golint)
- Line 348: warning: exported function AtomE3845 should have comment or be unexported (golint)
- Line 366: warning: exported function AtomC2558 should have comment or be unexported (golint)
- Line 384: warning: exported function Epyc7351 should have comment or be unexported (golint)
- Line 402: warning: exported function Epyc7301 should have comment or be unexported (golint)
- Line 420: warning: exported function Epyc7281 should have comment or be unexported (golint)
- Line 438: warning: exported function I210AT should have comment or be unexported (golint)
- Line 456: warning: exported function I350_DA4 should have comment or be unexported (golint)
- Line 474: warning: exported function ConnectX4_2x100 should have comment or be unexported (golint)
- Line 490: warning: exported function ConnectX4_2x25 should have comment or be unexported (golint)
- Line 505: warning: exported function NetronomeLX_100 should have comment or be unexported (golint)
- Line 505: warning: don't use underscores in Go names; func NetronomeLX_100 should be NetronomeLX100 (golint)
- Line 519: warning: exported function FsDac100 should have comment or be unexported (golint)
- Line 545: warning: exported function FsMpoBreakout40x10 should have comment or be unexported (golint)
- Line 591: warning: exported function Cat6 should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/common/config.go
- Line 15: warning: exported type TlsConfig should have comment or be unexported (golint)
- Line 21: warning: exported type ServiceConfig should have comment or be unexported (golint)
- Line 27: warning: exported method ServiceConfig.Endpoint should have comment or be unexported (golint)
- Line 31: warning: exported type Tuning should have comment or be unexported (golint)
- Line 37: warning: exported type NetConfig should have comment or be unexported (golint)
- Line 49: warning: exported type Config should have comment or be unexported (golint)
- Line 60: warning: exported function GetConfig should have comment or be unexported (golint)
- Line 67: warning: exported function LoadConfig should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/common/etcd.go
- Line 14: warning: exported function EtcdClient should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/common/logging.go
- Line 10: warning: exported function InitLogging should have comment or be unexported (golint)
- Line 29: warning: comment on exported function ErrorE should be of the form "ErrorE ..." (golint)
- Line 44: warning: comment on exported function ErrorF should be of the form "ErrorF ..." (golint)
- Line 58: warning: comment on exported function ErrorEF should be of the form "ErrorEF ..." (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/infranet.go
- Line 14: warning: exported const EtcdNamespace should have comment (or a comment on this block) or be unexported (golint)
- Line 20: warning: exported function InitInfranet should have comment or be unexported (golint)
- Line 418: warning: exported function TeardownInfranet should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/init.go
- Line 7: warning: exported function Init should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/fabric/canopy.go
- Line 10: warning: exported method AccessPort.Create should have comment or be unexported (golint)
- Line 14: warning: exported method AccessPort.Destroy should have comment or be unexported (golint)
- Line 32: warning: exported method TrunkPort.Create should have comment or be unexported (golint)
- Line 36: warning: exported method TrunkPort.Destroy should have comment or be unexported (golint)
- Line 70: warning: exported method Vtep.Create should have comment or be unexported (golint)
- Line 74: warning: exported method Vtep.Destroy should have comment or be unexported (golint)
- Line 146: warning: exported method LinkPlan.Create should have comment or be unexported (golint)
- Line 152: warning: exported method LinkPlan.Destroy should have comment or be unexported (golint)
- Line 186: warning: exported type CanopyOps should have comment or be unexported (golint)
- Line 188: warning: exported method CanopyOps.Exec should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/fabric/linkplan.go
- Line 11: warning: comment on exported type AccessMap should be of the form "AccessMap ..." (with optional leading article) (golint)
- Line 14: warning: exported method AccessMap.Add should have comment or be unexported (golint)
- Line 24: warning: comment on exported type TrunkMap should be of the form "TrunkMap ..." (with optional leading article) (golint)
- Line 27: warning: exported method TrunkMap.Add should have comment or be unexported (golint)
- Line 37: warning: comment on exported type VtepMap should be of the form "VtepMap ..." (with optional leading article) (golint)
- Line 40: warning: exported method VtepMap.Add should have comment or be unexported (golint)
- Line 69: warning: exported method LinkPlan.Key should have comment or be unexported (golint)
- Line 72: warning: exported method LinkPlan.GetVersion should have comment or be unexported (golint)
- Line 73: warning: exported method LinkPlan.SetVersion should have comment or be unexported (golint)
- Line 74: warning: exported method LinkPlan.Value should have comment or be unexported (golint)
- Line 76: warning: receiver name lp should be consistent with previous receiver name l for LinkPlan (golint)
- Line 104: warning: exported type AccessPort should have comment or be unexported (golint)
- Line 109: warning: exported type TrunkPort should have comment or be unexported (golint)
- Line 114: warning: exported type Vtep should have comment or be unexported (golint)
- Line 122: warning: exported var PersistentTrunks should have comment or be unexported (golint)
- Line 126: warning: exported function NewLinkPlan should have comment or be unexported (golint)
- Line 165: warning: exported function MapLeaves should have comment or be unexported (golint)
- Line 199: warning: exported function MapFabrics should have comment or be unexported (golint)
- Line 205: warning: should omit 2nd value from range; this loop is equivalent to `for leaf := range ...` (golint)
-
-
/gitlab.com/dcomptb/cogs/rex/beluga.go
- Line 10: warning: should not use dot imports (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/cog-actions.go
- Line 10: warning: exported const HarborNet should have comment (or a comment on this block) or be unexported (golint)
- Line 23: warning: exported const ContainerKind should have comment (or a comment on this block) or be unexported (golint)
- Line 84: warning: comment on exported const InfraCanopyHost should be of the form "InfraCanopyHost ..." (golint)
- Line 86: warning: exported const Svcbr should have comment (or a comment on this block) or be unexported (golint)
- Line 91: warning: exported function NexDeleteNetwork should have comment or be unexported (golint)
- Line 104: warning: exported function NexDeleteMembers should have comment or be unexported (golint)
- Line 115: warning: exported function NexCreateMembers should have comment or be unexported (golint)
- Line 128: warning: exported type ContainerImageData should have comment or be unexported (golint)
- Line 133: warning: exported type DeleteContainerData should have comment or be unexported (golint)
- Line 138: warning: exported type DeleteContainerIfxData should have comment or be unexported (golint)
- Line 145: warning: exported type LinkKind should have comment or be unexported (golint)
- Line 148: warning: exported const InfraLink should have comment (or a comment on this block) or be unexported (golint)
- Line 152: warning: exported type VLinkEdge should have comment or be unexported (golint)
- Line 155: warning: exported const VlanAccess should have comment (or a comment on this block) or be unexported (golint)
- Line 160: warning: exported type Endpoint should have comment or be unexported (golint)
- Line 166: warning: exported type LinkSpec should have comment or be unexported (golint)
- Line 174: warning: exported type BelugaSpec should have comment or be unexported (golint)
- Line 179: warning: exported type Vtep should have comment or be unexported (golint)
- Line 186: warning: exported type VtepSpec should have comment or be unexported (golint)
- Line 194: warning: exported type NodeSpec should have comment or be unexported (golint)
- Line 206: warning: exported type TargetNetwork should have comment or be unexported (golint)
- Line 213: warning: exported type ImageBinding should have comment or be unexported (golint)
- Line 220: warning: exported type ImageSpec should have comment or be unexported (golint)
- Line 228: warning: exported type FoundrySetSpec should have comment or be unexported (golint)
- Line 239: warning: exported type OtterSpec should have comment or be unexported (golint)
- Line 246: warning: exported type NimbusUser should have comment or be unexported (golint)
- Line 252: warning: exported type NimbusConfig should have comment or be unexported (golint)
- Line 259: warning: exported type RallyStore should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/plumbing.go
- Line 12: warning: exported type EnclaveSpec should have comment or be unexported (golint)
- Line 25: warning: exported type MacAdvSpec should have comment or be unexported (golint)
- Line 32: warning: exported function CreateIfx should have comment or be unexported (golint)
- Line 90: warning: exported function DeleteIfx should have comment or be unexported (golint)
- Line 273: warning: exported function CreateInfrapodNS should have comment or be unexported (golint)
- Line 283: warning: exported function DeleteInfrapodNS should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/sled.go
- Line 55: warning: exported type ImageDefaults should have comment or be unexported (golint)
- Line 60: warning: exported method ImageDefaults.Key should have comment or be unexported (golint)
- Line 61: warning: exported method ImageDefaults.GetVersion should have comment or be unexported (golint)
- Line 62: warning: exported method ImageDefaults.SetVersion should have comment or be unexported (golint)
- Line 63: warning: exported method ImageDefaults.Value should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/task.go
- Line 21: warning: should not use dot imports (golint)
- Line 25: warning: exported const TimeFormat should have comment (or a comment on this block) or be unexported (golint)
- Line 31: warning: exported type Task should have comment or be unexported (golint)
- Line 42: warning: exported function NewTask should have comment or be unexported (golint)
- Line 48: warning: exported method Task.Init should have comment or be unexported (golint)
- Line 56: warning: exported method Task.AddDep should have comment or be unexported (golint)
- Line 68: warning: exported method Task.Mzid should have comment or be unexported (golint)
- Line 78: warning: exported method Task.AddStage should have comment or be unexported (golint)
- Line 88: warning: exported method Task.InsertStage should have comment or be unexported (golint)
- Line 118: warning: exported method Task.Key should have comment or be unexported (golint)
- Line 119: warning: exported method Task.GetVersion should have comment or be unexported (golint)
- Line 120: warning: exported method Task.SetVersion should have comment or be unexported (golint)
- Line 121: warning: exported method Task.Value should have comment or be unexported (golint)
- Line 122: warning: exported method Task.Complete should have comment or be unexported (golint)
- Line 136: warning: exported method Task.Failed should have comment or be unexported (golint)
- Line 151: warning: exported method Task.ClearErrors should have comment or be unexported (golint)
- Line 162: warning: exported method Task.Reset should have comment or be unexported (golint)
- Line 174: warning: exported method Task.MaskAction should have comment or be unexported (golint)
- Line 180: warning: exported method Task.DepsSatisfied should have comment or be unexported (golint)
- Line 203: warning: exported method Task.Wait should have comment or be unexported (golint)
- Line 219: warning: exported type Stage should have comment or be unexported (golint)
- Line 224: warning: exported method Stage.Mzid should have comment or be unexported (golint)
- Line 234: warning: exported function NewStage should have comment or be unexported (golint)
- Line 240: warning: exported type MzOperation should have comment or be unexported (golint)
- Line 243: warning: exported const MzOutgoing should have comment (or a comment on this block) or be unexported (golint)
- Line 248: warning: exported type Action should have comment or be unexported (golint)
- Line 263: warning: exported method Action.Task should have comment or be unexported (golint)
- Line 264: warning: exported method Action.SetTask should have comment or be unexported (golint)
- Line 266: warning: exported method Action.Stage should have comment or be unexported (golint)
- Line 267: warning: exported method Action.SetStage should have comment or be unexported (golint)
- Line 269: warning: comment on exported function ListTasks should be of the form "ListTasks ..." (golint)
- Line 313: warning: comment on exported function LaunchTask should be of the form "LaunchTask ..." (golint)
- Line 338: warning: comment on exported function CancelTask should be of the form "CancelTask ..." (golint)
- Line 365: warning: exported function HandleTask should have comment or be unexported (golint)
- Line 408: warning: exported function LeaseTask should have comment or be unexported (golint)
- Line 443: warning: exported function ReadTask should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/model-test/components.go
- Line 13: warning: exported method DComp.NewEmu should have comment or be unexported (golint)
- Line 32: warning: exported method DComp.NewStor should have comment or be unexported (golint)
- Line 54: warning: exported method DComp.NewMgmt should have comment or be unexported (golint)
- Line 73: warning: exported method DComp.NewISpine should have comment or be unexported (golint)
- Line 93: warning: exported method DComp.NewXSpine should have comment or be unexported (golint)
- Line 113: warning: exported method DComp.NewIFabric should have comment or be unexported (golint)
- Line 135: warning: exported method DComp.NewXFabric should have comment or be unexported (golint)
- Line 158: warning: exported const NumDistrictRccVe should have comment (or a comment on this block) or be unexported (golint)
- Line 165: warning: exported method DComp.NewDistrict should have comment or be unexported (golint)
- Line 198: warning: exported method District.NewRccVe should have comment or be unexported (golint)
- Line 216: warning: exported method District.NewILeaf should have comment or be unexported (golint)
- Line 245: warning: exported method District.NewXLeaf should have comment or be unexported (golint)
- Line 268: warning: exported method District.NewConsoleServer should have comment or be unexported (golint)
- Line 287: warning: exported method District.NewChassis should have comment or be unexported (golint)
- Line 307: warning: exported const NumChassisMinnow should have comment (or a comment on this block) or be unexported (golint)
- Line 310: warning: exported method Chassis.NewXPort should have comment or be unexported (golint)
- Line 329: warning: exported method Chassis.NewMinnow should have comment or be unexported (golint)
- Line 349: warning: exported method DComp.ConnectIFabrics should have comment or be unexported (golint)
- Line 365: warning: exported method DComp.ConnectXFabrics should have comment or be unexported (golint)
- Line 381: warning: exported method DComp.ConnectILeaves should have comment or be unexported (golint)
- Line 402: warning: exported method DComp.ConnectXLeaves should have comment or be unexported (golint)
- Line 423: warning: exported method District.ConnectMinnows should have comment or be unexported (golint)
- Line 423: warning: receiver name di should be consistent with previous receiver name d for District (golint)
- Line 445: warning: exported method District.ConnectRccVes should have comment or be unexported (golint)
- Line 445: warning: receiver name di should be consistent with previous receiver name d for District (golint)
- Line 468: warning: exported method DComp.ConnectMgmt should have comment or be unexported (golint)
- Line 511: warning: exported method DComp.Cable should have comment or be unexported (golint)
- Line 516: warning: exported method District.Cable should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/model-test/topology.go
- Line 11: warning: exported type DComp should have comment or be unexported (golint)
- Line 47: warning: exported type District should have comment or be unexported (golint)
- Line 73: warning: exported type Chassis should have comment or be unexported (golint)
- Line 88: warning: exported const NumEmu should have comment (or a comment on this block) or be unexported (golint)
- Line 104: warning: exported function DCompTB should have comment or be unexported (golint)
- Line 147: warning: exported method DComp.Connect should have comment or be unexported (golint)
- Line 163: warning: exported method DComp.Net should have comment or be unexported (golint)
- Line 190: warning: exported method District.Net should have comment or be unexported (golint)
- Line 222: warning: exported method Chassis.Net should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/rex/canopy.go
- Line 17: warning: exported const VTEP_MTU should have comment (or a comment on this block) or be unexported (golint)
- Line 64: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/containers.go
- Line 13: warning: should not use dot imports (golint)
- Line 28: warning: exported const DefaultMountType should have comment (or a comment on this block) or be unexported (golint)
- Line 32: warning: exported var DefaultMountOptions should have comment or be unexported (golint)
- Line 37: warning: exported function ListContainers should have comment or be unexported (golint)
- Line 50: warning: exported function ListNamespaces should have comment or be unexported (golint)
- Line 64: warning: exported function SetupContainerLo should have comment or be unexported (golint)
- Line 76: warning: exported function PullContainerImage should have comment or be unexported (golint)
- Line 93: warning: exported function CreateContainer should have comment or be unexported (golint)
- Line 138: warning: exported function CreateContainerTask should have comment or be unexported (golint)
- Line 208: warning: exported function WithCtrMounts should have comment or be unexported (golint)
- Line 226: warning: exported function CreateContainerRecord should have comment or be unexported (golint)
- Line 261: warning: exported function WithCogCNI should have comment or be unexported (golint)
- Line 288: warning: exported function DeleteContainer should have comment or be unexported (golint)
- Line 308: warning: exported function DeleteContainerTask should have comment or be unexported (golint)
- Line 358: warning: exported function DeleteContainerIfx should have comment or be unexported (golint)
- Line 388: warning: exported function DeleteContainerRecord should have comment or be unexported (golint)
- Line 426: warning: exported function DestroyNetNS should have comment or be unexported (golint)
- Line 453: warning: don't use underscores in Go names; var __client should be _Client (golint)
- Line 767: warning: exported method ContainerSpec.Env should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/countset.go
- Line 5: warning: exported type CountSet should have comment or be unexported (golint)
- Line 14: warning: exported method CountSet.Next should have comment or be unexported (golint)
- Line 27: warning: exported method CountSet.Add should have comment or be unexported (golint)
- Line 38: warning: exported method CountSet.Remove should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/gobgp-internal.go
- Line 32: warning: exported function UnmarshalAttribute should have comment or be unexported (golint)
- Line 81: warning: exported function NewOriginAttributeFromNative should have comment or be unexported (golint)
- Line 87: warning: exported function NewAsPathAttributeFromNative should have comment or be unexported (golint)
- Line 100: warning: exported function NewNextHopAttributeFromNative should have comment or be unexported (golint)
- Line 106: warning: exported function NewMultiExitDiscAttributeFromNative should have comment or be unexported (golint)
- Line 112: warning: exported function NewLocalPrefAttributeFromNative should have comment or be unexported (golint)
- Line 118: warning: exported function NewAtomicAggregateAttributeFromNative should have comment or be unexported (golint)
- Line 122: warning: exported function NewAggregatorAttributeFromNative should have comment or be unexported (golint)
- Line 129: warning: exported function NewCommunitiesAttributeFromNative should have comment or be unexported (golint)
- Line 135: warning: exported function NewOriginatorIdAttributeFromNative should have comment or be unexported (golint)
- Line 141: warning: exported function NewClusterListAttributeFromNative should have comment or be unexported (golint)
- Line 151: warning: exported function MarshalRD should have comment or be unexported (golint)
- Line 180: warning: exported function UnmarshalRD should have comment or be unexported (golint)
- Line 200: warning: exported function NewEthernetSegmentIdentifierFromNative should have comment or be unexported (golint)
- Line 214: warning: exported function MarshalFlowSpecRules should have comment or be unexported (golint)
- Line 274: warning: exported function UnmarshalFlowSpecRules should have comment or be unexported (golint)
- Line 323: warning: exported function MarshalNLRI should have comment or be unexported (golint)
- Line 446: warning: exported function MarshalNLRIs should have comment or be unexported (golint)
- Line 454: warning: exported function UnmarshalNLRI should have comment or be unexported (golint)
- Line 594: warning: exported function UnmarshalNLRIs should have comment or be unexported (golint)
- Line 606: warning: exported function NewMpReachNLRIAttributeFromNative should have comment or be unexported (golint)
- Line 623: warning: exported function NewMpUnreachNLRIAttributeFromNative should have comment or be unexported (golint)
- Line 630: warning: exported function MarshalRT should have comment or be unexported (golint)
- Line 665: warning: exported function MarshalRTs should have comment or be unexported (golint)
- Line 673: warning: exported function UnmarshalRT should have comment or be unexported (golint)
- Line 693: warning: exported function UnmarshalRTs should have comment or be unexported (golint)
- Line 705: warning: exported function NewExtendedCommunitiesAttributeFromNative should have comment or be unexported (golint)
- Line 873: warning: exported function NewAs4PathAttributeFromNative should have comment or be unexported (golint)
- Line 886: warning: exported function NewAs4AggregatorAttributeFromNative should have comment or be unexported (golint)
- Line 893: warning: exported function NewPmsiTunnelAttributeFromNative should have comment or be unexported (golint)
- Line 907: warning: exported function NewTunnelEncapAttributeFromNative should have comment or be unexported (golint)
- Line 946: warning: exported function NewIP6ExtendedCommunitiesAttributeFromNative should have comment or be unexported (golint)
- Line 978: warning: exported function NewAigpAttributeFromNative should have comment or be unexported (golint)
- Line 1001: warning: exported function NewLargeCommunitiesAttributeFromNative should have comment or be unexported (golint)
- Line 1015: warning: exported function NewUnknownAttributeFromNative should have comment or be unexported (golint)
- Line 1023: warning: exported function MarshalPathAttributes should have comment or be unexported (golint)
- Line 1095: warning: exported function UnmarshalPathAttributes should have comment or be unexported (golint)
- Line 1308: warning: comment on exported type Path should be of the form "Path ..." (with optional leading article) (golint)
- Line 1320: warning: exported type Destination should have comment or be unexported (golint)
- Line 1324: warning: exported method Destination.MarshalJSON should have comment or be unexported (golint)
- Line 1328: warning: exported function NewDestination should have comment or be unexported (golint)
- Line 1348: warning: exported function NewPath should have comment or be unexported (golint)
- Line 1372: warning: exported function GetNativeNlri should have comment or be unexported (golint)
- Line 1379: warning: exported function GetNativePathAttributes should have comment or be unexported (golint)
- Line 1399: warning: exported function ToRouteFamily should have comment or be unexported (golint)
- Line 1403: warning: exported function ToApiFamily should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/fabric/xir.go
- Line 15: warning: exported function GetInfraLeaf should have comment or be unexported (golint)
- Line 40: warning: exported function GetLeaf should have comment or be unexported (golint)
- Line 77: warning: exported type VxlanConfig should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/bgp.go
- Line 16: warning: should not use dot imports (golint)
- Line 26: warning: exported type EvpnWithdrawData should have comment or be unexported (golint)
- Line 76: warning: exported function EvpnAdvertiseMac should have comment or be unexported (golint)
- Line 79: warning: exported function EvpnWithdrawMac should have comment or be unexported (golint)
- Line 121: warning: exported type EvpnInfo should have comment or be unexported (golint)
- Line 195: warning: exported function EvpnAdvertiseMulticast should have comment or be unexported (golint)
- Line 196: warning: exported function EvpnWithdrawMulticast should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/node.go
- Line 22: warning: exported function NodeSetup should have comment or be unexported (golint)
- Line 28: warning: exported function NodeRecycle should have comment or be unexported (golint)
- Line 34: warning: exported function NodeOps should have comment or be unexported (golint)
- Line 251: warning: exported function ListNodes should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/coglet.go
- Line 18: warning: exported type CogletInfo should have comment or be unexported (golint)
- Line 27: warning: comment on exported method CogletInfo.Key should be of the form "Key ..." (golint)
- Line 29: warning: exported method CogletInfo.GetVersion should have comment or be unexported (golint)
- Line 30: warning: exported method CogletInfo.SetVersion should have comment or be unexported (golint)
- Line 31: warning: exported method CogletInfo.Value should have comment or be unexported (golint)
- Line 33: warning: error should be the last type when returning multiple items (golint)
- Line 33: warning: exported function RegisterCoglet should have comment or be unexported (golint)
- Line 58: warning: exported function ListCoglets should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/etcd.go
- Line 10: warning: should not use dot imports (golint)
- Line 13: warning: comment on exported function EtcdConnect should be of the form "EtcdConnect ..." (golint)
- Line 31: warning: exported function EnsureEtcd should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/model-test/util.go
- Line 15: warning: exported type Ip should have comment or be unexported (golint)
- Line 19: warning: exported method Ip.IP should have comment or be unexported (golint)
- Line 29: warning: exported method Ip.Next should have comment or be unexported (golint)
- Line 55: warning: exported type BgpAS should have comment or be unexported (golint)
- Line 57: warning: exported method BgpAS.Next should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/util.go
- Line 13: warning: comment on exported function GetIntLike should be of the form "GetIntLike ..." (golint)
-
-
/gitlab.com/dcomptb/cogs/util/cogctl/mz.go
- Line 121: warning: should omit 2nd value from range; this loop is equivalent to `for name := range ...` (golint)
- Line 275: warning: should omit 2nd value from range; this loop is equivalent to `for node := range ...` (golint)
- Line 388: warning: should omit 2nd value from range; this loop is equivalent to `for name := range ...` (golint)
- Line 464: warning: should omit 2nd value from range; this loop is equivalent to `for name := range ...` (golint)
- Line 506: warning: exported type LeafInfo should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/rex/bookkeeping.go
- Line 26: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
/gitlab.com/dcomptb/cogs/rex/main.go
- Line 13: warning: should not use dot imports (golint)
- Line 19: warning: exported var BELUGA_ADDR should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/cogs.go
- Line 13: warning: should not use dot imports (golint)
- Line 16: warning: exported var Version should have comment or be unexported (golint)
- Line 19: warning: error var AlreadyWorking should have name of the form ErrFoo (golint)
- Line 19: warning: exported var AlreadyWorking should have comment or be unexported (golint)
- Line 28: warning: exported function CogletId should have comment or be unexported (golint)
- Line 56: warning: exported function CheckForTasks should have comment or be unexported (golint)
- Line 135: warning: exported function RevokeLease should have comment or be unexported (golint)
- Line 144: warning: exported function KeepLeaseAlive should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/mzdb.go
- Line 16: warning: exported type LeafPortState should have comment or be unexported (golint)
- Line 26: warning: exported type LeafPortMode should have comment or be unexported (golint)
- Line 29: warning: exported const Access should have comment (or a comment on this block) or be unexported (golint)
- Line 33: warning: exported method LeafPortState.Key should have comment or be unexported (golint)
- Line 37: warning: exported method LeafPortState.GetVersion should have comment or be unexported (golint)
- Line 41: warning: exported method LeafPortState.SetVersion should have comment or be unexported (golint)
- Line 45: warning: exported method LeafPortState.Value should have comment or be unexported (golint)
- Line 51: warning: exported type Container should have comment or be unexported (golint)
- Line 62: warning: exported method Container.Key should have comment or be unexported (golint)
- Line 65: warning: exported method Container.GetVersion should have comment or be unexported (golint)
- Line 66: warning: exported method Container.SetVersion should have comment or be unexported (golint)
- Line 67: warning: exported method Container.Value should have comment or be unexported (golint)
- Line 69: warning: exported type CtrComponent should have comment or be unexported (golint)
- Line 74: warning: exported type EnclaveVeth should have comment or be unexported (golint)
- Line 89: warning: exported method EnclaveVeth.Key should have comment or be unexported (golint)
- Line 92: warning: exported method EnclaveVeth.GetVersion should have comment or be unexported (golint)
- Line 93: warning: exported method EnclaveVeth.SetVersion should have comment or be unexported (golint)
- Line 94: warning: exported method EnclaveVeth.Value should have comment or be unexported (golint)
- Line 96: warning: exported type ContainerMount should have comment or be unexported (golint)
- Line 105: warning: exported method ContainerMount.Key should have comment or be unexported (golint)
- Line 108: warning: exported method ContainerMount.GetVersion should have comment or be unexported (golint)
- Line 109: warning: exported method ContainerMount.SetVersion should have comment or be unexported (golint)
- Line 110: warning: exported method ContainerMount.Value should have comment or be unexported (golint)
- Line 112: warning: exported type ContainerSpec should have comment or be unexported (golint)
- Line 121: warning: exported type NsnatSpec should have comment or be unexported (golint)
- Line 130: warning: comment on exported type NetNS should be of the form "NetNS ..." (with optional leading article) (golint)
- Line 138: warning: exported method NetNS.Key should have comment or be unexported (golint)
- Line 139: warning: exported method NetNS.GetVersion should have comment or be unexported (golint)
- Line 140: warning: exported method NetNS.SetVersion should have comment or be unexported (golint)
- Line 141: warning: exported method NetNS.Value should have comment or be unexported (golint)
- Line 142: warning: exported method NetNS.RemoveContainer should have comment or be unexported (golint)
- Line 156: warning: comment on exported type VxLan should be of the form "VxLan ..." (with optional leading article) (golint)
- Line 164: warning: exported method VxLan.Key should have comment or be unexported (golint)
- Line 165: warning: exported method VxLan.GetVersion should have comment or be unexported (golint)
- Line 166: warning: exported method VxLan.SetVersion should have comment or be unexported (golint)
- Line 167: warning: exported method VxLan.Value should have comment or be unexported (golint)
- Line 168: warning: exported method VxLan.RemoveInterface should have comment or be unexported (golint)
- Line 184: warning: exported method CountSet.Key should have comment or be unexported (golint)
- Line 185: warning: exported method CountSet.GetVersion should have comment or be unexported (golint)
- Line 186: warning: exported method CountSet.SetVersion should have comment or be unexported (golint)
- Line 187: warning: exported method CountSet.Value should have comment or be unexported (golint)
- Line 191: warning: exported method MzInfo.Key should have comment or be unexported (golint)
- Line 192: warning: exported method MzInfo.GetVersion should have comment or be unexported (golint)
- Line 193: warning: exported method MzInfo.SetVersion should have comment or be unexported (golint)
- Line 194: warning: exported method MzInfo.Value should have comment or be unexported (golint)
- Line 198: warning: exported method LinkInfo.Key should have comment or be unexported (golint)
- Line 201: warning: exported method LinkInfo.GetVersion should have comment or be unexported (golint)
- Line 202: warning: exported method LinkInfo.SetVersion should have comment or be unexported (golint)
- Line 203: warning: exported method LinkInfo.Value should have comment or be unexported (golint)
- Line 207: warning: exported type MzfIndex should have comment or be unexported (golint)
- Line 214: warning: exported method MzfIndex.Key should have comment or be unexported (golint)
- Line 215: warning: exported method MzfIndex.GetVersion should have comment or be unexported (golint)
- Line 215: warning: receiver name l should be consistent with previous receiver name x for MzfIndex (golint)
- Line 216: warning: exported method MzfIndex.SetVersion should have comment or be unexported (golint)
- Line 216: warning: receiver name l should be consistent with previous receiver name x for MzfIndex (golint)
- Line 217: warning: exported method MzfIndex.Value should have comment or be unexported (golint)
- Line 217: warning: receiver name l should be consistent with previous receiver name x for MzfIndex (golint)
- Line 221: warning: exported function ListMaterializations should have comment or be unexported (golint)
- Line 255: warning: exported method EnclaveSpec.Key should have comment or be unexported (golint)
- Line 258: warning: exported method EnclaveSpec.GetVersion should have comment or be unexported (golint)
- Line 259: warning: exported method EnclaveSpec.SetVersion should have comment or be unexported (golint)
- Line 260: warning: exported method EnclaveSpec.Value should have comment or be unexported (golint)
- Line 264: warning: exported method VLMap.Key should have comment or be unexported (golint)
- Line 267: warning: exported method VLMap.GetVersion should have comment or be unexported (golint)
- Line 268: warning: exported method VLMap.SetVersion should have comment or be unexported (golint)
- Line 269: warning: exported method VLMap.Value should have comment or be unexported (golint)
- Line 273: warning: exported method NodeStatus.Key should have comment or be unexported (golint)
- Line 276: warning: exported method NodeStatus.GetVersion should have comment or be unexported (golint)
- Line 276: warning: receiver name v should be consistent with previous receiver name n for NodeStatus (golint)
- Line 277: warning: exported method NodeStatus.SetVersion should have comment or be unexported (golint)
- Line 277: warning: receiver name v should be consistent with previous receiver name n for NodeStatus (golint)
- Line 278: warning: exported method NodeStatus.Value should have comment or be unexported (golint)
- Line 278: warning: receiver name v should be consistent with previous receiver name n for NodeStatus (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/runtime.go
- Line 14: warning: exported type NodeStatus should have comment or be unexported (golint)
- Line 22: warning: exported type SledStatus should have comment or be unexported (golint)
- Line 27: warning: exported type NodeInfo should have comment or be unexported (golint)
- Line 34: warning: exported type MzInfo should have comment or be unexported (golint)
- Line 56: warning: exported type LinkInfo should have comment or be unexported (golint)
- Line 67: warning: exported const InfrapodMznIfx should have comment (or a comment on this block) or be unexported (golint)
- Line 256: warning: exported function SvcCidr should have comment or be unexported (golint)
- Line 262: warning: exported function SvcAddress should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/store.go
- Line 14: warning: comment on exported type Object should be of the form "Object ..." (with optional leading article) (golint)
- Line 22: warning: error var NotFound should have name of the form ErrFoo (golint)
- Line 22: warning: exported var NotFound should have comment or be unexported (golint)
- Line 24: warning: exported function Read should have comment or be unexported (golint)
- Line 38: warning: exported function ReadNew should have comment or be unexported (golint)
- Line 49: warning: exported type ReadTimer should have comment or be unexported (golint)
- Line 82: warning: error should be the last type when returning multiple items (golint)
- Line 82: warning: exported function ReadObjects should have comment or be unexported (golint)
- Line 137: warning: exported function Write should have comment or be unexported (golint)
- Line 143: warning: exported function WriteObjects should have comment or be unexported (golint)
- Line 198: warning: exported function DeleteObjects should have comment or be unexported (golint)
- Line 227: warning: exported function Delete should have comment or be unexported (golint)
- Line 233: warning: exported type ObjectTx should have comment or be unexported (golint)
- Line 238: warning: exported function RunObjectTx should have comment or be unexported (golint)
- Line 281: warning: exported const TxnFailedPrefix should have comment (or a comment on this block) or be unexported (golint)
- Line 284: warning: exported function TxnFailed should have comment or be unexported (golint)
- Line 290: warning: exported function IsTxnFailed should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/xir.go
- Line 14: warning: exported const XIR_FILE_PATH should have comment (or a comment on this block) or be unexported (golint)
- Line 17: warning: exported function LoadXIR should have comment or be unexported (golint)
- Line 21: warning: exported function GetInfraEndpoint should have comment or be unexported (golint)
- Line 38: warning: exported function Merge2Local should have comment or be unexported (golint)
- Line 59: warning: exported function GetNodeLeaf should have comment or be unexported (golint)
- Line 71: warning: exported function ExtractConstraint should have comment or be unexported (golint)
- Line 88: warning: exported function AllResourceIds should have comment or be unexported (golint)
-
-
/gitlab.com/dcomptb/cogs/pkg/xpnet.go
- Line 14: warning: exported function CreateLinks should have comment or be unexported (golint)
- Line 20: warning: exported function DestroyLinks should have comment or be unexported (golint)
- Line 195: warning: exported type VLMentry should have comment or be unexported (golint)
- Line 200: warning: exported type VLMap should have comment or be unexported (golint)
gocyclo94%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
/gitlab.com/dcomptb/cogs/pkg/xpnet.go
- Line 26: warning: cyclomatic complexity 22 of function modifyLinks() is high (> 15) (gocyclo)
-
-
/gitlab.com/dcomptb/cogs/pkg/gobgp-internal.go
- Line 1112: warning: cyclomatic complexity 64 of function unmarshalAttribute() is high (> 15) (gocyclo)
- Line 454: warning: cyclomatic complexity 47 of function UnmarshalNLRI() is high (> 15) (gocyclo)
- Line 817: warning: cyclomatic complexity 23 of function unmarshalExComm() is high (> 15) (gocyclo)
- Line 1023: warning: cyclomatic complexity 23 of function MarshalPathAttributes() is high (> 15) (gocyclo)
- Line 705: warning: cyclomatic complexity 22 of function NewExtendedCommunitiesAttributeFromNative() is high (> 15) (gocyclo)
- Line 323: warning: cyclomatic complexity 21 of function MarshalNLRI() is high (> 15) (gocyclo)
- Line 274: warning: cyclomatic complexity 19 of function UnmarshalFlowSpecRules() is high (> 15) (gocyclo)
- Line 32: warning: cyclomatic complexity 18 of function UnmarshalAttribute() is high (> 15) (gocyclo)
-
-
/gitlab.com/dcomptb/cogs/pkg/countset_test.go
- Line 116: warning: cyclomatic complexity 27 of function TestCountsetOffset() is high (> 15) (gocyclo)
- Line 8: warning: cyclomatic complexity 27 of function TestCountsetBasic() is high (> 15) (gocyclo)
ineffassign96%
IneffAssign detects ineffectual assignments in Go code.
-
-
/gitlab.com/dcomptb/cogs/pkg/bgp.go
- Line 42: warning: ineffectual assignment to err (ineffassign)
-
-
/gitlab.com/dcomptb/cogs/pkg/countset_test.go
- Line 109: warning: ineffectual assignment to i (ineffassign)
- Line 217: warning: ineffectual assignment to i (ineffassign)
misspell94%
Misspell Finds commonly misspelled English words
-
-
/gitlab.com/dcomptb/cogs/pkg/containers.go
- Line 622: warning: "netowrk" is a misspelling of "network" (misspell)
-
-
/gitlab.com/dcomptb/cogs/pkg/foundry.go
- Line 28: warning: "infromation" is a misspelling of "information" (misspell)
-
-
/gitlab.com/dcomptb/cogs/rex/container.go
- Line 180: warning: "contianer" is a misspelling of "container" (misspell)