gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo99%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• cmd/inetmock/serve.go
  • Line 54: warning: cyclomatic complexity 16 of function startINetMock() is high (> 15) (gocyclo)

golint43%

Golint is a linter for Go source code.

• internal/pcap/consumers/audit/audit_consumer.go
  • Line 27: warning: exported function NewAuditConsumer should have comment or be unexported (golint)

• internal/rpc/test/test_grpc_server.go
  • Line 18: warning: exported type APIRegistration should have comment or be unexported (golint)
  • Line 20: warning: exported type GRPCServer should have comment or be unexported (golint)
  • Line 25: warning: exported function NewTestGRPCServer should have comment or be unexported (golint)
  • Line 43: warning: exported method GRPCServer.Dial should have comment or be unexported (golint)

• pkg/audit/sink/metric_sink.go
  • Line 10: warning: exported function NewMetricSink should have comment or be unexported (golint)

• internal/endpoint/lifecycle.go
  • Line 13: warning: exported function NewEndpointLifecycle should have comment or be unexported (golint)
  • Line 46: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• internal/rpc/health_server.go
  • Line 26: warning: exported function NewHealthServer should have comment or be unexported (golint)
  • Line 47: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 58: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 76: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• pkg/audit/writer.go
  • Line 14: warning: exported var ErrValueMostNotBeNil should have comment or be unexported (golint)
  • Line 16: warning: exported type Writer should have comment or be unexported (golint)
  • Line 21: warning: exported type EventWriterOption should have comment or be unexported (golint)
  • Line 23: warning: exported function NewEventWriter should have comment or be unexported (golint)

• internal/mock/audit/conn.go
  • Line 3: warning: don't use an underscore in package name (golint)

• internal/queue/auto_evicting_queue.go
  • Line 12: warning: exported type AutoEvicting should have comment or be unexported (golint)
  • Line 17: warning: exported function WrapToAutoEvict should have comment or be unexported (golint)

• internal/endpoint/net_proto.go
  • Line 3: warning: exported type NetProto should have comment or be unexported (golint)
  • Line 6: warning: exported const NetProtoUDP should have comment (or a comment on this block) or be unexported (golint)

• internal/test/http_client.go
  • Line 15: warning: exported function HTTPClientForListener should have comment or be unexported (golint)
  • Line 42: warning: exported function HTTPClientForInMemListener should have comment or be unexported (golint)
  • Line 55: warning: exported function HTTP2ClientForInMemListener should have comment or be unexported (golint)
  • Line 66: warning: exported function MustParseURL should have comment or be unexported (golint)

• protocols/dns/incremental_IP_resolver.go
  • Line 10: warning: exported type IncrementalIPResolver should have comment or be unexported (golint)
  • Line 16: warning: exported function NewIncrementalIPResolver should have comment or be unexported (golint)
  • Line 22: warning: exported method IncrementalIPResolver.Lookup should have comment or be unexported (golint)

• internal/state/store.go
  • Line 13: warning: exported const DefaultPrefix should have comment or be unexported (golint)
  • Line 16: warning: exported var ErrReceiverNotAPointer should have comment or be unexported (golint)
  • Line 24: warning: exported type TxnReader should have comment or be unexported (golint)
  • Line 28: warning: exported type TxnWriter should have comment or be unexported (golint)
  • Line 31: warning: exported type TxnReaderWriter should have comment or be unexported (golint)
  • Line 35: warning: exported type KVStore should have comment or be unexported (golint)
  • Line 45: warning: exported type StoreOptions should have comment or be unexported (golint)
  • Line 51: warning: exported type StoreOption should have comment or be unexported (golint)
  • Line 54: warning: exported type StoreOptionFunc should have comment or be unexported (golint)
  • Line 57: warning: exported method StoreOptionFunc.Apply should have comment or be unexported (golint)
  • Line 61: warning: exported function WithPath should have comment or be unexported (golint)
  • Line 67: warning: exported function WithInMemory should have comment or be unexported (golint)
  • Line 74: warning: exported function WithEncoding should have comment or be unexported (golint)
  • Line 80: warning: exported function WithLogger should have comment or be unexported (golint)
  • Line 86: warning: exported function NewDefault should have comment or be unexported (golint)
  • Line 103: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 112: warning: exported type Store should have comment or be unexported (golint)
  • Line 118: warning: exported method Store.ReadOnlyTransaction should have comment or be unexported (golint)
  • Line 124: warning: exported method Store.ReadWriteTransaction should have comment or be unexported (golint)
  • Line 130: warning: exported method Store.WithSuffixes should have comment or be unexported (golint)
  • Line 139: warning: exported method Store.Get should have comment or be unexported (golint)
  • Line 145: warning: exported method Store.GetAll should have comment or be unexported (golint)
  • Line 152: warning: exported type SetOption should have comment or be unexported (golint)
  • Line 155: warning: exported type SetOptionFunc should have comment or be unexported (golint)
  • Line 156: warning: exported type WithTTL should have comment or be unexported (golint)
  • Line 159: warning: exported method SetOptionFunc.Apply should have comment or be unexported (golint)
  • Line 163: warning: exported method WithTTL.Apply should have comment or be unexported (golint)
  • Line 167: warning: exported method Store.Set should have comment or be unexported (golint)
  • Line 173: warning: exported method Store.Close should have comment or be unexported (golint)

• protocols/dns/cache_handler.go
  • Line 17: warning: exported type ResourceRecordCache should have comment or be unexported (golint)
  • Line 23: warning: exported type CacheHandler should have comment or be unexported (golint)
  • Line 29: warning: exported method CacheHandler.AnswerDNSQuestion should have comment or be unexported (golint)

• pkg/health/check_delegate.go
  • Line 5: warning: exported function NewCheckFunc should have comment or be unexported (golint)

• pkg/health/result.go
  • Line 8: warning: exported type Result should have comment or be unexported (golint)
  • Line 10: warning: exported method Result.MarshalJSON should have comment or be unexported (golint)
  • Line 22: warning: exported method Result.IsHealthy should have comment or be unexported (golint)
  • Line 31: warning: exported method Result.CheckResult should have comment or be unexported (golint)
  • Line 36: warning: exported type ResultWriter should have comment or be unexported (golint)
  • Line 41: warning: exported function NewResultWriter should have comment or be unexported (golint)

• protocols/dhcp/ruled_handler.go
  • Line 16: warning: exported type DHCPv4MessageHandler should have comment or be unexported (golint)
  • Line 19: warning: exported type RequestFilter should have comment or be unexported (golint)
  • Line 22: warning: exported type FilterChain should have comment or be unexported (golint)
  • Line 23: warning: exported type HandlerChain should have comment or be unexported (golint)
  • Line 24: warning: exported type ConditionalHandler should have comment or be unexported (golint)
  • Line 28: warning: exported type DHCPv4MessageHandlerFunc should have comment or be unexported (golint)
  • Line 31: warning: exported var NoOpHandler should have comment or be unexported (golint)
  • Line 35: warning: exported method FilterChain.Matches should have comment or be unexported (golint)
  • Line 44: warning: exported method HandlerChain.Apply should have comment or be unexported (golint)
  • Line 53: warning: exported method DHCPv4MessageHandlerFunc.Handle should have comment or be unexported (golint)
  • Line 57: warning: exported type RuledHandler should have comment or be unexported (golint)
  • Line 65: warning: exported method RuledHandler.RegisterRule should have comment or be unexported (golint)
  • Line 96: warning: exported method RuledHandler.Handle should have comment or be unexported (golint)

• pkg/cert/generator.go
  • Line 15: warning: exported type GenerationOptions should have comment or be unexported (golint)
  • Line 28: warning: exported type Generator should have comment or be unexported (golint)
  • Line 33: warning: exported function NewDefaultGenerator should have comment or be unexported (golint)
  • Line 37: warning: exported function NewGenerator should have comment or be unexported (golint)
  • Line 54: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• pkg/health/dns/check_validator.go
  • Line 14: warning: exported var ErrResponseNil should have comment or be unexported (golint)
  • Line 27: warning: exported type Validator should have comment or be unexported (golint)
  • Line 31: warning: exported type ValidationChain should have comment or be unexported (golint)
  • Line 33: warning: exported method ValidationChain.Add should have comment or be unexported (golint)
  • Line 39: warning: exported method ValidationChain.Len should have comment or be unexported (golint)
  • Line 43: warning: exported method ValidationChain.Matches should have comment or be unexported (golint)
  • Line 52: warning: exported type CheckFilterFunc should have comment or be unexported (golint)
  • Line 54: warning: exported method CheckFilterFunc.Matches should have comment or be unexported (golint)
  • Line 58: warning: exported function ValidatorsForRule should have comment or be unexported (golint)
  • Line 79: warning: exported function NotEmptyResponseFilter should have comment or be unexported (golint)
  • Line 92: warning: exported function ResolvedHostResponseFilter should have comment or be unexported (golint)
  • Line 121: warning: exported function ResolvedIPResponseFilter should have comment or be unexported (golint)
  • Line 148: warning: exported function InCIDRResponseFilter should have comment or be unexported (golint)

• pkg/audit/tls_details.go
  • Line 16: warning: exported type TLSDetails should have comment or be unexported (golint)
  • Line 22: warning: exported function TLSVersionToEntity should have comment or be unexported (golint)
  • Line 29: warning: exported function NewTLSDetailsFromProto should have comment or be unexported (golint)
  • Line 41: warning: exported method TLSDetails.ProtoMessage should have comment or be unexported (golint)

• internal/state/statetest/test_store.go
  • Line 12: warning: exported type StoreSetup should have comment or be unexported (golint)
  • Line 15: warning: exported type StoreSetupFunc should have comment or be unexported (golint)
  • Line 18: warning: exported method StoreSetupFunc.Setup should have comment or be unexported (golint)
  • Line 23: warning: exported function NewTestStore should have comment or be unexported (golint)
  • Line 40: warning: exported function SetupStore should have comment or be unexported (golint)

• pkg/audit/conn_context.go
  • Line 19: warning: exported function StoreConnPropertiesInContext should have comment or be unexported (golint)
  • Line 37: warning: exported function TLSConnectionState should have comment or be unexported (golint)
  • Line 45: warning: exported function LocalAddr should have comment or be unexported (golint)
  • Line 53: warning: exported function RemoteAddr should have comment or be unexported (golint)

• internal/rules/params.go
  • Line 8: warning: exported var ErrAmbiguousParamCount should have comment or be unexported (golint)
  • Line 10: warning: exported function StringP should have comment or be unexported (golint)
  • Line 14: warning: exported function IntP should have comment or be unexported (golint)
  • Line 18: warning: exported function FloatP should have comment or be unexported (golint)
  • Line 22: warning: exported function ValidateParameterCount should have comment or be unexported (golint)

• internal/test/in_mem_listener.go
  • Line 10: warning: exported var ErrListenerClosed should have comment or be unexported (golint)
  • Line 12: warning: exported type InMemListener should have comment or be unexported (golint)
  • Line 18: warning: exported function NewInMemoryListener should have comment or be unexported (golint)

• pkg/health/http_rule_check.go
  • Line 16: warning: exported function NewHTTPRuleCheck should have comment or be unexported (golint)

• protocols/dhcp/server_behavior.go
  • Line 24: warning: exported type HandlerOptions should have comment or be unexported (golint)
  • Line 30: warning: exported function HandlerForRoutingRule should have comment or be unexported (golint)
  • Line 49: warning: exported function StaticIPHandler should have comment or be unexported (golint)
  • Line 55: warning: exported function IPRangeHandler should have comment or be unexported (golint)
  • Line 65: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 71: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 83: warning: exported function RouterIPHandler should have comment or be unexported (golint)
  • Line 89: warning: exported function NetmaskHandler should have comment or be unexported (golint)
  • Line 99: warning: exported function DNSHandler should have comment or be unexported (golint)
  • Line 149: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• pkg/cert/constants.go
  • Line 4: warning: exported const CurveTypeP224 should have comment (or a comment on this block) or be unexported (golint)

• pkg/audit/event_stream.go
  • Line 39: warning: exported function MustNewEventStream should have comment or be unexported (golint)
  • Line 47: warning: exported function NewEventStream should have comment or be unexported (golint)

• internal/state/marshal.go
  • Line 3: warning: exported type Encoder should have comment or be unexported (golint)
  • Line 7: warning: exported type Decoder should have comment or be unexported (golint)
  • Line 11: warning: exported type EncoderDecoder should have comment or be unexported (golint)

• pkg/metrics/metrics_factory.go
  • Line 11: warning: exported function Gauge should have comment or be unexported (golint)
  • Line 22: warning: exported function Histogram should have comment or be unexported (golint)
  • Line 36: warning: exported function Counter should have comment or be unexported (golint)

• internal/test/integration/testcontainer.go
  • Line 13: warning: exported function SetupINetMockContainer should have comment or be unexported (golint)

• protocols/dns/options.go
  • Line 70: warning: exported type Options should have comment or be unexported (golint)
  • Line 77: warning: exported function OptionsFromLifecycle should have comment or be unexported (golint)

• internal/test/in_mem_packetconn.go
  • Line 9: warning: exported function NewInMemoryPacketConnPipe should have comment or be unexported (golint)

• pkg/logging/fields.go
  • Line 10: warning: exported type IPArray should have comment or be unexported (golint)
  • Line 12: warning: exported method IPArray.MarshalLogArray should have comment or be unexported (golint)
  • Line 19: warning: exported function IP should have comment or be unexported (golint)
  • Line 23: warning: exported function IPs should have comment or be unexported (golint)

• protocols/dns/cache.go
  • Line 19: warning: exported var WithTTL should have comment or be unexported (golint)
  • Line 35: warning: exported type Record should have comment or be unexported (golint)
  • Line 40: warning: exported type IPResolver should have comment or be unexported (golint)
  • Line 44: warning: exported type IPResolverFunc should have comment or be unexported (golint)
  • Line 46: warning: exported method IPResolverFunc.Lookup should have comment or be unexported (golint)
  • Line 50: warning: exported type CacheOption should have comment or be unexported (golint)
  • Line 52: warning: exported function NewCache should have comment or be unexported (golint)
  • Line 88: warning: exported type Cache should have comment or be unexported (golint)
  • Line 97: warning: exported method Cache.PutRecord should have comment or be unexported (golint)
  • Line 110: warning: exported method Cache.ForwardLookup should have comment or be unexported (golint)
  • Line 116: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 122: warning: exported method Cache.ReverseLookup should have comment or be unexported (golint)
  • Line 128: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• protocols/dhcp/protocol_options.go
  • Line 17: warning: exported type DefaultOptions should have comment or be unexported (golint)
  • Line 25: warning: exported type ProtocolOptions should have comment or be unexported (golint)
  • Line 31: warning: exported function LoadFromConfig should have comment or be unexported (golint)

• protocols/dhcp/server4.go
  • Line 20: warning: exported const MaxDatagram should have comment or be unexported (golint)
  • Line 23: warning: exported var ErrDropRequest should have comment or be unexported (golint)
  • Line 32: warning: exported type Server4 should have comment or be unexported (golint)
  • Line 38: warning: exported method Server4.Serve should have comment or be unexported (golint)
  • Line 61: warning: exported method Server4.HandleMessage should have comment or be unexported (golint)
  • Line 66: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• protocols/dhcp/request_filter.go
  • Line 21: warning: exported type RequestFilterFunc should have comment or be unexported (golint)
  • Line 24: warning: exported method RequestFilterFunc.Matches should have comment or be unexported (golint)
  • Line 28: warning: exported function RequestFiltersForRoutingRule should have comment or be unexported (golint)
  • Line 37: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 49: warning: exported function MatchMACMatcher should have comment or be unexported (golint)
  • Line 69: warning: exported function ExactMACMatcher should have comment or be unexported (golint)

• internal/netutils/addr_utils.go
  • Line 9: warning: exported type IPPort should have comment or be unexported (golint)
  • Line 18: warning: exported function IPPortFromAddress should have comment or be unexported (golint)
  • Line 35: warning: exported function MustParseMAC should have comment or be unexported (golint)

• internal/mock/dns/cache.go
  • Line 9: warning: exported type CacheMockPutRecordCallParams should have comment or be unexported (golint)
  • Line 14: warning: exported type CacheMockForwardLookupCallParams should have comment or be unexported (golint)
  • Line 18: warning: exported type CacheMockForwardLookupCallResults should have comment or be unexported (golint)
  • Line 22: warning: exported type CacheMockReverseLookupCallParams should have comment or be unexported (golint)
  • Line 26: warning: exported type CacheMockReverseLookupCallResults should have comment or be unexported (golint)
  • Line 31: warning: exported type CacheMockPutRecordCall should have comment or be unexported (golint)
  • Line 36: warning: exported type CacheMockForwardLookupCall should have comment or be unexported (golint)
  • Line 42: warning: exported type CacheMockReverseLookupCall should have comment or be unexported (golint)
  • Line 48: warning: exported type CacheMockCalls should have comment or be unexported (golint)
  • Line 54: warning: exported type CacheMockCallsContext should have comment or be unexported (golint)
  • Line 59: warning: exported type CacheMock should have comment or be unexported (golint)
  • Line 67: warning: exported method CacheMock.PutRecord should have comment or be unexported (golint)
  • Line 87: warning: exported method CacheMock.ForwardLookup should have comment or be unexported (golint)
  • Line 109: warning: exported method CacheMock.ReverseLookup should have comment or be unexported (golint)

• internal/endpoint/api.go
  • Line 13: warning: exported var WithDecodeHook should have comment or be unexported (golint)
  • Line 32: warning: exported type UnmarshalOption should have comment or be unexported (golint)
  • Line 34: warning: exported type Lifecycle should have comment or be unexported (golint)
  • Line 40: warning: exported type ProtocolHandler should have comment or be unexported (golint)
  • Line 44: warning: exported type MultiplexHandler should have comment or be unexported (golint)

• internal/endpoint/uplink.go
  • Line 9: warning: exported function NewUplink should have comment or be unexported (golint)
  • Line 33: warning: exported type Uplink should have comment or be unexported (golint)
  • Line 41: warning: exported method Uplink.Close should have comment or be unexported (golint)

• internal/rpc/audit_server.go
  • Line 29: warning: exported function NewAuditServiceServer should have comment or be unexported (golint)

• pkg/health/http/check_validators.go
  • Line 20: warning: exported var ErrUnknownCheckFilter should have comment or be unexported (golint)
  • Line 43: warning: exported function ValidatorsForRule should have comment or be unexported (golint)
  • Line 55: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 67: warning: exported type Validator should have comment or be unexported (golint)
  • Line 71: warning: exported type ValidationChain should have comment or be unexported (golint)
  • Line 73: warning: exported method ValidationChain.Add should have comment or be unexported (golint)
  • Line 79: warning: exported method ValidationChain.Len should have comment or be unexported (golint)
  • Line 83: warning: exported method ValidationChain.Matches should have comment or be unexported (golint)
  • Line 92: warning: exported type CheckFilterFunc should have comment or be unexported (golint)
  • Line 94: warning: exported method CheckFilterFunc.Matches should have comment or be unexported (golint)
  • Line 98: warning: exported function StatusCodeFilter should have comment or be unexported (golint)
  • Line 120: warning: exported function ResponseHeaderFilter should have comment or be unexported (golint)
  • Line 155: warning: exported function ResponseBodyContainsFilter should have comment or be unexported (golint)
  • Line 164: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 207: warning: exported function ResponseBodyHashSHA256Filter should have comment or be unexported (golint)

• pkg/health/dns_resolver.go
  • Line 14: warning: exported type ResolverForModule should have comment or be unexported (golint)
  • Line 17: warning: exported type ResolversForModuleMap should have comment or be unexported (golint)
  • Line 20: warning: exported method ResolversForModuleMap.ResolverForModule should have comment or be unexported (golint)
  • Line 23: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 28: warning: exported function Resolvers should have comment or be unexported (golint)

• protocols/dns/doh/http_server.go
  • Line 21: warning: exported type Server should have comment or be unexported (golint)
  • Line 26: warning: exported method Server.Serve should have comment or be unexported (golint)
  • Line 30: warning: exported method Server.Shutdown should have comment or be unexported (golint)
  • Line 34: warning: exported method Server.Close should have comment or be unexported (golint)
  • Line 38: warning: exported function NewServer should have comment or be unexported (golint)
  • Line 49: warning: exported function DNSQueryHandler should have comment or be unexported (golint)

• pkg/cert/certs.go
  • Line 9: warning: exported type CurveType should have comment or be unexported (golint)
  • Line 11: warning: exported type TLSVersion should have comment or be unexported (golint)
  • Line 13: warning: exported method TLSVersion.Value should have comment or be unexported (golint)
  • Line 17: warning: exported method TLSVersion.TLSVersion should have comment or be unexported (golint)
  • Line 30: warning: exported type File should have comment or be unexported (golint)
  • Line 35: warning: exported type ValidityDuration should have comment or be unexported (golint)
  • Line 40: warning: exported type ValidityByPurpose should have comment or be unexported (golint)
  • Line 45: warning: exported type Options should have comment or be unexported (golint)

• internal/pcap/consumers/file_consumer.go
  • Line 31: warning: exported function NewWriterConsumer should have comment or be unexported (golint)

• internal/netutils/conversion.go
  • Line 9: warning: exported function Uint32ToIP should have comment or be unexported (golint)
  • Line 14: warning: exported function IPToInt32 should have comment or be unexported (golint)

• internal/pcap/api.go
  • Line 15: warning: exported type Consumer should have comment or be unexported (golint)
  • Line 21: warning: exported type Device should have comment or be unexported (golint)
  • Line 26: warning: exported type Subscription should have comment or be unexported (golint)
  • Line 31: warning: exported type RecordingOptions should have comment or be unexported (golint)
  • Line 36: warning: exported type StartRecordingResult should have comment or be unexported (golint)
  • Line 40: warning: exported type Recorder should have comment or be unexported (golint)

• internal/pcap/device_consumer.go
  • Line 23: warning: exported var ErrTransportStillRunning should have comment or be unexported (golint)

• internal/rpc/pcap_server.go
  • Line 27: warning: exported function NewPCAPServer should have comment or be unexported (golint)

• protocols/dns/rr_header.go
  • Line 10: warning: exported function RRHeader should have comment or be unexported (golint)

• pkg/audit/options.go
  • Line 18: warning: exported var WithBufferSize should have comment or be unexported (golint)
  • Line 55: warning: exported type EventStreamOption should have comment or be unexported (golint)

• cmd/inetmock/main.go
  • Line 22: warning: exported type Data should have comment or be unexported (golint)
  • Line 39: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 80: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• protocols/dns/handler.go
  • Line 9: warning: exported var ErrNoAnswerForQuestion should have comment or be unexported (golint)
  • Line 12: warning: exported type Question should have comment or be unexported (golint)
  • Line 13: warning: exported type ResourceRecord should have comment or be unexported (golint)
  • Line 14: warning: exported type HandlerFunc should have comment or be unexported (golint)
  • Line 17: warning: exported method HandlerFunc.AnswerDNSQuestion should have comment or be unexported (golint)
  • Line 21: warning: exported type Handler should have comment or be unexported (golint)

• pkg/audit/event.go
  • Line 16: warning: exported type Details should have comment or be unexported (golint)
  • Line 20: warning: exported type Event should have comment or be unexported (golint)
  • Line 33: warning: exported method Event.ProtoMessage should have comment or be unexported (golint)
  • Line 60: warning: exported method Event.ApplyDefaults should have comment or be unexported (golint)
  • Line 68: warning: exported method Event.SetSourceIPFromAddr should have comment or be unexported (golint)
  • Line 71: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 78: warning: exported method Event.SetDestinationIPFromAddr should have comment or be unexported (golint)
  • Line 81: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 88: warning: exported function NewEventFromProto should have comment or be unexported (golint)

• internal/endpoint/listener.go
  • Line 15: warning: exported var ErrUDPMultiplexer should have comment or be unexported (golint)
  • Line 19: warning: exported type HandlerReference should have comment or be unexported (golint)
  • Line 21: warning: exported method HandlerReference.ToLower should have comment or be unexported (golint)
  • Line 25: warning: exported type ListenerSpec should have comment or be unexported (golint)
  • Line 35: warning: exported type Spec should have comment or be unexported (golint)
  • Line 42: warning: exported method ListenerSpec.ConfigureMultiplexing should have comment or be unexported (golint)
  • Line 169: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• pkg/path/helpers.go
  • Line 7: warning: exported function FileExists should have comment or be unexported (golint)

• protocols/http/proxy/register.go
  • Line 20: warning: exported function AddHTTPProxy should have comment or be unexported (golint)

• pkg/cert/time_source.go
  • Line 7: warning: exported type TimeSource should have comment or be unexported (golint)
  • Line 11: warning: exported function NewTimeSource should have comment or be unexported (golint)

• pkg/wait/wg.go
  • Line 5: warning: exported function ForWaitGroupDone should have comment or be unexported (golint)

• pkg/audit/details/http_details.go
  • Line 36: warning: exported type HTTP should have comment or be unexported (golint)
  • Line 44: warning: exported function NewHTTPFromWireFormat should have comment or be unexported (golint)
  • Line 66: warning: exported method HTTP.MarshalToWireFormat should have comment or be unexported (golint)

• protocols/dns/mock/register.go
  • Line 9: warning: exported function New should have comment or be unexported (golint)
  • Line 16: warning: exported function AddDNSMock should have comment or be unexported (golint)

• protocols/dns/question_predicates.go
  • Line 18: warning: exported function QuestionPredicatesForRoutingRule should have comment or be unexported (golint)
  • Line 27: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 40: warning: exported function HostnameQuestionFilter should have comment or be unexported (golint)

• protocols/dhcp/fallback_handler.go
  • Line 11: warning: exported type FallbackHandler should have comment or be unexported (golint)
  • Line 17: warning: exported method FallbackHandler.Handle should have comment or be unexported (golint)

• protocols/dhcp/handler.go
  • Line 38: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 44: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 97: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• internal/app/app.go
  • Line 33: warning: exported function RandomSource should have comment or be unexported (golint)
  • Line 38: warning: exported type Spec should have comment or be unexported (golint)
  • Line 50: warning: exported type App should have comment or be unexported (golint)
  • Line 96: warning: exported function NewApp should have comment or be unexported (golint)

• internal/state/msgpack.go
  • Line 5: warning: exported type MsgPackEncoding should have comment or be unexported (golint)
  • Line 7: warning: exported method MsgPackEncoding.Encode should have comment or be unexported (golint)
  • Line 11: warning: exported method MsgPackEncoding.Decode should have comment or be unexported (golint)

• internal/rules/cidr.go
  • Line 5: warning: exported type CIDR should have comment or be unexported (golint)
  • Line 9: warning: exported method CIDR.UnmarshalText should have comment or be unexported (golint)
  • Line 14: warning: exported function ParseCIDR should have comment or be unexported (golint)
  • Line 22: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 27: warning: exported function MustParseCIDR should have comment or be unexported (golint)

• internal/test/generator.go
  • Line 1: warning: package comment should be of the form "Package test ..." (golint)
  • Line 9: warning: exported var Names should have comment or be unexported (golint)
  • Line 750: warning: comment on exported function GenerateDomain should be of the form "GenerateDomain ..." (golint)

• protocols/dns/doh/handler.go
  • Line 42: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• internal/rpc/middleware/ctx_error_handling.go
  • Line 12: warning: exported var ContextErrorConverter should have comment or be unexported (golint)

• internal/format/console_writer.go
  • Line 36: warning: exported function Writer should have comment or be unexported (golint)
  • Line 43: warning: exported type ConsoleWriter should have comment or be unexported (golint)

• internal/rules/errors.go
  • Line 6: warning: exported var ErrNoTerminatorDefined should have comment or be unexported (golint)

• internal/test/integration/http_server.go
  • Line 17: warning: exported function NewTestHTTPServer should have comment or be unexported (golint)
  • Line 46: warning: exported type HTTPServer should have comment or be unexported (golint)
  • Line 50: warning: exported method HTTPServer.Close should have comment or be unexported (golint)
  • Line 54: warning: exported method HTTPServer.Listen should have comment or be unexported (golint)

• protocols/dns/rule_handler.go
  • Line 11: warning: exported type RuleHandler should have comment or be unexported (golint)
  • Line 16: warning: exported method RuleHandler.AnswerDNSQuestion should have comment or be unexported (golint)
  • Line 38: warning: exported method RuleHandler.RegisterRule should have comment or be unexported (golint)

• internal/pcap/recorder.go
  • Line 14: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 19: warning: exported const DefaultReadTimeout should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: exported var ErrConsumerAlreadyRegistered should have comment or be unexported (golint)
  • Line 33: warning: exported function NewRecorder should have comment or be unexported (golint)

• internal/queue/priority_queue.go
  • Line 33: warning: exported type EvictionCallback should have comment or be unexported (golint)
  • Line 37: warning: exported type EvictionCallbackFunc should have comment or be unexported (golint)
  • Line 39: warning: exported method EvictionCallbackFunc.OnEvicted should have comment or be unexported (golint)
  • Line 43: warning: exported type TTL should have comment or be unexported (golint)
  • Line 52: warning: exported function NewTTLFromSeed should have comment or be unexported (golint)
  • Line 67: warning: exported function NewTTL should have comment or be unexported (golint)
  • Line 74: warning: exported method TTL.Len should have comment or be unexported (golint)
  • Line 80: warning: exported method TTL.Cap should have comment or be unexported (golint)
  • Line 86: warning: exported method TTL.Get should have comment or be unexported (golint)
  • Line 95: warning: exported method TTL.IndexOf should have comment or be unexported (golint)
  • Line 99: warning: exported method TTL.UpdateTTL should have comment or be unexported (golint)
  • Line 135: warning: exported method TTL.Evict should have comment or be unexported (golint)
  • Line 142: warning: exported method TTL.Push should have comment or be unexported (golint)
  • Line 187: warning: exported method TTL.PeekFront should have comment or be unexported (golint)
  • Line 196: warning: exported method TTL.OnEvicted should have comment or be unexported (golint)

• internal/rpc/errors.go
  • Line 10: warning: exported function PathToGRPCError should have comment or be unexported (golint)

• protocols/dns/client/http_transport.go
  • Line 17: warning: exported var RequestPackerPOST should have comment or be unexported (golint)
  • Line 20: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 46: warning: exported type RequestPacker should have comment or be unexported (golint)
  • Line 50: warning: exported type HTTPClient should have comment or be unexported (golint)
  • Line 54: warning: exported type RequestPackerFunc should have comment or be unexported (golint)
  • Line 56: warning: exported method RequestPackerFunc.Pack should have comment or be unexported (golint)
  • Line 60: warning: exported type HTTPTransport should have comment or be unexported (golint)
  • Line 67: warning: exported method HTTPTransport.RoundTrip should have comment or be unexported (golint)

• protocols/dns/ptr.go
  • Line 16: warning: exported function ParseInAddrArpa should have comment or be unexported (golint)
  • Line 32: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• pkg/health/http_client.go
  • Line 15: warning: exported type HTTPClientForModule should have comment or be unexported (golint)
  • Line 18: warning: exported type ClientsForModuleMap should have comment or be unexported (golint)
  • Line 21: warning: exported method ClientsForModuleMap.ClientForModule should have comment or be unexported (golint)
  • Line 24: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 29: warning: exported function HTTPClients should have comment or be unexported (golint)
  • Line 36: warning: exported function HTTPClient should have comment or be unexported (golint)
  • Line 64: warning: exported function HTTP2Client should have comment or be unexported (golint)

• internal/queue/offset.go
  • Line 5: warning: exported type Offset should have comment or be unexported (golint)
  • Line 9: warning: exported method Offset.Next should have comment or be unexported (golint)
  • Line 19: warning: exported method Offset.Inc should have comment or be unexported (golint)

• protocols/pprof/register.go
  • Line 48: warning: exported function New should have comment or be unexported (golint)
  • Line 55: warning: exported function AddPprof should have comment or be unexported (golint)

• internal/state/transaction.go
  • Line 9: warning: exported type BadgerTransaction should have comment or be unexported (golint)

• internal/rpc/grpc_api.go
  • Line 31: warning: exported type INetMockAPI should have comment or be unexported (golint)
  • Line 48: warning: exported function NewINetMockAPI should have comment or be unexported (golint)

• multiplexing/http_matchers.go
  • Line 14: warning: exported const HTTPVersionUnknown should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported type HTTPVersion should have comment or be unexported (golint)
  • Line 28: warning: exported type RequestPreface should have comment or be unexported (golint)
  • Line 36: warning: exported type RequestMatcher should have comment or be unexported (golint)
  • Line 39: warning: exported function HTTP should have comment or be unexported (golint)
  • Line 55: warning: exported function PathPrefixMatcher should have comment or be unexported (golint)
  • Line 61: warning: exported function HTTPMatchOr should have comment or be unexported (golint)
  • Line 67: warning: exported function HTTPMatchAnd should have comment or be unexported (golint)

• internal/rpc/pprof_server.go
  • Line 39: warning: exported function NewProfilingServer should have comment or be unexported (golint)
  • Line 76: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 89: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• pkg/health/http/check_initiator.go
  • Line 23: warning: exported var ErrNotAnHTTPInitiator should have comment or be unexported (golint)
  • Line 35: warning: exported type Initiator should have comment or be unexported (golint)
  • Line 39: warning: exported function InitiatorForRule should have comment or be unexported (golint)
  • Line 49: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 79: warning: exported function RequestInitiatorForMethod should have comment or be unexported (golint)

• pkg/audit/api.go
  • Line 11: warning: exported var ErrSinkAlreadyRegistered should have comment or be unexported (golint)
  • Line 13: warning: exported type Emitter should have comment or be unexported (golint)
  • Line 17: warning: exported type EmitterFunc should have comment or be unexported (golint)
  • Line 19: warning: exported method EmitterFunc.Emit should have comment or be unexported (golint)
  • Line 23: warning: exported type Sink should have comment or be unexported (golint)
  • Line 28: warning: exported type EventStream should have comment or be unexported (golint)

• internal/mock/dns/response_writer.go
  • Line 11: warning: exported type ResponseWriterMock should have comment or be unexported (golint)
  • Line 22: warning: exported method ResponseWriterMock.LocalAddr should have comment or be unexported (golint)
  • Line 29: warning: exported method ResponseWriterMock.RemoteAddr should have comment or be unexported (golint)
  • Line 36: warning: exported method ResponseWriterMock.WriteMsg should have comment or be unexported (golint)
  • Line 56: warning: exported method ResponseWriterMock.Close should have comment or be unexported (golint)
  • Line 66: warning: exported method ResponseWriterMock.TsigStatus should have comment or be unexported (golint)
  • Line 76: warning: exported method ResponseWriterMock.TsigTimersOnly should have comment or be unexported (golint)
  • Line 82: warning: exported method ResponseWriterMock.Hijack should have comment or be unexported (golint)

• internal/queue/entry.go
  • Line 5: warning: exported type Entry should have comment or be unexported (golint)
  • Line 12: warning: exported method Entry.WithTTL should have comment or be unexported (golint)
  • Line 17: warning: exported method Entry.TTL should have comment or be unexported (golint)

• pkg/health/dns_rule_check.go
  • Line 16: warning: exported function NewDNSRuleCheck should have comment or be unexported (golint)

• cmd/imctl/check.go
  • Line 78: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 138: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 144: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 268: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• internal/endpoint/options.go
  • Line 9: warning: exported type Mapping should have comment or be unexported (golint)
  • Line 13: warning: exported type MappingFunc should have comment or be unexported (golint)
  • Line 15: warning: exported method MappingFunc.MapTo should have comment or be unexported (golint)
  • Line 19: warning: exported type OptionByTypeDecoderBuilder should have comment or be unexported (golint)
  • Line 24: warning: exported function NewOptionByTypeDecoderBuilderFor should have comment or be unexported (golint)
  • Line 31: warning: exported method OptionByTypeDecoderBuilder.AddMappingToType should have comment or be unexported (golint)
  • Line 39: warning: exported method OptionByTypeDecoderBuilder.AddMappingToProvider should have comment or be unexported (golint)
  • Line 47: warning: exported method OptionByTypeDecoderBuilder.AddMappingToMapper should have comment or be unexported (golint)
  • Line 55: warning: exported method OptionByTypeDecoderBuilder.Build should have comment or be unexported (golint)
  • Line 75: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• protocols/dns/mock/handler.go
  • Line 28: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• protocols/dhcp/register.go
  • Line 38: warning: exported function New should have comment or be unexported (golint)
  • Line 46: warning: exported function AddDHCPMock should have comment or be unexported (golint)

• pkg/audit/sink/writer_sink.go
  • Line 5: warning: exported type WriterSinkOption should have comment or be unexported (golint)
  • Line 7: warning: exported var WithCloseOnExit should have comment or be unexported (golint)
  • Line 11: warning: exported function NewWriterSink should have comment or be unexported (golint)

• internal/mock/call_counter.go
  • Line 9: warning: exported function NewCallCounter should have comment or be unexported (golint)
  • Line 16: warning: exported type CallCounter should have comment or be unexported (golint)
  • Line 21: warning: exported method CallCounter.Inc should have comment or be unexported (golint)
  • Line 32: warning: exported method CallCounter.GetValueFor should have comment or be unexported (golint)

• internal/state/logger.go
  • Line 12: warning: exported type Logger should have comment or be unexported (golint)
  • Line 16: warning: exported method Logger.Errorf should have comment or be unexported (golint)
  • Line 20: warning: exported method Logger.Warningf should have comment or be unexported (golint)
  • Line 24: warning: exported method Logger.Infof should have comment or be unexported (golint)
  • Line 28: warning: exported method Logger.Debugf should have comment or be unexported (golint)
  • Line 34: warning: exported type TestLogger should have comment or be unexported (golint)
  • Line 38: warning: exported method TestLogger.Errorf should have comment or be unexported (golint)
  • Line 42: warning: exported method TestLogger.Warningf should have comment or be unexported (golint)
  • Line 46: warning: exported method TestLogger.Infof should have comment or be unexported (golint)
  • Line 50: warning: exported method TestLogger.Debugf should have comment or be unexported (golint)

• internal/test/matcher.go
  • Line 17: warning: exported function GenericMatcher should have comment or be unexported (golint)
  • Line 34: warning: exported function IP should have comment or be unexported (golint)

• internal/test/tcp_listener.go
  • Line 10: warning: exported function NewTCPListener should have comment or be unexported (golint)

• pkg/audit/details/dhcp_details.go
  • Line 9: warning: exported function NewDHCPFromWireFormat should have comment or be unexported (golint)
  • Line 19: warning: exported type DHCP should have comment or be unexported (golint)
  • Line 25: warning: exported method DHCP.MarshalToWireFormat should have comment or be unexported (golint)

• pkg/audit/details/dns_details.go
  • Line 9: warning: exported function NewDNSFromWireFormat should have comment or be unexported (golint)
  • Line 24: warning: exported type DNSQuestion should have comment or be unexported (golint)
  • Line 29: warning: exported type DNS should have comment or be unexported (golint)
  • Line 34: warning: exported method DNS.MarshalToWireFormat should have comment or be unexported (golint)

• pkg/health/dns/mock_resolver.go
  • Line 8: warning: exported type MockResolver should have comment or be unexported (golint)
  • Line 13: warning: exported method MockResolver.ResolverForModule should have comment or be unexported (golint)
  • Line 17: warning: exported method MockResolver.LookupA should have comment or be unexported (golint)
  • Line 24: warning: exported method MockResolver.LookupPTR should have comment or be unexported (golint)

• protocols/dns/random_ip_resolver.go
  • Line 12: warning: exported type RandomIPResolver should have comment or be unexported (golint)
  • Line 18: warning: comment on exported function NewRandomIPResolver should be of the form "NewRandomIPResolver ..." (golint)
  • Line 27: warning: exported method RandomIPResolver.Lookup should have comment or be unexported (golint)

• pkg/cert/cache.go
  • Line 12: warning: exported type Cache should have comment or be unexported (golint)
  • Line 17: warning: exported function NewFileSystemCache should have comment or be unexported (golint)
  • Line 48: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• internal/pcap/consumers/noop_consumer.go
  • Line 19: warning: exported function NewNoOpConsumer should have comment or be unexported (golint)
  • Line 23: warning: exported function NewNoOpConsumerWithName should have comment or be unexported (golint)

• internal/endpoint/registration.go
  • Line 1: warning: package comment should be of the form "Package endpoint ..." (golint)
  • Line 9: warning: exported type Registration should have comment or be unexported (golint)
  • Line 10: warning: exported type HandlerProvider should have comment or be unexported (golint)
  • Line 13: warning: exported type HandlerRegistry should have comment or be unexported (golint)
  • Line 19: warning: exported function NewHandlerRegistry should have comment or be unexported (golint)

• pkg/health/dns/check_initiator.go
  • Line 17: warning: exported var ErrNotADNSPInitiator should have comment or be unexported (golint)
  • Line 26: warning: exported type Response should have comment or be unexported (golint)
  • Line 31: warning: exported type Initiator should have comment or be unexported (golint)
  • Line 35: warning: exported type InitiatorFunc should have comment or be unexported (golint)
  • Line 37: warning: exported method InitiatorFunc.Do should have comment or be unexported (golint)
  • Line 41: warning: exported function CheckForRule should have comment or be unexported (golint)
  • Line 51: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 59: warning: exported function AorAAAAInitiator should have comment or be unexported (golint)
  • Line 77: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 85: warning: exported function PTRInitiator should have comment or be unexported (golint)

• internal/test/context.go
  • Line 8: warning: exported function Context should have comment or be unexported (golint)

• pkg/logging/factory.go
  • Line 14: warning: exported type LoggingOption should have comment or be unexported (golint)
  • Line 17: warning: exported type LoggingOptionFunc should have comment or be unexported (golint)
  • Line 20: warning: exported method LoggingOptionFunc.Apply should have comment or be unexported (golint)
  • Line 24: warning: exported function WithLevel should have comment or be unexported (golint)
  • Line 30: warning: exported function WithDevelopment should have comment or be unexported (golint)
  • Line 36: warning: exported function WithEncoding should have comment or be unexported (golint)
  • Line 42: warning: exported function WithInitialFields should have comment or be unexported (golint)
  • Line 48: warning: exported function ConfigureLogging should have comment or be unexported (golint)
  • Line 54: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 61: warning: exported function ParseLevel should have comment or be unexported (golint)
  • Line 78: warning: exported function CreateLogger should have comment or be unexported (golint)
  • Line 82: warning: exported function CreateTestLogger should have comment or be unexported (golint)

• pkg/health/health_handler.go
  • Line 8: warning: exported function NewHealthHandler should have comment or be unexported (golint)

• protocols/dns/doh/register.go
  • Line 11: warning: exported function New should have comment or be unexported (golint)
  • Line 18: warning: exported function AddDoH should have comment or be unexported (golint)

• internal/mock/audit/emitter.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 10: warning: exported type EmitterMockEmitCallParams should have comment or be unexported (golint)
  • Line 14: warning: exported type EmitterMockEmitCall should have comment or be unexported (golint)
  • Line 19: warning: exported type EmitterMockCalls should have comment or be unexported (golint)
  • Line 23: warning: exported type EmitterMockCallsContext should have comment or be unexported (golint)
  • Line 28: warning: exported type EmitterMock should have comment or be unexported (golint)
  • Line 34: warning: exported method EmitterMock.Emit should have comment or be unexported (golint)

• internal/rules/grammar.go
  • Line 14: warning: exported var ErrNoParser should have comment or be unexported (golint)
  • Line 78: warning: exported type FilteredPipeline should have comment or be unexported (golint)
  • Line 92: warning: exported method SingleResponsePipeline.Filters should have comment or be unexported (golint)
  • Line 109: warning: exported method ChainedResponsePipeline.Filters should have comment or be unexported (golint)
  • Line 116: warning: exported type Check should have comment or be unexported (golint)
  • Line 121: warning: exported type CheckScript should have comment or be unexported (golint)
  • Line 125: warning: exported type Filters should have comment or be unexported (golint)
  • Line 129: warning: exported type Call should have comment or be unexported (golint)
  • Line 135: warning: exported type Param should have comment or be unexported (golint)
  • Line 143: warning: exported method Param.AsString should have comment or be unexported (golint)
  • Line 150: warning: exported method Param.AsInt should have comment or be unexported (golint)
  • Line 157: warning: exported method Param.AsFloat should have comment or be unexported (golint)
  • Line 164: warning: exported method Param.AsIP should have comment or be unexported (golint)
  • Line 171: warning: exported method Param.AsCIDR should have comment or be unexported (golint)

• pkg/health/api.go
  • Line 15: warning: exported var ErrEmptyCheckName should have comment or be unexported (golint)
  • Line 20: warning: exported function New should have comment or be unexported (golint)
  • Line 26: warning: exported function NewFromConfig should have comment or be unexported (golint)
  • Line 61: warning: exported type Checker should have comment or be unexported (golint)
  • Line 66: warning: exported type Check should have comment or be unexported (golint)

• pkg/cert/store.go
  • Line 28: warning: exported type KeyProvider should have comment or be unexported (golint)
  • Line 30: warning: exported type Store should have comment or be unexported (golint)
  • Line 36: warning: exported function MustDefaultStore should have comment or be unexported (golint)
  • Line 47: warning: exported function NewDefaultStore should have comment or be unexported (golint)
  • Line 59: warning: exported function NewStore should have comment or be unexported (golint)
  • Line 156: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• pkg/health/dns/resolver.go
  • Line 9: warning: exported type Resolver should have comment or be unexported (golint)

• internal/test/dns_resolver.go
  • Line 7: warning: exported function DNSResolverForInMemListener should have comment or be unexported (golint)

• protocols/dns/client/dns_client.go
  • Line 36: warning: exported type RoundTripper should have comment or be unexported (golint)
  • Line 40: warning: exported type Resolver should have comment or be unexported (golint)
  • Line 44: warning: exported method Resolver.Do should have comment or be unexported (golint)
  • Line 48: warning: exported method Resolver.Question should have comment or be unexported (golint)
  • Line 56: warning: exported method Resolver.LookupA should have comment or be unexported (golint)
  • Line 61: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 66: warning: exported method Resolver.LookupAAAA should have comment or be unexported (golint)
  • Line 71: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 76: warning: exported method Resolver.LookupPTR should have comment or be unexported (golint)
  • Line 86: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 91: warning: exported method Resolver.LookupMX should have comment or be unexported (golint)
  • Line 95: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• protocols/dns/fallback_handler.go
  • Line 9: warning: exported function FallbackHandler should have comment or be unexported (golint)

• protocols/dns/ruled_resolver.go
  • Line 17: warning: exported function ResolverForRule should have comment or be unexported (golint)
  • Line 24: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 29: warning: exported function StaticIPResolverForArgs should have comment or be unexported (golint)
  • Line 36: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 43: warning: exported function IncrementalResolverForArgs should have comment or be unexported (golint)
  • Line 50: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 55: warning: exported function RandomIPResolverForArgs should have comment or be unexported (golint)
  • Line 62: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• pkg/health/config.go
  • Line 3: warning: exported type Server should have comment or be unexported (golint)
  • Line 9: warning: exported type ClientsConfig should have comment or be unexported (golint)
  • Line 16: warning: exported type ValidationRule should have comment or be unexported (golint)
  • Line 21: warning: exported type Config should have comment or be unexported (golint)

• pkg/audit/sink/generic_sink.go
  • Line 7: warning: exported function NewNoOpSink should have comment or be unexported (golint)
  • Line 11: warning: exported function NewGenericSink should have comment or be unexported (golint)

• internal/endpoint/endpoint.go
  • Line 12: warning: exported type Endpoint should have comment or be unexported (golint)
  • Line 18: warning: exported method Endpoint.Start should have comment or be unexported (golint)

• internal/endpoint/orchestrator.go
  • Line 17: warning: exported var ErrStartupTimeout should have comment or be unexported (golint)
  • Line 21: warning: exported function NewOrchestrator should have comment or be unexported (golint)
  • Line 33: warning: exported type Orchestrator should have comment or be unexported (golint)
  • Line 42: warning: exported method Orchestrator.RegisterListener should have comment or be unexported (golint)
  • Line 64: warning: exported method Orchestrator.Endpoints should have comment or be unexported (golint)
  • Line 68: warning: exported method Orchestrator.StartEndpoints should have comment or be unexported (golint)

• pkg/audit/http_handler.go
  • Line 11: warning: exported function EmittingHandler should have comment or be unexported (golint)

• protocols/dns/client/traditional_transport.go
  • Line 12: warning: exported type TraditionalTransport should have comment or be unexported (golint)
  • Line 18: warning: exported method TraditionalTransport.RoundTrip should have comment or be unexported (golint)

• pkg/logging/logger.go
  • Line 1: warning: package comment should be of the form "Package logging ..." (golint)
  • Line 8: warning: exported type Logger should have comment or be unexported (golint)
  • Line 25: warning: exported function NewLogger should have comment or be unexported (golint)

• protocols/dns/conditional_resolver.go
  • Line 3: warning: exported type QuestionPredicate should have comment or be unexported (golint)
  • Line 7: warning: exported type QuestionPredicateFunc should have comment or be unexported (golint)
  • Line 9: warning: exported method QuestionPredicateFunc.Matches should have comment or be unexported (golint)
  • Line 13: warning: exported type ConditionalResolver should have comment or be unexported (golint)
  • Line 18: warning: exported method ConditionalResolver.Matches should have comment or be unexported (golint)

• protocols/dhcp/emitting_handler.go
  • Line 11: warning: exported type EmittingHandler should have comment or be unexported (golint)
  • Line 16: warning: exported method EmittingHandler.Handle should have comment or be unexported (golint)

• pkg/cert/pem.go
  • Line 20: warning: exported type PEMCert should have comment or be unexported (golint)
  • Line 46: warning: exported function Read should have comment or be unexported (golint)
  • Line 53: warning: exported function ReadFrom should have comment or be unexported (golint)
  • Line 56: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• pkg/audit/reader.go
  • Line 18: warning: exported type Reader should have comment or be unexported (golint)
  • Line 22: warning: exported type EventReaderOption should have comment or be unexported (golint)
  • Line 24: warning: exported function NewEventReader should have comment or be unexported (golint)

• internal/mock/protocol/http_client_mock.go
  • Line 9: warning: exported type HTTPClientMockDoCallParams should have comment or be unexported (golint)
  • Line 13: warning: exported type HTTPClientMockDoCallResult should have comment or be unexported (golint)
  • Line 18: warning: exported type HTTPClientMockDoCall should have comment or be unexported (golint)
  • Line 24: warning: exported type HTTPClientMockCalls should have comment or be unexported (golint)
  • Line 28: warning: exported type HTTPClientMockContext should have comment or be unexported (golint)
  • Line 33: warning: exported type HTTPClientMock should have comment or be unexported (golint)
  • Line 39: warning: exported method HTTPClientMock.Do should have comment or be unexported (golint)

• pkg/audit/sink/log_sink.go
  • Line 14: warning: exported function NewLogSink should have comment or be unexported (golint)

• multiplexing/request_parsing.go
  • Line 18: warning: exported const HTTP2PseudoHeaderMethod should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: exported type HTTP2PseudoHeader should have comment or be unexported (golint)
  • Line 79: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• protocols/dns/mock/server.go
  • Line 70: warning: exported type Server should have comment or be unexported (golint)
  • Line 77: warning: exported method Server.ServeDNS should have comment or be unexported (golint)

• protocols/dhcp/range_msg_handler.go
  • Line 21: warning: exported type RangeLease should have comment or be unexported (golint)
  • Line 26: warning: exported type RangeMessageHandler should have comment or be unexported (golint)
  • Line 35: warning: exported method RangeMessageHandler.Handle should have comment or be unexported (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell0%

Misspell Finds commonly misspelled English words

An error occurred while running this test (exit status 2)