Preparing report...

Report for gitlab.com/mergetb/xir

A    Great!    Found 83 issues across 107 files

Tweet

gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo95%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint24%

Golint is a linter for Go source code.

    • /gitlab.com/mergetb/xir/lang/go/v0.2/sys/sys.go
    • Line 12: warning: exported type System should have comment or be unexported (golint)
    • Line 19: warning: exported type OperatingSystem should have comment or be unexported (golint)
    • Line 24: warning: comment on exported type OsConfig should be of the form "OsConfig ..." (with optional leading article) (golint)
    • Line 32: warning: exported function NewSystem should have comment or be unexported (golint)
    • Line 76: warning: exported method OperatingSystem.Link should have comment or be unexported (golint)
    • Line 99: warning: exported method System.Node should have comment or be unexported (golint)
    • Line 126: warning: exported function LinkInfo should have comment or be unexported (golint)
    • Line 143: warning: exported function Sys should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/hw/disk.go
    • Line 10: warning: exported type DiskFormFactor should have comment or be unexported (golint)
    • Line 13: warning: exported const DiskFormFactorUnknown should have comment (or a comment on this block) or be unexported (golint)
    • Line 78: warning: exported type DiskInterface should have comment or be unexported (golint)
    • Line 81: warning: exported const DiskInterfaceUnknown should have comment (or a comment on this block) or be unexported (golint)
    • Line 117: warning: exported type Disk should have comment or be unexported (golint)
    • Line 124: warning: exported function DiskHeader should have comment or be unexported (golint)
    • Line 130: warning: exported method Disk.Show should have comment or be unexported (golint)
    • Line 139: warning: exported method Disk.BaseInfo should have comment or be unexported (golint)
    • Line 141: warning: exported method Disk.Table should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.1/constraint.go
    • Line 3: warning: exported type Operator should have comment or be unexported (golint)
    • Line 6: warning: exported const EQ should have comment (or a comment on this block) or be unexported (golint)
    • Line 15: warning: exported type Constraint should have comment or be unexported (golint)
    • Line 20: warning: exported function Eq should have comment or be unexported (golint)
    • Line 21: warning: exported function Lt should have comment or be unexported (golint)
    • Line 22: warning: exported function Le should have comment or be unexported (golint)
    • Line 23: warning: exported function Gt should have comment or be unexported (golint)
    • Line 24: warning: exported function Ge should have comment or be unexported (golint)
    • Line 25: warning: exported function Choice should have comment or be unexported (golint)
    • Line 26: warning: exported function Select should have comment or be unexported (golint)
    • Line 28: warning: exported function LiftNetConstraints should have comment or be unexported (golint)
    • Line 44: warning: exported function IsValidOp should have comment or be unexported (golint)
    • Line 59: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 76: warning: exported function ExtractConstraint should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.1/structural.go
    • Line 26: warning: exported type Props should have comment or be unexported (golint)
    • Line 27: warning: exported type Prop should have comment or be unexported (golint)
    • Line 31: warning: exported type SortedProps should have comment or be unexported (golint)
    • Line 33: warning: exported type Vec2 should have comment or be unexported (golint)
    • Line 39: warning: exported type Bounds should have comment or be unexported (golint)
    • Line 43: warning: exported type Net should have comment or be unexported (golint)
    • Line 54: warning: exported type Endpoints should have comment or be unexported (golint)
    • Line 56: warning: exported type Node should have comment or be unexported (golint)
    • Line 70: warning: exported type Link should have comment or be unexported (golint)
    • Line 76: warning: exported type Endpoint should have comment or be unexported (golint)
    • Line 85: warning: comment on exported type AssetObject should be of the form "AssetObject ..." (with optional leading article) (golint)
    • Line 102: warning: exported type Software should have comment or be unexported (golint)
    • Line 107: warning: exported type Neighbor should have comment or be unexported (golint)
    • Line 114: warning: comment on exported method Props.Json should be of the form "Json ..." (golint)
    • Line 214: warning: exported method Net.AllLinks should have comment or be unexported (golint)
    • Line 229: warning: exported method Net.AllNodes should have comment or be unexported (golint)
    • Line 244: warning: exported method Net.Select should have comment or be unexported (golint)
    • Line 312: warning: exported method Net.AddLink should have comment or be unexported (golint)
    • Line 525: warning: exported method Net.Yaml should have comment or be unexported (golint)
    • Line 535: warning: exported method Node.Yaml should have comment or be unexported (golint)
    • Line 545: warning: receiver name net should be consistent with previous receiver name n for Net (golint)
    • Line 626: warning: comment on exported method Net.Json should be of the form "Json ..." (golint)
    • Line 698: warning: receiver name net should be consistent with previous receiver name n for Net (golint)
    • Line 766: warning: exported method Node.GetEndpoint should have comment or be unexported (golint)
    • Line 778: warning: exported method Node.GetEndpointId should have comment or be unexported (golint)
    • Line 800: warning: comment on exported method Node.AddSoftware should be of the form "AddSoftware ..." (golint)
    • Line 859: warning: exported method Node.GetNeighbor should have comment or be unexported (golint)
    • Line 990: warning: don't use underscores in Go names; var tags_ should be tags (golint)
    • Line 1008: warning: exported method Endpoints.Proto should have comment or be unexported (golint)
    • Line 1021: warning: exported method Endpoints.Has should have comment or be unexported (golint)
    • Line 1034: warning: exported method Endpoints.Tag should have comment or be unexported (golint)
    • Line 1038: warning: don't use underscores in Go names; var tags_ should be tags (golint)
    • Line 1052: warning: exported method Endpoints.Next should have comment or be unexported (golint)
    • Line 1064: warning: exported method Endpoints.RNext should have comment or be unexported (golint)
    • Line 1076: warning: exported method Node.Next should have comment or be unexported (golint)
    • Line 1082: warning: exported method Node.RNext should have comment or be unexported (golint)
    • Line 1088: warning: exported method Node.PNext should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.1/structural_test.go
    • Line 75: warning: don't use underscores in Go names; var t_ab should be tAb (golint)
    • Line 76: warning: don't use underscores in Go names; var t_ba should be tBa (golint)
    • Line 78: warning: don't use underscores in Go names; var t_bc should be tBc (golint)
    • Line 79: warning: don't use underscores in Go names; var t_cb should be tCb (golint)
    • Line 81: warning: don't use underscores in Go names; var t_ca should be tCa (golint)
    • Line 82: warning: don't use underscores in Go names; var t_ac should be tAc (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.1/hw/spec.go
    • Line 3: warning: exported type Procs should have comment or be unexported (golint)
    • Line 8: warning: exported type Dimms should have comment or be unexported (golint)
    • Line 13: warning: exported type Nics should have comment or be unexported (golint)
    • Line 18: warning: exported type Disks should have comment or be unexported (golint)
    • Line 38: warning: exported method DeviceSpec.AddProc should have comment or be unexported (golint)
    • Line 52: warning: exported method DeviceSpec.AddMemory should have comment or be unexported (golint)
    • Line 66: warning: exported method DeviceSpec.AddNic should have comment or be unexported (golint)
    • Line 80: warning: exported method DeviceSpec.AddDisk should have comment or be unexported (golint)
    • Line 94: warning: exported function NewSpec should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/hw/cable.go
    • Line 27: warning: exported const DACBreakout should have comment (or a comment on this block) or be unexported (golint)
    • Line 92: warning: exported method Cable.BaseInfo should have comment or be unexported (golint)
    • Line 93: warning: exported method Cable.Show should have comment or be unexported (golint)
    • Line 154: warning: comment on exported const QSFPDD should be of the form "QSFPDD ..." (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/hw/usb.go
    • Line 3: warning: exported type UsbVersion should have comment or be unexported (golint)
    • Line 6: warning: exported const USB1 should have comment (or a comment on this block) or be unexported (golint)
    • Line 14: warning: exported type Usb should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/hw/cables/copper.go
    • Line 165: warning: exported function Mlx100GDAC3M should have comment or be unexported (golint)
    • Line 195: warning: exported function Mlx100GDAC5M should have comment or be unexported (golint)
    • Line 225: warning: exported function Mlx25GDAC3M should have comment or be unexported (golint)
    • Line 255: warning: exported function Mlx100GDAC2M should have comment or be unexported (golint)
    • Line 285: warning: exported function Mlx100GDAC1M should have comment or be unexported (golint)
    • Line 315: warning: exported function Mlx10GDAC7M should have comment or be unexported (golint)
    • Line 377: warning: exported function Fs100GAOC should have comment or be unexported (golint)
    • Line 407: warning: exported function Fs10GAOC should have comment or be unexported (golint)
    • Line 437: warning: comment on exported function Fs25GDAC should be of the form "Fs25GDAC ..." (golint)
    • Line 469: warning: exported function Fs10GDAC should have comment or be unexported (golint)
    • Line 499: warning: comment on exported function Mlx200x50BreakoutDAC should be of the form "Mlx200x50BreakoutDAC ..." (golint)
    • Line 548: warning: exported function Mlx100x50BreakoutDAC2_5M should have comment or be unexported (golint)
    • Line 586: warning: exported function Mlx100x50BreakoutDAC1_5M should have comment or be unexported (golint)
    • Line 624: warning: exported function Mlx100x25BreakoutDAC2M should have comment or be unexported (golint)
    • Line 674: warning: exported function Mlx100x25BreakoutDAC2_5M should have comment or be unexported (golint)
    • Line 724: warning: exported function Mlx40x10BreakoutDAC5M should have comment or be unexported (golint)
    • Line 804: warning: exported function TenGtek40x10BreakoutDAC_3M should have comment or be unexported (golint)
    • Line 804: warning: don't use underscores in Go names; func TenGtek40x10BreakoutDAC_3M should be TenGtek40x10BreakoutDAC3M (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.1/sys/net.go
    • Line 11: warning: exported type PortRef should have comment or be unexported (golint)
    • Line 19: warning: exported type LinkKind should have comment or be unexported (golint)
    • Line 22: warning: exported const Loopback should have comment (or a comment on this block) or be unexported (golint)
    • Line 29: warning: exported type Link should have comment or be unexported (golint)
    • Line 39: warning: exported method Link.AddAddr should have comment or be unexported (golint)
    • Line 43: warning: exported type LinkSelector should have comment or be unexported (golint)
    • Line 45: warning: exported function Gbps should have comment or be unexported (golint)
    • Line 60: warning: exported function Lo should have comment or be unexported (golint)
    • Line 64: warning: exported function Links should have comment or be unexported (golint)
    • Line 84: warning: exported method OperatingSystem.Bond should have comment or be unexported (golint)
    • Line 102: warning: exported function GetBond should have comment or be unexported (golint)
    • Line 123: warning: exported type EvpnConfig should have comment or be unexported (golint)
    • Line 128: warning: exported type BridgeConfig should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/hw/unit.go
    • Line 7: warning: exported function MHz should have comment or be unexported (golint)
    • Line 11: warning: exported function Kb should have comment or be unexported (golint)
    • Line 15: warning: exported function Mb should have comment or be unexported (golint)
    • Line 19: warning: exported function Gb should have comment or be unexported (golint)
    • Line 23: warning: exported function Tb should have comment or be unexported (golint)
    • Line 27: warning: exported function Kbps should have comment or be unexported (golint)
    • Line 31: warning: exported function Mbps should have comment or be unexported (golint)
    • Line 35: warning: exported function Gbps should have comment or be unexported (golint)
    • Line 39: warning: exported function Tbps should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/test/dcomp/hw.go
    • Line 9: warning: exported function MinnowBoard should have comment or be unexported (golint)
    • Line 38: warning: exported function RccVe should have comment or be unexported (golint)
    • Line 77: warning: exported function XPort should have comment or be unexported (golint)
    • Line 95: warning: exported function Moa1000 should have comment or be unexported (golint)
    • Line 133: warning: exported function RSled1000 should have comment or be unexported (golint)
    • Line 162: warning: exported function DComp1000 should have comment or be unexported (golint)
    • Line 190: warning: exported function EdgecoreAS4610 should have comment or be unexported (golint)
    • Line 227: warning: exported function QuantaLYR4 should have comment or be unexported (golint)
    • Line 264: warning: exported function Msn2100 should have comment or be unexported (golint)
    • Line 293: warning: exported function Msn2700 should have comment or be unexported (golint)
    • Line 322: warning: exported function Zpe96 should have comment or be unexported (golint)
    • Line 348: warning: exported function AtomE3845 should have comment or be unexported (golint)
    • Line 366: warning: exported function AtomC2558 should have comment or be unexported (golint)
    • Line 384: warning: exported function Epyc7351 should have comment or be unexported (golint)
    • Line 402: warning: exported function Epyc7301 should have comment or be unexported (golint)
    • Line 420: warning: exported function Epyc7281 should have comment or be unexported (golint)
    • Line 438: warning: exported function I210AT should have comment or be unexported (golint)
    • Line 456: warning: exported function I350_DA4 should have comment or be unexported (golint)
    • Line 474: warning: exported function ConnectX4_2x100 should have comment or be unexported (golint)
    • Line 490: warning: exported function ConnectX4_2x25 should have comment or be unexported (golint)
    • Line 505: warning: exported function NetronomeLX_100 should have comment or be unexported (golint)
    • Line 505: warning: don't use underscores in Go names; func NetronomeLX_100 should be NetronomeLX100 (golint)
    • Line 519: warning: exported function FsDac100 should have comment or be unexported (golint)
    • Line 545: warning: exported function FsMpoBreakout40x10 should have comment or be unexported (golint)
    • Line 591: warning: exported function Cat6 should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/test/dcomp/topology.go
    • Line 11: warning: exported type DComp should have comment or be unexported (golint)
    • Line 47: warning: exported type District should have comment or be unexported (golint)
    • Line 73: warning: exported type Chassis should have comment or be unexported (golint)
    • Line 88: warning: exported const NumEmu should have comment (or a comment on this block) or be unexported (golint)
    • Line 104: warning: exported function DCompTB should have comment or be unexported (golint)
    • Line 147: warning: exported method DComp.Connect should have comment or be unexported (golint)
    • Line 163: warning: exported method DComp.Net should have comment or be unexported (golint)
    • Line 190: warning: exported method District.Net should have comment or be unexported (golint)
    • Line 222: warning: exported method Chassis.Net should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.1/xp/node.go
    • Line 7: warning: exported type Device should have comment or be unexported (golint)
    • Line 14: warning: exported type Proc should have comment or be unexported (golint)
    • Line 25: warning: exported type Memory should have comment or be unexported (golint)
    • Line 29: warning: exported type IP should have comment or be unexported (golint)
    • Line 34: warning: exported type Endpoint should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/hw/components/nic.go
    • Line 47: warning: exported function I210AT should have comment or be unexported (golint)
    • Line 170: warning: exported function ConnectX4_1x50 should have comment or be unexported (golint)
    • Line 188: warning: exported function ConnectX4_1x10 should have comment or be unexported (golint)
    • Line 206: warning: exported function ConnectX5_1x50 should have comment or be unexported (golint)
    • Line 243: warning: exported function ConnectX4_1x25 should have comment or be unexported (golint)
    • Line 286: warning: exported function ConnectX5_2x25 should have comment or be unexported (golint)
    • Line 307: warning: exported function XXV710DA2_OCP should have comment or be unexported (golint)
    • Line 328: warning: exported function ConnectX4_2x25_OCP should have comment or be unexported (golint)
    • Line 328: warning: don't use underscores in Go names; func ConnectX4_2x25_OCP should be ConnectX4_2x25OCP (golint)
    • Line 349: warning: exported function ConnectX5_2x25_OCP should have comment or be unexported (golint)
    • Line 349: warning: don't use underscores in Go names; func ConnectX5_2x25_OCP should be ConnectX5_2x25OCP (golint)
    • Line 370: warning: comment on exported function ConnectX6_2x50 should be of the form "ConnectX6_2x50 ..." (golint)
    • Line 503: warning: exported function NetronomeLX100 should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/hw/spec.go
    • Line 3: warning: exported type Procs should have comment or be unexported (golint)
    • Line 8: warning: exported type Dimms should have comment or be unexported (golint)
    • Line 13: warning: exported type Nics should have comment or be unexported (golint)
    • Line 18: warning: exported type Disks should have comment or be unexported (golint)
    • Line 38: warning: exported method DeviceSpec.CoreCount should have comment or be unexported (golint)
    • Line 49: warning: exported method DeviceSpec.MemoryCapacity should have comment or be unexported (golint)
    • Line 60: warning: exported method DeviceSpec.DiskCapacity should have comment or be unexported (golint)
    • Line 71: warning: exported method DeviceSpec.Bandwidth should have comment or be unexported (golint)
    • Line 84: warning: exported method DeviceSpec.AddProc should have comment or be unexported (golint)
    • Line 98: warning: exported method DeviceSpec.AddMemory should have comment or be unexported (golint)
    • Line 112: warning: exported method DeviceSpec.AddNic should have comment or be unexported (golint)
    • Line 126: warning: exported method DeviceSpec.AddDisk should have comment or be unexported (golint)
    • Line 140: warning: exported function NewSpec should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/hw/components/cpu.go
    • Line 7: warning: exported function XeonE31260L should have comment or be unexported (golint)
    • Line 26: warning: exported function XeonE52420v2 should have comment or be unexported (golint)
    • Line 44: warning: exported function XeonE52620v2 should have comment or be unexported (golint)
    • Line 81: warning: exported function XeonD2146NT should have comment or be unexported (golint)
    • Line 99: warning: exported function XeonD1527 should have comment or be unexported (golint)
    • Line 118: warning: exported function PentiumD1508 should have comment or be unexported (golint)
    • Line 137: warning: exported function Epyc7281 should have comment or be unexported (golint)
    • Line 213: warning: exported function Epyc7301 should have comment or be unexported (golint)
    • Line 252: warning: exported function Epyc7351 should have comment or be unexported (golint)
    • Line 271: warning: exported function Epyc7402 should have comment or be unexported (golint)
    • Line 290: warning: exported function Epyc7452 should have comment or be unexported (golint)
    • Line 410: warning: exported function XeonE52650V4 should have comment or be unexported (golint)
    • Line 429: warning: exported function AtomE3845 should have comment or be unexported (golint)
    • Line 448: warning: exported function AtomC3558 should have comment or be unexported (golint)
    • Line 467: warning: exported function AtomC2758 should have comment or be unexported (golint)
    • Line 486: warning: exported function AtomC2558 should have comment or be unexported (golint)
    • Line 505: warning: exported function AtomC2538 should have comment or be unexported (golint)
    • Line 524: warning: exported function AtomC2338 should have comment or be unexported (golint)
    • Line 543: warning: exported function BCMCoretexA9 should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/tb/lom.go
    • Line 14: warning: exported type Material should have comment or be unexported (golint)
    • Line 20: warning: exported method Material.ConfigItems should have comment or be unexported (golint)
    • Line 32: warning: exported type LOM should have comment or be unexported (golint)
    • Line 34: warning: exported type TBLOM should have comment or be unexported (golint)
    • Line 40: warning: exported method LOM.Print should have comment or be unexported (golint)
    • Line 49: warning: exported method TBLOM.Print should have comment or be unexported (golint)
    • Line 65: warning: exported function PrintMaterials should have comment or be unexported (golint)
    • Line 98: warning: exported function CalculateLOM should have comment or be unexported (golint)
    • Line 131: warning: exported method LOM.AddUnit should have comment or be unexported (golint)
    • Line 151: warning: exported method LOM.AddDevice should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.1/hw/unit.go
    • Line 7: warning: exported function Mhz should have comment or be unexported (golint)
    • Line 11: warning: exported function Mb should have comment or be unexported (golint)
    • Line 15: warning: exported function Gb should have comment or be unexported (golint)
    • Line 19: warning: exported function Tb should have comment or be unexported (golint)
    • Line 23: warning: exported function Kb should have comment or be unexported (golint)
    • Line 27: warning: exported function Mbps should have comment or be unexported (golint)
    • Line 31: warning: exported function Gbps should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/hw/nic.go
    • Line 12: warning: comment on exported type Layer1 should be of the form "Layer1 ..." (with optional leading article) (golint)
    • Line 16: warning: exported const UnspecProtocol should have comment (or a comment on this block) or be unexported (golint)
    • Line 18: warning: comment on exported const Base100T should be of the form "Base100T ..." (golint)
    • Line 21: warning: comment on exported const Base1000T should be of the form "Base1000T ..." (golint)
    • Line 32: warning: comment on exported const GBase10T should be of the form "GBase10T ..." (golint)
    • Line 43: warning: comment on exported const GBase25CR should be of the form "GBase25CR ..." (golint)
    • Line 49: warning: comment on exported const GBase40CR4 should be of the form "GBase40CR4 ..." (golint)
    • Line 55: warning: comment on exported const GBase100CR4 should be of the form "GBase100CR4 ..." (golint)
    • Line 62: warning: comment on exported const RS232 should be of the form "RS232 ..." (golint)
    • Line 66: warning: comment on exported const GBase50SR4 should be of the form "GBase50SR4 ..." (golint)
    • Line 80: warning: comment on exported const GBase200CR4 should be of the form "GBase200CR4 ..." (golint)
    • Line 91: warning: comment on exported const GBase400SR16 should be of the form "GBase400SR16 ..." (golint)
    • Line 262: warning: exported type Nic should have comment or be unexported (golint)
    • Line 270: warning: exported const Onboard should have comment (or a comment on this block) or be unexported (golint)
    • Line 274: warning: exported method Nic.BaseInfo should have comment or be unexported (golint)
    • Line 275: warning: exported method Nic.Show should have comment or be unexported (golint)
    • Line 284: warning: exported function NicHeader should have comment or be unexported (golint)
    • Line 290: warning: exported method Nic.Table should have comment or be unexported (golint)
    • Line 303: warning: exported method Nic.GetKind should have comment or be unexported (golint)
    • Line 306: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 311: warning: exported method Nic.Onboard should have comment or be unexported (golint)
    • Line 315: warning: exported type Port should have comment or be unexported (golint)
    • Line 326: warning: exported function Ports should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/hw/proc.go
    • Line 16: warning: exported const Unknown should have comment (or a comment on this block) or be unexported (golint)
    • Line 46: warning: exported method Proc.BaseInfo should have comment or be unexported (golint)
    • Line 47: warning: exported method Proc.Show should have comment or be unexported (golint)
    • Line 49: warning: exported function ProcHeader should have comment or be unexported (golint)
    • Line 55: warning: exported method Proc.Table should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/constraint.go
    • Line 3: warning: exported type Operator should have comment or be unexported (golint)
    • Line 6: warning: exported const EQ should have comment (or a comment on this block) or be unexported (golint)
    • Line 15: warning: exported type Constraint should have comment or be unexported (golint)
    • Line 20: warning: exported function Eq should have comment or be unexported (golint)
    • Line 21: warning: exported function Lt should have comment or be unexported (golint)
    • Line 22: warning: exported function Le should have comment or be unexported (golint)
    • Line 23: warning: exported function Gt should have comment or be unexported (golint)
    • Line 24: warning: exported function Ge should have comment or be unexported (golint)
    • Line 25: warning: exported function Choice should have comment or be unexported (golint)
    • Line 26: warning: exported function Select should have comment or be unexported (golint)
    • Line 28: warning: exported function LiftNetConstraints should have comment or be unexported (golint)
    • Line 44: warning: exported function IsValidOp should have comment or be unexported (golint)
    • Line 59: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 76: warning: exported function ExtractConstraint should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/sys/net.go
    • Line 12: warning: exported type PortRef should have comment or be unexported (golint)
    • Line 20: warning: exported type LinkKind should have comment or be unexported (golint)
    • Line 23: warning: exported const Loopback should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: exported type Link should have comment or be unexported (golint)
    • Line 42: warning: exported method Link.AddAddr should have comment or be unexported (golint)
    • Line 46: warning: exported type LinkSelector should have comment or be unexported (golint)
    • Line 48: warning: exported function Gbps should have comment or be unexported (golint)
    • Line 63: warning: exported function Lo should have comment or be unexported (golint)
    • Line 67: warning: exported function Links should have comment or be unexported (golint)
    • Line 87: warning: exported method OperatingSystem.Bond should have comment or be unexported (golint)
    • Line 105: warning: exported function GetBond should have comment or be unexported (golint)
    • Line 124: warning: exported function LinkLabel should have comment or be unexported (golint)
    • Line 149: warning: exported type EvpnConfig should have comment or be unexported (golint)
    • Line 154: warning: exported type BridgeConfig should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/test/dcomp/util.go
    • Line 15: warning: exported type Ip should have comment or be unexported (golint)
    • Line 19: warning: exported method Ip.IP should have comment or be unexported (golint)
    • Line 29: warning: exported method Ip.Next should have comment or be unexported (golint)
    • Line 55: warning: exported type BgpAS should have comment or be unexported (golint)
    • Line 57: warning: exported method BgpAS.Next should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.1/sys/sys.go
    • Line 13: warning: exported type System should have comment or be unexported (golint)
    • Line 20: warning: exported type OperatingSystem should have comment or be unexported (golint)
    • Line 25: warning: comment on exported type OsConfig should be of the form "OsConfig ..." (with optional leading article) (golint)
    • Line 31: warning: exported function NewSystem should have comment or be unexported (golint)
    • Line 71: warning: exported method OperatingSystem.Link should have comment or be unexported (golint)
    • Line 94: warning: exported method System.Node should have comment or be unexported (golint)
    • Line 119: warning: exported function LinkInfo should have comment or be unexported (golint)
    • Line 136: warning: exported function SysConfig should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/hw/components/disk.go
    • Line 9: warning: exported function DC_S3500_120 should have comment or be unexported (golint)
    • Line 26: warning: exported function DC_P4610_1600 should have comment or be unexported (golint)
    • Line 43: warning: exported function DC_P4510_1000 should have comment or be unexported (golint)
    • Line 60: warning: exported function DC_P4510_2000 should have comment or be unexported (golint)
    • Line 77: warning: exported function DC_P4510_4000 should have comment or be unexported (golint)
    • Line 94: warning: exported function DC_P4511_1024 should have comment or be unexported (golint)
    • Line 111: warning: exported function DC_S3520 should have comment or be unexported (golint)
    • Line 128: warning: exported function DC_P4101_256 should have comment or be unexported (golint)
    • Line 145: warning: exported function D3_P4610_1920 should have comment or be unexported (golint)
    • Line 162: warning: exported function D3_P4610_3200 should have comment or be unexported (golint)
    • Line 179: warning: exported function D3_S4610_960 should have comment or be unexported (golint)
    • Line 196: warning: exported function D3_S4510_1920 should have comment or be unexported (golint)
    • Line 213: warning: exported function Intel7600P_1TB should have comment or be unexported (golint)
    • Line 213: warning: don't use underscores in Go names; func Intel7600P_1TB should be Intel7600P1TB (golint)
    • Line 229: warning: exported function EMMC_32 should have comment or be unexported (golint)
    • Line 245: warning: exported function GenericDisk should have comment or be unexported (golint)
    • Line 261: warning: exported function CrucialMx500 should have comment or be unexported (golint)
    • Line 277: warning: exported function EXOS7E200_1024 should have comment or be unexported (golint)
    • Line 294: warning: exported function SeagateEnterpriseHDD_6TB should have comment or be unexported (golint)
    • Line 294: warning: don't use underscores in Go names; func SeagateEnterpriseHDD_6TB should be SeagateEnterpriseHDD6TB (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.1/hw/nic.go
    • Line 7: warning: comment on exported type Layer1 should be of the form "Layer1 ..." (with optional leading article) (golint)
    • Line 11: warning: exported const UnspecProtocol should have comment (or a comment on this block) or be unexported (golint)
    • Line 13: warning: comment on exported const Base100T should be of the form "Base100T ..." (golint)
    • Line 16: warning: comment on exported const Base1000T should be of the form "Base1000T ..." (golint)
    • Line 27: warning: comment on exported const GBase10T should be of the form "GBase10T ..." (golint)
    • Line 38: warning: comment on exported const GBase25CR should be of the form "GBase25CR ..." (golint)
    • Line 44: warning: comment on exported const GBase40CR4 should be of the form "GBase40CR4 ..." (golint)
    • Line 50: warning: comment on exported const GBase100CR4 should be of the form "GBase100CR4 ..." (golint)
    • Line 57: warning: comment on exported const RS232 should be of the form "RS232 ..." (golint)
    • Line 62: warning: exported type Nic should have comment or be unexported (golint)
    • Line 68: warning: exported method Nic.GetKind should have comment or be unexported (golint)
    • Line 71: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 76: warning: exported type Port should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/tools/xrvn/rvn.go
    • Line 3: warning: exported type Topo should have comment or be unexported (golint)
    • Line 12: warning: exported function NewTopo should have comment or be unexported (golint)
    • Line 25: warning: exported method Topo.NextPort should have comment or be unexported (golint)
    • Line 30: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 36: warning: exported type Node should have comment or be unexported (golint)
    • Line 47: warning: exported type CPU should have comment or be unexported (golint)
    • Line 51: warning: exported type Memory should have comment or be unexported (golint)
    • Line 55: warning: exported type Unit should have comment or be unexported (golint)
    • Line 60: warning: exported type Mount should have comment or be unexported (golint)
    • Line 65: warning: exported type Link should have comment or be unexported (golint)
    • Line 70: warning: exported type Endpoint should have comment or be unexported (golint)
    • Line 75: warning: exported type Config should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/xp/node.go
    • Line 7: warning: exported type Device should have comment or be unexported (golint)
    • Line 14: warning: exported type Proc should have comment or be unexported (golint)
    • Line 25: warning: exported type Memory should have comment or be unexported (golint)
    • Line 29: warning: exported type IP should have comment or be unexported (golint)
    • Line 34: warning: exported type Endpoint should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.1/hw/usb.go
    • Line 3: warning: exported type UsbVersion should have comment or be unexported (golint)
    • Line 6: warning: exported const USB1 should have comment (or a comment on this block) or be unexported (golint)
    • Line 14: warning: exported type Usb should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/hw/psu.go
    • Line 3: warning: exported type PowerRating should have comment or be unexported (golint)
    • Line 9: warning: exported type ACPowerRating should have comment or be unexported (golint)
    • Line 15: warning: exported type PowerConversionRating should have comment or be unexported (golint)
    • Line 20: warning: exported type PSU should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/test/dcomp/components.go
    • Line 11: warning: exported method DComp.NewEmu should have comment or be unexported (golint)
    • Line 30: warning: exported method DComp.NewStor should have comment or be unexported (golint)
    • Line 52: warning: exported method DComp.NewMgmt should have comment or be unexported (golint)
    • Line 71: warning: exported method DComp.NewISpine should have comment or be unexported (golint)
    • Line 91: warning: exported method DComp.NewXSpine should have comment or be unexported (golint)
    • Line 111: warning: exported method DComp.NewIFabric should have comment or be unexported (golint)
    • Line 133: warning: exported method DComp.NewXFabric should have comment or be unexported (golint)
    • Line 156: warning: exported const NumDistrictRccVe should have comment (or a comment on this block) or be unexported (golint)
    • Line 163: warning: exported method DComp.NewDistrict should have comment or be unexported (golint)
    • Line 196: warning: exported method District.NewRccVe should have comment or be unexported (golint)
    • Line 214: warning: exported method District.NewILeaf should have comment or be unexported (golint)
    • Line 238: warning: exported method District.NewXLeaf should have comment or be unexported (golint)
    • Line 261: warning: exported method District.NewConsoleServer should have comment or be unexported (golint)
    • Line 280: warning: exported method District.NewChassis should have comment or be unexported (golint)
    • Line 300: warning: exported const NumChassisMinnow should have comment (or a comment on this block) or be unexported (golint)
    • Line 303: warning: exported method Chassis.NewXPort should have comment or be unexported (golint)
    • Line 322: warning: exported method Chassis.NewMinnow should have comment or be unexported (golint)
    • Line 342: warning: exported method DComp.ConnectIFabrics should have comment or be unexported (golint)
    • Line 358: warning: exported method DComp.ConnectXFabrics should have comment or be unexported (golint)
    • Line 374: warning: exported method DComp.ConnectILeaves should have comment or be unexported (golint)
    • Line 395: warning: exported method DComp.ConnectXLeaves should have comment or be unexported (golint)
    • Line 416: warning: exported method District.ConnectMinnows should have comment or be unexported (golint)
    • Line 416: warning: receiver name di should be consistent with previous receiver name d for District (golint)
    • Line 438: warning: exported method District.ConnectRccVes should have comment or be unexported (golint)
    • Line 438: warning: receiver name di should be consistent with previous receiver name d for District (golint)
    • Line 461: warning: exported method DComp.ConnectMgmt should have comment or be unexported (golint)
    • Line 504: warning: exported method DComp.Cable should have comment or be unexported (golint)
    • Line 509: warning: exported method District.Cable should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/tb/generic.go
    • Line 8: warning: exported function SmallServer should have comment or be unexported (golint)
    • Line 41: warning: exported function MediumServer should have comment or be unexported (golint)
    • Line 79: warning: exported function LargeServer should have comment or be unexported (golint)
    • Line 117: warning: exported function GenericFabric should have comment or be unexported (golint)
    • Line 146: warning: exported function GenericLeaf should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/tb/resource.go
    • Line 18: warning: exported const AllocUnspec should have comment (or a comment on this block) or be unexported (golint)
    • Line 224: warning: exported function HasAllocMode should have comment or be unexported (golint)
    • Line 248: warning: exported function IsXp should have comment or be unexported (golint)
    • Line 307: warning: exported function HasRole should have comment or be unexported (golint)
    • Line 392: warning: exported function GetCableSpec should have comment or be unexported (golint)
    • Line 398: warning: exported function DecodeCable should have comment or be unexported (golint)
    • Line 416: warning: exported method Resource.NicKind should have comment or be unexported (golint)
    • Line 426: warning: exported method Resource.Port should have comment or be unexported (golint)
    • Line 434: warning: exported method Resource.Swp should have comment or be unexported (golint)
    • Line 435: warning: exported method Resource.Eth should have comment or be unexported (golint)
    • Line 436: warning: exported method Resource.Ipmi should have comment or be unexported (golint)
    • Line 438: warning: exported method Resource.NextSwp should have comment or be unexported (golint)
    • Line 453: warning: comment on exported function AssignSwpRole should be of the form "AssignSwpRole ..." (golint)
    • Line 462: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/tb/cost.go
    • Line 14: warning: exported type Cost should have comment or be unexported (golint)
    • Line 20: warning: exported type Tally should have comment or be unexported (golint)
    • Line 22: warning: exported type TallyItem should have comment or be unexported (golint)
    • Line 27: warning: exported method Tally.Add should have comment or be unexported (golint)
    • Line 46: warning: exported method Tally.Print should have comment or be unexported (golint)
    • Line 86: warning: exported function CalculateCost should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/hw/components/psu.go
    • Line 7: warning: exported function Gigabyte2200WPSU should have comment or be unexported (golint)
    • Line 55: warning: exported function Gigabyte1600WPSU should have comment or be unexported (golint)
    • Line 103: warning: exported function Gigabyte1200WPSU should have comment or be unexported (golint)
    • Line 151: warning: exported function Gigabyte1100WPSU should have comment or be unexported (golint)
    • Line 199: warning: exported function Mellanox765WPSU should have comment or be unexported (golint)
    • Line 225: warning: exported function Quanta215WPSU should have comment or be unexported (golint)
    • Line 251: warning: exported function Quanta66WPSU should have comment or be unexported (golint)
    • Line 277: warning: exported function Supermicro450WPSU should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/hw/device.go
    • Line 9: warning: exported type Device should have comment or be unexported (golint)
    • Line 21: warning: exported method Device.BaseInfo should have comment or be unexported (golint)
    • Line 22: warning: exported method Device.Show should have comment or be unexported (golint)
    • Line 24: warning: exported method Device.Node should have comment or be unexported (golint)
    • Line 108: warning: exported method Device.ComponentPower should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/hw/memory.go
    • Line 10: warning: exported type MemoryType should have comment or be unexported (golint)
    • Line 13: warning: exported const MemoryTypeUnknown should have comment (or a comment on this block) or be unexported (golint)
    • Line 29: warning: exported type Dimm should have comment or be unexported (golint)
    • Line 36: warning: exported method Dimm.BaseInfo should have comment or be unexported (golint)
    • Line 37: warning: exported method Dimm.Show should have comment or be unexported (golint)
    • Line 39: warning: exported function DimmHeader should have comment or be unexported (golint)
    • Line 45: warning: exported method Dimm.Table should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/structural_test.go
    • Line 75: warning: don't use underscores in Go names; var t_ab should be tAb (golint)
    • Line 76: warning: don't use underscores in Go names; var t_ba should be tBa (golint)
    • Line 78: warning: don't use underscores in Go names; var t_bc should be tBc (golint)
    • Line 79: warning: don't use underscores in Go names; var t_cb should be tCb (golint)
    • Line 81: warning: don't use underscores in Go names; var t_ca should be tCa (golint)
    • Line 82: warning: don't use underscores in Go names; var t_ac should be tAc (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.1/viz.go
    • Line 12: warning: exported type Point should have comment or be unexported (golint)
    • Line 18: warning: exported method Node.Position should have comment or be unexported (golint)
    • Line 22: warning: exported method Node.Velocity should have comment or be unexported (golint)
    • Line 26: warning: exported method Node.Weight should have comment or be unexported (golint)
    • Line 37: warning: exported method Net.Position should have comment or be unexported (golint)
    • Line 40: warning: exported method Net.Velocity should have comment or be unexported (golint)
    • Line 46: warning: exported method Endpoint.Position should have comment or be unexported (golint)
    • Line 49: warning: exported method Endpoint.Velocity should have comment or be unexported (golint)
    • Line 55: warning: exported method Net.Global should have comment or be unexported (golint)
    • Line 67: warning: exported method Node.Global should have comment or be unexported (golint)
    • Line 75: warning: exported method Endpoint.Global should have comment or be unexported (golint)
    • Line 83: warning: exported function Add should have comment or be unexported (golint)
    • Line 89: warning: exported method Net.Bounds should have comment or be unexported (golint)
    • Line 89: warning: receiver name net should be consistent with previous receiver name n for Net (golint)
    • Line 114: warning: exported method Bounds.Consume should have comment or be unexported (golint)
    • /gitlab.com/mergetb/xir/lang/go/v0.2/structural.go
    • Line 27: warning: exported type Props should have comment or be unexported (golint)
    • Line 28: warning: exported type Prop should have comment or be unexported (golint)
    • Line 32: warning: exported type SortedProps should have comment or be unexported (golint)
    • Line 34: warning: exported type Vec2 should have comment or be unexported (golint)
    • Line 40: warning: exported type Bounds should have comment or be unexported (golint)
    • Line 44: warning: exported type Model should have comment or be unexported (golint)
    • Line 48: warning: exported type Net should have comment or be unexported (golint)
    • Line 57: warning: exported type Endpoints should have comment or be unexported (golint)
    • Line 59: warning: exported type Node should have comment or be unexported (golint)
    • Line 68: warning: exported type Link should have comment or be unexported (golint)
    • Line 74: warning: exported type Endpoint should have comment or be unexported (golint)
    • Line 81: warning: exported type EndpointRef should have comment or be unexported (golint)
    • Line 87: warning: exported method Endpoint.Ref should have comment or be unexported (golint)
    • Line 95: warning: exported method Endpoint.Id should have comment or be unexported (golint)
    • Line 99: warning: exported method EndpointRef.Id should have comment or be unexported (golint)
    • Line 103: warning: comment on exported type AssetObject should be of the form "AssetObject ..." (with optional leading article) (golint)
    • Line 121: warning: exported type Software should have comment or be unexported (golint)
    • Line 126: warning: exported type Neighbor should have comment or be unexported (golint)
    • Line 133: warning: comment on exported method Props.Json should be of the form "Json ..." (golint)
    • Line 232: warning: exported method Net.AllLinks should have comment or be unexported (golint)
    • Line 247: warning: exported method Net.AllMounts should have comment or be unexported (golint)
    • Line 257: warning: exported method Net.AllNodes should have comment or be unexported (golint)
    • Line 272: warning: exported method Net.Select should have comment or be unexported (golint)
    • Line 323: warning: exported function LinkID should have comment or be unexported (golint)
    • Line 352: warning: exported method Net.AddLink should have comment or be unexported (golint)
    • Line 552: warning: exported method Net.Yaml should have comment or be unexported (golint)
    • Line 562: warning: exported method Node.Yaml should have comment or be unexported (golint)
    • Line 572: warning: receiver name net should be consistent with previous receiver name n for Net (golint)
    • Line 653: warning: comment on exported method Net.Json should be of the form "Json ..." (golint)
    • Line 727: warning: receiver name net should be consistent with previous receiver name n for Net (golint)
    • Line 793: warning: exported method Node.GetEndpoint should have comment or be unexported (golint)
    • Line 805: warning: exported method Node.GetEndpointById should have comment or be unexported (golint)
    • Line 827: warning: comment on exported method Node.AddSoftware should be of the form "AddSoftware ..." (golint)
    • Line 889: warning: exported method Node.GetNeighbor should have comment or be unexported (golint)
    • Line 1019: warning: don't use underscores in Go names; var tags_ should be tags (golint)
    • Line 1037: warning: exported method Endpoints.Proto should have comment or be unexported (golint)
    • Line 1050: warning: exported method Endpoints.Has should have comment or be unexported (golint)
    • Line 1063: warning: exported method Endpoints.Tag should have comment or be unexported (golint)
    • Line 1067: warning: don't use underscores in Go names; var tags_ should be tags (golint)
    • Line 1081: warning: exported method Endpoints.Next should have comment or be unexported (golint)
    • Line 1093: warning: exported method Endpoints.RNext should have comment or be unexported (golint)
    • Line 1105: warning: exported method Node.Next should have comment or be unexported (golint)
    • Line 1111: warning: exported method Node.RNext should have comment or be unexported (golint)
    • Line 1117: warning: exported method Node.PNext should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign95%

IneffAssign detects ineffectual assignments in Go code.


misspell95%

Misspell Finds commonly misspelled English words