gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo88%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• cluster-api-provider-openstack/api/v1alpha3/zz_generated.conversion.go
  • Line 41: warning: cyclomatic complexity 59 of function RegisterConversions() is high (> 15) (gocyclo)

• cluster-api-provider-openstack/pkg/cloud/services/loadbalancer/loadbalancer.go
  • Line 234: warning: cyclomatic complexity 17 of function (*Service).ReconcileLoadBalancerMember() is high (> 15) (gocyclo)

• cluster-api-provider-openstack/controllers/openstackmachine_controller.go
  • Line 255: warning: cyclomatic complexity 22 of function (*OpenStackMachineReconciler).reconcileNormal() is high (> 15) (gocyclo)
  • Line 188: warning: cyclomatic complexity 18 of function (*OpenStackMachineReconciler).reconcileDelete() is high (> 15) (gocyclo)

• cluster-api-provider-openstack/controllers/openstackcluster_controller.go
  • Line 330: warning: cyclomatic complexity 20 of function reconcileNetworkComponents() is high (> 15) (gocyclo)

• cluster-api-provider-openstack/pkg/cloud/services/networking/router.go
  • Line 34: warning: cyclomatic complexity 20 of function (*Service).ReconcileRouter() is high (> 15) (gocyclo)

• cluster-api-provider-openstack/pkg/cloud/services/networking/securitygroups.go
  • Line 378: warning: cyclomatic complexity 16 of function (*Service).reconcileGroupRules() is high (> 15) (gocyclo)

• cluster-api-provider-openstack/pkg/cloud/services/compute/instance.go
  • Line 152: warning: cyclomatic complexity 19 of function (*Service).createInstance() is high (> 15) (gocyclo)

golint53%

Golint is a linter for Go source code.

• cluster-api-provider-openstack/api/v1alpha3/conversion.go
  • Line 28: warning: exported method OpenStackCluster.ConvertTo should have comment or be unexported (golint)
  • Line 34: warning: exported method OpenStackCluster.ConvertFrom should have comment or be unexported (golint)
  • Line 42: warning: exported method OpenStackClusterList.ConvertTo should have comment or be unexported (golint)
  • Line 48: warning: exported method OpenStackClusterList.ConvertFrom should have comment or be unexported (golint)
  • Line 56: warning: exported method OpenStackMachine.ConvertTo should have comment or be unexported (golint)
  • Line 62: warning: exported method OpenStackMachine.ConvertFrom should have comment or be unexported (golint)
  • Line 70: warning: exported method OpenStackMachineList.ConvertTo should have comment or be unexported (golint)
  • Line 76: warning: exported method OpenStackMachineList.ConvertFrom should have comment or be unexported (golint)
  • Line 84: warning: exported method OpenStackMachineTemplate.ConvertTo should have comment or be unexported (golint)
  • Line 90: warning: exported method OpenStackMachineTemplate.ConvertFrom should have comment or be unexported (golint)
  • Line 98: warning: exported method OpenStackMachineTemplateList.ConvertTo should have comment or be unexported (golint)
  • Line 104: warning: exported method OpenStackMachineTemplateList.ConvertFrom should have comment or be unexported (golint)
  • Line 112: warning: don't use underscores in Go names; func Convert_v1alpha3_OpenStackClusterSpec_To_v1alpha4_OpenStackClusterSpec should be ConvertV1alpha3OpenStackClusterSpecToV1alpha4OpenStackClusterSpec (golint)
  • Line 118: warning: don't use underscores in Go names; func Convert_v1alpha3_OpenStackMachineSpec_To_v1alpha4_OpenStackMachineSpec should be ConvertV1alpha3OpenStackMachineSpecToV1alpha4OpenStackMachineSpec (golint)

• cluster-api-provider-openstack/api/v1alpha3/openstackcluster_conversion.go
  • Line 26: warning: don't use underscores in Go names; func Convert_v1alpha3_APIEndpoint_To_v1alpha4_APIEndpoint should be ConvertV1alpha3APIEndpointToV1alpha4APIEndpoint (golint)
  • Line 31: warning: don't use underscores in Go names; func Convert_v1alpha4_APIEndpoint_To_v1alpha3_APIEndpoint should be ConvertV1alpha4APIEndpointToV1alpha3APIEndpoint (golint)

• cluster-api-provider-openstack/api/v1alpha4/openstackmachinetemplate_webhook.go
  • Line 32: warning: exported method OpenStackMachineTemplate.SetupWebhookWithManager should have comment or be unexported (golint)

• cluster-api-provider-openstack/pkg/cloud/services/compute/availabilityzone.go
  • Line 25: warning: exported method Service.GetAvailabilityZones should have comment or be unexported (golint)

• cluster-api-provider-openstack/pkg/cloud/services/networking/floatingip.go
  • Line 30: warning: exported method Service.GetOrCreateFloatingIP should have comment or be unexported (golint)
  • Line 75: warning: exported method Service.GetFloatingIPByPortID should have comment or be unexported (golint)
  • Line 90: warning: exported method Service.DeleteFloatingIP should have comment or be unexported (golint)
  • Line 118: warning: exported method Service.AssociateFloatingIP should have comment or be unexported (golint)
  • Line 142: warning: exported method Service.DisassociateFloatingIP should have comment or be unexported (golint)

• cluster-api-provider-openstack/pkg/cloud/services/networking/network.go
  • Line 45: warning: exported method Service.ReconcileExternalNetwork should have comment or be unexported (golint)
  • Line 93: warning: exported method Service.ReconcileNetwork should have comment or be unexported (golint)
  • Line 153: warning: exported method Service.DeleteNetwork should have comment or be unexported (golint)
  • Line 174: warning: exported method Service.ReconcileSubnet should have comment or be unexported (golint)
  • Line 324: warning: comment on exported method Service.GetNetworkIDsByFilter should be of the form "GetNetworkIDsByFilter ..." (golint)
  • Line 337: warning: comment on exported method Service.GetSubnetsByFilter should be of the form "GetSubnetsByFilter ..." (golint)

• cluster-api-provider-openstack/api/v1alpha4/openstackcluster_webhook.go
  • Line 28: warning: exported method OpenStackCluster.SetupWebhookWithManager should have comment or be unexported (golint)

• cluster-api-provider-openstack/controllers/openstackcluster_controller.go
  • Line 66: warning: exported method OpenStackClusterReconciler.Reconcile should have comment or be unexported (golint)
  • Line 432: warning: exported method OpenStackClusterReconciler.SetupWithManager should have comment or be unexported (golint)

• cluster-api-provider-openstack/pkg/cloud/services/compute/instance.go
  • Line 55: warning: exported const TimeoutInstanceCreate should have comment (or a comment on this block) or be unexported (golint)
  • Line 67: warning: exported method Service.CreateInstance should have comment or be unexported (golint)
  • Line 499: warning: exported method Service.AssociateFloatingIP should have comment or be unexported (golint)
  • Line 511: warning: exported method Service.DeleteInstance should have comment or be unexported (golint)
  • Line 717: warning: exported method Service.GetInstance should have comment or be unexported (golint)
  • Line 735: warning: exported method Service.InstanceExists should have comment or be unexported (golint)
  • Line 804: warning: exported function GetIPFromInstance should have comment or be unexported (golint)

• cluster-api-provider-openstack/pkg/utils/names/names.go
  • Line 23: warning: exported function GetDescription should have comment or be unexported (golint)

• cluster-api-provider-openstack/pkg/cloud/services/compute/bastion.go
  • Line 25: warning: exported method Service.CreateBastion should have comment or be unexported (golint)

• cluster-api-provider-openstack/pkg/cloud/services/compute/service.go
  • Line 31: warning: exported type Service should have comment or be unexported (golint)

• cluster-api-provider-openstack/api/v1alpha3/types.go
  • Line 25: warning: exported type ExternalRouterIPParam should have comment or be unexported (golint)
  • Line 32: warning: exported type SecurityGroupParam should have comment or be unexported (golint)
  • Line 41: warning: exported type SecurityGroupFilter should have comment or be unexported (golint)
  • Line 57: warning: exported type NetworkParam should have comment or be unexported (golint)
  • Line 68: warning: exported type Filter should have comment or be unexported (golint)
  • Line 87: warning: exported type SubnetParam should have comment or be unexported (golint)
  • Line 95: warning: exported type SubnetFilter should have comment or be unexported (golint)
  • Line 119: warning: exported type Instance should have comment or be unexported (golint)
  • Line 141: warning: exported type RootVolume should have comment or be unexported (golint)
  • Line 230: warning: exported var InstanceStateBuilding should have comment or be unexported (golint)

• cluster-api-provider-openstack/pkg/record/recorder.go
  • Line 55: warning: comment on exported function Warn should be of the form "Warn ..." (golint)
  • Line 60: warning: comment on exported function Warnf should be of the form "Warnf ..." (golint)

• cluster-api-provider-openstack/pkg/cloud/services/networking/router.go
  • Line 34: warning: exported method Service.ReconcileRouter should have comment or be unexported (golint)
  • Line 197: warning: exported method Service.DeleteRouter should have comment or be unexported (golint)

• cluster-api-provider-openstack/api/v1alpha3/doc.go
  • Line 17: warning: package comment should be of the form "Package v1alpha3 ..." (golint)

• cluster-api-provider-openstack/pkg/cloud/services/networking/securitygroups.go
  • Line 59: warning: comment on exported method Service.ReconcileSecurityGroups should be of the form "ReconcileSecurityGroups ..." (golint)
  • Line 337: warning: exported method Service.DeleteSecurityGroups should have comment or be unexported (golint)
  • Line 351: warning: exported method Service.DeleteBastionSecurityGroup should have comment or be unexported (golint)

• cluster-api-provider-openstack/api/v1alpha4/openstackmachine_webhook.go
  • Line 35: warning: exported method OpenStackMachine.SetupWebhookWithManager should have comment or be unexported (golint)

• cluster-api-provider-openstack/api/v1alpha4/types.go
  • Line 25: warning: exported type ExternalRouterIPParam should have comment or be unexported (golint)
  • Line 32: warning: exported type SecurityGroupParam should have comment or be unexported (golint)
  • Line 41: warning: exported type SecurityGroupFilter should have comment or be unexported (golint)
  • Line 57: warning: exported type NetworkParam should have comment or be unexported (golint)
  • Line 68: warning: exported type Filter should have comment or be unexported (golint)
  • Line 87: warning: exported type SubnetParam should have comment or be unexported (golint)
  • Line 95: warning: exported type SubnetFilter should have comment or be unexported (golint)
  • Line 119: warning: exported type Instance should have comment or be unexported (golint)
  • Line 141: warning: exported type RootVolume should have comment or be unexported (golint)
  • Line 230: warning: exported var InstanceStateBuilding should have comment or be unexported (golint)

• cluster-api-provider-openstack/pkg/metrics/metrics.go
  • Line 27: warning: exported type OpenstackPrometheusMetrics should have comment or be unexported (golint)
  • Line 69: warning: exported var APIRequestPrometheusMetrics should have comment or be unexported (golint)
  • Line 92: warning: exported function RegisterAPIPrometheusMetrics should have comment or be unexported (golint)

• cluster-api-provider-openstack/pkg/cloud/services/loadbalancer/loadbalancer.go
  • Line 43: warning: exported method Service.ReconcileLoadBalancer should have comment or be unexported (golint)
  • Line 234: warning: exported method Service.ReconcileLoadBalancerMember should have comment or be unexported (golint)
  • Line 321: warning: exported method Service.DeleteLoadBalancer should have comment or be unexported (golint)
  • Line 363: warning: exported method Service.DeleteLoadBalancerMember should have comment or be unexported (golint)

• cluster-api-provider-openstack/api/v1alpha4/openstackmachinelist_webhook.go
  • Line 28: warning: exported method OpenStackMachineList.SetupWebhookWithManager should have comment or be unexported (golint)

• cluster-api-provider-openstack/controllers/openstackmachine_controller.go
  • Line 75: warning: exported method OpenStackMachineReconciler.Reconcile should have comment or be unexported (golint)
  • Line 151: warning: exported method OpenStackMachineReconciler.SetupWithManager should have comment or be unexported (golint)
  • Line 402: warning: comment on exported method OpenStackMachineReconciler.OpenStackClusterToOpenStackMachines should be of the form "OpenStackClusterToOpenStackMachines ..." (golint)

• cluster-api-provider-openstack/test/e2e/shared/kubernetesversions/template.go
  • Line 20: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 45: warning: exported type GenerateCIArtifactsInjectedTemplateForDebianInput should have comment or be unexported (golint)

• cluster-api-provider-openstack/version/version.go
  • Line 33: warning: exported type Info should have comment or be unexported (golint)
  • Line 45: warning: exported function Get should have comment or be unexported (golint)

• cluster-api-provider-openstack/api/v1alpha4/openstackmachinetemplatelist_webhook.go
  • Line 28: warning: exported method OpenStackMachineTemplateList.SetupWebhookWithManager should have comment or be unexported (golint)

• cluster-api-provider-openstack/pkg/cloud/services/provider/provider.go
  • Line 40: warning: exported const CloudsSecretKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 44: warning: exported function NewClientFromMachine should have comment or be unexported (golint)
  • Line 62: warning: exported function NewClientFromCluster should have comment or be unexported (golint)
  • Line 80: warning: exported function NewClient should have comment or be unexported (golint)
  • Line 180: warning: exported function GetProjectID should have comment or be unexported (golint)

• cluster-api-provider-openstack/api/v1alpha4/openstackclusterlist_webhook.go
  • Line 28: warning: exported method OpenStackClusterList.SetupWebhookWithManager should have comment or be unexported (golint)

• cluster-api-provider-openstack/pkg/utils/errors/errors.go
  • Line 26: warning: exported function IsRetryable should have comment or be unexported (golint)
  • Line 35: warning: exported function IsNotFound should have comment or be unexported (golint)
  • Line 56: warning: exported function IsInvalidError should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!