Preparing report...

Report for github.com/kubernetes-sigs/secrets-store-csi-driver

A+    Excellent!    Found 20 issues across 92 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint82%

Golint is a linter for Go source code.

    • secrets-store-csi-driver/pkg/csi-common/nodeserver-default.go
    • Line 26: warning: exported type DefaultNodeServer should have comment or be unexported (golint)
    • Line 30: warning: exported method DefaultNodeServer.NodePublishVolume should have comment or be unexported (golint)
    • Line 34: warning: exported method DefaultNodeServer.NodeUnpublishVolume should have comment or be unexported (golint)
    • Line 38: warning: exported method DefaultNodeServer.NodeGetInfo should have comment or be unexported (golint)
    • Line 44: warning: exported method DefaultNodeServer.NodeGetCapabilities should have comment or be unexported (golint)
    • Line 58: warning: exported method DefaultNodeServer.NodeGetVolumeStats should have comment or be unexported (golint)
    • secrets-store-csi-driver/controllers/secretproviderclasspodstatus_controller.go
    • Line 57: warning: exported const SecretManagedLabel should have comment (or a comment on this block) or be unexported (golint)
    • Line 91: warning: exported method SecretProviderClassPodStatusReconciler.RunPatcher should have comment or be unexported (golint)
    • Line 107: warning: exported method SecretProviderClassPodStatusReconciler.Patcher should have comment or be unexported (golint)
    • Line 216: warning: exported method SecretProviderClassPodStatusReconciler.Reconcile should have comment or be unexported (golint)
    • Line 357: warning: exported method SecretProviderClassPodStatusReconciler.SetupWithManager should have comment or be unexported (golint)
    • secrets-store-csi-driver/pkg/csi-common/controllerserver-default.go
    • Line 26: warning: exported type DefaultControllerServer should have comment or be unexported (golint)
    • Line 30: warning: exported method DefaultControllerServer.CreateVolume should have comment or be unexported (golint)
    • Line 34: warning: exported method DefaultControllerServer.DeleteVolume should have comment or be unexported (golint)
    • Line 38: warning: exported method DefaultControllerServer.ControllerPublishVolume should have comment or be unexported (golint)
    • Line 42: warning: exported method DefaultControllerServer.ControllerUnpublishVolume should have comment or be unexported (golint)
    • Line 46: warning: exported method DefaultControllerServer.ValidateVolumeCapabilities should have comment or be unexported (golint)
    • Line 50: warning: exported method DefaultControllerServer.ListVolumes should have comment or be unexported (golint)
    • Line 54: warning: exported method DefaultControllerServer.GetCapacity should have comment or be unexported (golint)
    • Line 66: warning: exported method DefaultControllerServer.CreateSnapshot should have comment or be unexported (golint)
    • Line 70: warning: exported method DefaultControllerServer.DeleteSnapshot should have comment or be unexported (golint)
    • Line 74: warning: exported method DefaultControllerServer.ListSnapshots should have comment or be unexported (golint)
    • Line 78: warning: exported method DefaultControllerServer.ControllerExpandVolume should have comment or be unexported (golint)
    • Line 82: warning: exported method DefaultControllerServer.ControllerGetVolume should have comment or be unexported (golint)
    • secrets-store-csi-driver/pkg/csi-common/driver.go
    • Line 63: warning: exported method CSIDriver.ValidateControllerServiceRequest should have comment or be unexported (golint)
    • Line 76: warning: exported method CSIDriver.AddControllerServiceCapabilities should have comment or be unexported (golint)
    • Line 87: warning: exported method CSIDriver.AddVolumeCapabilityAccessModes should have comment or be unexported (golint)
    • Line 97: warning: exported method CSIDriver.GetVolumeCapabilityAccessModes should have comment or be unexported (golint)
    • secrets-store-csi-driver/provider/fake/fake_server.go
    • Line 31: warning: exported type MockCSIProviderServer should have comment or be unexported (golint)
    • Line 84: warning: exported method MockCSIProviderServer.Start should have comment or be unexported (golint)
    • Line 94: warning: exported method MockCSIProviderServer.Stop should have comment or be unexported (golint)
    • secrets-store-csi-driver/pkg/secrets-store/mocks/stats_reporter_mock.go
    • Line 16: warning: exported type FakeReporter should have comment or be unexported (golint)
    • Line 25: warning: exported function NewFakeReporter should have comment or be unexported (golint)
    • Line 29: warning: exported method FakeReporter.ReportNodePublishCtMetric should have comment or be unexported (golint)
    • Line 33: warning: exported method FakeReporter.ReportNodeUnPublishCtMetric should have comment or be unexported (golint)
    • Line 37: warning: exported method FakeReporter.ReportNodePublishErrorCtMetric should have comment or be unexported (golint)
    • Line 41: warning: exported method FakeReporter.ReportNodeUnPublishErrorCtMetric should have comment or be unexported (golint)
    • Line 45: warning: exported method FakeReporter.ReportSyncK8SecretCtMetric should have comment or be unexported (golint)
    • Line 49: warning: exported method FakeReporter.ReportSyncK8SecretDuration should have comment or be unexported (golint)
    • Line 53: warning: exported method FakeReporter.ReportNodePublishCtMetricInvoked should have comment or be unexported (golint)
    • Line 56: warning: exported method FakeReporter.ReportNodeUnPublishCtMetricInvoked should have comment or be unexported (golint)
    • Line 59: warning: exported method FakeReporter.ReportNodePublishErrorCtMetricInvoked should have comment or be unexported (golint)
    • Line 62: warning: exported method FakeReporter.ReportNodeUnPublishErrorCtMetricInvoked should have comment or be unexported (golint)
    • Line 65: warning: exported method FakeReporter.ReportSyncK8SecretCtMetricInvoked should have comment or be unexported (golint)
    • Line 68: warning: exported method FakeReporter.ReportSyncK8SecretDurationInvoked should have comment or be unexported (golint)
    • secrets-store-csi-driver/pkg/csi-common/identityserver-default.go
    • Line 26: warning: exported type DefaultIdentityServer should have comment or be unexported (golint)
    • Line 30: warning: exported method DefaultIdentityServer.GetPluginInfo should have comment or be unexported (golint)
    • Line 45: warning: exported method DefaultIdentityServer.Probe should have comment or be unexported (golint)
    • Line 49: warning: exported method DefaultIdentityServer.GetPluginCapabilities should have comment or be unexported (golint)
    • secrets-store-csi-driver/pkg/csi-common/utils.go
    • Line 32: warning: exported function ParseEndpoint should have comment or be unexported (golint)
    • Line 42: warning: exported function NewVolumeCapabilityAccessMode should have comment or be unexported (golint)
    • Line 46: warning: exported function NewDefaultNodeServer should have comment or be unexported (golint)
    • Line 52: warning: exported function NewDefaultIdentityServer should have comment or be unexported (golint)
    • Line 58: warning: exported function NewDefaultControllerServer should have comment or be unexported (golint)
    • Line 64: warning: exported function NewControllerServiceCapability should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!