Preparing report...

Report for kubevault.dev/operator

A+    Excellent!    Found 136 issues across 205 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • /kubevault.dev/operator/pkg/vault/engine/config.go
    • Line 284: warning: cyclomatic complexity 16 of function (*SecretEngine).CreateElasticsearchConfig() is high (> 15) (gocyclo)
    • Line 360: warning: cyclomatic complexity 16 of function (*SecretEngine).CreateAWSConfig() is high (> 15) (gocyclo)
    • Line 442: warning: cyclomatic complexity 16 of function (*SecretEngine).CreateAzureConfig() is high (> 15) (gocyclo)

golint34%

Golint is a linter for Go source code.

    • /kubevault.dev/operator/test/e2e/framework/vault.go
    • Line 28: warning: should not use dot imports (golint)
    • Line 46: warning: exported const VaultTokenSecret should have comment (or a comment on this block) or be unexported (golint)
    • Line 52: warning: exported method Framework.DeployVaultServer should have comment or be unexported (golint)
    • Line 224: warning: exported method Framework.CleanUpVaultServer should have comment or be unexported (golint)
    • Line 229: warning: exported method Framework.DeleteVault should have comment or be unexported (golint)
    • Line 249: warning: exported method Framework.GetNodePortIP should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/docker/checks.go
    • Line 20: warning: exported const ACRegistry should have comment (or a comment on this block) or be unexported (golint)
    • Line 24: warning: exported type Docker should have comment or be unexported (golint)
    • Line 28: warning: exported method Docker.ToContainerImage should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/util/util.go
    • Line 33: warning: comment on exported function GetJwtTokenSecretFromServiceAccount should be of the form "GetJwtTokenSecretFromServiceAccount ..." (golint)
    • Line 63: warning: exported function TryGetJwtTokenSecretNameFromServiceAccount should have comment or be unexported (golint)
    • Line 72: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • /kubevault.dev/operator/pkg/vault/engine/config.go
    • Line 33: warning: exported const KVConfigMaxVersions should have comment or be unexported (golint)
    • Line 34: warning: exported const KVConfigCasRequired should have comment or be unexported (golint)
    • Line 35: warning: exported const KVConfigDeleteVersionsAfter should have comment or be unexported (golint)
    • Line 37: warning: exported method SecretEngine.CreateConfig should have comment or be unexported (golint)
    • Line 359: warning: comment on exported method SecretEngine.CreateAWSConfig should be of the form "CreateAWSConfig ..." (golint)
    • Line 441: warning: comment on exported method SecretEngine.CreateAzureConfig should be of the form "CreateAzureConfig ..." (golint)
    • Line 501: warning: comment on exported method SecretEngine.CreateGCPConfig should be of the form "CreateGCPConfig ..." (golint)
    • Line 545: warning: exported method SecretEngine.CreateKVConfig should have comment or be unexported (golint)
    • /kubevault.dev/operator/test/e2e/framework/appbinding.go
    • Line 28: warning: exported method Framework.CreateAppBinding should have comment or be unexported (golint)
    • Line 33: warning: exported method Framework.GetAppBinding should have comment or be unexported (golint)
    • Line 37: warning: exported method Framework.DeleteAppBinding should have comment or be unexported (golint)
    • Line 41: warning: exported method Framework.CreateLocalRef2AppRef should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/admission/azure_access_key_request_validator.go
    • Line 33: warning: exported type AzureAccessKeyRequestValidator should have comment or be unexported (golint)
    • Line 40: warning: exported method AzureAccessKeyRequestValidator.Resource should have comment or be unexported (golint)
    • Line 49: warning: exported method AzureAccessKeyRequestValidator.Initialize should have comment or be unexported (golint)
    • Line 57: warning: exported method AzureAccessKeyRequestValidator.Admit should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/secret/engines/pki/secret.go
    • Line 29: warning: exported const UID should have comment or be unexported (golint)
    • Line 31: warning: exported type CertOptions should have comment or be unexported (golint)
    • Line 43: warning: exported type SecretInfo should have comment or be unexported (golint)
    • Line 55: warning: exported function New should have comment or be unexported (golint)
    • Line 59: warning: exported function NewSecretManager should have comment or be unexported (golint)
    • Line 65: warning: exported function NewSecretManagerWithOptions should have comment or be unexported (golint)
    • Line 91: warning: exported function NewSecretGetter should have comment or be unexported (golint)
    • Line 100: warning: exported method SecretInfo.SetOptions should have comment or be unexported (golint)
    • Line 124: warning: exported method SecretInfo.GetSecret should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/unsealer/unsealer.go
    • Line 48: warning: exported const K8sTokenReviewerJwtEnv should have comment (or a comment on this block) or be unexported (golint)
    • Line 53: warning: exported type Unsealer should have comment or be unexported (golint)
    • Line 80: warning: exported function NewUnsealerService should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/auth/types/types.go
    • Line 32: warning: exported type AuthLoginResponse should have comment or be unexported (golint)
    • Line 36: warning: exported type Auth should have comment or be unexported (golint)
    • Line 40: warning: exported type AuthInfo should have comment or be unexported (golint)
    • Line 49: warning: exported type AuthExtraInfo should have comment or be unexported (golint)
    • Line 55: warning: exported function GetAuthInfoFromAppBinding should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/secret/engines/aws/secret.go
    • Line 30: warning: exported const UID should have comment (or a comment on this block) or be unexported (golint)
    • Line 34: warning: exported type SecretInfo should have comment or be unexported (golint)
    • Line 48: warning: exported function New should have comment or be unexported (golint)
    • Line 52: warning: exported function NewSecretManager should have comment or be unexported (golint)
    • Line 56: warning: exported function NewSecretManagerWithOptions should have comment or be unexported (golint)
    • Line 62: warning: exported function NewSecretGetter should have comment or be unexported (golint)
    • Line 70: warning: exported method SecretInfo.SetOptions should have comment or be unexported (golint)
    • Line 86: warning: exported method SecretInfo.GetSecret should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/secret/engines/gcp/secret.go
    • Line 31: warning: exported const UID should have comment (or a comment on this block) or be unexported (golint)
    • Line 34: warning: exported type SecretInfo should have comment or be unexported (golint)
    • Line 53: warning: exported function New should have comment or be unexported (golint)
    • Line 57: warning: exported function NewSecretManager should have comment or be unexported (golint)
    • Line 61: warning: exported function NewSecretManagerWithOptions should have comment or be unexported (golint)
    • Line 67: warning: exported function NewSecretGetter should have comment or be unexported (golint)
    • Line 78: warning: exported method SecretInfo.SetOptions should have comment or be unexported (golint)
    • Line 98: warning: exported method SecretInfo.GetSecret should have comment or be unexported (golint)
    • /kubevault.dev/operator/test/e2e/framework/postgres.go
    • Line 24: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 25: warning: should not use dot imports (golint)
    • Line 36: warning: exported const PostgresUser should have comment (or a comment on this block) or be unexported (golint)
    • Line 178: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 234: warning: exported method Framework.DeletePostgres should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/admission/gcp_access_key_request_validator.go
    • Line 33: warning: exported type GCPAccessKeyRequestValidator should have comment or be unexported (golint)
    • Line 40: warning: exported method GCPAccessKeyRequestValidator.Resource should have comment or be unexported (golint)
    • Line 49: warning: exported method GCPAccessKeyRequestValidator.Initialize should have comment or be unexported (golint)
    • Line 57: warning: exported method GCPAccessKeyRequestValidator.Admit should have comment or be unexported (golint)
    • /kubevault.dev/operator/test/e2e/framework/mongodb.go
    • Line 23: warning: should not use dot imports (golint)
    • Line 33: warning: exported const MongodbUser should have comment (or a comment on this block) or be unexported (golint)
    • Line 39: warning: exported var MongodbServiceName should have comment or be unexported (golint)
    • Line 195: warning: exported method Framework.DeleteMongodb should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/credential/credential.go
    • Line 33: warning: exported type CredManager should have comment or be unexported (golint)
    • Line 39: warning: comment on exported method CredManager.CreateSecret should be of the form "CreateSecret ..." (golint)
    • Line 65: warning: comment on exported method CredManager.CreateRole should be of the form "CreateRole ..." (golint)
    • Line 100: warning: comment on exported method CredManager.CreateRoleBinding should be of the form "CreateRoleBinding ..." (golint)
    • Line 124: warning: comment on exported method CredManager.IsLeaseExpired should be of the form "IsLeaseExpired ..." (golint)
    • Line 171: warning: comment on exported method CredManager.GetCredential should be of the form "GetCredential ..." (golint)
    • /kubevault.dev/operator/pkg/admission/database_access_request_validator.go
    • Line 38: warning: exported type DatabaseAccessRequestValidator should have comment or be unexported (golint)
    • Line 45: warning: exported method DatabaseAccessRequestValidator.Resource should have comment or be unexported (golint)
    • Line 54: warning: exported method DatabaseAccessRequestValidator.Initialize should have comment or be unexported (golint)
    • Line 62: warning: exported method DatabaseAccessRequestValidator.Admit should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/controller/vault.go
    • Line 53: warning: exported const EnvVaultAPIAddr should have comment (or a comment on this block) or be unexported (golint)
    • Line 66: warning: exported type Vault should have comment or be unexported (golint)
    • Line 90: warning: exported function NewVault should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/credential/aws/aws.go
    • Line 37: warning: exported type AWSCredManager should have comment or be unexported (golint)
    • Line 45: warning: exported function NewAWSCredentialManager should have comment or be unexported (golint)
    • Line 72: warning: exported function GetVaultRefAndRole should have comment or be unexported (golint)
    • Line 80: warning: exported method AWSCredManager.ParseCredential should have comment or be unexported (golint)
    • Line 94: warning: exported method AWSCredManager.GetOwnerReference should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/secret/engines/kv/secret.go
    • Line 28: warning: exported const UID should have comment or be unexported (golint)
    • Line 30: warning: exported type SecretInfo should have comment or be unexported (golint)
    • Line 40: warning: exported function New should have comment or be unexported (golint)
    • Line 44: warning: exported function NewSecretManager should have comment or be unexported (golint)
    • Line 48: warning: exported function NewSecretManagerWithOptions should have comment or be unexported (golint)
    • Line 60: warning: exported function NewSecretGetter should have comment or be unexported (golint)
    • Line 68: warning: exported method SecretInfo.SetOptions should have comment or be unexported (golint)
    • Line 79: warning: exported method SecretInfo.GetSecret should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/role/azure/azure.go
    • Line 30: warning: exported const DefaultAzurePath should have comment or be unexported (golint)
    • Line 32: warning: exported type AzureRoleInterface should have comment or be unexported (golint)
    • Line 39: warning: exported function NewAzureRole should have comment or be unexported (golint)
    • Line 62: warning: comment on exported function GetAzurePath should be of the form "GetAzurePath ..." (golint)
    • /kubevault.dev/operator/pkg/vault/storage/mysql/mysql.go
    • Line 34: warning: exported const MySQLTLSCAFile should have comment (or a comment on this block) or be unexported (golint)
    • Line 43: warning: exported type Options should have comment or be unexported (golint)
    • Line 49: warning: exported function NewOptions should have comment or be unexported (golint)
    • Line 81: warning: exported method Options.Apply should have comment or be unexported (golint)
    • Line 107: warning: comment on exported method Options.GetStorageConfig should be of the form "GetStorageConfig ..." (golint)
    • /kubevault.dev/operator/test/e2e/framework/policybinding.go
    • Line 24: warning: should not use dot imports (golint)
    • Line 31: warning: exported method Invocation.VaultPolicyBinding should have comment or be unexported (golint)
    • Line 59: warning: exported method Framework.CreateVaultPolicyBinding should have comment or be unexported (golint)
    • Line 63: warning: exported method Framework.GetVaultPolicyBinding should have comment or be unexported (golint)
    • Line 67: warning: exported method Framework.UpdateVaultPolicyBinding should have comment or be unexported (golint)
    • Line 71: warning: exported method Framework.DeleteVaultPolicyBinding should have comment or be unexported (golint)
    • Line 75: warning: exported method Framework.EventuallyVaultPolicyBinding should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/storage/dynamodb/dynamodb.go
    • Line 34: warning: exported type Options should have comment or be unexported (golint)
    • Line 38: warning: exported function NewOptions should have comment or be unexported (golint)
    • Line 44: warning: exported method Options.Apply should have comment or be unexported (golint)
    • Line 88: warning: comment on exported method Options.GetStorageConfig should be of the form "GetStorageConfig ..." (golint)
    • /kubevault.dev/operator/pkg/vault/storage/etcd/etcd.go
    • Line 30: warning: comment on exported const EtcdTLSAssetDir should be of the form "EtcdTLSAssetDir ..." (golint)
    • Line 32: warning: exported const EtcdClientCaName should have comment (or a comment on this block) or be unexported (golint)
    • Line 43: warning: exported type Options should have comment or be unexported (golint)
    • Line 47: warning: exported function NewOptions should have comment or be unexported (golint)
    • Line 107: warning: comment on exported method Options.GetStorageConfig should be of the form "GetStorageConfig ..." (golint)
    • /kubevault.dev/operator/pkg/vault/engine/engine.go
    • Line 36: warning: exported const DefaultKVPath should have comment or be unexported (golint)
    • Line 37: warning: exported const DefaultKVVersion should have comment or be unexported (golint)
    • Line 39: warning: exported type SecretEngine should have comment or be unexported (golint)
    • Line 47: warning: exported function NewSecretEngine should have comment or be unexported (golint)
    • Line 71: warning: exported function GetSecretEnginePath should have comment or be unexported (golint)
    • Line 90: warning: comment on exported method SecretEngine.IsSecretEngineEnabled should be of the form "IsSecretEngineEnabled ..." (golint)
    • Line 106: warning: comment on exported method SecretEngine.EnableSecretEngine should be of the form "EnableSecretEngine ..." (golint)
    • Line 152: warning: exported method SecretEngine.DisableSecretEngine should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/admission/aws_access_key_request_validator.go
    • Line 38: warning: exported type AWSAccessKeyRequestValidator should have comment or be unexported (golint)
    • Line 45: warning: exported method AWSAccessKeyRequestValidator.Resource should have comment or be unexported (golint)
    • Line 54: warning: exported method AWSAccessKeyRequestValidator.Initialize should have comment or be unexported (golint)
    • Line 62: warning: exported method AWSAccessKeyRequestValidator.Admit should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/engine/config_test.go
    • Line 76: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 97: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 153: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 181: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 227: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 273: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 335: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • /kubevault.dev/operator/test/e2e/framework/admission.go
    • Line 30: warning: should not use dot imports (golint)
    • Line 31: warning: should not use dot imports (golint)
    • Line 41: warning: exported method Framework.NewTestVaultServerOptions should have comment or be unexported (golint)
    • Line 56: warning: exported method Framework.StartAPIServerAndOperator should have comment or be unexported (golint)
    • Line 90: warning: exported method Framework.EventuallyAPIServerReady should have comment or be unexported (golint)
    • Line 107: warning: exported method Framework.CleanAdmissionConfigs should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/server/server.go
    • Line 53: warning: exported var Scheme should have comment or be unexported (golint)
    • Line 75: warning: exported type VaultServerConfig should have comment or be unexported (golint)
    • Line 86: warning: exported method VaultServer.Run should have comment or be unexported (golint)
    • Line 96: warning: exported type CompletedConfig should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/cmds/server/options.go
    • Line 35: warning: exported type ExtraOptions should have comment or be unexported (golint)
    • Line 46: warning: exported function NewExtraOptions should have comment or be unexported (golint)
    • Line 57: warning: exported method ExtraOptions.AddGoFlags should have comment or be unexported (golint)
    • Line 70: warning: exported method ExtraOptions.AddFlags should have comment or be unexported (golint)
    • Line 76: warning: exported method ExtraOptions.ApplyTo should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/storage/gcs/gcs.go
    • Line 36: warning: exported const GoogleCredentialFile should have comment (or a comment on this block) or be unexported (golint)
    • Line 41: warning: exported type Options should have comment or be unexported (golint)
    • Line 45: warning: exported function NewOptions should have comment or be unexported (golint)
    • Line 51: warning: exported method Options.Apply should have comment or be unexported (golint)
    • Line 75: warning: comment on exported method Options.GetStorageConfig should be of the form "GetStorageConfig ..." (golint)
    • /kubevault.dev/operator/test/e2e/framework/vaultserver.go
    • Line 26: warning: should not use dot imports (golint)
    • Line 27: warning: should not use dot imports (golint)
    • Line 38: warning: exported method Invocation.VaultServer should have comment or be unexported (golint)
    • Line 55: warning: exported method Invocation.VaultServerWithUnsealer should have comment or be unexported (golint)
    • Line 61: warning: exported method Framework.CreateVaultServer should have comment or be unexported (golint)
    • Line 65: warning: exported method Framework.GetVaultServer should have comment or be unexported (golint)
    • Line 69: warning: exported method Framework.UpdateVaultServer should have comment or be unexported (golint)
    • Line 83: warning: exported method Framework.DeleteVaultServerObj should have comment or be unexported (golint)
    • Line 91: warning: exported method Framework.DeleteVaultServer should have comment or be unexported (golint)
    • Line 99: warning: exported method Framework.EventuallyVaultServer should have comment or be unexported (golint)
    • /kubevault.dev/operator/test/e2e/framework/secret.go
    • Line 23: warning: should not use dot imports (golint)
    • Line 30: warning: exported method Framework.CreateSecret should have comment or be unexported (golint)
    • Line 35: warning: exported method Framework.CreateSecretWithData should have comment or be unexported (golint)
    • Line 47: warning: exported method Framework.DeleteSecret should have comment or be unexported (golint)
    • Line 55: warning: exported method Framework.EventuallySecret should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/controller/vaultservers.go
    • Line 81: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 218: warning: exported method VaultController.CreateVaultTLSSecret should have comment or be unexported (golint)
    • Line 234: warning: exported method VaultController.CreateVaultConfig should have comment or be unexported (golint)
    • Line 242: warning: comment on exported method VaultController.DeployVault should be of the form "DeployVault ..." (golint)
    • /kubevault.dev/operator/pkg/admission/vault_server_validator.go
    • Line 45: warning: exported type VaultServerValidator should have comment or be unexported (golint)
    • Line 54: warning: exported method VaultServerValidator.Resource should have comment or be unexported (golint)
    • Line 63: warning: exported method VaultServerValidator.Initialize should have comment or be unexported (golint)
    • Line 79: warning: exported method VaultServerValidator.Admit should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/role/aws/aws.go
    • Line 30: warning: exported const DefaultAWSPath should have comment or be unexported (golint)
    • Line 32: warning: exported type AWSRoleInterface should have comment or be unexported (golint)
    • Line 39: warning: exported function NewAWSRole should have comment or be unexported (golint)
    • Line 63: warning: comment on exported function GetAWSPath should be of the form "GetAWSPath ..." (golint)
    • /kubevault.dev/operator/test/e2e/framework/policy.go
    • Line 24: warning: should not use dot imports (golint)
    • Line 32: warning: exported method Invocation.VaultPolicy should have comment or be unexported (golint)
    • Line 50: warning: exported method Framework.CreateVaultPolicy should have comment or be unexported (golint)
    • Line 54: warning: exported method Framework.GetVaultPolicy should have comment or be unexported (golint)
    • Line 58: warning: exported method Framework.UpdateVaultPolicy should have comment or be unexported (golint)
    • Line 62: warning: exported method Framework.DeleteVaultPolicy should have comment or be unexported (golint)
    • Line 66: warning: exported method Framework.EventuallyVaultPolicy should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/storage/swift/swift.go
    • Line 34: warning: exported type Options should have comment or be unexported (golint)
    • Line 38: warning: exported function NewOptions should have comment or be unexported (golint)
    • Line 44: warning: exported method Options.Apply should have comment or be unexported (golint)
    • Line 88: warning: comment on exported method Options.GetStorageConfig should be of the form "GetStorageConfig ..." (golint)
    • /kubevault.dev/operator/test/e2e/framework/postgresql.go
    • Line 26: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 27: warning: should not use dot imports (golint)
    • Line 43: warning: exported method Framework.DeployPostgresSQL should have comment or be unexported (golint)
    • Line 244: warning: exported method Framework.DeletePostgresSQL should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/cmds/server/start.go
    • Line 36: warning: exported type VaultServerOptions should have comment or be unexported (golint)
    • Line 44: warning: exported function NewVaultServerOptions should have comment or be unexported (golint)
    • Line 61: warning: exported method VaultServerOptions.AddFlags should have comment or be unexported (golint)
    • Line 66: warning: exported method VaultServerOptions.Validate should have comment or be unexported (golint)
    • Line 70: warning: exported method VaultServerOptions.Complete should have comment or be unexported (golint)
    • Line 74: warning: exported method VaultServerOptions.Config should have comment or be unexported (golint)
    • Line 100: warning: exported method VaultServerOptions.Run should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/credential/azure/azure.go
    • Line 38: warning: exported type AzureCredManager should have comment or be unexported (golint)
    • Line 46: warning: exported function NewAzureCredentialManager should have comment or be unexported (golint)
    • Line 74: warning: exported function GetVaultRefAndRole should have comment or be unexported (golint)
    • Line 82: warning: exported method AzureCredManager.ParseCredential should have comment or be unexported (golint)
    • Line 98: warning: exported method AzureCredManager.GetOwnerReference should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/credential/gcp/gcp.go
    • Line 38: warning: exported type GCPCredManager should have comment or be unexported (golint)
    • Line 46: warning: exported function NewGCPCredentialManager should have comment or be unexported (golint)
    • Line 74: warning: exported function GetVaultRefAndRole should have comment or be unexported (golint)
    • Line 82: warning: exported method GCPCredManager.ParseCredential should have comment or be unexported (golint)
    • Line 98: warning: exported method GCPCredManager.GetOwnerReference should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/role/database/database_role.go
    • Line 38: warning: exported const DefaultDatabasePath should have comment (or a comment on this block) or be unexported (golint)
    • Line 41: warning: exported type DatabaseRole should have comment or be unexported (golint)
    • Line 47: warning: exported function NewDatabaseRoleForPostgres should have comment or be unexported (golint)
    • Line 76: warning: exported function NewDatabaseRoleForMysql should have comment or be unexported (golint)
    • Line 104: warning: exported function NewDatabaseRoleForMongodb should have comment or be unexported (golint)
    • Line 131: warning: exported function NewDatabaseRoleForElasticsearch should have comment or be unexported (golint)
    • Line 212: warning: comment on exported function GetMySQLDatabasePath should be of the form "GetMySQLDatabasePath ..." (golint)
    • Line 220: warning: comment on exported function GetMongoDBDatabasePath should be of the form "GetMongoDBDatabasePath ..." (golint)
    • Line 228: warning: comment on exported function GetPostgresDatabasePath should be of the form "GetPostgresDatabasePath ..." (golint)
    • Line 236: warning: comment on exported function GetElasticsearchDatabasePath should be of the form "GetElasticsearchDatabasePath ..." (golint)
    • /kubevault.dev/operator/test/e2e/framework/deployment.go
    • Line 22: warning: should not use dot imports (golint)
    • Line 28: warning: exported method Framework.CreateDeployment should have comment or be unexported (golint)
    • Line 32: warning: exported method Framework.DeleteDeployment should have comment or be unexported (golint)
    • Line 36: warning: exported method Framework.EventuallyDeployment should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/credential/factory.go
    • Line 34: warning: exported function NewCredentialManagerForDatabase should have comment or be unexported (golint)
    • Line 49: warning: exported function NewCredentialManagerForAWS should have comment or be unexported (golint)
    • Line 64: warning: exported function NewCredentialManagerForGCP should have comment or be unexported (golint)
    • Line 79: warning: exported function NewCredentialManagerForAzure should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/admission/vault_server_mutator.go
    • Line 35: warning: exported type VaultServerMutator should have comment or be unexported (golint)
    • Line 42: warning: exported method VaultServerMutator.Resource should have comment or be unexported (golint)
    • Line 51: warning: exported method VaultServerMutator.Initialize should have comment or be unexported (golint)
    • Line 59: warning: exported method VaultServerMutator.Admit should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/role/gcp/gcp_role.go
    • Line 29: warning: exported type GCPRole should have comment or be unexported (golint)
    • Line 37: warning: exported const GCPSecretType should have comment (or a comment on this block) or be unexported (golint)
    • Line 41: warning: comment on exported method GCPRole.CreateRole should be of the form "CreateRole ..." (golint)
    • /kubevault.dev/operator/pkg/vault/unsealer/aws/aws_kms_ssm.go
    • Line 32: warning: exported const ModeAwsKmsSsm should have comment (or a comment on this block) or be unexported (golint)
    • Line 35: warning: exported type Options should have comment or be unexported (golint)
    • Line 39: warning: exported function NewOptions should have comment or be unexported (golint)
    • Line 45: warning: exported method Options.Apply should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/eventer/recorder.go
    • Line 35: warning: exported const EventReasonInvalidRestic should have comment (or a comment on this block) or be unexported (golint)
    • Line 59: warning: exported function NewEventRecorder should have comment or be unexported (golint)
    • Line 73: warning: exported function CreateEvent should have comment or be unexported (golint)
    • Line 97: warning: exported function CreateEventWithLog should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/storage/azure/azure.go
    • Line 29: warning: exported const AzureAccountKeyEnv should have comment (or a comment on this block) or be unexported (golint)
    • Line 38: warning: exported type Options should have comment or be unexported (golint)
    • Line 42: warning: exported function NewOptions should have comment or be unexported (golint)
    • Line 48: warning: exported method Options.Apply should have comment or be unexported (golint)
    • Line 65: warning: exported method Options.GetSecrets should have comment or be unexported (golint)
    • Line 69: warning: comment on exported method Options.GetStorageConfig should be of the form "GetStorageConfig ..." (golint)
    • /kubevault.dev/operator/test/e2e/framework/configmap.go
    • Line 22: warning: should not use dot imports (golint)
    • Line 28: warning: exported method Framework.CreateConfigMap should have comment or be unexported (golint)
    • Line 33: warning: exported method Framework.DeleteConfigMap should have comment or be unexported (golint)
    • Line 37: warning: exported method Framework.EventuallyConfigMap should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/admission/vault_policy_binding_mutator.go
    • Line 37: warning: exported type PolicyBindingMutator should have comment or be unexported (golint)
    • Line 44: warning: exported method PolicyBindingMutator.Resource should have comment or be unexported (golint)
    • Line 53: warning: exported method PolicyBindingMutator.Initialize should have comment or be unexported (golint)
    • Line 61: warning: exported method PolicyBindingMutator.Admit should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/secret/engines/database/secret.go
    • Line 28: warning: exported const UID should have comment or be unexported (golint)
    • Line 30: warning: exported type SecretInfo should have comment or be unexported (golint)
    • Line 40: warning: exported function New should have comment or be unexported (golint)
    • Line 44: warning: exported function NewSecretManager should have comment or be unexported (golint)
    • Line 48: warning: exported function NewSecretManagerWithOptions should have comment or be unexported (golint)
    • Line 60: warning: exported function NewSecretGetter should have comment or be unexported (golint)
    • Line 68: warning: exported method SecretInfo.SetOptions should have comment or be unexported (golint)
    • Line 79: warning: exported method SecretInfo.GetSecret should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/engine/policy.go
    • Line 39: warning: comment on exported const SecretEnginePolicyGCP should be of the form "SecretEnginePolicyGCP ..." (golint)
    • Line 62: warning: comment on exported const SecretEnginePolicyAWS should be of the form "SecretEnginePolicyAWS ..." (golint)
    • Line 85: warning: comment on exported const SecretEnginePolicyAzure should be of the form "SecretEnginePolicyAzure ..." (golint)
    • Line 104: warning: comment on exported const SecretEnginePolicyDatabase should be of the form "SecretEnginePolicyDatabase ..." (golint)
    • Line 123: warning: exported const SecretEnginePolicyKVV2 should have comment or be unexported (golint)
    • Line 129: warning: exported type KubernetesAuthRole should have comment or be unexported (golint)
    • Line 132: warning: exported type RoleData should have comment or be unexported (golint)
    • Line 146: warning: exported method SecretEngine.CreatePolicy should have comment or be unexported (golint)
    • Line 187: warning: exported function GetVaultRoleInfo should have comment or be unexported (golint)
    • Line 230: warning: exported method SecretEngine.UpdateAuthRole should have comment or be unexported (golint)
    • Line 265: warning: exported method SecretEngine.DeletePolicyAndUpdateRole should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/secret/engines/azure/secret.go
    • Line 29: warning: exported const UID should have comment (or a comment on this block) or be unexported (golint)
    • Line 32: warning: exported type SecretInfo should have comment or be unexported (golint)
    • Line 42: warning: exported function New should have comment or be unexported (golint)
    • Line 46: warning: exported function NewSecretManager should have comment or be unexported (golint)
    • Line 50: warning: exported function NewSecretManagerWithOptions should have comment or be unexported (golint)
    • Line 56: warning: exported function NewSecretGetter should have comment or be unexported (golint)
    • Line 64: warning: exported method SecretInfo.SetOptions should have comment or be unexported (golint)
    • Line 75: warning: exported method SecretInfo.GetSecret should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/storage/file/file.go
    • Line 35: warning: exported const VaultFileSystemVolumeName should have comment (or a comment on this block) or be unexported (golint)
    • Line 44: warning: exported type Options should have comment or be unexported (golint)
    • Line 49: warning: exported function NewOptions should have comment or be unexported (golint)
    • Line 100: warning: exported method Options.Apply should have comment or be unexported (golint)
    • Line 122: warning: comment on exported method Options.GetStorageConfig should be of the form "GetStorageConfig ..." (golint)
    • /kubevault.dev/operator/pkg/vault/role/gcp/gcp.go
    • Line 30: warning: exported const DefaultGCPPath should have comment or be unexported (golint)
    • Line 32: warning: exported type GCPRoleInterface should have comment or be unexported (golint)
    • Line 39: warning: exported function NewGCPRole should have comment or be unexported (golint)
    • Line 61: warning: comment on exported function GetGCPPath should be of the form "GetGCPPath ..." (golint)
    • /kubevault.dev/operator/pkg/vault/credential/database/database.go
    • Line 38: warning: exported type DBCredManager should have comment or be unexported (golint)
    • Line 46: warning: exported function NewDatabaseCredentialManager should have comment or be unexported (golint)
    • Line 65: warning: exported function GetVaultRefAndRole should have comment or be unexported (golint)
    • Line 132: warning: exported method DBCredManager.ParseCredential should have comment or be unexported (golint)
    • Line 148: warning: exported method DBCredManager.GetOwnerReference should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/util/vault_config.go
    • Line 30: warning: exported const VaultContainerName should have comment (or a comment on this block) or be unexported (golint)
    • Line 60: warning: comment on exported function GetListenerConfig should be of the form "GetListenerConfig ..." (golint)
    • Line 70: warning: exported function NewVaultClient should have comment or be unexported (golint)
    • /kubevault.dev/operator/test/e2e/framework/framework.go
    • Line 26: warning: should not use dot imports (golint)
    • Line 45: warning: exported var SelfHostedOperator should have comment or be unexported (golint)
    • Line 51: warning: exported type Framework should have comment or be unexported (golint)
    • Line 69: warning: exported function New should have comment or be unexported (golint)
    • Line 90: warning: exported method Framework.InitialSetup should have comment or be unexported (golint)
    • Line 126: warning: exported method Framework.Cleanup should have comment or be unexported (golint)
    • Line 161: warning: exported method Framework.Invoke should have comment or be unexported (golint)
    • Line 168: warning: exported type Invocation should have comment or be unexported (golint)
    • /kubevault.dev/operator/pkg/vault/storage/consul/consul.go
    • Line 34: warning: comment on exported const ConsulTLSAssetDir should be of the form "ConsulTLSAssetDir ..." (golint)
    • Line 36: warning: exported const ConsulClientCaName should have comment (or a comment on this block) or be unexported (golint)
    • Line 47: warning: exported type Options should have comment or be unexported (golint)
    • Line 53: warning: exported function NewOptions should have comment or be unexported (golint)
    • Line 86: warning: comment on exported method Options.GetStorageConfig should be of the form "GetStorageConfig ..." (golint)
    • Line 134: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • /kubevault.dev/operator/pkg/vault/storage/s3/s3.go
    • Line 34: warning: exported type Options should have comment or be unexported (golint)
    • Line 38: warning: exported function NewOptions should have comment or be unexported (golint)
    • Line 44: warning: comment on exported method Options.Apply should be of the form "Apply ..." (golint)
    • Line 92: warning: comment on exported method Options.GetStorageConfig should be of the form "GetStorageConfig ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!