Report for github.com/mashiike/stefunny
A+ Excellent! Found 11 issues across 19 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo94%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
stefunny/internal/asl/asl.go
- Line 115: warning: cyclomatic complexity 24 of function (*State).toGraph() is high (> 15) (gocyclo)
golint42%
Golint is a linter for Go source code.
-
-
stefunny/internal/jsonutil/util.go
- Line 14: warning: exported function JSONDiffString should have comment or be unexported (golint)
- Line 49: warning: exported function MarshalJSONString should have comment or be unexported (golint)
- Line 96: warning: exported function Yaml2Json should have comment or be unexported (golint)
-
-
stefunny/internal/asl/asl.go
- Line 13: warning: comment on exported type StateMachine should be of the form "StateMachine ..." (with optional leading article) (golint)
- Line 19: warning: exported type State should have comment or be unexported (golint)
- Line 30: warning: exported type Choice should have comment or be unexported (golint)
- Line 34: warning: exported type Catch should have comment or be unexported (golint)
- Line 39: warning: exported function Parse should have comment or be unexported (golint)
- Line 51: warning: exported method StateMachine.MarshalDOT should have comment or be unexported (golint)
-
-
stefunny/config.go
- Line 24: warning: exported type Config should have comment or be unexported (golint)
- Line 40: warning: exported type StateMachineConfig should have comment or be unexported (golint)
- Line 50: warning: exported type StateMachineLoggingConfig should have comment or be unexported (golint)
- Line 58: warning: exported type StateMachineLoggingDestinationConfig should have comment or be unexported (golint)
- Line 62: warning: exported type StateMachineTracingConfig should have comment or be unexported (golint)
- Line 66: warning: exported type EndpointsConfig should have comment or be unexported (golint)
- Line 73: warning: exported type ScheduleConfig should have comment or be unexported (golint)
- Line 78: warning: exported method Config.Load should have comment or be unexported (golint)
- Line 271: warning: exported function NewDefaultConfig should have comment or be unexported (golint)
- Line 292: warning: exported method Config.LoadDefinition should have comment or be unexported (golint)
- Line 299: warning: exported method StateMachineConfig.LoadTracingConfiguration should have comment or be unexported (golint)
- Line 323: warning: exported method Config.EndpointResolver should have comment or be unexported (golint)
-
-
stefunny/delete.go
- Line 11: warning: exported method App.Delete should have comment or be unexported (golint)
-
-
stefunny/deploy.go
- Line 12: warning: exported method App.Deploy should have comment or be unexported (golint)
- Line 66: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
stefunny/options.go
- Line 7: warning: exported type DeleteOption should have comment or be unexported (golint)
- Line 12: warning: exported method DeleteOption.DryRunString should have comment or be unexported (golint)
- Line 19: warning: exported type DeployOption should have comment or be unexported (golint)
- Line 25: warning: exported method DeployOption.DryRunString should have comment or be unexported (golint)
- Line 32: warning: exported type RenderOption should have comment or be unexported (golint)
- Line 36: warning: exported type LoadConfigOption should have comment or be unexported (golint)
-
-
stefunny/internal/logger/logger.go
- Line 12: warning: exported function Setup should have comment or be unexported (golint)
-
-
stefunny/app.go
- Line 22: warning: exported type App should have comment or be unexported (golint)
- Line 27: warning: exported function New should have comment or be unexported (golint)
- Line 45: warning: exported function NewWithClient should have comment or be unexported (golint)
- Line 52: warning: exported method App.Render should have comment or be unexported (golint)
- Line 69: warning: exported method App.LoadLoggingConfiguration should have comment or be unexported (golint)
- Line 95: warning: exported method App.LoadStateMachine should have comment or be unexported (golint)
- Line 125: warning: exported method App.LoadScheduleRule should have comment or be unexported (golint)
-
-
stefunny/aws.go
- Line 20: warning: exported type SFnClient should have comment or be unexported (golint)
- Line 30: warning: exported type CWLogsClient should have comment or be unexported (golint)
- Line 33: warning: exported type EventBridgeClient should have comment or be unexported (golint)
- Line 42: warning: exported type AWSClients should have comment or be unexported (golint)
- Line 47: warning: exported type AWSService should have comment or be unexported (golint)
- Line 55: warning: exported function NewAWSService should have comment or be unexported (golint)
- Line 67: warning: exported var ErrScheduleRuleDoesNotExist should have comment or be unexported (golint)
- Line 72: warning: exported type StateMachine should have comment or be unexported (golint)
- Line 80: warning: exported method AWSService.DescribeStateMachine should have comment or be unexported (golint)
- Line 122: warning: exported method AWSService.GetStateMachineArn should have comment or be unexported (golint)
- Line 144: warning: exported method AWSService.GetLogGroupArn should have comment or be unexported (golint)
- Line 167: warning: exported type DeployStateMachineOutput should have comment or be unexported (golint)
- Line 173: warning: exported method AWSService.DeployStateMachine should have comment or be unexported (golint)
- Line 233: warning: exported method AWSService.DeleteStateMachine should have comment or be unexported (golint)
- Line 253: warning: exported method StateMachine.DiffString should have comment or be unexported (golint)
- Line 279: warning: exported type ScheduleRule should have comment or be unexported (golint)
- Line 286: warning: exported method AWSService.DescribeScheduleRule should have comment or be unexported (golint)
- Line 328: warning: exported type DeployScheduleRuleOutput should have comment or be unexported (golint)
- Line 334: warning: exported method AWSService.DeployScheduleRule should have comment or be unexported (golint)
- Line 354: warning: exported method AWSService.DeleteScheduleRule should have comment or be unexported (golint)
- Line 362: warning: exported method ScheduleRule.SetStateMachineArn should have comment or be unexported (golint)
- Line 391: warning: exported method ScheduleRule.DiffString should have comment or be unexported (golint)
- Line 397: warning: exported method ScheduleRule.SetEnalbed should have comment or be unexported (golint)
-
-
stefunny/create.go
- Line 12: warning: exported method App.Create should have comment or be unexported (golint)
-
-
stefunny/cmd/stefunny/main.go
- Line 19: warning: exported var Version should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!