Preparing report...

Report for github.com/mhmxs/calico-route-reflector-operator

A+    Excellent!    Found 9 issues across 19 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo89%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint57%

Golint is a linter for Go source code.

    • calico-route-reflector-operator/topologies/multi.go
    • Line 1: warning: package comment should be of the form "Package topologies ..." (golint)
    • Line 33: warning: exported type MultiTopology should have comment or be unexported (golint)
    • Line 38: warning: exported method MultiTopology.IsRouteReflector should have comment or be unexported (golint)
    • Line 43: warning: exported method MultiTopology.GetClusterID should have comment or be unexported (golint)
    • Line 58: warning: exported method MultiTopology.GetNodeLabel should have comment or be unexported (golint)
    • Line 62: warning: exported method MultiTopology.NewNodeListOptions should have comment or be unexported (golint)
    • Line 66: warning: exported method MultiTopology.GetRouteReflectorStatuses should have comment or be unexported (golint)
    • Line 102: warning: exported method MultiTopology.GenerateBGPPeers should have comment or be unexported (golint)
    • Line 267: warning: exported function NewMultiTopology should have comment or be unexported (golint)
    • calico-route-reflector-operator/topologies/single.go
    • Line 1: warning: package comment should be of the form "Package topologies ..." (golint)
    • Line 30: warning: exported type SingleTopology should have comment or be unexported (golint)
    • Line 34: warning: exported method SingleTopology.IsRouteReflector should have comment or be unexported (golint)
    • Line 39: warning: exported method SingleTopology.GetClusterID should have comment or be unexported (golint)
    • Line 43: warning: exported method SingleTopology.GetNodeLabel should have comment or be unexported (golint)
    • Line 47: warning: exported method SingleTopology.NewNodeListOptions should have comment or be unexported (golint)
    • Line 67: warning: exported method SingleTopology.GetRouteReflectorStatuses should have comment or be unexported (golint)
    • Line 94: warning: exported method SingleTopology.GenerateBGPPeers should have comment or be unexported (golint)
    • Line 134: warning: exported function NewSingleTopology should have comment or be unexported (golint)
    • calico-route-reflector-operator/topologies/topology.go
    • Line 27: warning: comment on exported const DefaultRouteReflectorMeshName should be of the form "DefaultRouteReflectorMeshName ..." (golint)
    • Line 29: warning: exported const DefaultRouteReflectorClientName should have comment (or a comment on this block) or be unexported (golint)
    • Line 32: warning: exported type RouteReflectorStatus should have comment or be unexported (golint)
    • Line 39: warning: exported type Topology should have comment or be unexported (golint)
    • Line 48: warning: exported type Config should have comment or be unexported (golint)
    • calico-route-reflector-operator/datastores/etcd.go
    • Line 1: warning: package comment should be of the form "Package datastores ..." (golint)
    • Line 34: warning: exported type EtcdDataStore should have comment or be unexported (golint)
    • Line 39: warning: exported method EtcdDataStore.RemoveRRStatus should have comment or be unexported (golint)
    • Line 46: warning: exported method EtcdDataStore.AddRRStatus should have comment or be unexported (golint)
    • Line 87: warning: exported function NewEtcdDatastore should have comment or be unexported (golint)
    • calico-route-reflector-operator/datastores/kdd.go
    • Line 1: warning: package comment should be of the form "Package datastores ..." (golint)
    • Line 24: warning: exported const RouteReflectorClusterIDAnnotation should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: exported type KddDataStore should have comment or be unexported (golint)
    • Line 31: warning: exported method KddDataStore.RemoveRRStatus should have comment or be unexported (golint)
    • Line 39: warning: exported method KddDataStore.AddRRStatus should have comment or be unexported (golint)
    • Line 49: warning: exported function NewKddDatastore should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!