Report for github.com/qlik-oss/corectl
A+ Excellent! Found 8 issues across 68 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
golint92%
Golint is a linter for Go source code.
-
-
corectl/internal/rest/metadata.go
- Line 31: warning: exported type RestMetadata should have comment or be unexported (golint)
- Line 37: warning: exported method RestMetadata.TableByName should have comment or be unexported (golint)
- Line 48: warning: exported method RestMetadata.FieldByName should have comment or be unexported (golint)
-
-
corectl/internal/log/log.go
- Line 114: warning: exported function Quietln should have comment or be unexported (golint)
- Line 118: warning: exported function Quietf should have comment or be unexported (golint)
- Line 122: warning: exported function Quiet should have comment or be unexported (golint)
- Line 126: warning: exported function Fatalf should have comment or be unexported (golint)
- Line 131: warning: exported function Fatalln should have comment or be unexported (golint)
- Line 136: warning: exported function Fatal should have comment or be unexported (golint)
- Line 141: warning: exported function Errorln should have comment or be unexported (golint)
- Line 145: warning: exported function Errorf should have comment or be unexported (golint)
- Line 149: warning: exported function Error should have comment or be unexported (golint)
- Line 153: warning: exported function Warnln should have comment or be unexported (golint)
- Line 157: warning: exported function Warnf should have comment or be unexported (golint)
- Line 161: warning: exported function Warn should have comment or be unexported (golint)
- Line 165: warning: exported function Infoln should have comment or be unexported (golint)
- Line 169: warning: exported function Infof should have comment or be unexported (golint)
- Line 173: warning: exported function Info should have comment or be unexported (golint)
- Line 177: warning: exported function Verboseln should have comment or be unexported (golint)
- Line 181: warning: exported function Verbosef should have comment or be unexported (golint)
- Line 185: warning: exported function Verbose should have comment or be unexported (golint)
-
-
corectl/test/toolkit/environment.go
- Line 14: warning: exported var EngineStdIP should have comment or be unexported (golint)
- Line 15: warning: exported var EngineJwtIP should have comment or be unexported (golint)
- Line 16: warning: exported var EngineAbacIP should have comment or be unexported (golint)
- Line 17: warning: exported var EngineBadLicenseServerIP should have comment or be unexported (golint)
-
-
corectl/test/toolkit/test_toolkit.go
- Line 19: warning: exported type Params should have comment or be unexported (golint)
- Line 42: warning: exported function AddGoldPolisher should have comment or be unexported (golint)
- Line 54: warning: exported method Params.ExpectGolden should have comment or be unexported (golint)
- Line 60: warning: exported method Params.ExpectGoldenErr should have comment or be unexported (golint)
- Line 66: warning: exported method Params.ExpectOK should have comment or be unexported (golint)
- Line 71: warning: exported method Params.ExpectEmptyOK should have comment or be unexported (golint)
- Line 77: warning: exported method Params.ExpectError should have comment or be unexported (golint)
- Line 83: warning: exported method Params.ExpectErrorEquals should have comment or be unexported (golint)
- Line 90: warning: exported method Params.ExpectErrorIncludes should have comment or be unexported (golint)
- Line 97: warning: exported method Params.ExpectIncludes should have comment or be unexported (golint)
- Line 103: warning: exported method Params.ExpectEqual should have comment or be unexported (golint)
- Line 113: warning: exported method Params.ExpectEmptyJsonArray should have comment or be unexported (golint)
- Line 119: warning: exported method Params.ExpectJsonArray should have comment or be unexported (golint)
- Line 126: warning: exported method Params.Describe should have comment or be unexported (golint)
- Line 143: warning: exported method Params.WithParams should have comment or be unexported (golint)
- Line 172: warning: exported method Params.Run should have comment or be unexported (golint)
- Line 295: warning: exported method Params.Reset should have comment or be unexported (golint)
-
-
corectl/internal/rest/app.go
- Line 49: warning: exported type RestNxApp should have comment or be unexported (golint)
- Line 53: warning: exported method RestNxApp.Get should have comment or be unexported (golint)
gocyclo97%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
corectl/printer/entities.go
- Line 67: warning: cyclomatic complexity 26 of function PrintGenericEntityProperties() is high (> 15) (gocyclo)
-
-
corectl/test/toolkit/test_toolkit.go
- Line 172: warning: cyclomatic complexity 28 of function (*Params).Run() is high (> 15) (gocyclo)
ineffassign97%
IneffAssign detects ineffectual assignments in Go code.
-
-
corectl/printer/entities.go
- Line 126: warning: ineffectual assignment to err (ineffassign)
- Line 128: warning: ineffectual assignment to err (ineffassign)
- Line 135: warning: ineffectual assignment to err (ineffassign)
- Line 141: warning: ineffectual assignment to err (ineffassign)
- Line 148: warning: ineffectual assignment to err (ineffassign)
- Line 154: warning: ineffectual assignment to err (ineffassign)
- Line 177: warning: ineffectual assignment to err (ineffassign)
- Line 183: warning: ineffectual assignment to err (ineffassign)
- Line 189: warning: ineffectual assignment to err (ineffassign)
- Line 196: warning: ineffectual assignment to err (ineffassign)
- Line 202: warning: ineffectual assignment to err (ineffassign)
-
-
corectl/internal/object.go
- Line 160: warning: ineffectual assignment to err (ineffassign)
misspell98%
Misspell Finds commonly misspelled English words
-
-
corectl/test/corectl_integration_test.go
- Line 488: warning: "overriden" is a misspelling of "overridden" (misspell)