gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• reef-pi/controller/utils/number_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• reef-pi/controller/utils/systemd.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• reef-pi/controller/telemetry/mailer.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• reef-pi/controller/telemetry/mailer_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• reef-pi/controller/telemetry/vcgencmd.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• reef-pi/controller/pwm_profile/random.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• reef-pi/controller/modules/ph/api_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• reef-pi/controller/utils/number.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo89%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• reef-pi/controller/homestatsis.go
  • Line 108: warning: cyclomatic complexity 16 of function (*Homeostasis).Sync() is high (> 15) (gocyclo)

• reef-pi/controller/modules/ph/api_test.go
  • Line 12: warning: cyclomatic complexity 21 of function TestPhAPI() is high (> 15) (gocyclo)

• reef-pi/controller/modules/ato/controlller_test.go
  • Line 15: warning: cyclomatic complexity 25 of function TestController() is high (> 15) (gocyclo)

• reef-pi/controller/modules/temperature/api_test.go
  • Line 14: warning: cyclomatic complexity 22 of function TestTemperatureAPI() is high (> 15) (gocyclo)

• reef-pi/controller/modules/lighting/api_test.go
  • Line 15: warning: cyclomatic complexity 17 of function TestLightingAPI() is high (> 15) (gocyclo)

• reef-pi/controller/telemetry/mailer_test.go
  • Line 9: warning: cyclomatic complexity 20 of function TestMailer() is high (> 15) (gocyclo)

• reef-pi/controller/drivers/api_test.go
  • Line 39: warning: cyclomatic complexity 16 of function TestDrivers_API() is high (> 15) (gocyclo)

• reef-pi/controller/modules/doser/api_test.go
  • Line 16: warning: cyclomatic complexity 17 of function TestDoserAPI() is high (> 15) (gocyclo)

• reef-pi/controller/daemon/api_test.go
  • Line 14: warning: cyclomatic complexity 22 of function TestAPI() is high (> 15) (gocyclo)

• reef-pi/controller/modules/ph/controller.go
  • Line 119: warning: cyclomatic complexity 22 of function (*Controller).InUse() is high (> 15) (gocyclo)

• reef-pi/controller/modules/ato/controlller.go
  • Line 110: warning: cyclomatic complexity 16 of function (*Controller).InUse() is high (> 15) (gocyclo)

• reef-pi/controller/modules/system/api_test.go
  • Line 14: warning: cyclomatic complexity 21 of function TestSystemController() is high (> 15) (gocyclo)

• reef-pi/controller/modules/timer/api_test.go
  • Line 15: warning: cyclomatic complexity 22 of function TestTimerController() is high (> 15) (gocyclo)

• reef-pi/commands/db.go
  • Line 83: warning: cyclomatic complexity 20 of function (*dbCmd).Execute() is high (> 15) (gocyclo)

• reef-pi/controller/connectors/jack_test.go
  • Line 14: warning: cyclomatic complexity 16 of function TestJacksAPI() is high (> 15) (gocyclo)

• reef-pi/controller/modules/camera/camera_test.go
  • Line 14: warning: cyclomatic complexity 17 of function TestCamera() is high (> 15) (gocyclo)

• reef-pi/controller/modules/equipment/controller_test.go
  • Line 14: warning: cyclomatic complexity 22 of function TestEquipmentController() is high (> 15) (gocyclo)

golint33%

Golint is a linter for Go source code.

• reef-pi/controller/connectors/inlet.go
  • Line 18: warning: exported const InletBucket should have comment or be unexported (golint)
  • Line 20: warning: comment on exported type Inlet should be of the form "Inlet ..." (with optional leading article) (golint)
  • Line 30: warning: exported type Inlets should have comment or be unexported (golint)
  • Line 35: warning: exported method Inlets.LoadAPI should have comment or be unexported (golint)
  • Line 152: warning: exported method Inlet.IsValid should have comment or be unexported (golint)
  • Line 162: warning: exported function NewInlets should have comment or be unexported (golint)
  • Line 169: warning: exported method Inlets.Setup should have comment or be unexported (golint)
  • Line 169: warning: receiver name c should be consistent with previous receiver name e for Inlets (golint)
  • Line 173: warning: receiver name c should be consistent with previous receiver name e for Inlets (golint)
  • Line 194: warning: exported method Inlets.Create should have comment or be unexported (golint)
  • Line 194: warning: receiver name c should be consistent with previous receiver name e for Inlets (golint)
  • Line 205: warning: exported method Inlets.Update should have comment or be unexported (golint)
  • Line 205: warning: receiver name c should be consistent with previous receiver name e for Inlets (golint)
  • Line 213: warning: exported method Inlets.List should have comment or be unexported (golint)
  • Line 213: warning: receiver name c should be consistent with previous receiver name e for Inlets (golint)
  • Line 226: warning: exported method Inlets.Delete should have comment or be unexported (golint)
  • Line 226: warning: receiver name c should be consistent with previous receiver name e for Inlets (golint)
  • Line 237: warning: exported method Inlets.Get should have comment or be unexported (golint)
  • Line 237: warning: receiver name c should be consistent with previous receiver name e for Inlets (golint)
  • Line 242: warning: receiver name c should be consistent with previous receiver name e for Inlets (golint)
  • Line 249: warning: receiver name c should be consistent with previous receiver name e for Inlets (golint)
  • Line 256: warning: receiver name c should be consistent with previous receiver name e for Inlets (golint)
  • Line 263: warning: receiver name c should be consistent with previous receiver name e for Inlets (golint)
  • Line 270: warning: receiver name c should be consistent with previous receiver name e for Inlets (golint)
  • Line 278: warning: receiver name c should be consistent with previous receiver name e for Inlets (golint)

• reef-pi/controller/modules/system/uptime.go
  • Line 10: warning: exported type TimeLog should have comment or be unexported (golint)
  • Line 38: warning: exported method Controller.Uptime should have comment or be unexported (golint)

• reef-pi/controller/daemon/dashboard.go
  • Line 11: warning: comment on exported type Dashboard should be of the form "Dashboard ..." (with optional leading article) (golint)
  • Line 20: warning: exported type Chart should have comment or be unexported (golint)
  • Line 25: warning: exported var DefaultDashboard should have comment or be unexported (golint)
  • Line 51: warning: exported method ReefPi.GetDashboard should have comment or be unexported (golint)
  • Line 58: warning: exported method ReefPi.UpdateDashboard should have comment or be unexported (golint)

• reef-pi/controller/subsystem_composite.go
  • Line 10: warning: exported type SubsystemComposite should have comment or be unexported (golint)
  • Line 15: warning: exported function NewSubsystemComposite should have comment or be unexported (golint)
  • Line 22: warning: exported method SubsystemComposite.Unload should have comment or be unexported (golint)
  • Line 28: warning: exported method SubsystemComposite.UnloadAll should have comment or be unexported (golint)
  • Line 36: warning: exported method SubsystemComposite.Load should have comment or be unexported (golint)
  • Line 42: warning: exported method SubsystemComposite.Sub should have comment or be unexported (golint)
  • Line 52: warning: exported method SubsystemComposite.LoadAPI should have comment or be unexported (golint)
  • Line 58: warning: exported method SubsystemComposite.Setup should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/lunar.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 15: warning: exported const FullMoonFormat should have comment (or a comment on this block) or be unexported (golint)
  • Line 30: warning: exported function Lunar should have comment or be unexported (golint)

• reef-pi/controller/modules/timer/runner.go
  • Line 12: warning: exported type Trigger should have comment or be unexported (golint)
  • Line 19: warning: exported type SubSystemRunner should have comment or be unexported (golint)
  • Line 25: warning: exported function NewSubSystemRunner should have comment or be unexported (golint)
  • Line 41: warning: exported method SubSystemRunner.Run should have comment or be unexported (golint)

• reef-pi/controller/controller.go
  • Line 10: warning: exported type Subsystem should have comment or be unexported (golint)
  • Line 19: warning: exported type Controller should have comment or be unexported (golint)

• reef-pi/controller/storage/testdb.go
  • Line 9: warning: exported function TestDB should have comment or be unexported (golint)

• reef-pi/controller/connectors/outlet.go
  • Line 17: warning: exported const OutletBucket should have comment or be unexported (golint)
  • Line 19: warning: comment on exported type Outlet should be of the form "Outlet ..." (with optional leading article) (golint)
  • Line 41: warning: exported method Outlet.IsValid should have comment or be unexported (golint)
  • Line 49: warning: exported type Outlets should have comment or be unexported (golint)
  • Line 54: warning: exported function NewOutlets should have comment or be unexported (golint)
  • Line 61: warning: exported method Outlets.Setup should have comment or be unexported (golint)
  • Line 65: warning: exported method Outlets.Configure should have comment or be unexported (golint)
  • Line 82: warning: exported method Outlets.Create should have comment or be unexported (golint)
  • Line 93: warning: exported method Outlets.Update should have comment or be unexported (golint)
  • Line 101: warning: exported method Outlets.List should have comment or be unexported (golint)
  • Line 114: warning: exported method Outlets.Delete should have comment or be unexported (golint)
  • Line 125: warning: exported method Outlets.Get should have comment or be unexported (golint)
  • Line 130: warning: exported method Outlets.LoadAPI should have comment or be unexported (golint)
  • Line 130: warning: receiver name e should be consistent with previous receiver name c for Outlets (golint)

• reef-pi/controller/modules/system/display.go
  • Line 10: warning: exported const PowerFile should have comment (or a comment on this block) or be unexported (golint)
  • Line 14: warning: comment on exported type DisplayState should be of the form "DisplayState ..." (with optional leading article) (golint)
  • Line 20: warning: comment on exported type DisplayConfig should be of the form "DisplayConfig ..." (with optional leading article) (golint)

• reef-pi/commands/db.go
  • Line 23: warning: error var _wrongArguments should have name of the form errFoo (golint)
  • Line 66: warning: exported function NewDBCmd should have comment or be unexported (golint)
  • Line 83: warning: receiver name cmd should be consistent with previous receiver name d for dbCmd (golint)
  • Line 136: warning: receiver name cmd should be consistent with previous receiver name d for dbCmd (golint)
  • Line 146: warning: receiver name cmd should be consistent with previous receiver name d for dbCmd (golint)
  • Line 150: warning: receiver name cmd should be consistent with previous receiver name d for dbCmd (golint)
  • Line 161: warning: receiver name cmd should be consistent with previous receiver name d for dbCmd (golint)
  • Line 170: warning: receiver name cmd should be consistent with previous receiver name d for dbCmd (golint)
  • Line 186: warning: receiver name cmd should be consistent with previous receiver name d for dbCmd (golint)
  • Line 198: warning: receiver name cmd should be consistent with previous receiver name d for dbCmd (golint)
  • Line 209: warning: receiver name cmd should be consistent with previous receiver name d for dbCmd (golint)
  • Line 220: warning: receiver name cmd should be consistent with previous receiver name d for dbCmd (golint)

• reef-pi/controller/daemon/capabilities.go
  • Line 9: warning: exported method ReefPi.GetCapabilities should have comment or be unexported (golint)

• reef-pi/controller/modules/journal/api.go
  • Line 9: warning: exported method Subsystem.LoadAPI should have comment or be unexported (golint)

• reef-pi/controller/modules/ato/api.go
  • Line 11: warning: exported method Controller.LoadAPI should have comment or be unexported (golint)

• reef-pi/controller/modules/ato/usage.go
  • Line 10: warning: exported type Usage should have comment or be unexported (golint)
  • Line 15: warning: exported method Usage.Rollup should have comment or be unexported (golint)
  • Line 25: warning: exported method Usage.Before should have comment or be unexported (golint)
  • Line 30: warning: exported method Controller.NotifyIfNeeded should have comment or be unexported (golint)

• reef-pi/controller/modules/system/controller.go
  • Line 7: warning: exported const Bucket should have comment or be unexported (golint)
  • Line 9: warning: exported type Config should have comment or be unexported (golint)
  • Line 16: warning: don't use underscores in Go names; struct field RPI_PWMFreq should be RPIPWMFreq (golint)
  • Line 17: warning: don't use underscores in Go names; struct field PCA9685_PWMFreq should be PCA9685PWMFreq (golint)
  • Line 20: warning: exported type Controller should have comment or be unexported (golint)
  • Line 26: warning: exported function New should have comment or be unexported (golint)
  • Line 35: warning: exported method Controller.Start should have comment or be unexported (golint)
  • Line 39: warning: exported method Controller.Stop should have comment or be unexported (golint)
  • Line 43: warning: exported method Controller.Setup should have comment or be unexported (golint)
  • Line 46: warning: exported method Controller.On should have comment or be unexported (golint)
  • Line 50: warning: exported method Controller.InUse should have comment or be unexported (golint)

• reef-pi/controller/modules/temperature/controller.go
  • Line 14: warning: exported const Bucket should have comment or be unexported (golint)
  • Line 15: warning: exported const UsageBucket should have comment or be unexported (golint)
  • Line 16: warning: exported const CalibrationBucket should have comment or be unexported (golint)
  • Line 18: warning: exported type Controller should have comment or be unexported (golint)
  • Line 28: warning: exported function New should have comment or be unexported (golint)
  • Line 39: warning: exported method Controller.Setup should have comment or be unexported (golint)
  • Line 74: warning: exported method Controller.Start should have comment or be unexported (golint)
  • Line 95: warning: exported method Controller.Stop should have comment or be unexported (golint)
  • Line 108: warning: exported method Controller.On should have comment or be unexported (golint)
  • Line 122: warning: exported method Controller.InUse should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/sine.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 17: warning: exported function Sine should have comment or be unexported (golint)

• reef-pi/controller/daemon/reef_pi.go
  • Line 14: warning: exported const Bucket should have comment or be unexported (golint)
  • Line 16: warning: exported type ReefPi should have comment or be unexported (golint)
  • Line 27: warning: exported function New should have comment or be unexported (golint)
  • Line 60: warning: exported method ReefPi.Start should have comment or be unexported (golint)
  • Line 80: warning: exported method ReefPi.Stop should have comment or be unexported (golint)
  • Line 91: warning: exported method ReefPi.Subsystem should have comment or be unexported (golint)
  • Line 95: warning: exported method ReefPi.DM should have comment or be unexported (golint)
  • Line 99: warning: exported method ReefPi.Store should have comment or be unexported (golint)
  • Line 103: warning: exported method ReefPi.Telemetry should have comment or be unexported (golint)

• reef-pi/controller/modules/equipment/api.go
  • Line 11: warning: comment on exported method Controller.LoadAPI should be of the form "LoadAPI ..." (golint)
  • Line 120: warning: comment on exported type EquipmentAction should be of the form "EquipmentAction ..." (with optional leading article) (golint)
  • Line 125: warning: exported method Controller.Control should have comment or be unexported (golint)
  • Line 125: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)
  • Line 134: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)
  • Line 141: warning: exported method Controller.GetEquipment should have comment or be unexported (golint)
  • Line 141: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)
  • Line 148: warning: exported method Controller.ListEquipment should have comment or be unexported (golint)
  • Line 148: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)
  • Line 155: warning: exported method Controller.CreateEquipment should have comment or be unexported (golint)
  • Line 155: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)
  • Line 163: warning: exported method Controller.UpdateEquipment should have comment or be unexported (golint)
  • Line 163: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)
  • Line 171: warning: exported method Controller.DeleteEquipment should have comment or be unexported (golint)
  • Line 171: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)

• reef-pi/controller/modules/ph/controller.go
  • Line 17: warning: exported const Bucket should have comment or be unexported (golint)
  • Line 18: warning: exported const CalibrationBucket should have comment or be unexported (golint)
  • Line 20: warning: exported type Controller should have comment or be unexported (golint)
  • Line 30: warning: exported function New should have comment or be unexported (golint)
  • Line 41: warning: exported method Controller.Setup should have comment or be unexported (golint)
  • Line 70: warning: exported method Controller.Start should have comment or be unexported (golint)
  • Line 94: warning: exported method Controller.Stop should have comment or be unexported (golint)
  • Line 105: warning: exported method Controller.On should have comment or be unexported (golint)
  • Line 119: warning: exported method Controller.InUse should have comment or be unexported (golint)

• reef-pi/controller/daemon/config.go
  • Line 9: warning: exported type Config should have comment or be unexported (golint)
  • Line 13: warning: exported var DefaultConfig should have comment or be unexported (golint)
  • Line 17: warning: exported function ParseConfig should have comment or be unexported (golint)

• reef-pi/controller/utils/http_json.go
  • Line 11: warning: exported type Doer should have comment or be unexported (golint)
  • Line 15: warning: exported function ErrorResponse should have comment or be unexported (golint)
  • Line 29: warning: exported function JSONResponse should have comment or be unexported (golint)
  • Line 38: warning: exported function JSONResponseWithStatus should have comment or be unexported (golint)
  • Line 48: warning: exported function JSONGetResponse should have comment or be unexported (golint)
  • Line 61: warning: exported function JSONListResponse should have comment or be unexported (golint)
  • Line 72: warning: exported function JSONCreateResponse should have comment or be unexported (golint)
  • Line 86: warning: exported function JSONUpdateResponse should have comment or be unexported (golint)
  • Line 101: warning: exported function JSONDeleteResponse should have comment or be unexported (golint)
  • Line 111: warning: exported function JSONGetUsage should have comment or be unexported (golint)

• reef-pi/controller/modules/lighting/api.go
  • Line 11: warning: exported method Controller.LoadAPI should have comment or be unexported (golint)
  • Line 97: warning: exported method Controller.GetLight should have comment or be unexported (golint)
  • Line 104: warning: exported method Controller.ListLights should have comment or be unexported (golint)
  • Line 110: warning: exported method Controller.CreateLight should have comment or be unexported (golint)
  • Line 117: warning: exported method Controller.UpdateLight should have comment or be unexported (golint)
  • Line 124: warning: exported method Controller.DeleteLight should have comment or be unexported (golint)

• reef-pi/controller/telemetry/vcgencmd.go
  • Line 16: warning: don't use underscores in Go names; const _get_throttled should be _getThrottled (golint)
  • Line 17: warning: don't use underscores in Go names; const _measure_volts should be _measureVolts (golint)
  • Line 23: warning: exported type ThrottleType should have comment or be unexported (golint)
  • Line 34: warning: exported const UnderVoltage should have comment (or a comment on this block) or be unexported (golint)
  • Line 57: warning: exported type Runner should have comment or be unexported (golint)
  • Line 58: warning: exported type Factory should have comment or be unexported (golint)
  • Line 60: warning: exported function ExecFactory should have comment or be unexported (golint)
  • Line 64: warning: exported function VcgencmdGetThrottled should have comment or be unexported (golint)
  • Line 70: warning: exported function GetThrottled should have comment or be unexported (golint)
  • Line 87: warning: exported function GetThrottleTypes should have comment or be unexported (golint)
  • Line 88: warning: should omit 2nd value from range; this loop is equivalent to `for tType := range ...` (golint)

• reef-pi/controller/settings/capabilities.go
  • Line 3: warning: comment on exported type Capabilities should be of the form "Capabilities ..." (with optional leading article) (golint)
  • Line 21: warning: exported var DefaultCapabilities should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/random_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• reef-pi/controller/connectors/analog_input.go
  • Line 18: warning: exported const AnalogInputBucket should have comment or be unexported (golint)
  • Line 20: warning: comment on exported type AnalogInput should be of the form "AnalogInput ..." (with optional leading article) (golint)
  • Line 28: warning: exported type AnalogInputs should have comment or be unexported (golint)
  • Line 41: warning: exported method AnalogInput.IsValid should have comment or be unexported (golint)
  • Line 52: warning: exported function NewAnalogInputs should have comment or be unexported (golint)
  • Line 59: warning: exported method AnalogInputs.Setup should have comment or be unexported (golint)
  • Line 67: warning: exported method AnalogInputs.Get should have comment or be unexported (golint)
  • Line 72: warning: exported method AnalogInputs.List should have comment or be unexported (golint)
  • Line 85: warning: exported method AnalogInputs.Create should have comment or be unexported (golint)
  • Line 100: warning: exported method AnalogInputs.Update should have comment or be unexported (golint)
  • Line 111: warning: exported method AnalogInputs.Delete should have comment or be unexported (golint)
  • Line 119: warning: exported method AnalogInputs.LoadAPI should have comment or be unexported (golint)
  • Line 224: warning: receiver name ais should be consistent with previous receiver name c for AnalogInputs (golint)
  • Line 235: warning: exported method AnalogInputs.Calibrate should have comment or be unexported (golint)
  • Line 235: warning: receiver name ais should be consistent with previous receiver name c for AnalogInputs (golint)
  • Line 247: warning: exported type AnalogReading should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/fixed.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 17: warning: exported function Fixed should have comment or be unexported (golint)
  • Line 28: warning: receiver name m should be consistent with previous receiver name f for fixed (golint)

• reef-pi/controller/daemon/error.go
  • Line 13: warning: comment on exported type Error should be of the form "Error ..." (with optional leading article) (golint)
  • Line 25: warning: exported method ReefPi.DeleteErrors should have comment or be unexported (golint)
  • Line 45: warning: exported method ReefPi.ListErrors should have comment or be unexported (golint)
  • Line 76: warning: exported method ReefPi.DeleteError should have comment or be unexported (golint)
  • Line 80: warning: exported method ReefPi.LogError should have comment or be unexported (golint)
  • Line 93: warning: exported method ReefPi.GetError should have comment or be unexported (golint)

• reef-pi/controller/utils/test_helpers.go
  • Line 13: warning: exported type TestRouter should have comment or be unexported (golint)
  • Line 17: warning: exported function NewTestRouter should have comment or be unexported (golint)
  • Line 23: warning: exported method TestRouter.Do should have comment or be unexported (golint)

• reef-pi/controller/telemetry/stats_manager.go
  • Line 13: warning: exported type Metric should have comment or be unexported (golint)
  • Line 18: warning: comment on exported type StatsResponse should be of the form "StatsResponse ..." (with optional leading article) (golint)
  • Line 23: warning: exported type Stats should have comment or be unexported (golint)
  • Line 28: warning: exported type StatsOnDisk should have comment or be unexported (golint)
  • Line 33: warning: exported type StatsManager should have comment or be unexported (golint)

• reef-pi/controller/homestatsis.go
  • Line 21: warning: exported type Observation should have comment or be unexported (golint)
  • Line 30: warning: exported method Observation.Rollup should have comment or be unexported (golint)
  • Line 45: warning: exported function NewObservation should have comment or be unexported (golint)
  • Line 54: warning: exported method Observation.Before should have comment or be unexported (golint)
  • Line 62: warning: exported type HomeoStasisConfig should have comment or be unexported (golint)
  • Line 72: warning: exported type Homeostasis should have comment or be unexported (golint)
  • Line 80: warning: exported function NewHomeostasis should have comment or be unexported (golint)
  • Line 97: warning: exported method Homeostasis.Sub should have comment or be unexported (golint)
  • Line 104: warning: exported method Homeostasis.EmitMetric should have comment or be unexported (golint)
  • Line 108: warning: exported method Homeostasis.Sync should have comment or be unexported (golint)

• reef-pi/controller/modules/equipment/equipment.go
  • Line 10: warning: exported const Bucket should have comment or be unexported (golint)
  • Line 12: warning: comment on exported type Equipment should be of the form "Equipment ..." (with optional leading article) (golint)
  • Line 21: warning: exported method Controller.Get should have comment or be unexported (golint)
  • Line 26: warning: exported method Controller.List should have comment or be unexported (golint)
  • Line 39: warning: exported method Controller.Create should have comment or be unexported (golint)
  • Line 54: warning: exported method Controller.Update should have comment or be unexported (golint)
  • Line 62: warning: exported method Controller.Delete should have comment or be unexported (golint)

• reef-pi/controller/modules/doser/usage.go
  • Line 7: warning: exported type Usage should have comment or be unexported (golint)
  • Line 12: warning: exported method Usage.Rollup should have comment or be unexported (golint)
  • Line 22: warning: exported method Usage.Before should have comment or be unexported (golint)

• reef-pi/controller/modules/camera/camera.go
  • Line 16: warning: exported const Bucket should have comment or be unexported (golint)
  • Line 17: warning: exported const ItemBucket should have comment or be unexported (golint)
  • Line 19: warning: exported type Controller should have comment or be unexported (golint)
  • Line 27: warning: exported function New should have comment or be unexported (golint)
  • Line 37: warning: exported method Controller.On should have comment or be unexported (golint)
  • Line 41: warning: exported method Controller.Start should have comment or be unexported (golint)
  • Line 79: warning: exported method Controller.Stop should have comment or be unexported (golint)
  • Line 83: warning: exported method Controller.Setup should have comment or be unexported (golint)
  • Line 105: warning: exported method Controller.Capture should have comment or be unexported (golint)
  • Line 142: warning: exported method Controller.InUse should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/diurnal.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 17: warning: exported function Diurnal should have comment or be unexported (golint)

• reef-pi/controller/telemetry/mqtt.go
  • Line 10: warning: exported type MQTTConfig should have comment or be unexported (golint)
  • Line 20: warning: exported var DefaultMQTTConfig should have comment or be unexported (golint)
  • Line 29: warning: exported type MQTTClient should have comment or be unexported (golint)
  • Line 34: warning: exported function NewMQTTClient should have comment or be unexported (golint)
  • Line 56: warning: exported method MQTTClient.Publish should have comment or be unexported (golint)

• reef-pi/controller/utils/command.go
  • Line 8: warning: exported type ExecCommand should have comment or be unexported (golint)
  • Line 14: warning: exported method ExecCommand.Run should have comment or be unexported (golint)
  • Line 21: warning: exported method ExecCommand.CombinedOutput should have comment or be unexported (golint)
  • Line 28: warning: exported method ExecCommand.WithDevMode should have comment or be unexported (golint)
  • Line 33: warning: exported function Command should have comment or be unexported (golint)
  • Line 40: warning: exported method ExecCommand.RunDetached should have comment or be unexported (golint)

• reef-pi/controller/modules/journal/parameter.go
  • Line 10: warning: exported type Parameter should have comment or be unexported (golint)
  • Line 17: warning: exported type Entry should have comment or be unexported (golint)
  • Line 23: warning: exported method Entry.Before should have comment or be unexported (golint)
  • Line 27: warning: exported method Entry.Rollup should have comment or be unexported (golint)
  • Line 31: warning: exported method Subsystem.On should have comment or be unexported (golint)
  • Line 35: warning: exported method Subsystem.Get should have comment or be unexported (golint)
  • Line 39: warning: exported method Subsystem.List should have comment or be unexported (golint)
  • Line 52: warning: exported method Subsystem.Create should have comment or be unexported (golint)
  • Line 64: warning: exported method Subsystem.Update should have comment or be unexported (golint)
  • Line 69: warning: exported method Subsystem.Delete should have comment or be unexported (golint)
  • Line 79: warning: exported method Subsystem.AddEntry should have comment or be unexported (golint)

• reef-pi/controller/modules/ph/probe.go
  • Line 20: warning: exported const ReadingsBucket should have comment or be unexported (golint)
  • Line 22: warning: exported type Notify should have comment or be unexported (golint)
  • Line 28: warning: exported type ChartConfig should have comment or be unexported (golint)
  • Line 35: warning: comment on exported type Probe should be of the form "Probe ..." (with optional leading article) (golint)
  • Line 69: warning: comment on exported type CalibrationPoint should be of the form "CalibrationPoint ..." (with optional leading article) (golint)
  • Line 76: warning: exported method Controller.Get should have comment or be unexported (golint)
  • Line 81: warning: exported method Controller.List should have comment or be unexported (golint)
  • Line 94: warning: exported method Controller.Create should have comment or be unexported (golint)
  • Line 115: warning: exported method Controller.Update should have comment or be unexported (golint)
  • Line 137: warning: exported method Controller.Delete should have comment or be unexported (golint)
  • Line 166: warning: exported method Controller.Run should have comment or be unexported (golint)
  • Line 224: warning: exported method Controller.Calibrate should have comment or be unexported (golint)
  • Line 249: warning: exported method Controller.CalibratePoint should have comment or be unexported (golint)
  • Line 283: warning: exported method Probe.CreateFeed should have comment or be unexported (golint)
  • Line 303: warning: exported method Probe.WithinRange should have comment or be unexported (golint)

• reef-pi/controller/modules/system/api.go
  • Line 16: warning: exported type InstallReq should have comment or be unexported (golint)
  • Line 20: warning: exported method Controller.LoadAPI should have comment or be unexported (golint)
  • Line 127: warning: exported method Controller.EnableDisplay should have comment or be unexported (golint)
  • Line 134: warning: exported method Controller.DisableDisplay should have comment or be unexported (golint)
  • Line 141: warning: exported method Controller.SetBrightness should have comment or be unexported (golint)
  • Line 149: warning: exported method Controller.GetDisplayState should have comment or be unexported (golint)
  • Line 158: warning: exported method Controller.GetSummary should have comment or be unexported (golint)
  • Line 158: warning: receiver name t should be consistent with previous receiver name c for Controller (golint)
  • Line 165: warning: exported method Controller.Poweroff should have comment or be unexported (golint)
  • Line 177: warning: exported method Controller.Reboot should have comment or be unexported (golint)

• reef-pi/controller/utils/system_metrics.go
  • Line 9: warning: exported function AvgCpuLoad should have comment or be unexported (golint)

• reef-pi/controller/modules/timer/api.go
  • Line 11: warning: exported method Controller.LoadAPI should have comment or be unexported (golint)
  • Line 95: warning: exported method Controller.GetJob should have comment or be unexported (golint)
  • Line 102: warning: exported method Controller.ListJobs should have comment or be unexported (golint)
  • Line 109: warning: exported method Controller.CreateJob should have comment or be unexported (golint)
  • Line 117: warning: exported method Controller.UpdateJob should have comment or be unexported (golint)
  • Line 126: warning: exported method Controller.DeleteJob should have comment or be unexported (golint)

• reef-pi/controller/modules/ato/ato.go
  • Line 12: warning: exported type Notify should have comment or be unexported (golint)
  • Line 17: warning: comment on exported type ATO should be of the form "ATO ..." (with optional leading article) (golint)
  • Line 32: warning: exported method Controller.On should have comment or be unexported (golint)
  • Line 46: warning: exported method Controller.Get should have comment or be unexported (golint)
  • Line 50: warning: exported method Controller.List should have comment or be unexported (golint)
  • Line 63: warning: exported method Controller.Create should have comment or be unexported (golint)
  • Line 85: warning: exported method Controller.Update should have comment or be unexported (golint)
  • Line 108: warning: exported method Controller.Delete should have comment or be unexported (golint)
  • Line 123: warning: exported method Controller.Check should have comment or be unexported (golint)
  • Line 152: warning: exported method Controller.Run should have comment or be unexported (golint)
  • Line 184: warning: exported method ATO.CreateFeed should have comment or be unexported (golint)

• reef-pi/controller/modules/lighting/controller.go
  • Line 13: warning: exported const Bucket should have comment or be unexported (golint)
  • Line 15: warning: exported type Config should have comment or be unexported (golint)
  • Line 19: warning: exported var DefaultConfig should have comment or be unexported (golint)
  • Line 23: warning: exported type Controller should have comment or be unexported (golint)
  • Line 33: warning: exported function New should have comment or be unexported (golint)
  • Line 44: warning: exported method Controller.Start should have comment or be unexported (golint)
  • Line 47: warning: exported method Controller.StartCycle should have comment or be unexported (golint)
  • Line 61: warning: exported method Controller.Stop should have comment or be unexported (golint)
  • Line 66: warning: exported method Controller.Setup should have comment or be unexported (golint)
  • Line 89: warning: exported method Controller.On should have comment or be unexported (golint)
  • Line 109: warning: exported method Controller.InUse should have comment or be unexported (golint)

• reef-pi/controller/drivers/main.go
  • Line 17: warning: exported const DriverBucket should have comment (or a comment on this block) or be unexported (golint)
  • Line 21: warning: comment on exported type Driver should be of the form "Driver ..." (with optional leading article) (golint)
  • Line 31: warning: exported type Drivers should have comment or be unexported (golint)
  • Line 35: warning: don't use underscores in Go names; struct field dev_mode should be devMode (golint)
  • Line 36: warning: don't use underscores in Go names; struct field pwm_freq should be pwmFreq (golint)
  • Line 40: warning: exported function NewDrivers should have comment or be unexported (golint)
  • Line 54: warning: exported method Drivers.Get should have comment or be unexported (golint)
  • Line 83: warning: exported method Drivers.DigitalInputDriver should have comment or be unexported (golint)
  • Line 95: warning: exported method Drivers.DigitalOutputDriver should have comment or be unexported (golint)
  • Line 107: warning: exported method Drivers.PWMDriver should have comment or be unexported (golint)
  • Line 119: warning: exported method Drivers.AnalogInputDriver should have comment or be unexported (golint)
  • Line 146: warning: exported method Drivers.Create should have comment or be unexported (golint)
  • Line 173: warning: exported method Drivers.Update should have comment or be unexported (golint)
  • Line 182: warning: exported method Drivers.Delete should have comment or be unexported (golint)
  • Line 193: warning: exported method Drivers.List should have comment or be unexported (golint)
  • Line 210: warning: exported method Drivers.ListOptions should have comment or be unexported (golint)
  • Line 221: warning: exported method Drivers.ValidateParameters should have comment or be unexported (golint)
  • Line 234: warning: exported method Drivers.Close should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/auto_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• reef-pi/controller/pwm_profile/composite.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 10: warning: exported type CompositeProfile should have comment or be unexported (golint)
  • Line 29: warning: exported function Composite should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/interval_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• reef-pi/controller/pwm_profile/lunar_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• reef-pi/controller/utils/systemd.go
  • Line 35: warning: exported function SystemdExecute should have comment or be unexported (golint)

• reef-pi/controller/settings/healthcheck.go
  • Line 3: warning: exported type HealthCheckNotify should have comment or be unexported (golint)

• reef-pi/controller/modules/lighting/light.go
  • Line 10: warning: exported type Light should have comment or be unexported (golint)
  • Line 18: warning: exported method Light.LoadChannels should have comment or be unexported (golint)
  • Line 26: warning: exported method Controller.Get should have comment or be unexported (golint)
  • Line 35: warning: exported method Controller.List should have comment or be unexported (golint)
  • Line 85: warning: exported method Controller.Create should have comment or be unexported (golint)
  • Line 107: warning: exported method Controller.Update should have comment or be unexported (golint)
  • Line 124: warning: exported method Controller.Delete should have comment or be unexported (golint)

• reef-pi/controller/connectors/jack.go
  • Line 18: warning: exported const JackBucket should have comment or be unexported (golint)
  • Line 20: warning: comment on exported type Jack should be of the form "Jack ..." (with optional leading article) (golint)
  • Line 29: warning: exported type Jacks should have comment or be unexported (golint)
  • Line 42: warning: exported method Jack.IsValid should have comment or be unexported (golint)
  • Line 58: warning: exported function NewJacks should have comment or be unexported (golint)
  • Line 65: warning: exported method Jacks.Setup should have comment or be unexported (golint)
  • Line 73: warning: exported method Jacks.Get should have comment or be unexported (golint)
  • Line 78: warning: exported method Jacks.List should have comment or be unexported (golint)
  • Line 91: warning: exported method Jacks.Create should have comment or be unexported (golint)
  • Line 106: warning: exported method Jacks.Update should have comment or be unexported (golint)
  • Line 117: warning: exported method Jacks.Delete should have comment or be unexported (golint)
  • Line 125: warning: exported method Jacks.LoadAPI should have comment or be unexported (golint)
  • Line 235: warning: exported type PinValues should have comment or be unexported (golint)
  • Line 237: warning: exported method Jacks.Control should have comment or be unexported (golint)
  • Line 237: warning: receiver name jacks should be consistent with previous receiver name c for Jacks (golint)

• reef-pi/controller/telemetry/noop.go
  • Line 9: warning: exported function TestTelemetry should have comment or be unexported (golint)

• reef-pi/controller/settings/settings.go
  • Line 3: warning: comment on exported type Settings should be of the form "Settings ..." (with optional leading article) (golint)
  • Line 14: warning: don't use underscores in Go names; struct field RPI_PWMFreq should be RPIPWMFreq (golint)
  • Line 19: warning: exported var DefaultSettings should have comment or be unexported (golint)

• reef-pi/controller/modules/camera/process.go
  • Line 12: warning: exported type ImageItem should have comment or be unexported (golint)
  • Line 17: warning: exported method Controller.Process should have comment or be unexported (golint)
  • Line 54: warning: exported method Controller.List should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/loop_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• reef-pi/controller/modules/timer/job.go
  • Line 14: warning: exported const Bucket should have comment or be unexported (golint)
  • Line 16: warning: comment on exported type Job should be of the form "Job ..." (with optional leading article) (golint)
  • Line 31: warning: exported method Job.CronSpec should have comment or be unexported (golint)
  • Line 35: warning: exported method Job.Validate should have comment or be unexported (golint)
  • Line 70: warning: exported method Controller.Get should have comment or be unexported (golint)
  • Line 75: warning: exported method Controller.List should have comment or be unexported (golint)
  • Line 88: warning: exported method Controller.Create should have comment or be unexported (golint)
  • Line 106: warning: exported method Controller.Update should have comment or be unexported (golint)
  • Line 127: warning: exported method Controller.Delete should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/temporal.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 22: warning: exported function Temporal should have comment or be unexported (golint)
  • Line 33: warning: exported function NewTemporal should have comment or be unexported (golint)

• reef-pi/controller/drivers/test_helper.go
  • Line 10: warning: exported function TestDrivers should have comment or be unexported (golint)

• reef-pi/controller/modules/camera/api.go
  • Line 11: warning: exported method Controller.LoadAPI should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/composite_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• reef-pi/controller/telemetry/telemetry.go
  • Line 19: warning: exported const DBKey should have comment or be unexported (golint)
  • Line 23: warning: exported type ErrorLogger should have comment or be unexported (golint)
  • Line 25: warning: exported type Telemetry should have comment or be unexported (golint)
  • Line 36: warning: exported type AlertStats should have comment or be unexported (golint)
  • Line 41: warning: exported type AdafruitIO should have comment or be unexported (golint)
  • Line 48: warning: comment on exported type TelemetryConfig should be of the form "TelemetryConfig ..." (with optional leading article) (golint)
  • Line 60: warning: exported var DefaultTelemetryConfig should have comment or be unexported (golint)
  • Line 81: warning: exported function Initialize should have comment or be unexported (golint)
  • Line 99: warning: exported function NewTelemetry should have comment or be unexported (golint)
  • Line 175: warning: exported function SanitizeAdafruitIOFeedName should have comment or be unexported (golint)
  • Line 179: warning: exported function SanitizePrometheusMetricName should have comment or be unexported (golint)

• reef-pi/controller/drivers/factories.go
  • Line 40: warning: exported function AbstractFactory should have comment or be unexported (golint)

• reef-pi/controller/device_manager/device_manager.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 36: warning: exported type DeviceManager should have comment or be unexported (golint)
  • Line 46: warning: exported function New should have comment or be unexported (golint)
  • Line 79: warning: exported method DeviceManager.Setup should have comment or be unexported (golint)
  • Line 95: warning: exported method DeviceManager.Inlets should have comment or be unexported (golint)
  • Line 98: warning: exported method DeviceManager.Outlets should have comment or be unexported (golint)
  • Line 101: warning: exported method DeviceManager.AnalogInputs should have comment or be unexported (golint)
  • Line 105: warning: exported method DeviceManager.Jacks should have comment or be unexported (golint)
  • Line 109: warning: exported method DeviceManager.Drivers should have comment or be unexported (golint)
  • Line 113: warning: exported method DeviceManager.LoadAPI should have comment or be unexported (golint)
  • Line 121: warning: exported method DeviceManager.Close should have comment or be unexported (golint)

• reef-pi/controller/modules/doser/controller.go
  • Line 19: warning: exported const Bucket should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: exported type Controller should have comment or be unexported (golint)
  • Line 34: warning: exported function New should have comment or be unexported (golint)
  • Line 46: warning: exported method Controller.Stop should have comment or be unexported (golint)
  • Line 51: warning: exported method Controller.Setup should have comment or be unexported (golint)
  • Line 58: warning: exported method Controller.Start should have comment or be unexported (golint)
  • Line 94: warning: exported method Controller.On should have comment or be unexported (golint)
  • Line 111: warning: exported method Controller.InUse should have comment or be unexported (golint)

• reef-pi/controller/utils/calibration.go
  • Line 7: warning: exported type CalibrationType should have comment or be unexported (golint)
  • Line 10: warning: exported const OnePointCalibration should have comment (or a comment on this block) or be unexported (golint)
  • Line 14: warning: exported type Measurement should have comment or be unexported (golint)
  • Line 19: warning: exported type CalibrationConfiguration should have comment or be unexported (golint)
  • Line 24: warning: exported function CalibratorFactory should have comment or be unexported (golint)
  • Line 73: warning: exported type Calibrator should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/loop.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 26: warning: exported function Loop should have comment or be unexported (golint)

• reef-pi/commands/main.go
  • Line 12: warning: exported var Version should have comment or be unexported (golint)

• reef-pi/controller/modules/timer/reminder.go
  • Line 7: warning: exported type Reminder should have comment or be unexported (golint)
  • Line 12: warning: exported type ReminderRunner should have comment or be unexported (golint)
  • Line 17: warning: exported method ReminderRunner.Run should have comment or be unexported (golint)

• reef-pi/controller/telemetry/health.go
  • Line 19: warning: exported const HealthStatsKey should have comment or be unexported (golint)
  • Line 21: warning: exported type HealthChecker should have comment or be unexported (golint)
  • Line 37: warning: exported type HealthMetric should have comment or be unexported (golint)
  • Line 47: warning: exported method HealthMetric.Rollup should have comment or be unexported (golint)
  • Line 72: warning: exported method HealthMetric.Before should have comment or be unexported (golint)
  • Line 77: warning: exported function NewHealthChecker should have comment or be unexported (golint)

• reef-pi/controller/utils/tls.go
  • Line 15: warning: exported function GenerateCerts should have comment or be unexported (golint)

• reef-pi/controller/noop.go
  • Line 49: warning: exported function NoopSubsystem should have comment or be unexported (golint)
  • Line 56: warning: exported function TestController should have comment or be unexported (golint)

• reef-pi/controller/modules/camera/config.go
  • Line 10: warning: exported const DefaulCaptureFlags should have comment or be unexported (golint)
  • Line 12: warning: exported type MotionConfig should have comment or be unexported (golint)
  • Line 19: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)
  • Line 29: warning: exported var Default should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/auto.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 18: warning: exported function Auto should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/diurnal_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• reef-pi/controller/pwm_profile/factory_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• reef-pi/controller/pwm_profile/sine_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• reef-pi/controller/telemetry/retention.go
  • Line 3: warning: exported const CurrentLimit should have comment or be unexported (golint)
  • Line 4: warning: exported const HistoricalLimit should have comment or be unexported (golint)

• reef-pi/controller/storage/boltdb.go
  • Line 18: warning: exported type Extractor should have comment or be unexported (golint)
  • Line 20: warning: exported function NewStore should have comment or be unexported (golint)

• reef-pi/controller/storage/store.go
  • Line 4: warning: exported const ReefPiBucket should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported type ObjectStore should have comment or be unexported (golint)
  • Line 43: warning: exported type Store should have comment or be unexported (golint)

• reef-pi/controller/modules/doser/api.go
  • Line 11: warning: exported method Controller.LoadAPI should have comment or be unexported (golint)

• reef-pi/controller/modules/doser/runner.go
  • Line 11: warning: exported type Runner should have comment or be unexported (golint)
  • Line 17: warning: exported method Runner.Dose should have comment or be unexported (golint)
  • Line 30: warning: exported method Runner.Run should have comment or be unexported (golint)

• reef-pi/controller/modules/macro/step.go
  • Line 13: warning: exported type GenericStep should have comment or be unexported (golint)
  • Line 18: warning: exported type WaitStep should have comment or be unexported (golint)
  • Line 21: warning: exported type AlertStep should have comment or be unexported (golint)
  • Line 26: warning: exported type Step should have comment or be unexported (golint)
  • Line 31: warning: exported method Step.Run should have comment or be unexported (golint)

• reef-pi/controller/modules/ph/api.go
  • Line 13: warning: exported method Controller.LoadAPI should have comment or be unexported (golint)
  • Line 188: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)
  • Line 196: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)
  • Line 204: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)
  • Line 211: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)
  • Line 216: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)
  • Line 227: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)
  • Line 234: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)
  • Line 242: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)
  • Line 250: warning: receiver name c should be consistent with previous receiver name e for Controller (golint)

• reef-pi/controller/modules/macro/api.go
  • Line 12: warning: exported method Subsystem.LoadAPI should have comment or be unexported (golint)
  • Line 141: warning: receiver name c should be consistent with previous receiver name t for Subsystem (golint)
  • Line 148: warning: receiver name c should be consistent with previous receiver name t for Subsystem (golint)
  • Line 156: warning: receiver name c should be consistent with previous receiver name t for Subsystem (golint)
  • Line 163: warning: receiver name c should be consistent with previous receiver name t for Subsystem (golint)
  • Line 171: warning: receiver name c should be consistent with previous receiver name t for Subsystem (golint)
  • Line 183: warning: receiver name c should be consistent with previous receiver name t for Subsystem (golint)

• reef-pi/controller/modules/macro/macro.go
  • Line 9: warning: comment on exported type Macro should be of the form "Macro ..." (with optional leading article) (golint)
  • Line 17: warning: exported method Subsystem.Get should have comment or be unexported (golint)
  • Line 21: warning: exported method Subsystem.List should have comment or be unexported (golint)
  • Line 34: warning: exported method Subsystem.Create should have comment or be unexported (golint)
  • Line 42: warning: exported method Subsystem.Update should have comment or be unexported (golint)
  • Line 47: warning: exported method Subsystem.Delete should have comment or be unexported (golint)
  • Line 57: warning: exported method Subsystem.Run should have comment or be unexported (golint)

• reef-pi/controller/modules/macro/subsystem.go
  • Line 12: warning: exported const Bucket should have comment or be unexported (golint)
  • Line 13: warning: exported const UsageBucket should have comment or be unexported (golint)
  • Line 15: warning: exported type Subsystem should have comment or be unexported (golint)
  • Line 22: warning: exported function New should have comment or be unexported (golint)
  • Line 29: warning: exported method Subsystem.Setup should have comment or be unexported (golint)
  • Line 33: warning: exported method Subsystem.Start should have comment or be unexported (golint)
  • Line 36: warning: exported method Subsystem.Stop should have comment or be unexported (golint)
  • Line 38: warning: exported method Subsystem.On should have comment or be unexported (golint)
  • Line 46: warning: exported method Subsystem.InUse should have comment or be unexported (golint)

• reef-pi/controller/modules/doser/pump.go
  • Line 14: warning: comment on exported type Pump should be of the form "Pump ..." (with optional leading article) (golint)
  • Line 23: warning: exported method Controller.Get should have comment or be unexported (golint)
  • Line 28: warning: exported method Controller.Create should have comment or be unexported (golint)
  • Line 46: warning: exported method Controller.List should have comment or be unexported (golint)
  • Line 59: warning: exported method Controller.Calibrate should have comment or be unexported (golint)
  • Line 73: warning: exported method Controller.Update should have comment or be unexported (golint)
  • Line 93: warning: exported function Validate should have comment or be unexported (golint)
  • Line 100: warning: exported method Controller.Schedule should have comment or be unexported (golint)
  • Line 126: warning: exported method Controller.Delete should have comment or be unexported (golint)
  • Line 136: warning: exported method Pump.Runner should have comment or be unexported (golint)

• reef-pi/controller/modules/doser/types.go
  • Line 9: warning: comment on exported type DosingRegiment should be of the form "DosingRegiment ..." (with optional leading article) (golint)
  • Line 17: warning: comment on exported type CalibrationDetails should be of the form "CalibrationDetails ..." (with optional leading article) (golint)
  • Line 23: warning: exported type Schedule should have comment or be unexported (golint)
  • Line 32: warning: exported method Schedule.CronSpec should have comment or be unexported (golint)
  • Line 36: warning: exported method Schedule.Validate should have comment or be unexported (golint)

• reef-pi/controller/drivers/api.go
  • Line 13: warning: exported method Drivers.LoadAPI should have comment or be unexported (golint)

• reef-pi/controller/daemon/settings.go
  • Line 42: warning: exported method ReefPi.GetSettings should have comment or be unexported (golint)
  • Line 50: warning: exported method ReefPi.UpdateSettings should have comment or be unexported (golint)

• reef-pi/controller/utils/auth.go
  • Line 13: warning: comment on exported type Credentials should be of the form "Credentials ..." (with optional leading article) (golint)
  • Line 19: warning: exported type Auth should have comment or be unexported (golint)
  • Line 34: warning: exported function NewAuth should have comment or be unexported (golint)

• reef-pi/controller/modules/lighting/channel.go
  • Line 10: warning: comment on exported type Channel should be of the form "Channel ..." (with optional leading article) (golint)
  • Line 36: warning: exported method Controller.UpdateChannel should have comment or be unexported (golint)
  • Line 45: warning: exported method Channel.ValueAt should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/fixed_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• reef-pi/controller/pwm_profile/interval.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 43: warning: exported function Interval should have comment or be unexported (golint)

• reef-pi/controller/modules/temperature/api.go
  • Line 21: warning: exported method Controller.LoadAPI should have comment or be unexported (golint)
  • Line 229: warning: receiver name c should be consistent with previous receiver name t for Controller (golint)
  • Line 255: warning: receiver name c should be consistent with previous receiver name t for Controller (golint)
  • Line 263: warning: receiver name c should be consistent with previous receiver name t for Controller (golint)
  • Line 275: warning: receiver name c should be consistent with previous receiver name t for Controller (golint)
  • Line 283: warning: receiver name c should be consistent with previous receiver name t for Controller (golint)

• reef-pi/controller/telemetry/mailer.go
  • Line 9: warning: exported type Mailer should have comment or be unexported (golint)
  • Line 13: warning: exported type MailerConfig should have comment or be unexported (golint)
  • Line 22: warning: exported var GMailMailer should have comment or be unexported (golint)
  • Line 28: warning: exported type MailerCustomizer should have comment or be unexported (golint)
  • Line 30: warning: exported method MailerConfig.Mailer should have comment or be unexported (golint)
  • Line 56: warning: exported type NoopMailer should have comment or be unexported (golint)
  • Line 58: warning: exported method NoopMailer.Email should have comment or be unexported (golint)

• reef-pi/controller/telemetry/teletime.go
  • Line 7: warning: exported type TeleTime should have comment or be unexported (golint)
  • Line 11: warning: exported method TeleTime.Before should have comment or be unexported (golint)
  • Line 15: warning: exported method TeleTime.Hour should have comment or be unexported (golint)
  • Line 19: warning: exported method TeleTime.Day should have comment or be unexported (golint)
  • Line 23: warning: exported method TeleTime.MarshalJSON should have comment or be unexported (golint)
  • Line 31: warning: exported method TeleTime.UnmarshalJSON should have comment or be unexported (golint)

• reef-pi/controller/modules/equipment/controller.go
  • Line 13: warning: exported type Controller should have comment or be unexported (golint)
  • Line 19: warning: exported function New should have comment or be unexported (golint)
  • Line 27: warning: exported method Controller.Setup should have comment or be unexported (golint)
  • Line 31: warning: exported method Controller.Start should have comment or be unexported (golint)
  • Line 51: warning: exported method Controller.Stop should have comment or be unexported (golint)
  • Line 54: warning: exported method Controller.InUse should have comment or be unexported (golint)
  • Line 73: warning: exported method Controller.On should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/factory.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 21: warning: exported type Profile should have comment or be unexported (golint)
  • Line 26: warning: exported type TemporalProfile should have comment or be unexported (golint)
  • Line 32: warning: exported type ProfileSpec should have comment or be unexported (golint)
  • Line 39: warning: exported method ProfileSpec.CreateProfile should have comment or be unexported (golint)

• reef-pi/controller/pwm_profile/random.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 25: warning: exported function Random should have comment or be unexported (golint)
  • Line 33: warning: exported function NewRandom should have comment or be unexported (golint)
  • Line 40: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
  • Line 51: warning: receiver name s should be consistent with previous receiver name r for random (golint)

• reef-pi/controller/pwm_profile/temporal_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• reef-pi/controller/modules/system/info.go
  • Line 18: warning: comment on exported type Summary should be of the form "Summary ..." (with optional leading article) (golint)
  • Line 29: warning: exported method Controller.ComputeSummary should have comment or be unexported (golint)
  • Line 52: warning: exported method Controller.HostIP should have comment or be unexported (golint)
  • Line 72: warning: comment on exported method Controller.CPUTemperature should be of the form "CPUTemperature ..." (golint)
  • Line 84: warning: exported method Controller.GetModel should have comment or be unexported (golint)

• reef-pi/controller/modules/temperature/control.go
  • Line 12: warning: exported method Controller.Check should have comment or be unexported (golint)
  • Line 68: warning: exported method Controller.NotifyIfNeeded should have comment or be unexported (golint)

• reef-pi/controller/utils/doc.go
  • Line 21: warning: exported function APIDoc should have comment or be unexported (golint)
  • Line 49: warning: exported function SummarizeAPI should have comment or be unexported (golint)

• reef-pi/controller/modules/journal/subsystem.go
  • Line 9: warning: exported const Bucket should have comment or be unexported (golint)
  • Line 10: warning: exported const UsageBucket should have comment or be unexported (golint)
  • Line 12: warning: exported type Subsystem should have comment or be unexported (golint)
  • Line 17: warning: exported function New should have comment or be unexported (golint)
  • Line 24: warning: exported method Subsystem.Setup should have comment or be unexported (golint)
  • Line 31: warning: exported method Subsystem.Start should have comment or be unexported (golint)
  • Line 32: warning: exported method Subsystem.Stop should have comment or be unexported (golint)
  • Line 33: warning: exported method Subsystem.InUse should have comment or be unexported (golint)

• reef-pi/controller/modules/timer/controller.go
  • Line 16: warning: exported type Controller should have comment or be unexported (golint)
  • Line 22: warning: exported function New should have comment or be unexported (golint)
  • Line 30: warning: exported method Controller.Setup should have comment or be unexported (golint)
  • Line 34: warning: exported method Controller.Start should have comment or be unexported (golint)
  • Line 41: warning: exported method Controller.Stop should have comment or be unexported (golint)
  • Line 45: warning: exported method Controller.On should have comment or be unexported (golint)
  • Line 54: warning: exported method Controller.InUse should have comment or be unexported (golint)
  • Line 85: warning: exported method Controller.Runner should have comment or be unexported (golint)

• reef-pi/controller/modules/temperature/tc.go
  • Line 16: warning: exported type ChartConfig should have comment or be unexported (golint)
  • Line 22: warning: exported type Notify should have comment or be unexported (golint)
  • Line 28: warning: comment on exported type TC should be of the form "TC ..." (with optional leading article) (golint)
  • Line 68: warning: exported method Controller.Get should have comment or be unexported (golint)
  • Line 78: warning: exported method Controller.List should have comment or be unexported (golint)
  • Line 91: warning: exported method Controller.Create should have comment or be unexported (golint)
  • Line 115: warning: exported method Controller.Update should have comment or be unexported (golint)
  • Line 140: warning: exported method Controller.Delete should have comment or be unexported (golint)
  • Line 182: warning: exported method Controller.IsEquipmentInUse should have comment or be unexported (golint)
  • Line 200: warning: exported method Controller.Run should have comment or be unexported (golint)
  • Line 228: warning: exported method TC.SetEnable should have comment or be unexported (golint)
  • Line 228: warning: receiver name tc should be consistent with previous receiver name t for TC (golint)
  • Line 234: warning: exported method TC.CreateFeed should have comment or be unexported (golint)
  • Line 234: warning: receiver name tc should be consistent with previous receiver name t for TC (golint)
  • Line 252: warning: exported method Controller.Calibrate should have comment or be unexported (golint)
  • Line 268: warning: exported method TC.WithinRange should have comment or be unexported (golint)

• reef-pi/controller/modules/ato/controlller.go
  • Line 15: warning: exported const Bucket should have comment or be unexported (golint)
  • Line 16: warning: exported const UsageBucket should have comment or be unexported (golint)
  • Line 18: warning: exported type Controller should have comment or be unexported (golint)
  • Line 27: warning: exported function New should have comment or be unexported (golint)
  • Line 45: warning: exported method Controller.Setup should have comment or be unexported (golint)
  • Line 52: warning: exported method Controller.Start should have comment or be unexported (golint)
  • Line 78: warning: exported method Controller.Stop should have comment or be unexported (golint)
  • Line 91: warning: exported method Controller.Control should have comment or be unexported (golint)
  • Line 110: warning: exported method Controller.InUse should have comment or be unexported (golint)

• reef-pi/controller/daemon/api.go
  • Line 13: warning: exported var DefaultCredentials should have comment or be unexported (golint)
  • Line 18: warning: exported method ReefPi.API should have comment or be unexported (golint)
  • Line 52: warning: exported method ReefPi.UnAuthenticatedAPI should have comment or be unexported (golint)
  • Line 57: warning: comment on exported method ReefPi.AuthenticatedAPI should be of the form "AuthenticatedAPI ..." (golint)
  • Line 228: warning: error should be the last type when returning multiple items (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell98%

Misspell Finds commonly misspelled English words

• reef-pi/controller/telemetry/vcgencmd.go
  • Line 51: warning: "occured" is a misspelling of "occurred" (misspell)

• reef-pi/controller/modules/system/api.go
  • Line 39: warning: "brigthness" is a misspelling of "brightness" (misspell)