Preparing report...

Report for github.com/stackanetes/kubernetes-entrypoint

A+    Excellent!    Found 22 issues across 41 files

Tweet

gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint51%

Golint is a linter for Go source code.

    • kubernetes-entrypoint/client/client.go
    • Line 11: warning: exported type ClientInterface should have comment or be unexported (golint)
    • Line 18: warning: exported type Client should have comment or be unexported (golint)
    • Line 22: warning: exported method Client.Pods should have comment or be unexported (golint)
    • Line 26: warning: exported method Client.Jobs should have comment or be unexported (golint)
    • Line 30: warning: exported method Client.Endpoints should have comment or be unexported (golint)
    • Line 33: warning: exported method Client.DaemonSets should have comment or be unexported (golint)
    • Line 37: warning: exported method Client.Services should have comment or be unexported (golint)
    • Line 41: warning: exported function New should have comment or be unexported (golint)
    • kubernetes-entrypoint/mocks/endpoints.go
    • Line 18: warning: exported const MockEndpointError should have comment (or a comment on this block) or be unexported (golint)
    • Line 65: warning: receiver name s should be consistent with previous receiver name e for eClient (golint)
    • Line 81: warning: exported function NewEClient should have comment or be unexported (golint)
    • kubernetes-entrypoint/dependencies/daemonset/daemonset.go
    • Line 15: warning: exported const PodNameEnvVar should have comment (or a comment on this block) or be unexported (golint)
    • Line 19: warning: exported type Daemonset should have comment or be unexported (golint)
    • Line 39: warning: exported function NewDaemonset should have comment or be unexported (golint)
    • Line 50: warning: exported method Daemonset.IsResolved should have comment or be unexported (golint)
    • kubernetes-entrypoint/dependencies/container/container.go
    • Line 17: warning: exported const PodNameNotSetError should have comment (or a comment on this block) or be unexported (golint)
    • Line 21: warning: exported type Container should have comment or be unexported (golint)
    • Line 41: warning: exported function NewContainer should have comment or be unexported (golint)
    • Line 46: warning: exported method Container.IsResolved should have comment or be unexported (golint)
    • kubernetes-entrypoint/dependencies/config/config.go
    • Line 18: warning: exported const NamespaceNotSupported should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: exported type Config should have comment or be unexported (golint)
    • Line 50: warning: exported function NewConfig should have comment or be unexported (golint)
    • Line 71: warning: exported method Config.IsResolved should have comment or be unexported (golint)
    • kubernetes-entrypoint/mocks/entrypoint.go
    • Line 7: warning: exported type MockEntrypoint should have comment or be unexported (golint)
    • Line 12: warning: exported method MockEntrypoint.Resolve should have comment or be unexported (golint)
    • Line 15: warning: exported method MockEntrypoint.Client should have comment or be unexported (golint)
    • Line 19: warning: exported method MockEntrypoint.GetNamespace should have comment or be unexported (golint)
    • Line 23: warning: exported function NewEntrypointInNamespace should have comment or be unexported (golint)
    • Line 30: warning: exported function NewEntrypoint should have comment or be unexported (golint)
    • kubernetes-entrypoint/mocks/pod.go
    • Line 15: warning: exported const MockContainerName should have comment or be unexported (golint)
    • Line 21: warning: exported const PodNotPresent should have comment (or a comment on this block) or be unexported (golint)
    • Line 126: warning: exported function NewPClient should have comment or be unexported (golint)
    • Line 130: warning: exported function NewPod should have comment or be unexported (golint)
    • kubernetes-entrypoint/dependencies/socket/socket.go
    • Line 14: warning: exported const NonExistingErrorFormat should have comment (or a comment on this block) or be unexported (golint)
    • Line 19: warning: exported type Socket should have comment or be unexported (golint)
    • Line 38: warning: exported function NewSocket should have comment or be unexported (golint)
    • Line 42: warning: exported method Socket.IsResolved should have comment or be unexported (golint)
    • kubernetes-entrypoint/entrypoint/entrypoint.go
    • Line 16: warning: exported const JsonSuffix should have comment (or a comment on this block) or be unexported (golint)
    • Line 25: warning: exported type EntrypointInterface should have comment or be unexported (golint)
    • Line 55: warning: exported method Entrypoint.Client should have comment or be unexported (golint)
    • kubernetes-entrypoint/util/env/env.go
    • Line 12: warning: exported const Separator should have comment (or a comment on this block) or be unexported (golint)
    • Line 15: warning: exported type Dependency should have comment or be unexported (golint)
    • Line 20: warning: exported type PodDependency should have comment or be unexported (golint)
    • Line 26: warning: exported type JobDependency should have comment or be unexported (golint)
    • Line 32: warning: exported function SplitCommand should have comment or be unexported (golint)
    • kubernetes-entrypoint/dependencies/service/service.go
    • Line 11: warning: exported const FailingStatusFormat should have comment or be unexported (golint)
    • Line 13: warning: exported type Service should have comment or be unexported (golint)
    • Line 29: warning: exported function NewService should have comment or be unexported (golint)
    • Line 37: warning: exported method Service.IsResolved should have comment or be unexported (golint)
    • kubernetes-entrypoint/dependencies/job/job.go
    • Line 13: warning: exported const FailingStatusFormat should have comment or be unexported (golint)
    • Line 15: warning: exported type Job should have comment or be unexported (golint)
    • Line 36: warning: exported function NewJob should have comment or be unexported (golint)
    • Line 48: warning: exported method Job.IsResolved should have comment or be unexported (golint)
    • kubernetes-entrypoint/mocks/client.go
    • Line 10: warning: exported type Client should have comment or be unexported (golint)
    • Line 18: warning: exported method Client.Pods should have comment or be unexported (golint)
    • Line 22: warning: exported method Client.Services should have comment or be unexported (golint)
    • Line 26: warning: exported method Client.DaemonSets should have comment or be unexported (golint)
    • Line 30: warning: exported method Client.Endpoints should have comment or be unexported (golint)
    • Line 33: warning: exported method Client.Jobs should have comment or be unexported (golint)
    • Line 37: warning: exported function NewClient should have comment or be unexported (golint)
    • kubernetes-entrypoint/mocks/job.go
    • Line 14: warning: exported const SucceedingJobName should have comment (or a comment on this block) or be unexported (golint)
    • Line 75: warning: exported function NewJClient should have comment or be unexported (golint)
    • Line 79: warning: exported function NewJob should have comment or be unexported (golint)
    • kubernetes-entrypoint/dependencies/pod/pod.go
    • Line 15: warning: exported const PodNameEnvVar should have comment (or a comment on this block) or be unexported (golint)
    • Line 19: warning: exported type Pod should have comment or be unexported (golint)
    • Line 40: warning: exported function NewPod should have comment or be unexported (golint)
    • Line 52: warning: exported method Pod.IsResolved should have comment or be unexported (golint)
    • Line 89: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign95%

IneffAssign detects ineffectual assignments in Go code.


misspell97%

Misspell Finds commonly misspelled English words