gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo88%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• /stash.appscode.dev/stash/pkg/controller/stash.go
  • Line 67: warning: cyclomatic complexity 17 of function setRollingUpdate() is high (> 15) (gocyclo)

• /stash.appscode.dev/stash/test/e2e/framework/util.go
  • Line 314: warning: cyclomatic complexity 18 of function getGVRAndObjectMeta() is high (> 15) (gocyclo)

• /stash.appscode.dev/stash/pkg/controller/backup_configuration.go
  • Line 102: warning: cyclomatic complexity 31 of function (*StashController).applyBackupInvokerReconciliationLogic() is high (> 15) (gocyclo)
  • Line 278: warning: cyclomatic complexity 21 of function (*StashController).sendEventToWorkloadQueue() is high (> 15) (gocyclo)

• /stash.appscode.dev/stash/pkg/cmds/restore_volumesnapshot.go
  • Line 112: warning: cyclomatic complexity 23 of function (*VSoption).restoreVolumeSnapshot() is high (> 15) (gocyclo)

• /stash.appscode.dev/stash/pkg/controller/restore_session.go
  • Line 165: warning: cyclomatic complexity 54 of function (*StashController).applyRestoreInvokerReconciliationLogic() is high (> 15) (gocyclo)
  • Line 443: warning: cyclomatic complexity 27 of function (*StashController).ensureRestoreJob() is high (> 15) (gocyclo)

• /stash.appscode.dev/stash/pkg/util/util.go
  • Line 260: warning: cyclomatic complexity 20 of function (*WorkloadClients).IsTargetExist() is high (> 15) (gocyclo)
  • Line 58: warning: cyclomatic complexity 19 of function GetHostName() is high (> 15) (gocyclo)

• /stash.appscode.dev/stash/pkg/cmds/backup.go
  • Line 40: warning: cyclomatic complexity 17 of function NewCmdBackup() is high (> 15) (gocyclo)

• /stash.appscode.dev/stash/pkg/controller/restics.go
  • Line 317: warning: cyclomatic complexity 41 of function (*StashController).EnsureSidecarDeleted() is high (> 15) (gocyclo)
  • Line 245: warning: cyclomatic complexity 19 of function (*StashController).EnsureSidecar() is high (> 15) (gocyclo)

• /stash.appscode.dev/stash/pkg/controller/backup_session.go
  • Line 123: warning: cyclomatic complexity 31 of function (*StashController).applyBackupSessionReconciliationLogic() is high (> 15) (gocyclo)
  • Line 270: warning: cyclomatic complexity 19 of function (*StashController).ensureBackupJob() is high (> 15) (gocyclo)

• /stash.appscode.dev/stash/pkg/controller/replicasets.go
  • Line 87: warning: cyclomatic complexity 16 of function (*StashController).runReplicaSetInjector() is high (> 15) (gocyclo)

• /stash.appscode.dev/stash/pkg/controller/sidecar.go
  • Line 256: warning: cyclomatic complexity 16 of function (*StashController).ensureWorkloadLatestState() is high (> 15) (gocyclo)

• /stash.appscode.dev/stash/pkg/status/status.go
  • Line 241: warning: cyclomatic complexity 29 of function (UpdateStatusOptions).executePostBackupActions() is high (> 15) (gocyclo)

• /stash.appscode.dev/stash/pkg/scale/scale.go
  • Line 64: warning: cyclomatic complexity 33 of function (*Controller).ScaleDownWorkload() is high (> 15) (gocyclo)
  • Line 206: warning: cyclomatic complexity 16 of function ScaleUpWorkload() is high (> 15) (gocyclo)

• /stash.appscode.dev/stash/pkg/cmds/create_volumesnapshot.go
  • Line 143: warning: cyclomatic complexity 16 of function (*VSoption).createVolumeSnapshot() is high (> 15) (gocyclo)

• /stash.appscode.dev/stash/pkg/server/server.go
  • Line 126: warning: cyclomatic complexity 17 of function (completedConfig).New() is high (> 15) (gocyclo)

• /stash.appscode.dev/stash/pkg/resolve/task.go
  • Line 50: warning: cyclomatic complexity 17 of function (TaskResolver).GetPodSpec() is high (> 15) (gocyclo)

golint14%

Golint is a linter for Go source code.

• /stash.appscode.dev/stash/test/e2e/volumes/volume.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/test/e2e/misc/filtering.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/test/e2e/framework/namespace.go
  • Line 28: warning: exported method Framework.Namespace should have comment or be unexported (golint)
  • Line 32: warning: exported method Framework.CreateTestNamespace should have comment or be unexported (golint)
  • Line 44: warning: exported method Framework.CreateNamespace should have comment or be unexported (golint)
  • Line 49: warning: exported method Framework.DeleteNamespace should have comment or be unexported (golint)
  • Line 57: warning: exported method Framework.NewNamespace should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/server/server.go
  • Line 57: warning: exported var Scheme should have comment or be unexported (golint)
  • Line 80: warning: exported type StashConfig should have comment or be unexported (golint)
  • Line 91: warning: exported method StashServer.Run should have comment or be unexported (golint)
  • Line 105: warning: exported type CompletedConfig should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/matcher/sidecar_matcher.go
  • Line 27: warning: exported function HaveSidecar should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cmds/snapshot.go
  • Line 33: warning: exported function NewCmdSnapshots should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/misc/pause_backup.go
  • Line 28: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/pkg/controller/deployment.go
  • Line 42: warning: exported method StashController.NewDeploymentWebhook should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/rest_server.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 37: warning: exported const REST_PUBLIC_CRT_NAME should have comment (or a comment on this block) or be unexported (golint)
  • Line 48: warning: exported method Invocation.CreateRestServer should have comment or be unexported (golint)
  • Line 97: warning: exported method Invocation.SecretForRestServer should have comment or be unexported (golint)
  • Line 113: warning: exported method Invocation.PVCForRestServer should have comment or be unexported (golint)
  • Line 133: warning: exported method Framework.CreatePersistentVolumeClaimForRestServer should have comment or be unexported (golint)
  • Line 137: warning: exported method Invocation.DeploymentForRestServer should have comment or be unexported (golint)
  • Line 219: warning: exported method Invocation.RemoveRestSecretVolumeMount should have comment or be unexported (golint)
  • Line 230: warning: exported method Invocation.RemoveRestSecretVolume should have comment or be unexported (golint)
  • Line 234: warning: exported method Invocation.CreateDeploymentForRestServer should have comment or be unexported (golint)
  • Line 238: warning: exported method Invocation.ServiceForRestServer should have comment or be unexported (golint)
  • Line 260: warning: exported method Invocation.CreateServiceForRestServer should have comment or be unexported (golint)
  • Line 264: warning: exported method Invocation.RestServerSANs should have comment or be unexported (golint)
  • Line 272: warning: exported method Invocation.RestServiceAddres should have comment or be unexported (golint)
  • Line 277: warning: exported method Invocation.CreateRestUser should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/rbac/cronjob.go
  • Line 36: warning: exported function EnsureCronJobRBAC should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cmds/backup.go
  • Line 40: warning: exported function NewCmdBackup should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/controller/migration.go
  • Line 33: warning: exported method StashController.MigrateObservedGeneration should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/service.go
  • Line 26: warning: exported method Invocation.HeadlessService should have comment or be unexported (golint)
  • Line 47: warning: exported method Framework.CreateService should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/status/status.go
  • Line 47: warning: exported type UpdateStatusOptions should have comment or be unexported (golint)
  • Line 66: warning: exported method UpdateStatusOptions.UpdateBackupStatusFromFile should have comment or be unexported (golint)
  • Line 92: warning: exported method UpdateStatusOptions.UpdateRestoreStatusFromFile should have comment or be unexported (golint)
  • Line 114: warning: exported method UpdateStatusOptions.UpdatePostBackupStatus should have comment or be unexported (golint)
  • Line 190: warning: exported method UpdateStatusOptions.UpdatePostRestoreStatus should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/rbac/backup_job.go
  • Line 37: warning: exported function EnsureBackupJobRBAC should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cmds/backup_pvc.go
  • Line 60: warning: exported function NewCmdBackupPVC should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cmds/create_volumesnapshot.go
  • Line 49: warning: exported type VSoption should have comment or be unexported (golint)
  • Line 68: warning: exported function NewCmdCreateVolumeSnapshot should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/registry/snapshot/utils.go
  • Line 49: warning: exported const ExecStash should have comment (or a comment on this block) or be unexported (golint)
  • Line 400: warning: exported method REST.GetVersionedSnapshots should have comment or be unexported (golint)
  • Line 409: warning: exported method REST.ForgetVersionedSnapshots should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/backend/azure.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/test/e2e/backend/b2.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/test/e2e/hooks/post_restore.go
  • Line 27: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)
  • Line 30: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/hack/import_hacks.go
  • Line 20: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• /stash.appscode.dev/stash/test/e2e/framework/daemonset.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 26: warning: should not use dot imports (golint)
  • Line 37: warning: exported method Invocation.DaemonSet should have comment or be unexported (golint)
  • Line 95: warning: exported method Framework.CreateDaemonSet should have comment or be unexported (golint)
  • Line 99: warning: exported method Framework.EventuallyDaemonSet should have comment or be unexported (golint)
  • Line 107: warning: exported method Invocation.WaitUntilDaemonSetReadyWithSidecar should have comment or be unexported (golint)
  • Line 135: warning: exported method Invocation.DeployDaemonSet should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/misc/backupsession.go
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/pkg/cmds/run_hook.go
  • Line 64: warning: exported function NewCmdRunHook should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/workloads/replicaset.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/pkg/cmds/forget.go
  • Line 32: warning: exported function NewCmdForget should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/controller/rcs.go
  • Line 42: warning: exported method StashController.NewReplicationControllerWebhook should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/rbac/sidecar.go
  • Line 46: warning: exported function EnsureSidecarClusterRole should have comment or be unexported (golint)
  • Line 121: warning: exported function EnsureSidecarRoleBinding should have comment or be unexported (golint)
  • Line 165: warning: exported function EnsureUnnecessaryWorkloadRBACDeleted should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/misc/clone_pvc.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/test/e2e/framework/backup_configuration.go
  • Line 28: warning: should not use dot imports (golint)
  • Line 38: warning: exported method Invocation.GetBackupConfiguration should have comment or be unexported (golint)
  • Line 69: warning: exported method Invocation.CreateBackupConfiguration should have comment or be unexported (golint)
  • Line 74: warning: exported method Invocation.DeleteBackupConfiguration should have comment or be unexported (golint)
  • Line 82: warning: exported method Framework.EventuallyCronJobCreated should have comment or be unexported (golint)
  • Line 96: warning: exported method Framework.GetCronJob should have comment or be unexported (golint)
  • Line 100: warning: exported method Framework.EventuallyCronJobSuspended should have comment or be unexported (golint)
  • Line 114: warning: exported method Framework.EventuallyCronJobResumed should have comment or be unexported (golint)
  • Line 128: warning: exported method Framework.EventuallyBackupConfigurationCreated should have comment or be unexported (golint)
  • Line 142: warning: exported method Framework.GetBackupJob should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cli/restic.go
  • Line 33: warning: exported const Exe should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: exported type ResticWrapper should have comment or be unexported (golint)
  • Line 44: warning: exported function New should have comment or be unexported (golint)
  • Line 56: warning: exported type Snapshot should have comment or be unexported (golint)
  • Line 68: warning: exported method ResticWrapper.ListSnapshots should have comment or be unexported (golint)
  • Line 80: warning: exported method ResticWrapper.DeleteSnapshots should have comment or be unexported (golint)
  • Line 90: warning: exported method ResticWrapper.InitRepositoryIfAbsent should have comment or be unexported (golint)
  • Line 102: warning: exported method ResticWrapper.Backup should have comment or be unexported (golint)
  • Line 120: warning: exported method ResticWrapper.Forget should have comment or be unexported (golint)
  • Line 174: warning: exported method ResticWrapper.Restore should have comment or be unexported (golint)
  • Line 197: warning: exported method ResticWrapper.Check should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/controller/repository.go
  • Line 41: warning: exported method StashController.NewRepositoryWebhook should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/deployment.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 26: warning: should not use dot imports (golint)
  • Line 38: warning: exported const ProberDemoPodPrefix should have comment (or a comment on this block) or be unexported (golint)
  • Line 47: warning: exported method Invocation.Deployment should have comment or be unexported (golint)
  • Line 69: warning: exported method Framework.CreateDeployment should have comment or be unexported (golint)
  • Line 73: warning: exported method Framework.EventuallyDeployment should have comment or be unexported (golint)
  • Line 84: warning: exported method Invocation.WaitUntilDeploymentReadyWithSidecar should have comment or be unexported (golint)
  • Line 112: warning: exported method Invocation.DeployDeployment should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/util/util.go
  • Line 50: warning: exported type RepoLabelData should have comment or be unexported (golint)
  • Line 139: warning: exported function BackupModel should have comment or be unexported (golint)
  • Line 148: warning: exported function RestoreModel should have comment or be unexported (golint)
  • Line 152: warning: exported function GetRepoNameAndSnapshotID should have comment or be unexported (golint)
  • Line 172: warning: exported function FixBackendPrefix should have comment or be unexported (golint)
  • Line 197: warning: comment on exported function GetBucketAndPrefix should be of the form "GetBucketAndPrefix ..." (golint)
  • Line 215: warning: exported function ExtractDataFromRepositoryLabel should have comment or be unexported (golint)
  • Line 239: warning: exported function AttachPVC should have comment or be unexported (golint)
  • Line 252: warning: exported type WorkloadClients should have comment or be unexported (golint)
  • Line 260: warning: exported method WorkloadClients.IsTargetExist should have comment or be unexported (golint)
  • Line 333: warning: exported function HasStashContainer should have comment or be unexported (golint)
  • Line 337: warning: exported function HasStashSidecar should have comment or be unexported (golint)
  • Line 347: warning: exported function HasStashInitContainer should have comment or be unexported (golint)
  • Line 414: warning: comment on exported function ResourceKindShortForm should be of the form "ResourceKindShortForm ..." (golint)
  • Line 436: warning: exported function ExecuteHook should have comment or be unexported (golint)
  • Line 473: warning: exported function HookExecutorContainer should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cmds/restore_volumesnapshot.go
  • Line 49: warning: exported function NewCmdRestoreVolumeSnapshot should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/common.go
  • Line 27: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)
  • Line 30: warning: should not use dot imports (golint)
  • Line 37: warning: exported method Invocation.GenerateSampleData should have comment or be unexported (golint)
  • Line 52: warning: exported method Invocation.GenerateBigSampleFile should have comment or be unexported (golint)
  • Line 71: warning: exported method Invocation.SetupWorkloadBackup should have comment or be unexported (golint)
  • Line 105: warning: exported method Invocation.CreateBackupConfigForWorkload should have comment or be unexported (golint)
  • Line 138: warning: exported method Invocation.WaitForTargetToBeReadyWithSidecar should have comment or be unexported (golint)
  • Line 169: warning: exported method Invocation.TakeInstantBackup should have comment or be unexported (golint)
  • Line 184: warning: exported method Invocation.RestoredData should have comment or be unexported (golint)
  • Line 194: warning: exported method Invocation.SetupRestoreProcess should have comment or be unexported (golint)
  • Line 220: warning: exported method Invocation.CreateRestoreSessionForWorkload should have comment or be unexported (golint)
  • Line 256: warning: exported function GetTargetRef should have comment or be unexported (golint)
  • Line 286: warning: exported method Invocation.PrintDebugInfoOnFailure should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/replicaset.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 26: warning: should not use dot imports (golint)
  • Line 37: warning: exported method Invocation.ReplicaSet should have comment or be unexported (golint)
  • Line 59: warning: exported method Framework.CreateReplicaSet should have comment or be unexported (golint)
  • Line 63: warning: exported method Framework.EventuallyReplicaSet should have comment or be unexported (golint)
  • Line 71: warning: exported method Invocation.WaitUntilRSReadyWithSidecar should have comment or be unexported (golint)
  • Line 99: warning: exported method Invocation.DeployReplicaSet should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cmds/create_backupsession.go
  • Line 53: warning: exported function NewCmdCreateBackupSession should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/hooks/post_backup.go
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/test/e2e/workloads/statefulset.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/test/e2e/workloads/deployment.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/pkg/controller/restics.go
  • Line 53: warning: exported method StashController.NewResticWebhook should have comment or be unexported (golint)
  • Line 166: warning: exported method StashController.EnsureScaledownCronJob should have comment or be unexported (golint)
  • Line 245: warning: exported method StashController.EnsureSidecar should have comment or be unexported (golint)
  • Line 317: warning: exported method StashController.EnsureSidecarDeleted should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/configmap.go
  • Line 28: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)
  • Line 33: warning: exported method Framework.CheckLeaderElection should have comment or be unexported (golint)
  • Line 58: warning: exported method Framework.GetLeaderIdentity should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cmds/server/options.go
  • Line 37: warning: exported type ExtraOptions should have comment or be unexported (golint)
  • Line 57: warning: exported function NewExtraOptions should have comment or be unexported (golint)
  • Line 71: warning: exported method ExtraOptions.AddFlags should have comment or be unexported (golint)
  • Line 92: warning: exported method ExtraOptions.ApplyTo should have comment or be unexported (golint)
  • Line 136: warning: exported method ExtraOptions.Validate should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/backup/scheduler.go
  • Line 42: warning: exported method Controller.BackupScheduler should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/registry/snapshot/snapshot.go
  • Line 43: warning: exported const KeyRepository should have comment (or a comment on this block) or be unexported (golint)
  • Line 47: warning: exported type REST should have comment or be unexported (golint)
  • Line 61: warning: exported function NewREST should have comment or be unexported (golint)
  • Line 73: warning: exported method REST.NamespaceScoped should have comment or be unexported (golint)
  • Line 77: warning: exported method REST.New should have comment or be unexported (golint)
  • Line 81: warning: exported method REST.GroupVersionKind should have comment or be unexported (golint)
  • Line 85: warning: exported method REST.Categories should have comment or be unexported (golint)
  • Line 89: warning: exported method REST.Get should have comment or be unexported (golint)
  • Line 104: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 122: warning: exported method REST.NewList should have comment or be unexported (golint)
  • Line 126: warning: exported method REST.List should have comment or be unexported (golint)
  • Line 183: warning: exported method REST.ConvertToTable should have comment or be unexported (golint)
  • Line 187: warning: exported method REST.Delete should have comment or be unexported (golint)
  • Line 200: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• /stash.appscode.dev/stash/pkg/controller/stash.go
  • Line 184: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 192: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• /stash.appscode.dev/stash/test/e2e/framework/restore_session.go
  • Line 27: warning: should not use dot imports (golint)
  • Line 39: warning: exported method Invocation.GetRestoreSession should have comment or be unexported (golint)
  • Line 59: warning: exported method Invocation.CreateRestoreSession should have comment or be unexported (golint)
  • Line 64: warning: exported method Invocation.DeleteRestoreSession should have comment or be unexported (golint)
  • Line 72: warning: exported method Framework.EventuallyRestoreProcessCompleted should have comment or be unexported (golint)
  • Line 89: warning: exported method Framework.GetRestoreJobs should have comment or be unexported (golint)
  • Line 107: warning: exported function JobsTargetMatch should have comment or be unexported (golint)
  • Line 119: warning: exported function RulesMigrated should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/statefulset.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 26: warning: should not use dot imports (golint)
  • Line 37: warning: exported method Invocation.StatefulSet should have comment or be unexported (golint)
  • Line 100: warning: exported method Framework.CreateStatefulSet should have comment or be unexported (golint)
  • Line 104: warning: exported method Framework.EventuallyStatefulSet should have comment or be unexported (golint)
  • Line 112: warning: exported method Invocation.WaitUntilStatefulSetReadyWithSidecar should have comment or be unexported (golint)
  • Line 140: warning: exported method Invocation.DeployStatefulSet should have comment or be unexported (golint)
  • Line 168: warning: exported method Invocation.DeployStatefulSetWithProbeClient should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/resolve/task.go
  • Line 40: warning: exported type TaskResolver should have comment or be unexported (golint)
  • Line 50: warning: exported method TaskResolver.GetPodSpec should have comment or be unexported (golint)
  • Line 204: warning: exported function ResolveBackupBlueprint should have comment or be unexported (golint)
  • Line 208: warning: exported function ResolvePVCSpec should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cmds/run_backup.go
  • Line 40: warning: exported function NewCmdRunBackup should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/util/job.go
  • Line 42: warning: exported function NewCheckJob should have comment or be unexported (golint)
  • Line 119: warning: exported function NewRecoveryJob should have comment or be unexported (golint)
  • Line 318: warning: exported function NewVolumeSnapshotterJob should have comment or be unexported (golint)
  • Line 363: warning: exported function NewVolumeRestorerJob should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/misc/failure_handling.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 26: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/pkg/controller/recoveries.go
  • Line 52: warning: exported const RecoveryEventComponent should have comment (or a comment on this block) or be unexported (golint)
  • Line 55: warning: exported method StashController.NewRecoveryWebhook should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/scale/scale.go
  • Line 41: warning: exported type Options should have comment or be unexported (golint)
  • Line 47: warning: exported type Controller should have comment or be unexported (golint)
  • Line 53: warning: exported var ZeroReplica should have comment or be unexported (golint)
  • Line 57: warning: exported function New should have comment or be unexported (golint)
  • Line 64: warning: exported method Controller.ScaleDownWorkload should have comment or be unexported (golint)
  • Line 206: warning: exported function ScaleUpWorkload should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/util/kubernetes.go
  • Line 45: warning: exported function IsBackupTarget should have comment or be unexported (golint)
  • Line 55: warning: exported function IsRestoreTarget should have comment or be unexported (golint)
  • Line 65: warning: exported function GetString should have comment or be unexported (golint)
  • Line 72: warning: exported function UpsertScratchVolume should have comment or be unexported (golint)
  • Line 81: warning: exported function UpsertTmpVolume should have comment or be unexported (golint)
  • Line 93: warning: exported function UpsertTmpVolumeMount should have comment or be unexported (golint)
  • Line 100: warning: comment on exported function UpsertDownwardVolume should be of the form "UpsertDownwardVolume ..." (golint)
  • Line 119: warning: exported function UpsertSecretVolume should have comment or be unexported (golint)
  • Line 214: warning: exported function MergeLocalVolume should have comment or be unexported (golint)
  • Line 241: warning: exported function EnsureVolumeDeleted should have comment or be unexported (golint)
  • Line 250: warning: exported function RecoveryEqual should have comment or be unexported (golint)
  • Line 261: warning: exported function WorkloadExists should have comment or be unexported (golint)
  • Line 287: warning: exported function GetConfigmapLockName should have comment or be unexported (golint)
  • Line 291: warning: exported function GetBackupConfigmapLockName should have comment or be unexported (golint)
  • Line 295: warning: exported function GetRestoreConfigmapLockName should have comment or be unexported (golint)
  • Line 299: warning: exported function DeleteConfigmapLock should have comment or be unexported (golint)
  • Line 303: warning: exported function DeleteBackupConfigMapLock should have comment or be unexported (golint)
  • Line 307: warning: exported function DeleteRestoreConfigMapLock should have comment or be unexported (golint)
  • Line 311: warning: exported function DeleteAllConfigMapLocks should have comment or be unexported (golint)
  • Line 330: warning: exported function WorkloadReplicas should have comment or be unexported (golint)
  • Line 336: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 343: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 350: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 359: warning: exported function HasOldReplicaAnnotation should have comment or be unexported (golint)
  • Line 393: warning: exported function WaitUntilDeploymentReady should have comment or be unexported (golint)
  • Line 402: warning: exported function WaitUntilDaemonSetReady should have comment or be unexported (golint)
  • Line 411: warning: exported function WaitUntilReplicaSetReady should have comment or be unexported (golint)
  • Line 420: warning: exported function WaitUntilRCReady should have comment or be unexported (golint)
  • Line 430: warning: exported function WaitUntilStatefulSetReady should have comment or be unexported (golint)
  • Line 439: warning: exported function WaitUntilDeploymentConfigReady should have comment or be unexported (golint)
  • Line 448: warning: exported function WaitUntilVolumeSnapshotReady should have comment or be unexported (golint)
  • Line 457: warning: exported function WaitUntilPVCReady should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/repository.go
  • Line 28: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)
  • Line 39: warning: exported type KindMetaReplicas should have comment or be unexported (golint)
  • Line 45: warning: exported method Framework.EventuallyRepositoryCreated should have comment or be unexported (golint)
  • Line 58: warning: exported method Framework.GetRepositories should have comment or be unexported (golint)
  • Line 80: warning: exported method Framework.DeleteRepository should have comment or be unexported (golint)
  • Line 87: warning: exported method Framework.BrowseBackendRepository should have comment or be unexported (golint)
  • Line 149: warning: exported method Invocation.NewGCSRepository should have comment or be unexported (golint)
  • Line 169: warning: exported method Invocation.NewMinioRepository should have comment or be unexported (golint)
  • Line 189: warning: exported method Invocation.NewS3Repository should have comment or be unexported (golint)
  • Line 209: warning: exported method Invocation.NewAzureRepository should have comment or be unexported (golint)
  • Line 229: warning: exported method Invocation.NewRestRepository should have comment or be unexported (golint)
  • Line 250: warning: exported method Invocation.NewSwiftRepository should have comment or be unexported (golint)
  • Line 269: warning: exported method Invocation.NewB2Repository should have comment or be unexported (golint)
  • Line 288: warning: exported method Invocation.SetupGCSRepository should have comment or be unexported (golint)
  • Line 326: warning: exported method Invocation.SetupMinioRepository should have comment or be unexported (golint)
  • Line 361: warning: exported method Invocation.SetupS3Repository should have comment or be unexported (golint)
  • Line 399: warning: exported method Invocation.SetupAzureRepository should have comment or be unexported (golint)
  • Line 437: warning: exported method Invocation.SetupRestRepository should have comment or be unexported (golint)
  • Line 473: warning: exported method Invocation.SetupSwiftRepository should have comment or be unexported (golint)
  • Line 511: warning: exported method Invocation.SetupB2Repository should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/eventer/recorder.go
  • Line 35: warning: exported const EventReasonInvalidRestic should have comment (or a comment on this block) or be unexported (golint)
  • Line 55: warning: comment on exported const EventSourceBackupConfigurationController should be of the form "EventSourceBackupConfigurationController ..." (golint)
  • Line 65: warning: comment on exported const EventReasonCronJobCreationFailed should be of the form "EventReasonCronJobCreationFailed ..." (golint)
  • Line 69: warning: comment on exported const EventReasonBackupSessionFailed should be of the form "EventReasonBackupSessionFailed ..." (golint)
  • Line 76: warning: comment on exported const EventReasonRestoreRunning should be of the form "EventReasonRestoreRunning ..." (golint)
  • Line 85: warning: comment on exported const EventReasonSidecarInjectionFailed should be of the form "EventReasonSidecarInjectionFailed ..." (golint)
  • Line 92: warning: comment on exported const EventReasonInitContainerInjectionFailed should be of the form "EventReasonInitContainerInjectionFailed ..." (golint)
  • Line 102: warning: exported function NewEventRecorder should have comment or be unexported (golint)
  • Line 116: warning: exported function CreateEvent should have comment or be unexported (golint)
  • Line 140: warning: exported function CreateEventWithLog should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/rbac/volume_snapshot.go
  • Line 39: warning: exported function EnsureVolumeSnapshotterJobRBAC should have comment or be unexported (golint)
  • Line 148: warning: exported function EnsureVolumeSnapshotRestorerJobRBAC should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/matcher/restored_data_matcher.go
  • Line 26: warning: exported function BeSameAs should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/util/options.go
  • Line 27: warning: comment on exported type ExtraOptions should be of the form "ExtraOptions ..." (with optional leading article) (golint)
  • Line 36: warning: exported function BackupOptionsForBackupTarget should have comment or be unexported (golint)
  • Line 48: warning: comment on exported function RestoreOptionsForHost should be of the form "RestoreOptionsForHost ..." (golint)
  • Line 81: warning: exported function SetupOptionsForRepository should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/restore/restore.go
  • Line 45: warning: exported const RestoreModelInitContainer should have comment (or a comment on this block) or be unexported (golint)
  • Line 49: warning: exported type Options should have comment or be unexported (golint)
  • Line 71: warning: exported method Options.Restore should have comment or be unexported (golint)
  • Line 106: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 222: warning: exported method Options.HandleRestoreSuccess should have comment or be unexported (golint)
  • Line 222: warning: receiver name c should be consistent with previous receiver name opt for Options (golint)
  • Line 241: warning: exported method Options.HandleRestoreFailure should have comment or be unexported (golint)
  • Line 241: warning: receiver name c should be consistent with previous receiver name opt for Options (golint)

• /stash.appscode.dev/stash/test/e2e/misc/managed_deployment.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/test/e2e/backend/rest.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/test/e2e/framework/snapshots.go
  • Line 28: warning: exported method Invocation.ListSnapshots should have comment or be unexported (golint)
  • Line 37: warning: exported method Invocation.GetSnapshot should have comment or be unexported (golint)
  • Line 41: warning: exported method Invocation.DeleteSnapshot should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cmds/recover.go
  • Line 32: warning: exported function NewCmdRecover should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/workloads/daemonset.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/pkg/cmds/check.go
  • Line 30: warning: exported function NewCmdCheck should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cmds/run.go
  • Line 30: warning: exported function NewCmdRun should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/matcher/snaphsot_matcher.go
  • Line 28: warning: exported function HavePrefixInName should have comment or be unexported (golint)
  • Line 60: warning: exported function ComeFrom should have comment or be unexported (golint)
  • Line 88: warning: exported function HaveHostname should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/secret.go
  • Line 34: warning: exported const TEST_RESTIC_PASSWORD should have comment (or a comment on this block) or be unexported (golint)
  • Line 37: warning: exported method Invocation.SecretForS3Backend should have comment or be unexported (golint)
  • Line 57: warning: exported const DO_ACCESS_KEY_ID should have comment (or a comment on this block) or be unexported (golint)
  • Line 61: warning: exported method Invocation.SecretForDOBackend should have comment or be unexported (golint)
  • Line 80: warning: exported method Invocation.SecretForGCSBackend should have comment or be unexported (golint)
  • Line 100: warning: exported method Invocation.SecretForAzureBackend should have comment or be unexported (golint)
  • Line 119: warning: exported method Invocation.SecretForSwiftBackend should have comment or be unexported (golint)
  • Line 144: warning: exported method Invocation.SecretForB2Backend should have comment or be unexported (golint)
  • Line 163: warning: exported method Invocation.SecretForMinioBackend should have comment or be unexported (golint)
  • Line 181: warning: exported method Invocation.SecretForRestBackend should have comment or be unexported (golint)
  • Line 199: warning: exported method Invocation.SecretForRegistry should have comment or be unexported (golint)
  • Line 214: warning: exported method Framework.CreateSecret should have comment or be unexported (golint)
  • Line 219: warning: exported method Framework.DeleteSecret should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cmds/server/start.go
  • Line 40: warning: exported type StashOptions should have comment or be unexported (golint)
  • Line 48: warning: exported function NewStashOptions should have comment or be unexported (golint)
  • Line 65: warning: exported method StashOptions.AddFlags should have comment or be unexported (golint)
  • Line 70: warning: exported method StashOptions.Validate should have comment or be unexported (golint)
  • Line 77: warning: exported method StashOptions.Complete should have comment or be unexported (golint)
  • Line 81: warning: exported method StashOptions.Config should have comment or be unexported (golint)
  • Line 125: warning: exported method StashOptions.Run should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/matcher/init_container_matcher.go
  • Line 27: warning: exported function HaveInitContainer should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cmds/restore_pvc.go
  • Line 37: warning: exported function NewCmdRestorePVC should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/pod.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 26: warning: should not use dot imports (golint)
  • Line 36: warning: exported const TestSourceDataVolumeName should have comment (or a comment on this block) or be unexported (golint)
  • Line 42: warning: exported method Invocation.PodTemplate should have comment or be unexported (golint)
  • Line 79: warning: exported method Framework.GetPod should have comment or be unexported (golint)
  • Line 92: warning: exported method Framework.GetAllPods should have comment or be unexported (golint)
  • Line 110: warning: exported method Framework.GetOperatorPod should have comment or be unexported (golint)
  • Line 127: warning: exported method Framework.GetMinioPod should have comment or be unexported (golint)
  • Line 140: warning: exported method Invocation.Pod should have comment or be unexported (golint)
  • Line 186: warning: exported method Invocation.CreatePod should have comment or be unexported (golint)
  • Line 190: warning: exported method Invocation.DeletePod should have comment or be unexported (golint)
  • Line 198: warning: exported method Framework.EventuallyAllPodsAccessible should have comment or be unexported (golint)
  • Line 223: warning: exported method Framework.EventuallyPodAccessible should have comment or be unexported (golint)
  • Line 234: warning: exported method Invocation.DeployPod should have comment or be unexported (golint)

• /stash.appscode.dev/stash/version.go
  • Line 24: warning: exported var Version should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/misc/backward_compatibility.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/pkg/controller/deploymentconfiguration.go
  • Line 44: warning: exported method StashController.NewDeploymentConfigWebhook should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cmds/restore.go
  • Line 40: warning: exported function NewCmdRestore should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/rbac/restore_job.go
  • Line 37: warning: exported function EnsureRestoreJobRBAC should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/backend/swift.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/pkg/rbac/init_container.go
  • Line 39: warning: exported function EnsureRestoreInitContainerRBAC should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/rbac/jobs.go
  • Line 43: warning: exported const ScaledownJobRole should have comment (or a comment on this block) or be unexported (golint)
  • Line 46: warning: comment on exported function EnsureScaledownJobRBAC should be of the form "EnsureScaledownJobRBAC ..." (golint)
  • Line 133: warning: comment on exported function EnsureRecoveryRBAC should be of the form "EnsureRecoveryRBAC ..." (golint)
  • Line 178: warning: exported function EnsureRepoReaderRBAC should have comment or be unexported (golint)
  • Line 260: warning: exported function GetRepoReaderRoleBindingName should have comment or be unexported (golint)
  • Line 264: warning: exported function EnsureRepoReaderRolebindingDeleted should have comment or be unexported (golint)
  • Line 295: warning: exported function EnsureLicenseReaderClusterRoleBinding should have comment or be unexported (golint)
  • Line 320: warning: exported function EnsureClusterRoleBindingDeleted should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cli/env.go
  • Line 33: warning: exported const RESTIC_REPOSITORY should have comment (or a comment on this block) or be unexported (golint)
  • Line 53: warning: comment on exported const ST_AUTH should be of the form "ST_AUTH ..." (golint)
  • Line 57: warning: comment on exported const OS_AUTH_URL should be of the form "OS_AUTH_URL ..." (golint)
  • Line 64: warning: comment on exported const OS_USER_DOMAIN_NAME should be of the form "OS_USER_DOMAIN_NAME ..." (golint)
  • Line 68: warning: comment on exported const OS_STORAGE_URL should be of the form "OS_STORAGE_URL ..." (golint)
  • Line 71: warning: comment on exported const CA_CERT_DATA should be of the form "CA_CERT_DATA ..." (golint)
  • Line 75: warning: exported method ResticWrapper.SetupEnv should have comment or be unexported (golint)
  • Line 79: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 182: warning: exported method ResticWrapper.DumpEnv should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/backup/backup.go
  • Line 57: warning: exported type Options should have comment or be unexported (golint)
  • Line 79: warning: exported type Controller should have comment or be unexported (golint)
  • Line 97: warning: exported const CheckRole should have comment (or a comment on this block) or be unexported (golint)
  • Line 101: warning: exported function New should have comment or be unexported (golint)
  • Line 124: warning: exported method Controller.Backup should have comment or be unexported (golint)
  • Line 283: warning: don't use underscores in Go names; var restic_session_success should be resticSessionSuccess (golint)
  • Line 289: warning: don't use underscores in Go names; var restic_session_fail should be resticSessionFail (golint)
  • Line 295: warning: don't use underscores in Go names; var restic_session_duration_seconds_total should be resticSessionDurationSecondsTotal (golint)
  • Line 301: warning: don't use underscores in Go names; var restic_session_duration_seconds should be resticSessionDurationSeconds (golint)
  • Line 375: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• /stash.appscode.dev/stash/test/e2e/backend/gcs.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/test/e2e/misc/runtimesettings.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/pkg/controller/config.go
  • Line 63: warning: exported type Config should have comment or be unexported (golint)
  • Line 74: warning: exported function NewConfig should have comment or be unexported (golint)
  • Line 80: warning: exported method Config.New should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/recovery/recovery.go
  • Line 41: warning: exported type Controller should have comment or be unexported (golint)
  • Line 50: warning: exported const RecoveryEventComponent should have comment (or a comment on this block) or be unexported (golint)
  • Line 53: warning: exported function New should have comment or be unexported (golint)
  • Line 63: warning: exported method Controller.Run should have comment or be unexported (golint)
  • Line 167: warning: exported method Controller.RecoverOrErr should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/util/restic.go
  • Line 34: warning: exported function GetAppliedRestic should have comment or be unexported (golint)
  • Line 50: warning: exported function FindRestic should have comment or be unexported (golint)
  • Line 84: warning: exported function ResticEqual should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/controller/statefulsets.go
  • Line 42: warning: exported method StashController.NewStatefulSetWebhook should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/conditions.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 30: warning: exported method Framework.EventuallyCondition should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/exec.go
  • Line 28: warning: exported method Framework.ExecOnPod should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cmds/update_status.go
  • Line 33: warning: exported function NewCmdUpdateStatus should have comment or be unexported (golint)
  • Line 67: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• /stash.appscode.dev/stash/pkg/cmds/root.go
  • Line 38: warning: exported function NewRootCmd should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/controller/restore_session.go
  • Line 64: warning: exported const RestorerInitContainer should have comment (or a comment on this block) or be unexported (golint)
  • Line 69: warning: exported method StashController.NewRestoreSessionWebhook should have comment or be unexported (golint)
  • Line 95: warning: exported method StashController.NewRestoreSessionMutator should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/workloads/replicationcontroller.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/pkg/util/backup_configuration.go
  • Line 112: warning: exported function BackupPending should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/controller/replicasets.go
  • Line 42: warning: exported method StashController.NewReplicaSetWebhook should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/volumesnapshot/volumesnapshot_cleanup_policy.go
  • Line 81: warning: exported type VolumeSnapshot should have comment or be unexported (golint)
  • Line 85: warning: exported type VolumeSnapshots should have comment or be unexported (golint)
  • Line 159: warning: exported function CleanupSnapshots should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/util.go
  • Line 32: warning: should not use dot imports (golint)
  • Line 33: warning: should not use dot imports (golint)
  • Line 52: warning: exported const PullInterval should have comment (or a comment on this block) or be unexported (golint)
  • Line 90: warning: exported method Framework.EventuallyEvent should have comment or be unexported (golint)
  • Line 109: warning: exported method Framework.ReadSampleDataFromFromWorkload should have comment or be unexported (golint)
  • Line 147: warning: exported function WaitUntilRepositoryDeleted should have comment or be unexported (golint)
  • Line 153: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 161: warning: exported method Framework.GetNodeName should have comment or be unexported (golint)
  • Line 180: warning: exported method Framework.CreateSampleDataInsideWorkload should have comment or be unexported (golint)
  • Line 205: warning: exported method Invocation.CreateSampleFiles should have comment or be unexported (golint)
  • Line 221: warning: exported method Invocation.CleanupSampleDataFromWorkload should have comment or be unexported (golint)
  • Line 248: warning: exported method Invocation.AppendToCleanupList should have comment or be unexported (golint)
  • Line 254: warning: exported method Invocation.CleanupTestResources should have comment or be unexported (golint)
  • Line 275: warning: exported method Invocation.DeleteResource should have comment or be unexported (golint)
  • Line 293: warning: exported method Invocation.WaitUntilResourceDeleted should have comment or be unexported (golint)
  • Line 306: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 386: warning: exported method Invocation.PrintDebugHelpers should have comment or be unexported (golint)
  • Line 440: warning: exported method Framework.PrintOperatorLog should have comment or be unexported (golint)
  • Line 471: warning: exported method Invocation.HookFailed should have comment or be unexported (golint)
  • Line 491: warning: exported method Framework.EventuallyEventWritten should have comment or be unexported (golint)
  • Line 512: warning: exported function HasFSGroup should have comment or be unexported (golint)
  • Line 516: warning: exported function HasResources should have comment or be unexported (golint)
  • Line 532: warning: exported function HasSecurityContext should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/backup/backupsession.go
  • Line 55: warning: exported type BackupSessionController should have comment or be unexported (golint)
  • Line 82: warning: exported method BackupSessionController.RunBackup should have comment or be unexported (golint)
  • Line 433: warning: exported method BackupSessionController.HandleBackupSetupFailure should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/backend/s3.go
  • Line 25: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/pkg/util/init_container.go
  • Line 35: warning: exported function NewInitContainer should have comment or be unexported (golint)
  • Line 53: warning: exported function NewRestoreInitContainer should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/pvc.go
  • Line 28: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)
  • Line 37: warning: exported method Invocation.PersistentVolumeClaim should have comment or be unexported (golint)
  • Line 57: warning: exported method Framework.CreatePersistentVolumeClaim should have comment or be unexported (golint)
  • Line 61: warning: exported method Invocation.CreateNewPVC should have comment or be unexported (golint)
  • Line 75: warning: exported method Invocation.SetupPVCBackup should have comment or be unexported (golint)
  • Line 101: warning: exported method Invocation.SetupRestoreProcessForPVC should have comment or be unexported (golint)
  • Line 132: warning: exported method Invocation.CleanupUndeletedPVCs should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/check/check.go
  • Line 36: warning: exported const CheckEventComponent should have comment (or a comment on this block) or be unexported (golint)
  • Line 39: warning: exported type Options should have comment or be unexported (golint)
  • Line 46: warning: exported type Controller should have comment or be unexported (golint)
  • Line 52: warning: exported function New should have comment or be unexported (golint)
  • Line 60: warning: exported method Controller.Run should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/hooks/pre_restore.go
  • Line 27: warning: should not use dot imports (golint)
  • Line 29: warning: should not use dot imports (golint)
  • Line 30: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/pkg/controller/backup_session.go
  • Line 67: warning: exported const BackupExecutorSidecar should have comment (or a comment on this block) or be unexported (golint)
  • Line 72: warning: exported method StashController.NewBackupSessionWebhook should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/controller/daemonsets.go
  • Line 42: warning: exported method StashController.NewDaemonSetWebhook should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/backup/prometheus.go
  • Line 41: warning: exported method Controller.JobName should have comment or be unexported (golint)
  • Line 45: warning: exported method Controller.GroupingKeys should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/framework.go
  • Line 24: warning: should not use dot imports (golint)
  • Line 35: warning: exported type Framework should have comment or be unexported (golint)
  • Line 51: warning: exported var TestFailed should have comment or be unexported (golint)
  • Line 53: warning: exported function New should have comment or be unexported (golint)
  • Line 79: warning: exported function NewInvocation should have comment or be unexported (golint)
  • Line 83: warning: exported method Framework.Invoke should have comment or be unexported (golint)
  • Line 91: warning: exported method Invocation.AppLabel should have comment or be unexported (golint)
  • Line 95: warning: exported method Invocation.App should have comment or be unexported (golint)
  • Line 99: warning: exported type Invocation should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/replicationcontroller.go
  • Line 26: warning: should not use dot imports (golint)
  • Line 27: warning: should not use dot imports (golint)
  • Line 37: warning: exported method Invocation.ReplicationController should have comment or be unexported (golint)
  • Line 57: warning: exported method Framework.CreateReplicationController should have comment or be unexported (golint)
  • Line 61: warning: exported method Framework.EventuallyReplicationController should have comment or be unexported (golint)
  • Line 69: warning: exported method Invocation.WaitUntilRCReadyWithSidecar should have comment or be unexported (golint)
  • Line 97: warning: exported method Invocation.DeployReplicationController should have comment or be unexported (golint)

• /stash.appscode.dev/stash/pkg/cmds/scaledown.go
  • Line 29: warning: exported function NewCmdScaleDown should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/misc/snapshots.go
  • Line 29: warning: should not use dot imports (golint)
  • Line 31: warning: should not use dot imports (golint)
  • Line 32: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/pkg/controller/controller.go
  • Line 51: warning: exported type StashController should have comment or be unexported (golint)
  • Line 153: warning: exported method StashController.Run should have comment or be unexported (golint)
  • Line 168: warning: exported method StashController.RunInformers should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/backup_session.go
  • Line 1: warning: package comment should be of the form "Package framework ..." (golint)
  • Line 26: warning: should not use dot imports (golint)
  • Line 32: warning: exported method Framework.EventuallyBackupSessionPhase should have comment or be unexported (golint)
  • Line 41: warning: exported method Framework.EventuallyBackupProcessCompleted should have comment or be unexported (golint)
  • Line 58: warning: exported method Framework.EventuallyBackupSessionCreated should have comment or be unexported (golint)
  • Line 67: warning: exported method Framework.GetBackupSession should have comment or be unexported (golint)
  • Line 82: warning: exported method Invocation.TriggerInstantBackup should have comment or be unexported (golint)
  • Line 105: warning: exported method Invocation.EventuallySuccessfulBackupCount should have comment or be unexported (golint)
  • Line 115: warning: exported method Invocation.EventuallySkippedBackupCount should have comment or be unexported (golint)
  • Line 125: warning: exported method Invocation.GetSuccessfulBackupSessionCount should have comment or be unexported (golint)
  • Line 140: warning: exported method Invocation.GetSkippedBackupSessionCount should have comment or be unexported (golint)
  • Line 155: warning: exported method Invocation.EventuallyRunningBackupCompleted should have comment or be unexported (golint)
  • Line 170: warning: exported method Invocation.EventuallyBackupSessionCount should have comment or be unexported (golint)
  • Line 180: warning: exported method Invocation.GetBackupSessionsForInvoker should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/framework/minio_server.go
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)
  • Line 43: warning: exported const MINIO_PUBLIC_CRT_NAME should have comment (or a comment on this block) or be unexported (golint)
  • Line 66: warning: exported method Framework.CreateMinioServer should have comment or be unexported (golint)
  • Line 105: warning: exported method Framework.SecretForMinioServer should have comment or be unexported (golint)
  • Line 121: warning: exported method Framework.PVCForMinioServer should have comment or be unexported (golint)
  • Line 145: warning: exported method Framework.CreatePersistentVolumeClaimForMinioServer should have comment or be unexported (golint)
  • Line 150: warning: exported method Framework.DeploymentForMinioServer should have comment or be unexported (golint)
  • Line 251: warning: exported method Framework.RemoveSecretVolumeMount should have comment or be unexported (golint)
  • Line 262: warning: exported method Framework.CreateDeploymentForMinioServer should have comment or be unexported (golint)
  • Line 267: warning: exported method Framework.ServiceForMinioServer should have comment or be unexported (golint)
  • Line 288: warning: exported method Framework.GetMinioServiceName should have comment or be unexported (golint)
  • Line 292: warning: exported method Framework.CreateServiceForMinioServer should have comment or be unexported (golint)
  • Line 296: warning: exported method Framework.DeleteMinioServer should have comment or be unexported (golint)
  • Line 311: warning: exported method Framework.DeleteSecretForMinioServer should have comment or be unexported (golint)
  • Line 319: warning: exported method Framework.DeletePVCForMinioServer should have comment or be unexported (golint)
  • Line 327: warning: exported method Framework.DeleteDeploymentForMinioServer should have comment or be unexported (golint)
  • Line 335: warning: exported method Framework.DeleteServiceForMinioServer should have comment or be unexported (golint)
  • Line 343: warning: exported method Framework.MinioServerSANs should have comment or be unexported (golint)
  • Line 351: warning: exported method Framework.MinioServiceAddres should have comment or be unexported (golint)
  • Line 355: warning: exported method Invocation.CreateBackendSecretForMinio should have comment or be unexported (golint)

• /stash.appscode.dev/stash/test/e2e/hooks/pre_backup.go
  • Line 27: warning: should not use dot imports (golint)
  • Line 28: warning: should not use dot imports (golint)

• /stash.appscode.dev/stash/pkg/controller/jobs.go
  • Line 67: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• /stash.appscode.dev/stash/pkg/util/sidecar.go
  • Line 37: warning: exported function NewSidecarContainer should have comment or be unexported (golint)
  • Line 110: warning: exported function NewBackupSidecarContainer should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell97%

Misspell Finds commonly misspelled English words

• /stash.appscode.dev/stash/pkg/controller/backup_session.go
  • Line 621: warning: "succesfully" is a misspelling of "successfully" (misspell)

• /stash.appscode.dev/stash/pkg/controller/restore_session.go
  • Line 430: warning: "idenitfy" is a misspelling of "identify" (misspell)

• /stash.appscode.dev/stash/pkg/cmds/restore_volumesnapshot.go
  • Line 137: warning: "definiton" is a misspelling of "definition" (misspell)